From nobody Fri Dec 19 07:35:40 2025 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E22B1632D7 for ; Mon, 17 Feb 2025 08:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739779688; cv=none; b=I6YXRmqBQkd+Qylh1KK+66fNiKmjom0xxdwPX0zES+uSulfpnoIPes3zi5BASH4fxMyDjhe3vuH4R0G3pJ/8jYNjqa+Su4/S2QitJxGzZ9/AvBzvIJzKuEIfX5z6XZebQztUMO9txC2SBkPl2RPEEe++d8IN71iC5nY13iFwFFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739779688; c=relaxed/simple; bh=2ikSgfGf1exOnsFu88z+5kxpMPTxBzklFFNfq0MBXfk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Nq407V6vLRsfRQfOqDbbW78OpKXlWPpSO1/5MA4eIanQkckcGghPqR3+3UkoiwsIX2z71FNp5neA7PObhG17f6asae9KQ5I+kqXQCGNYONUKgxuA5sziXoQ+NHDSFuKd9Ep5yyNwb10/TfagWnf21v1p+k3+4sOjcgtyzYH+dis= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fcb+1zgw; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fcb+1zgw" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5ded368fcd9so5034899a12.1 for ; Mon, 17 Feb 2025 00:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739779684; x=1740384484; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ziFzV0Y9ZdSXReLGJPFeArO5FCiM55hkxr4sd1Sn0do=; b=fcb+1zgwh2mXX1AMSgeEnNFcHK5Mf2w1i1Zi0KaTTmM6YjVrBKmIqVF1Dc2OFwd0w4 OkysB3CFui06AqR3Sk+//iriDKsbGWA5+75okgn7Pd/y6gB1a9c65uhxsQf9QVEjQj+p pYLpvTcmk8+JfzbiK74fRLqJ+doBD4LlaNhbaHaFIia4IlSWlkGDVoiIzp9BcKj2lMnB mPxFgDXsCMZyRh8pPEGOt6Nsz+oKrLcQJ6DIWl9twHMwuUVTsb90XG4GE0IRFXiGjFbd GcBaWkPvfwK2bOl4XTIzLeDeWBe5ijlYbDz/5ajO58lVXKFXPdg+Vdh9BcuDKk3Og786 gJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739779684; x=1740384484; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ziFzV0Y9ZdSXReLGJPFeArO5FCiM55hkxr4sd1Sn0do=; b=QEOXoq22QKby2qXyrjT9HCPgBDuqFmqMy4Uf8VjsiPKT8jILVZ50jrXfzblTdqw0/S pZGr4I0J3U4wInnuGGAIV90OSwgccLgm7w5hRLwp7pG3hlh+Wg3O8mv4ArINPJjrBKP8 zMPLtsb1LeUPyE1ca1NG7t1QkQkIGaOQn0X/4VgBZY4f+gZnk8ZsVsMy0/cLfe7doU46 76QlwdR0LNEmP2Mh9GZgx4OAwf7L3x8iFm16C5K9DOFSqBgETF8uKIFlDreN2I7hPoyT yD/jr/0hZueW1jNtExGRC8y670UnauNj+Zn8A6WPXvRmadlqWd3C/qbj8MBYvgWK/Piv 8ixg== X-Forwarded-Encrypted: i=1; AJvYcCX9DY0gdggFXiAe+jUpkoMVODwfiX7qTTx7xuwcU/SiB5Rvtxa5CknmVa054nY2liqmn+OSQHoFssprFHM=@vger.kernel.org X-Gm-Message-State: AOJu0YzQvVqlZfhGjfXS06b4H3oBzCxI3FH8VUBolLoytzENlIwSTko5 3E5ElTviFkM9InLTbBXGlmN+T/iT5KhNg/IkowRn+MONZJZ85T7H2Hv7jkWa5Wk= X-Gm-Gg: ASbGncskp6lIVBWEraJZtDI9t2Glw6iHh+/690GpV33elj8fI97sCdp/9oK019X2IIj Jwhzwh6WKJZFjX9vUbk1cc3R4BYvXIn7VZC/qDnEjH0e5h9ZjD4Zv3kr1JOmqyq7FlAHVL/4yvi hGhDQYSu2tEzjSCO1DBnjSyRA7C7o5y1wsz+wf7J2+6/ALsLjKYDBJo0V92AAPLavp3BOn23GgG iS4VqM0c5gWLRlA4zZca9k7kzglx0rNJ/1ptA8HCYybi3GIExaEHu5o/49vC8M72NIr1t9q3X2k 1fCt+n9FgHl/445HrlwM X-Google-Smtp-Source: AGHT+IFBXYQnvhbaTs+R1+H9kU9Himyc237EX2vSSmBY82Bm6sjx/eueayJNYvLdiOzneYVu+KD0DQ== X-Received: by 2002:a05:6402:348d:b0:5dc:882f:74b7 with SMTP id 4fb4d7f45d1cf-5e0361747fbmr10164192a12.30.1739779684400; Mon, 17 Feb 2025 00:08:04 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-5dece287cebsm6843141a12.74.2025.02.17.00.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 00:08:04 -0800 (PST) Date: Mon, 17 Feb 2025 11:08:00 +0300 From: Dan Carpenter To: Dikshita Agarwal Cc: Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] media: iris: fix error code in iris_load_fw_to_memory() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return -ENOMEM if memremap() fails. Don't return success. Fixes: d19b163356b8 ("media: iris: implement video firmware load/unload") Signed-off-by: Dan Carpenter Reviewed-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/med= ia/platform/qcom/iris/iris_firmware.c index 7c493b4a75db..f1b5cd56db32 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -53,8 +53,10 @@ static int iris_load_fw_to_memory(struct iris_core *core= , const char *fw_name) } =20 mem_virt =3D memremap(mem_phys, res_size, MEMREMAP_WC); - if (!mem_virt) + if (!mem_virt) { + ret =3D -ENOMEM; goto err_release_fw; + } =20 ret =3D qcom_mdt_load(dev, firmware, fw_name, pas_id, mem_virt, mem_phys, res_size, NULL); --=20 2.47.2