From nobody Sun Feb 8 11:40:39 2026 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A7BA3FD4; Mon, 12 Aug 2024 02:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723428029; cv=none; b=Bpm4T0Yhha8ARJh+MiTTcanPP1k9ytMfo+6TOasmVOJPI18cwjvs9U+cUU74qj24OuWwpWEOhIop/ofYQOdSEZiwkGzIG2CrllD4/zkad6utbkCYtahby2PJl+s1lm6zZqbLQoyKNzsADj8kNuxuIchBQX1SpO8G2QCclIaYbJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723428029; c=relaxed/simple; bh=LTqswOMYIvuMSo69TxBE4FFx+VdMdKLPpGZu0+5lvU0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ooNXn/Elf9o+j6qdZG750pIwG0G1yJljg5VMWeXF5rTxBqtFAfR7YiMXGdNslHiSBnfnGt6HUZQuVlmHDaU6pLUZkKoy1uN9Bow4+kAmX5wuUYJ2qAbz+XmLHtzc3uhvTidGLy0M/I1IlaY3GyQ8pksK/FZ9bHSQGEJRp7cvo10= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=wpIwxb4e; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="wpIwxb4e" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1723428025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RKcmkKHprKaGo3TWBWY608Q1owHtNCcC2SHOqOY293I=; b=wpIwxb4eGG3D+c3GHnXUf2CVr2ZT5w5LkFjXVbn6V+OdSXmxFIYnbfF7h/0LsrPP4zw0lr 1ioc2dY0WgyiIUs571TB5lTB0FbbBkluaAwCU+hR3uVzQYRDcbk/xt6Wp1WuGwq5o8fDIC NXZswVRI0U1qFgTCfdGgnsiJ24zqaitL0yMrOLttPSkRLp2DlHkseCGX3WbdNy4GgEwWXW s7YcdmGWaSbZayrdsswAwDQQR8L5TLP7t+gYYlVrpuIsHQ2fNB6GE5tm+Cr7S9RgqRwk9Q D11j34PSBO++joPeH7pImp0P9Zhd6fhzgVZH+SDGwYh29uHZYirse4erlMYR4w== To: linux-sunxi@lists.linux.dev Cc: wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, uwu@icenowy.me, wenst@chromium.org, broonie@kernel.org Subject: [PATCH] arm64: dts: allwinner: Add GPU thermal trips to the SoC dtsi for A64 Date: Mon, 12 Aug 2024 04:00:20 +0200 Message-Id: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Add thermal trips for the two GPU thermal sensors found in the Allwinner A6= 4. There's only one GPU OPP defined since the commit 1428f0c19f9c ("arm64: dts: allwinner: a64: Run GPU at 432 MHz"), so defining only the critical thermal trips makes sense for the A64's two GPU thermal zones. Having these critical thermal trips defined ensures that no hot spots devel= op inside the SoC die that exceed the maximum junction temperature. That might have been possible before, although quite unlikely, because the CPU and GPU portions of the SoC are packed closely inside the SoC, so the overheating G= PU would inevitably result in the heat soaking into the CPU portion of the SoC, causing the CPU thermal sensor to return high readings and trigger the CPU critical thermal trips. However, it's better not to rely on the heat soak and have the critical GPU thermal trips properly defined instead. While there, remove a few spotted comments that are rather redundant, becau= se it's pretty much obvious what units are used in those places. Signed-off-by: Dragan Simic --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boo= t/dts/allwinner/sun50i-a64.dtsi index e868ca5ae753..bc5d3a2e6c98 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -212,7 +212,6 @@ timer { =20 thermal-zones { cpu_thermal: cpu0-thermal { - /* milliseconds */ polling-delay-passive =3D <0>; polling-delay =3D <0>; thermal-sensors =3D <&ths 0>; @@ -236,40 +235,51 @@ map1 { =20 trips { cpu_alert0: cpu-alert0 { - /* milliCelsius */ temperature =3D <75000>; hysteresis =3D <2000>; type =3D "passive"; }; =20 cpu_alert1: cpu-alert1 { - /* milliCelsius */ temperature =3D <90000>; hysteresis =3D <2000>; type =3D "hot"; }; =20 cpu_crit: cpu-crit { - /* milliCelsius */ temperature =3D <110000>; hysteresis =3D <2000>; type =3D "critical"; }; }; }; =20 gpu0_thermal: gpu0-thermal { - /* milliseconds */ polling-delay-passive =3D <0>; polling-delay =3D <0>; thermal-sensors =3D <&ths 1>; + + trips { + gpu0_crit: gpu0-crit { + temperature =3D <110000>; + hysteresis =3D <2000>; + type =3D "critical"; + }; + }; }; =20 gpu1_thermal: gpu1-thermal { - /* milliseconds */ polling-delay-passive =3D <0>; polling-delay =3D <0>; thermal-sensors =3D <&ths 2>; + + trips { + gpu1_crit: gpu1-crit { + temperature =3D <110000>; + hysteresis =3D <2000>; + type =3D "critical"; + }; + }; }; };