From nobody Fri Dec 19 07:20:22 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40937175D2F for ; Wed, 28 Aug 2024 12:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724847669; cv=none; b=OqilELABJ2y0b5/VE/0Z/UFE9lFYcjRNEcZ8n7UTdmuvPksY+lbpwHEiUkpOc9dCjVpUaR8OJ8FxMakwLnWb5b/8Id/HfZyvFmnbJFH0AscTFpaRLJ79jM7tbBsvWeOv6DhNAaa1F7Ro/1gj0LOdKKsWYS+5t5XhX6m76LajS50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724847669; c=relaxed/simple; bh=u/GGavIYEqX7mrGveiWklk5oJ5JVVxYHnZ/LQ8zYQfk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=u4jykAtVeyLzh84rjvZ6H3Nl7ria8yIIw7JQQhNvcysEcNtEXqR78QNRupU7FUgw2kcOVlm/2REyOZyjYiiGiBbN8V2ozSGRnr7NR5U5bWt3jscKG5Id1OMpC/zXbd7IrrsDOzRVkvckGErAcBVDdnry944cICUyHtsXwlvOHlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bprus1cX; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bprus1cX" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-202508cb8ebso44966055ad.3 for ; Wed, 28 Aug 2024 05:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724847667; x=1725452467; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=fGi93qralUPl1hkuQ7DwE7sDUcYkj0+qWkjztC3U/qM=; b=Bprus1cXQEirRvl3xVpPCZGs29SQr8nRPHOerWSxhk60jJP1pGHu2WPhZMUno9p58+ hqaJEGIA2FxFMJ93p1WxM+BgfcQh0MqHEcyGXi92SjSqU7u9AIoBeFi7R65fvRtOMdq0 c8DT3JX6eEZlpMnxsJSmtA22kXRzb8Au6/6Ehr+8F1zEz5vBoRqEBJ2Bjmnxk5p+ZGoQ FETGxvGhU5r+3hDmppk0VzO2w+CA20XTFk1HslMdC1aBgMHZ30HMqKW845Ah6WR++k86 qWA/Kn6kN+x/GmT/5Gr8cy3w56LtAQwPD8mXwyG4bj/c6U6hsLxA/+0yordrSJPh50RN JzRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724847667; x=1725452467; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fGi93qralUPl1hkuQ7DwE7sDUcYkj0+qWkjztC3U/qM=; b=f0pN5V+OjWOoQH5GbLm6EnbLPzE6HR8+c+qplW7bc9ZIW3f3mM1SCM3WBISsGqnxbJ uTB6II819h3V4S6rupzS2oQiB+L98VbUNYBgvInxbhQW2rtJzsQ2xHrpYWSLEI7P9nJ+ qHzVWcOAcmRV8p6Gm5cyG79laamr0YCp0RJoxyljUp2hjA2vscTxVJ3iLCc3NbSEX7cU 0KdrYpLTkRoXPwkV1PHfsenojGWdz5FEwpSBR1brLcetRy099nh+EBTlpGM0iv0JcoH8 +gk06hPgSPHjhCSBw8XiO0oA4zWxEBqVAQkU+QPFFzI+QGFHCypQ5hKOoXVUjSn8Ywg0 QGEg== X-Forwarded-Encrypted: i=1; AJvYcCUYn4pL0zhXwhWF9CMOmPuBUfNnXy9bG0j8Od7zTppyPTuz7f4nkHbaid5PW44hqeagRzNY+X4sGpyTlSM=@vger.kernel.org X-Gm-Message-State: AOJu0YyoqZA4A247xklhjU3496ObxaAdefpQqjEmDqLeuLcSmnAtwdt/ OegFxpoMg4hjynFECQ8AVZU4ahreg8rmmDOPputYTM262uR115toDXtcJg== X-Google-Smtp-Source: AGHT+IGzzCQT12/LB8yEvY34gIYfqYYDIzA0cF/Udk5kGAnad3O95MKPiZ7yjzOwKM3DINqiwyyRQg== X-Received: by 2002:a17:902:e804:b0:202:3e32:5d3e with SMTP id d9443c01a7336-204f9bd27c9mr19838765ad.36.1724847667319; Wed, 28 Aug 2024 05:21:07 -0700 (PDT) Received: from victor-IdeaPad-Gaming-3-16IAH7 ([116.68.77.85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2038560975csm97405865ad.194.2024.08.28.05.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 05:21:07 -0700 (PDT) Date: Wed, 28 Aug 2024 17:51:02 +0530 From: vivek t s To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase warning from checkpatch. Signed-off-by: vivek t s --- compile tested. V2: Prefix added for function as suggested by Greg Kroah-Hartman . Commit message corrections as suggested by Dan Carpenter . drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index e4063713fecc..23268ec502a7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -277,7 +277,7 @@ void expire_timeout_chk(struct adapter *padapter) /* switch to correct channel of current network before issue keep-alive= frames */ if (rtw_get_oper_ch(padapter) !=3D pmlmeext->cur_channel) { backup_oper_channel =3D rtw_get_oper_ch(padapter); - SelectChannel(padapter, pmlmeext->cur_channel); + r8723bs_select_channel(padapter, pmlmeext->cur_channel); } =20 /* issue null data to check sta alive*/ @@ -315,7 +315,7 @@ void expire_timeout_chk(struct adapter *padapter) } =20 if (backup_oper_channel > 0) /* back to the original operation channel */ - SelectChannel(padapter, backup_oper_channel); + r8723bs_select_channel(padapter, backup_oper_channel); } =20 associated_clients_update(padapter, updated); diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 9ebf25a0ef9b..60861a480b3b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -3831,10 +3831,10 @@ void site_survey(struct adapter *padapter) } else { #ifdef DBG_FIXED_CHAN if (pmlmeext->fixed_chan !=3D 0xff) - SelectChannel(padapter, pmlmeext->fixed_chan); + r8723bs_select_channel(padapter, pmlmeext->fixed_chan); else #endif - SelectChannel(padapter, survey_channel); + r8723bs_select_channel(padapter, survey_channel); } =20 if (ScanType =3D=3D SCAN_ACTIVE) { /* obey the channel plan setting... */ diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 7fac9ca3e9a0..87ce4a9b3aad 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -333,7 +333,7 @@ inline unsigned long rtw_get_on_cur_ch_time(struct adap= ter *adapter) return 0; } =20 -void SelectChannel(struct adapter *padapter, unsigned char channel) +void r8723bs_select_channel(struct adapter *padapter, unsigned char channe= l) { if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/sta= ging/rtl8723bs/include/rtw_mlme_ext.h index 720aeeb002b0..8315399b64fd 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -455,7 +455,7 @@ u8 rtw_get_center_ch(u8 channel, u8 chnl_bw, u8 chnl_of= fset); unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter); =20 void set_channel_bwmode(struct adapter *padapter, unsigned char channel, u= nsigned char channel_offset, unsigned short bwmode); -void SelectChannel(struct adapter *padapter, unsigned char channel); +void r8723bs_select_channel(struct adapter *padapter, unsigned char channe= l); =20 unsigned int decide_wait_for_beacon_timeout(unsigned int bcn_interval); =20 --=20 2.43.0