From nobody Sat Feb 7 23:12:14 2026 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E2D139564 for ; Tue, 12 Mar 2024 17:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710263522; cv=none; b=SF3pZymIVTOWwLYTaKhW6Q+MQJWW2Z2IBfBdyEnTsIa1cEiutfewkiTng3UY0Q7oTMpvLo/qTwWML8EC55q8MJD750BzdQBnKg3UAOLBSiDBkDP9pIgSZ60CVzZFP3pRuvslkwsr12Zx78kVez4N2bWB8uZzLO0IzoLOejor3II= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710263522; c=relaxed/simple; bh=+4z/fKVxIVcUeK/DqyugogB+o5o/9pkjvamszPJbA3M=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=edluVkT4FZ4ok4U5svKMKsk4gE4Z5Onx3aswPQk/kA4LVTqtnF52F3uRE4lWidZJqx1KUqq4787Hk/ChI3kDnmv9e3GI8daeidHiBiS4nzL1WQy5pLTuGbpYR8kw+7Gs3sqjAggn9J+UxgBZkzRn6MkBozoR4cB2+lrl7B3iArA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nHQlcvUY; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHQlcvUY" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-513c1a82b30so927437e87.1 for ; Tue, 12 Mar 2024 10:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710263519; x=1710868319; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=GCpDHHk1rEgXXfVDzy2o6ifm7MNu/s628JnAZoViwZM=; b=nHQlcvUYRSbMuVKFHKNksdeUYoSgh5RIItibPTrmyoDtuJqYKk589Xoq43KN6VTBlo AYFD3+M0A0Qy46emDj8txdgPkuyIdHVPxTb3IthkX5fgkG1xjlQdNRao0bLRKkXz/ow8 CcbdYEbwPWnUE5CZdyTV7G/Q8N0KygZVNrDkISMkYWrkuKIeiJJkFRJJh/DwUShrR5FY CaICY0NzQGP8wBQjVm0EpX+EOLPnDAlWZK2VeNtAebadPWORYqrPmml7S36je3xv+3/k g54s/IQgGI6NrG+sHxkVugRP2dChniorHA4CZGhtJ8zJR3nDN4E2hS+MQ4ebK8yIJrg0 Crtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710263519; x=1710868319; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GCpDHHk1rEgXXfVDzy2o6ifm7MNu/s628JnAZoViwZM=; b=B4i3n6iaJDKUD6hzrpcSDtXIvAihX3KYLxogmusHB+0D+tWROUHfLwFWmzOdmqxXbq SmwnkrC+P6uV2uGSgadfLfrFxEOh7YseguITfJK9ukJIxFtvjCYKAgBZAvh2V0YUQV1/ LvwvfjIfILM3AhK3LDXFZPLEmIbicjxYlmQi8A/q40BSK4RRlii9+X+c+0aLvjB0XzYM 7FrGAt36sGU3bPIYiDwkvKTpoNyVNOyW7+oh7/k52rq53ojw4CLNooywaobNOuaMFVYZ 0B3fGdl5NZHNwPITMk4ojOQyZus+hAQTZpKcIDMH31qrvkctZ581GgluK9+6dRF8MDdp YRig== X-Forwarded-Encrypted: i=1; AJvYcCV1N8AxdJts60a7+dMgj2u6sgUX2CRACTF+fPawryFRLTvlDp/AsEWJ/MglS14HnLUp1bmirDKk1KemuyK8PZoHyE8W+Li3okwzswiy X-Gm-Message-State: AOJu0YyEaNowYwlXncPXQIiUN2iUl/i58Ah+xAKzqZI33t+H8eszLS7f 5g8rejux61YCyUywDml1HuiFwLyFdSxEitmNN32lq4XH9h1WtY8a X-Google-Smtp-Source: AGHT+IFoaUFmekupZMWSBdIFGI8p404pPfoUjAX1esuRQ+pbxijn8Do/xwbyzhMShgceQk2+ebRdnQ== X-Received: by 2002:ac2:5b9b:0:b0:513:5977:4286 with SMTP id o27-20020ac25b9b000000b0051359774286mr7015029lfn.19.1710263518513; Tue, 12 Mar 2024 10:11:58 -0700 (PDT) Received: from MOLeToid ([102.244.37.37]) by smtp.gmail.com with ESMTPSA id bt11-20020a056000080b00b0033e9186f043sm6910960wrb.41.2024.03.12.10.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 10:11:57 -0700 (PDT) Date: Tue, 12 Mar 2024 18:11:53 +0100 From: "Felix N. Kimbu" To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: outreachy@lists.linux.dev Subject: [PATCH v3] staging: wlan-ng: Rename 'foo' to 'rc' in p80211conv.c Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename identifer 'foo' to 'rc' Suggested-by Alison Schofield in functions skb_p80211_to_ether() and skb_ether_to_p80211(). Fix indentation necessitated by above rename Suggested-by Dan Carpenter and Philipp Hortmann. This change adds intuitive meaning to the idenfier, adhering to best practices and coding style. Also, driver has been included in the subject Suggested-by Philipp Hortmann. Signed-off-by: Felix N. Kimbu --- Changes since v2: - Fix wrong indentation introduced in v1 - Correct subject to include driver from v1 Changes since v1: - Rename identifier 'foo' to 'decrypt_check' drivers/staging/wlan-ng/p80211conv.c | 30 ++++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng= /p80211conv.c index 8336435eccc2..7401a6cacb7f 100644 --- a/drivers/staging/wlan-ng/p80211conv.c +++ b/drivers/staging/wlan-ng/p80211conv.c @@ -93,7 +93,7 @@ int skb_ether_to_p80211(struct wlandevice *wlandev, u32 e= thconv, struct wlan_ethhdr e_hdr; struct wlan_llc *e_llc; struct wlan_snap *e_snap; - int foo; + int rc; =20 memcpy(&e_hdr, skb->data, sizeof(e_hdr)); =20 @@ -185,14 +185,14 @@ int skb_ether_to_p80211(struct wlandevice *wlandev, u= 32 ethconv, p80211_wep->data =3D kmalloc(skb->len, GFP_ATOMIC); if (!p80211_wep->data) return -ENOMEM; - foo =3D wep_encrypt(wlandev, skb->data, p80211_wep->data, - skb->len, - wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK, - p80211_wep->iv, p80211_wep->icv); - if (foo) { + rc =3D wep_encrypt(wlandev, skb->data, p80211_wep->data, + skb->len, + wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK, + p80211_wep->iv, p80211_wep->icv); + if (rc) { netdev_warn(wlandev->netdev, "Host en-WEP failed, dropping frame (%d).\n", - foo); + rc); kfree(p80211_wep->data); return 2; } @@ -265,7 +265,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32= ethconv, struct wlan_llc *e_llc; struct wlan_snap *e_snap; =20 - int foo; + int rc; =20 payload_length =3D skb->len - WLAN_HDR_A3_LEN - WLAN_CRC_LEN; payload_offset =3D WLAN_HDR_A3_LEN; @@ -305,15 +305,15 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u= 32 ethconv, "WEP frame too short (%u).\n", skb->len); return 1; } - foo =3D wep_decrypt(wlandev, skb->data + payload_offset + 4, - payload_length - 8, -1, - skb->data + payload_offset, - skb->data + payload_offset + - payload_length - 4); - if (foo) { + rc =3D wep_decrypt(wlandev, skb->data + payload_offset + 4, + payload_length - 8, -1, + skb->data + payload_offset, + skb->data + payload_offset + + payload_length - 4); + if (rc) { /* de-wep failed, drop skb. */ netdev_dbg(netdev, "Host de-WEP failed, dropping frame (%d).\n", - foo); + rc); wlandev->rx.decrypt_err++; return 2; } --=20 2.34.1