From nobody Sun Feb 8 01:30:20 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55BA255E43 for ; Mon, 11 Mar 2024 18:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710180483; cv=none; b=YEQOe3+9TSxW/secSboJtQnHrhrxkut+BNSuc9tUHMwPmHqi1xET3IcKZQB2h3vFEeBloL/NFdbR5izNo8YnAfjrUUu70ttTu/saQWfwV4tmyGalCwqN0Y88K5FUn65AFpN7RcdUNc7peMKuLy+aYuRY2WhSSUHj7B/ZP9YskDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710180483; c=relaxed/simple; bh=TtjcSFJzD1ZaiKH3GMBWqMzWiUymwQvzGYA6LQYJsms=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=vGhaiQQowQDwRVScobZ8KaIf3A+PyxuFGStWCCdsz2R/f5wp4mO5ItKC2bKRFVaXnAELloHZ4X63R+nFTcenCZKwBtq6vqkbASpHsUZZishuMBk3FRiWEcOaFzu/SayIQruIlzDF5mGNCtzqoovorE1FJi6Rkv+pY/fBbM7ptg8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fzo9FXWb; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fzo9FXWb" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-33e7946bddfso2506654f8f.0 for ; Mon, 11 Mar 2024 11:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710180480; x=1710785280; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=KiTdgp2i9o6Qc3jLXuNAJ1XZ4ZXjWbgbhcsi2rEm3y0=; b=Fzo9FXWb3D3oYzfDo+8VhZCs5RQjFtHuayj2b1KtsJbmU/BrHbR4zJ+I/kEKl61FBg k5tJip+NGr0Crt44f7cH/xbM0Y8EzgmUs4qxjQSv3Wyd1C8KaGfSP1LkHnBEK4cKOkOM HIUDLURf/AliZq2knvLmkE/5YTBDVOp7M0GMoXsk45IVD5ijdVbRkHPM112840WxmSpy TbyN9+QW6YXAgM5OqVQ9IhWBjGmUYrBiR7quSVa04wbGHojl+lESlZEEU2aTyu/X0JKt ghfAx7eAeCrxN2ydBScNw+uU+MemNJRitq00fOTK8gFGmKFfupasWobcPbXiT5WPhjAx 41kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710180480; x=1710785280; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KiTdgp2i9o6Qc3jLXuNAJ1XZ4ZXjWbgbhcsi2rEm3y0=; b=esIgMwhoh4ksmvh4iMUKNm0tjhwSq5be/8nHpgjJL053+euBLu9dM28E+DI2z9rKqj J+Z5ssZN10zetz299K58YNnNb4qLsaYe1eUJ6oSREWtY2HZrsjtITWOEaC4VqxZpV5QR eun6Ik0hgypjprO46f/+xe3xQUZOPiqiqCTlgYgWDM0RO5iH7E8KzMDEJ3ql2xerf9UL GBJ4jaOQLyYTtr3OGkDqxZiS44P9wOyF9sOEHkMg7l7qcLcfh75SolGepHhKy0v+O/xe pWc2QtbidTjppTC3gRS/eqNFsO1HZtNzLgXZEee1YEAAWNBgUfaE/AArqHjgO185aHOB wicw== X-Forwarded-Encrypted: i=1; AJvYcCVpT8JnTdFgIT/Rq4rRHT9PYGTiP5jeOk7mVecladvwPRgtoIc263qbHPt7Uo4LmVO89CAX5vYogNAUwbsgRAasy4m810vu32FXgOx9 X-Gm-Message-State: AOJu0YyIJYIPQ6OKSlu+ZAUtyRRn/5KyQMPt6xdhzfcRkzX57lDHJnSZ +Q5iDSCY3rl5FUo0tKFLFbI4OuFjHqPPSOejI13p2Ucj6D16q42N X-Google-Smtp-Source: AGHT+IEnSAYRCmjpdDdukAm/E4JgNytzywkoKx5MGmmJG1cRliuHLBwk00Weun696vg1kCPJvzepTg== X-Received: by 2002:a5d:4e90:0:b0:33e:9311:5fda with SMTP id e16-20020a5d4e90000000b0033e93115fdamr3637250wru.29.1710180479454; Mon, 11 Mar 2024 11:07:59 -0700 (PDT) Received: from MOLeToid ([129.0.78.235]) by smtp.gmail.com with ESMTPSA id cc4-20020a5d5c04000000b0033e91fed625sm4343811wrb.23.2024.03.11.11.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 11:07:58 -0700 (PDT) Date: Mon, 11 Mar 2024 19:07:55 +0100 From: "Felix N. Kimbu" To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: outreachy@lists.linux.dev Subject: [PATCH] staging: p80211conv: Rename local foo to decrypt_check Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This change renames the local variable foo to decrypt_check in functions skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive meaning to the identifier. It also indents the parameters to match the the opening parentheses. Signed-off-by: Felix N. Kimbu --- drivers/staging/wlan-ng/p80211conv.c | 30 ++++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng= /p80211conv.c index 8336435eccc2..a0413928a843 100644 --- a/drivers/staging/wlan-ng/p80211conv.c +++ b/drivers/staging/wlan-ng/p80211conv.c @@ -93,7 +93,7 @@ int skb_ether_to_p80211(struct wlandevice *wlandev, u32 e= thconv, struct wlan_ethhdr e_hdr; struct wlan_llc *e_llc; struct wlan_snap *e_snap; - int foo; + int decrypt_check; =20 memcpy(&e_hdr, skb->data, sizeof(e_hdr)); =20 @@ -185,14 +185,14 @@ int skb_ether_to_p80211(struct wlandevice *wlandev, u= 32 ethconv, p80211_wep->data =3D kmalloc(skb->len, GFP_ATOMIC); if (!p80211_wep->data) return -ENOMEM; - foo =3D wep_encrypt(wlandev, skb->data, p80211_wep->data, - skb->len, - wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK, - p80211_wep->iv, p80211_wep->icv); - if (foo) { + decrypt_check =3D wep_encrypt(wlandev, skb->data, p80211_wep->data, + skb->len, + wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK, + p80211_wep->iv, p80211_wep->icv); + if (decrypt_check) { netdev_warn(wlandev->netdev, "Host en-WEP failed, dropping frame (%d).\n", - foo); + decrypt_check); kfree(p80211_wep->data); return 2; } @@ -265,7 +265,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32= ethconv, struct wlan_llc *e_llc; struct wlan_snap *e_snap; =20 - int foo; + int decrypt_check; =20 payload_length =3D skb->len - WLAN_HDR_A3_LEN - WLAN_CRC_LEN; payload_offset =3D WLAN_HDR_A3_LEN; @@ -305,15 +305,15 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u= 32 ethconv, "WEP frame too short (%u).\n", skb->len); return 1; } - foo =3D wep_decrypt(wlandev, skb->data + payload_offset + 4, - payload_length - 8, -1, - skb->data + payload_offset, - skb->data + payload_offset + - payload_length - 4); - if (foo) { + decrypt_check =3D wep_decrypt(wlandev, skb->data + payload_offset + 4, + payload_length - 8, -1, + skb->data + payload_offset, + skb->data + payload_offset + + payload_length - 4); + if (decrypt_check) { /* de-wep failed, drop skb. */ netdev_dbg(netdev, "Host de-WEP failed, dropping frame (%d).\n", - foo); + decrypt_check); wlandev->rx.decrypt_err++; return 2; } --=20 2.34.1