From nobody Sat Dec 27 01:05:12 2025 Received: from out28-81.mail.aliyun.com (out28-81.mail.aliyun.com [115.124.28.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46ADF25778; Tue, 26 Dec 2023 08:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sjterm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sjterm.com X-Alimail-AntiSpam: AC=CONTINUE;BC=0.502714|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.0655499-0.0022427-0.932207;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047190;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=15;RT=15;SR=0;TI=SMTPD_---.VtBiFDR_1703580005; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.VtBiFDR_1703580005) by smtp.aliyun-inc.com; Tue, 26 Dec 2023 16:40:06 +0800 Date: Tue, 26 Dec 2023 16:40:05 +0800 From: Fuyao Kashizuku To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Florian Fainelli , Wei Xu , Gregory CLEMENT , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: =?utf-8?B?6bqm5YGl5bu6?= Subject: [PATCH v2] ARM: dts: sun8i: Open FETA40i-C regulator aldo1 Message-ID: Mail-Followup-To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Florian Fainelli , Wei Xu , Gregory CLEMENT , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, =?utf-8?B?6bqm5YGl5bu6?= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Organization: work_work_work Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The USB PHY in the Allwinner R40 SoC seems to rely on voltage on the VCC-TVIN/OUT supply pins for proper operation, on top of its own supply voltage on VCC-USB. Without a 3.3V voltage supplied to VCC-TV*, USB operation becomes unstable and can result in disconnects. The Forlinx FETA40i-C SoM connects both the VCC-TVOUT and VCC-TVIN pins to the ALDO1 rail of the PMIC, so we need to enable that rail for USB operation. Since there is no supply property in the DT bindings for the USB core, we need to always enable the regulator. This fixes unstable USB operation on boards using the Forlinx FETA40i-C module. Signed-off-by: Fuyao Kashizuku Reviewed-by: Andre Przywara Reviewed-by: Jernej Skrabec --- Changes in v2: - Subject include board name. - regulator name changed to vcc-3v3-tv-usb. - explain why we need to enable the regulator. - use full name of the commiter - Link to v1: https://lore.kernel.org/lkml/ZYKjYypuAx7gNuam@debian.cyg/ arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi b/arch/arm/= boot/dts/allwinner/sun8i-r40-feta40i.dtsi index 9f39b5a2bb35..c12361d0317f 100644 --- a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi @@ -42,6 +42,13 @@ &pio { vcc-pg-supply =3D <®_dldo1>; }; =20 +®_aldo1 { + regulator-always-on; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + regulator-name =3D "vcc-3v3-tv-usb"; +}; + ®_aldo2 { regulator-always-on; regulator-min-microvolt =3D <1800000>; --=20 2.39.2