From nobody Fri Dec 19 08:03:57 2025 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 442A41DA3B for ; Thu, 21 Dec 2023 20:22:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M737iOJh" Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-4668e197c86so65162137.0 for ; Thu, 21 Dec 2023 12:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703190171; x=1703794971; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tlWO+EdyxwPW7Uhxu8/ReF7tvyUpNnVhta1PM1rJscI=; b=M737iOJhz3ELS7rH8oe8hPTNEjpvDXpvC7RKu94b1ylTMgXMJ/Ahr+d4fIIwxxWEym qwKvfmLB89MSyUKMX43vzfg8b9nTDv/LaJvSWiXHQyjMDoSCDiQ/IZG/BPhbnxa8YgXP Pha+W9vL2BOmsGCqUA7BHEgv4naIqfxTLxjGkplxJeRpBTL/I8PfYC8m+EaR9Q7tvxVR XacRMCllynswHBLeIK4pWASP6yMMQxGQIHktu3sJ5KhvAzbVA5TvLzBPyN1zSUut3SYb 9wm9Gg3Uh11qG+k50LobjDz0T9xjbXe1Mw9XEUc0fQbwk32+KRTkp3pfgGnvomuJnvnS g2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703190171; x=1703794971; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tlWO+EdyxwPW7Uhxu8/ReF7tvyUpNnVhta1PM1rJscI=; b=HspDLAuwMmDX024LhNpbVl7sF1w/VHJLYs+/ptDiuYYHMGDw7z5PR0I5K17/f604mW /tlWa9FtLjv+/yZ/Pj9UMEOsOTDm9Ps7bGs8UYsywbvkRzMTt2spOonTMEaqREhNZDGZ ygtH1CesiT45paxLni7tMSsi/0DzrKmbB7RkZ81h9tkYYToJ6YabcVHzREh/cGKEUIjC K3bk+17r4N0mRIKYmGDZ0k3Teh3NlC6/R4QNjXHhtBYC39PHxteeXfmcAu2fWCYbk2y3 moZPVMt4izXHarF3tKukwo7+HMd4uECoMQHPMdj961UeOlW6RI37isH/DYICWebvMM+3 WCSQ== X-Gm-Message-State: AOJu0Yze9x9lQIHf7xGYVlZwU0UfFZEMUWJLcln1a7OlBimmPnVR0ElA FBdsvd8rI1R2gyU4reBzpSI= X-Google-Smtp-Source: AGHT+IFwKL3HEDsRvlFvkG3PEcM4iKVZdyiyyOlbnk79n609Jp2eYb52eTQtEHx3WUhctvs3HeMj9Q== X-Received: by 2002:a05:6102:837:b0:466:9404:a839 with SMTP id k23-20020a056102083700b004669404a839mr304098vsb.1.1703190170607; Thu, 21 Dec 2023 12:22:50 -0800 (PST) Received: from kernel.ryanengland.xyz ([2600:3c05::f03c:94ff:fea1:5b99]) by smtp.gmail.com with ESMTPSA id ek2-20020ad45982000000b0067f339c0c16sm854633qvb.134.2023.12.21.12.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 12:22:48 -0800 (PST) Date: Thu, 21 Dec 2023 20:22:48 +0000 From: Ryan England To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH v2] staging: rtl8712: fix open parentheses alignment Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adhere to Linux kernel coding style. Reported by checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by: Ryan England --- Made corrections give the 100 line limit. Resending v2 as no change was made other than including this comment below ---. Thank you for the correction. Here's to learning with every submission. drivers/staging/rtl8712/os_intfs.c | 3 +- drivers/staging/rtl8712/rtl8712_efuse.c | 9 +- drivers/staging/rtl8712/rtl8712_recv.c | 3 +- drivers/staging/rtl8712/rtl8712_xmit.c | 60 +++--- drivers/staging/rtl8712/rtl871x_cmd.c | 159 +++++--------- drivers/staging/rtl8712/rtl871x_cmd.h | 37 ++-- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 203 +++++++----------- 7 files changed, 173 insertions(+), 301 deletions(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/o= s_intfs.c index b18e6d9c832b..7554613fe7e1 100644 --- a/drivers/staging/rtl8712/os_intfs.c +++ b/drivers/staging/rtl8712/os_intfs.c @@ -221,8 +221,7 @@ struct net_device *r8712_init_netdev(void) =20 static u32 start_drv_threads(struct _adapter *padapter) { - padapter->cmd_thread =3D kthread_run(r8712_cmd_thread, padapter, "%s", - padapter->pnetdev->name); + padapter->cmd_thread =3D kthread_run(r8712_cmd_thread, padapter, "%s", pa= dapter->pnetdev->name); if (IS_ERR(padapter->cmd_thread)) return _FAIL; return _SUCCESS; diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8= 712/rtl8712_efuse.c index c9400e40a1d6..a39d6c06648f 100644 --- a/drivers/staging/rtl8712/rtl8712_efuse.c +++ b/drivers/staging/rtl8712/rtl8712_efuse.c @@ -213,8 +213,8 @@ u16 r8712_efuse_get_current_size(struct _adapter *adapt= er) u8 hworden =3D 0; u8 efuse_data, word_cnts =3D 0; =20 - while (bContinual && efuse_one_byte_read(adapter, efuse_addr, - &efuse_data) && (efuse_addr < efuse_available_max_size)) { + while (bContinual && efuse_one_byte_read(adapter, efuse_addr, &efuse_data= ) && + (efuse_addr < efuse_available_max_size)) { if (efuse_data !=3D 0xFF) { hworden =3D efuse_data & 0x0F; word_cnts =3D calculate_word_cnts(hworden); @@ -252,9 +252,8 @@ u8 r8712_efuse_pg_packet_read(struct _adapter *adapter,= u8 offset, u8 *data) memset(tmpdata, 0xFF, PGPKT_DATA_SIZE); for (tmpidx =3D 0; tmpidx < word_cnts * 2; tmpidx++) { - if (efuse_one_byte_read(adapter, - efuse_addr + 1 + tmpidx, - &efuse_data)) { + if (efuse_one_byte_read(adapter, efuse_addr + 1 + tmpidx, + &efuse_data)) { tmpdata[tmpidx] =3D efuse_data; } else { ret =3D false; diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl87= 12/rtl8712_recv.c index 7da014ab0723..a3c4713c59b3 100644 --- a/drivers/staging/rtl8712/rtl8712_recv.c +++ b/drivers/staging/rtl8712/rtl8712_recv.c @@ -267,8 +267,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _ad= apter *padapter, /*the first fragment*/ if (!list_empty(&pdefrag_q->queue)) { /*free current defrag_q */ - r8712_free_recvframe_queue(pdefrag_q, - pfree_recv_queue); + r8712_free_recvframe_queue(pdefrag_q, pfree_recv_queue); } } /* Then enqueue the 0~(n-1) fragment to the defrag_q */ diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl87= 12/rtl8712_xmit.c index 4cb01f590673..d7d678b04ca8 100644 --- a/drivers/staging/rtl8712/rtl8712_xmit.c +++ b/drivers/staging/rtl8712/rtl8712_xmit.c @@ -147,9 +147,8 @@ static u32 get_ff_hwaddr(struct xmit_frame *pxmitframe) } =20 static struct xmit_frame *dequeue_one_xmitframe(struct xmit_priv *pxmitpri= v, - struct hw_xmit *phwxmit, - struct tx_servq *ptxservq, - struct __queue *pframe_queue) + struct hw_xmit *phwxmit, struct tx_servq *ptxservq, + struct __queue *pframe_queue) { struct list_head *xmitframe_plist, *xmitframe_phead; struct xmit_frame *pxmitframe =3D NULL; @@ -167,7 +166,7 @@ static struct xmit_frame *dequeue_one_xmitframe(struct = xmit_priv *pxmitpriv, } =20 static struct xmit_frame *dequeue_xframe_ex(struct xmit_priv *pxmitpriv, - struct hw_xmit *phwxmit_i, sint entry) + struct hw_xmit *phwxmit_i, sint entry) { unsigned long irqL0; struct list_head *sta_plist, *sta_phead; @@ -197,11 +196,10 @@ static struct xmit_frame *dequeue_xframe_ex(struct xm= it_priv *pxmitpriv, sta_phead =3D &phwxmit->sta_queue->queue; sta_plist =3D sta_phead->next; while (!end_of_queue_search(sta_phead, sta_plist)) { - ptxservq =3D container_of(sta_plist, struct tx_servq, - tx_pending); + ptxservq =3D container_of(sta_plist, struct tx_servq, tx_pending); pframe_queue =3D &ptxservq->sta_pending; - pxmitframe =3D dequeue_one_xmitframe(pxmitpriv, phwxmit, - ptxservq, pframe_queue); + pxmitframe =3D dequeue_one_xmitframe(pxmitpriv, phwxmit, ptxservq, + pframe_queue); if (pxmitframe) { phwxmit->accnt--; goto exit_dequeue_xframe_ex; @@ -221,8 +219,7 @@ static struct xmit_frame *dequeue_xframe_ex(struct xmit= _priv *pxmitpriv, return pxmitframe; } =20 -void r8712_do_queue_select(struct _adapter *padapter, - struct pkt_attrib *pattrib) +void r8712_do_queue_select(struct _adapter *padapter, struct pkt_attrib *p= attrib) { unsigned int qsel =3D 0; struct dvobj_priv *pdvobj =3D &padapter->dvobjpriv; @@ -292,14 +289,12 @@ void r8712_append_mpdu_unit(struct xmit_buf *pxmitbuf, r8712_xmit_complete(padapter, pxmitframe); if (pxmitframe->attrib.ether_type !=3D 0x0806) { if ((pxmitframe->attrib.ether_type !=3D 0x888e) && - (pxmitframe->attrib.dhcp_pkt !=3D 1)) { - r8712_issue_addbareq_cmd(padapter, - pxmitframe->attrib.priority); + (pxmitframe->attrib.dhcp_pkt !=3D 1)) { + r8712_issue_addbareq_cmd(padapter, pxmitframe->attrib.priority); } } pxmitframe->last[0] =3D 1; - update_txdesc(pxmitframe, (uint *)(pxmitframe->buf_addr), - pxmitframe->attrib.last_txcmdsz); + update_txdesc(pxmitframe, (uint *)(pxmitframe->buf_addr), pxmitframe->att= rib.last_txcmdsz); /*padding zero */ last_txcmdsz =3D pxmitframe->attrib.last_txcmdsz; padding_sz =3D (8 - (last_txcmdsz % 8)); @@ -333,8 +328,7 @@ void r8712_xmitframe_aggr_1st(struct xmit_buf *pxmitbuf, pxmitbuf->aggr_nr =3D 1; } =20 -u16 r8712_xmitframe_aggr_next(struct xmit_buf *pxmitbuf, - struct xmit_frame *pxmitframe) +u16 r8712_xmitframe_aggr_next(struct xmit_buf *pxmitbuf, struct xmit_frame= *pxmitframe) { pxmitframe->pxmitbuf =3D pxmitbuf; pxmitbuf->priv_data =3D pxmitframe; @@ -374,9 +368,9 @@ void r8712_dump_aggr_xframe(struct xmit_buf *pxmitbuf, pxmitframe->bpending[0] =3D false; pxmitframe->mem_addr =3D pxmitbuf->pbuf; =20 - if ((pdvobj->ishighspeed && ((total_length + TXDESC_SIZE) % 0x200) =3D=3D - 0) || ((!pdvobj->ishighspeed && ((total_length + TXDESC_SIZE) % - 0x40) =3D=3D 0))) { + if ((pdvobj->ishighspeed && ((total_length + TXDESC_SIZE) % 0x200) =3D=3D= 0) || + ((!pdvobj->ishighspeed && ((total_length + TXDESC_SIZE) % + 0x40) =3D=3D 0))) { ptxdesc->txdw0 |=3D cpu_to_le32 (((TXDESC_SIZE + OFFSET_SZ + 8) << OFFSET_SHT) & 0x00ff0000); @@ -387,8 +381,8 @@ void r8712_dump_aggr_xframe(struct xmit_buf *pxmitbuf, 0x00ff0000); /*default =3D 32 bytes for TX Desc*/ } - r8712_write_port(pxmitframe->padapter, RTL8712_DMA_H2CCMD, - total_length + TXDESC_SIZE, (u8 *)pxmitframe); + r8712_write_port(pxmitframe->padapter, RTL8712_DMA_H2CCMD, total_length += TXDESC_SIZE, + (u8 *)pxmitframe); } =20 #endif @@ -618,14 +612,12 @@ int r8712_xmitframe_complete(struct _adapter *padapte= r, pxmitframe =3D dequeue_xframe_ex(pxmitpriv, phwxmits, hwentry); /* need to remember the 1st frame */ if (pxmitframe) { - #ifdef CONFIG_R8712_TX_AGGR /* 1. dequeue 2nd frame * 2. aggr if 2nd xframe is dequeued, else dump directly */ if (AGGR_NR_HIGH_BOUND > 1) - p2ndxmitframe =3D dequeue_xframe_ex(pxmitpriv, phwxmits, - hwentry); + p2ndxmitframe =3D dequeue_xframe_ex(pxmitpriv, phwxmits, hwentry); if (pxmitframe->frame_tag !=3D DATA_FRAMETAG) { r8712_free_xmitbuf(pxmitpriv, pxmitbuf); return false; @@ -639,16 +631,12 @@ int r8712_xmitframe_complete(struct _adapter *padapte= r, if (p2ndxmitframe) { u16 total_length; =20 - total_length =3D r8712_xmitframe_aggr_next( - pxmitbuf, p2ndxmitframe); + total_length =3D r8712_xmitframe_aggr_next(pxmitbuf, p2ndxmitframe); do { - p2ndxmitframe =3D dequeue_xframe_ex( - pxmitpriv, phwxmits, hwentry); + p2ndxmitframe =3D dequeue_xframe_ex(pxmitpriv, phwxmits, hwentry); if (p2ndxmitframe) total_length =3D - r8712_xmitframe_aggr_next( - pxmitbuf, - p2ndxmitframe); + r8712_xmitframe_aggr_next(pxmitbuf, p2ndxmitframe); else break; } while (total_length <=3D 0x1800 && @@ -662,8 +650,8 @@ int r8712_xmitframe_complete(struct _adapter *padapter, xmitframe_xmitbuf_attach(pxmitframe, pxmitbuf); if (pxmitframe->frame_tag =3D=3D DATA_FRAMETAG) { if (pxmitframe->attrib.priority <=3D 15) - res =3D r8712_xmitframe_coalesce(padapter, - pxmitframe->pkt, pxmitframe); + res =3D r8712_xmitframe_coalesce(padapter, pxmitframe->pkt, + pxmitframe); /* always return ndis_packet after * r8712_xmitframe_coalesce */ @@ -714,10 +702,10 @@ static void dump_xframe(struct _adapter *padapter, ff_hwaddr =3D get_ff_hwaddr(pxmitframe); #ifdef CONFIG_R8712_TX_AGGR r8712_write_port(padapter, RTL8712_DMA_H2CCMD, w_sz, - (unsigned char *)pxmitframe); + (unsigned char *)pxmitframe); #else r8712_write_port(padapter, ff_hwaddr, w_sz, - (unsigned char *)pxmitframe); + (unsigned char *)pxmitframe); #endif mem_addr +=3D w_sz; mem_addr =3D (u8 *)RND4(((addr_t)(mem_addr))); diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl871= 2/rtl871x_cmd.c index 4be96df5a329..bbd4a13c7bb9 100644 --- a/drivers/staging/rtl8712/rtl871x_cmd.c +++ b/drivers/staging/rtl8712/rtl871x_cmd.c @@ -242,8 +242,7 @@ void r8712_set_chplan_cmd(struct _adapter *padapter, in= t chplan) kfree(ph2c); return; } - init_h2fwcmd_w_parm_no_rsp(ph2c, psetchplanpara, - GEN_CMD_CODE(_SetChannelPlan)); + init_h2fwcmd_w_parm_no_rsp(ph2c, psetchplanpara, GEN_CMD_CODE(_SetChannel= Plan)); psetchplanpara->ChannelPlan =3D chplan; r8712_enqueue_cmd(pcmdpriv, ph2c); } @@ -302,8 +301,7 @@ void r8712_getbbrfreg_cmdrsp_callback(struct _adapter *= padapter, padapter->mppriv.workparam.bcompleted =3D true; } =20 -void r8712_readtssi_cmdrsp_callback(struct _adapter *padapter, - struct cmd_obj *pcmd) +void r8712_readtssi_cmdrsp_callback(struct _adapter *padapter, struct cmd_= obj *pcmd) { kfree(pcmd->parmbuf); kfree(pcmd); @@ -374,11 +372,10 @@ int r8712_joinbss_cmd(struct _adapter *padapter, str= uct wlan_network *pnetwork) psecuritypriv->authenticator_ie[0] =3D (unsigned char) psecnetwork->IELength; if ((psecnetwork->IELength - 12) < (256 - 1)) - memcpy(&psecuritypriv->authenticator_ie[1], - &psecnetwork->IEs[12], psecnetwork->IELength - 12); + memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], + psecnetwork->IELength - 12); else - memcpy(&psecuritypriv->authenticator_ie[1], - &psecnetwork->IEs[12], (256 - 1)); + memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], (256 = - 1)); psecnetwork->IELength =3D 0; /* * If the driver wants to use the bssid to create the connection. @@ -388,19 +385,15 @@ int r8712_joinbss_cmd(struct _adapter *padapter, str= uct wlan_network *pnetwork) if (!pmlmepriv->assoc_by_bssid) ether_addr_copy(&pmlmepriv->assoc_bssid[0], &pnetwork->network.MacAddress[0]); - psecnetwork->IELength =3D r8712_restruct_sec_ie(padapter, - &pnetwork->network.IEs[0], - &psecnetwork->IEs[0], - pnetwork->network.IELength); + psecnetwork->IELength =3D r8712_restruct_sec_ie(padapter, &pnetwork->netw= ork.IEs[0], + &psecnetwork->IEs[0], pnetwork->network.IELength); pqospriv->qos_option =3D 0; if (pregistrypriv->wmm_enable) { u32 tmp_len; =20 - tmp_len =3D r8712_restruct_wmm_ie(padapter, - &pnetwork->network.IEs[0], - &psecnetwork->IEs[0], - pnetwork->network.IELength, - psecnetwork->IELength); + tmp_len =3D r8712_restruct_wmm_ie(padapter, &pnetwork->network.IEs[0], + &psecnetwork->IEs[0], pnetwork->network.IELength, + psecnetwork->IELength); if (psecnetwork->IELength !=3D tmp_len) { psecnetwork->IELength =3D tmp_len; pqospriv->qos_option =3D 1; /* WMM IE in beacon */ @@ -427,39 +420,28 @@ int r8712_joinbss_cmd(struct _adapter *padapter, str= uct wlan_network *pnetwork) psecuritypriv->supplicant_ie[0] =3D (u8)psecnetwork->IELength; if (psecnetwork->IELength < 255) memcpy(&psecuritypriv->supplicant_ie[1], &psecnetwork->IEs[0], - psecnetwork->IELength); + psecnetwork->IELength); else memcpy(&psecuritypriv->supplicant_ie[1], &psecnetwork->IEs[0], - 255); + 255); /* get cmdsz before endian conversion */ pcmd->cmdsz =3D r8712_get_wlan_bssid_ex_sz(psecnetwork); #ifdef __BIG_ENDIAN /* wlan_network endian conversion */ psecnetwork->Length =3D cpu_to_le32(psecnetwork->Length); - psecnetwork->Ssid.SsidLength =3D cpu_to_le32( - psecnetwork->Ssid.SsidLength); + psecnetwork->Ssid.SsidLength =3D cpu_to_le32(psecnetwork->Ssid.SsidLength= ); psecnetwork->Privacy =3D cpu_to_le32(psecnetwork->Privacy); psecnetwork->Rssi =3D cpu_to_le32(psecnetwork->Rssi); - psecnetwork->NetworkTypeInUse =3D cpu_to_le32( - psecnetwork->NetworkTypeInUse); - psecnetwork->Configuration.ATIMWindow =3D cpu_to_le32( - psecnetwork->Configuration.ATIMWindow); - psecnetwork->Configuration.BeaconPeriod =3D cpu_to_le32( - psecnetwork->Configuration.BeaconPeriod); - psecnetwork->Configuration.DSConfig =3D cpu_to_le32( - psecnetwork->Configuration.DSConfig); - psecnetwork->Configuration.FHConfig.DwellTime =3D cpu_to_le32( - psecnetwork->Configuration.FHConfig.DwellTime); - psecnetwork->Configuration.FHConfig.HopPattern =3D cpu_to_le32( - psecnetwork->Configuration.FHConfig.HopPattern); - psecnetwork->Configuration.FHConfig.HopSet =3D cpu_to_le32( - psecnetwork->Configuration.FHConfig.HopSet); - psecnetwork->Configuration.FHConfig.Length =3D cpu_to_le32( - psecnetwork->Configuration.FHConfig.Length); - psecnetwork->Configuration.Length =3D cpu_to_le32( - psecnetwork->Configuration.Length); - psecnetwork->InfrastructureMode =3D cpu_to_le32( - psecnetwork->InfrastructureMode); + psecnetwork->NetworkTypeInUse =3D cpu_to_le32(psecnetwork->NetworkTypeInU= se); + psecnetwork->Configuration.ATIMWindow =3D cpu_to_le32(psecnetwork->Config= uration.ATIMWindow); + psecnetwork->Configuration.BeaconPeriod =3D cpu_to_le32(psecnetwork->Conf= iguration.BeaconPeriod); + psecnetwork->Configuration.DSConfig =3D cpu_to_le32(psecnetwork->Configur= ation.DSConfig); + psecnetwork->Configuration.FHConfig.DwellTime =3D cpu_to_le32(psecnetwork= ->Configuration.FHConfig.DwellTime); + psecnetwork->Configuration.FHConfig.HopPattern =3D cpu_to_le32(psecnetwor= k->Configuration.FHConfig.HopPattern); + psecnetwork->Configuration.FHConfig.HopSet =3D cpu_to_le32(psecnetwork->C= onfiguration.FHConfig.HopSet); + psecnetwork->Configuration.FHConfig.Length =3D cpu_to_le32(psecnetwork->C= onfiguration.FHConfig.Length); + psecnetwork->Configuration.Length =3D cpu_to_le32(psecnetwork->Configurat= ion.Length); + psecnetwork->InfrastructureMode =3D cpu_to_le32(psecnetwork->Infrastructu= reMode); psecnetwork->IELength =3D cpu_to_le32(psecnetwork->IELength); #endif INIT_LIST_HEAD(&pcmd->list); @@ -485,13 +467,12 @@ void r8712_disassoc_cmd(struct _adapter *padapter) /*= for sta_mode */ kfree(pdisconnect_cmd); return; } - init_h2fwcmd_w_parm_no_rsp(pdisconnect_cmd, pdisconnect, - _DisConnect_CMD_); + init_h2fwcmd_w_parm_no_rsp(pdisconnect_cmd, pdisconnect, _DisConnect_CMD_= ); r8712_enqueue_cmd(pcmdpriv, pdisconnect_cmd); } =20 void r8712_setopmode_cmd(struct _adapter *padapter, - enum NDIS_802_11_NETWORK_INFRASTRUCTURE networktype) + enum NDIS_802_11_NETWORK_INFRASTRUCTURE networktype) { struct cmd_obj *ph2c; struct setopmode_parm *psetop; @@ -543,14 +524,12 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u= 8 *psta, u8 unicast_key) psetstakey_para->algorithm =3D (unsigned char) psecuritypriv->PrivacyAlgrthm; else - GET_ENCRY_ALGO(psecuritypriv, sta, - psetstakey_para->algorithm, false); + GET_ENCRY_ALGO(psecuritypriv, sta, psetstakey_para->algorithm, false); if (unicast_key) memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16); else - memcpy(&psetstakey_para->key, - &psecuritypriv->XGrpKey[ - psecuritypriv->XGrpKeyid - 1]. skey, 16); + memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGr= pKeyid - 1]. + skey, 16); r8712_enqueue_cmd(pcmdpriv, ph2c); } =20 @@ -568,8 +547,7 @@ void r8712_setMacAddr_cmd(struct _adapter *padapter, co= nst u8 *mac_addr) kfree(ph2c); return; } - init_h2fwcmd_w_parm_no_rsp(ph2c, psetMacAddr_para, - _SetMacAddress_CMD_); + init_h2fwcmd_w_parm_no_rsp(ph2c, psetMacAddr_para, _SetMacAddress_CMD_); ether_addr_copy(psetMacAddr_para->MacAddr, mac_addr); r8712_enqueue_cmd(pcmdpriv, ph2c); } @@ -589,8 +567,7 @@ void r8712_addbareq_cmd(struct _adapter *padapter, u8 t= id) return; } paddbareq_parm->tid =3D tid; - init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm, - GEN_CMD_CODE(_AddBAReq)); + init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm, GEN_CMD_CODE(_AddBAReq)); r8712_enqueue_cmd_ex(pcmdpriv, ph2c); } =20 @@ -644,13 +621,11 @@ void r8712_joinbss_cmd_callback(struct _adapter *pada= pter, struct cmd_obj *pcmd) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 if (pcmd->res !=3D H2C_SUCCESS) - mod_timer(&pmlmepriv->assoc_timer, - jiffies + msecs_to_jiffies(1)); + mod_timer(&pmlmepriv->assoc_timer, jiffies + msecs_to_jiffies(1)); r8712_free_cmd_obj(pcmd); } =20 -void r8712_createbss_cmd_callback(struct _adapter *padapter, - struct cmd_obj *pcmd) +void r8712_createbss_cmd_callback(struct _adapter *padapter, struct cmd_ob= j *pcmd) { unsigned long irqL; struct sta_info *psta =3D NULL; @@ -660,8 +635,7 @@ void r8712_createbss_cmd_callback(struct _adapter *pada= pter, struct wlan_network *tgt_network =3D &(pmlmepriv->cur_network); =20 if (pcmd->res !=3D H2C_SUCCESS) - mod_timer(&pmlmepriv->assoc_timer, - jiffies + msecs_to_jiffies(1)); + mod_timer(&pmlmepriv->assoc_timer, jiffies + msecs_to_jiffies(1)); del_timer(&pmlmepriv->assoc_timer); #ifdef __BIG_ENDIAN /* endian_convert */ @@ -670,31 +644,21 @@ void r8712_createbss_cmd_callback(struct _adapter *pa= dapter, pnetwork->Privacy =3D le32_to_cpu(pnetwork->Privacy); pnetwork->Rssi =3D le32_to_cpu(pnetwork->Rssi); pnetwork->NetworkTypeInUse =3D le32_to_cpu(pnetwork->NetworkTypeInUse); - pnetwork->Configuration.ATIMWindow =3D - le32_to_cpu(pnetwork->Configuration.ATIMWindow); - pnetwork->Configuration.DSConfig =3D - le32_to_cpu(pnetwork->Configuration.DSConfig); - pnetwork->Configuration.FHConfig.DwellTime =3D - le32_to_cpu(pnetwork->Configuration.FHConfig.DwellTime); - pnetwork->Configuration.FHConfig.HopPattern =3D - le32_to_cpu(pnetwork->Configuration.FHConfig.HopPattern); - pnetwork->Configuration.FHConfig.HopSet =3D - le32_to_cpu(pnetwork->Configuration.FHConfig.HopSet); - pnetwork->Configuration.FHConfig.Length =3D - le32_to_cpu(pnetwork->Configuration.FHConfig.Length); - pnetwork->Configuration.Length =3D - le32_to_cpu(pnetwork->Configuration.Length); - pnetwork->InfrastructureMode =3D - le32_to_cpu(pnetwork->InfrastructureMode); + pnetwork->Configuration.ATIMWindow =3D le32_to_cpu(pnetwork->Configuratio= n.ATIMWindow); + pnetwork->Configuration.DSConfig =3D le32_to_cpu(pnetwork->Configuration.= DSConfig); + pnetwork->Configuration.FHConfig.DwellTime =3D le32_to_cpu(pnetwork->Conf= iguration.FHConfig.DwellTime); + pnetwork->Configuration.FHConfig.HopPattern =3D le32_to_cpu(pnetwork->Con= figuration.FHConfig.HopPattern); + pnetwork->Configuration.FHConfig.HopSet =3D le32_to_cpu(pnetwork->Configu= ration.FHConfig.HopSet); + pnetwork->Configuration.FHConfig.Length =3D le32_to_cpu(pnetwork->Configu= ration.FHConfig.Length); + pnetwork->Configuration.Length =3D le32_to_cpu(pnetwork->Configuration.Le= ngth); + pnetwork->InfrastructureMode =3D le32_to_cpu(pnetwork->InfrastructureMode= ); pnetwork->IELength =3D le32_to_cpu(pnetwork->IELength); #endif spin_lock_irqsave(&pmlmepriv->lock, irqL); if ((pmlmepriv->fw_state) & WIFI_AP_STATE) { - psta =3D r8712_get_stainfo(&padapter->stapriv, - pnetwork->MacAddress); + psta =3D r8712_get_stainfo(&padapter->stapriv, pnetwork->MacAddress); if (!psta) { - psta =3D r8712_alloc_stainfo(&padapter->stapriv, - pnetwork->MacAddress); + psta =3D r8712_alloc_stainfo(&padapter->stapriv, pnetwork->MacAddress); if (!psta) goto createbss_cmd_fail; } @@ -702,20 +666,17 @@ void r8712_createbss_cmd_callback(struct _adapter *pa= dapter, } else { pwlan =3D _r8712_alloc_network(pmlmepriv); if (!pwlan) { - pwlan =3D r8712_get_oldest_wlan_network( - &pmlmepriv->scanned_queue); + pwlan =3D r8712_get_oldest_wlan_network(&pmlmepriv->scanned_queue); if (!pwlan) goto createbss_cmd_fail; pwlan->last_scanned =3D jiffies; } else { - list_add_tail(&(pwlan->list), - &pmlmepriv->scanned_queue.queue); + list_add_tail(&(pwlan->list), &pmlmepriv->scanned_queue.queue); } pnetwork->Length =3D r8712_get_wlan_bssid_ex_sz(pnetwork); memcpy(&(pwlan->network), pnetwork, pnetwork->Length); pwlan->fixed =3D true; - memcpy(&tgt_network->network, pnetwork, - (r8712_get_wlan_bssid_ex_sz(pnetwork))); + memcpy(&tgt_network->network, pnetwork, (r8712_get_wlan_bssid_ex_sz(pnet= work))); if (pmlmepriv->fw_state & _FW_UNDER_LINKING) pmlmepriv->fw_state ^=3D _FW_UNDER_LINKING; /* @@ -728,14 +689,11 @@ void r8712_createbss_cmd_callback(struct _adapter *pa= dapter, r8712_free_cmd_obj(pcmd); } =20 -void r8712_setstaKey_cmdrsp_callback(struct _adapter *padapter, - struct cmd_obj *pcmd) +void r8712_setstaKey_cmdrsp_callback(struct _adapter *padapter, struct cmd= _obj *pcmd) { struct sta_priv *pstapriv =3D &padapter->stapriv; - struct set_stakey_rsp *psetstakey_rsp =3D (struct set_stakey_rsp *) - (pcmd->rsp); - struct sta_info *psta =3D r8712_get_stainfo(pstapriv, - psetstakey_rsp->addr); + struct set_stakey_rsp *psetstakey_rsp =3D (struct set_stakey_rsp *) (pcmd= ->rsp); + struct sta_info *psta =3D r8712_get_stainfo(pstapriv, psetstakey_rsp->add= r); =20 if (!psta) goto exit; @@ -750,27 +708,23 @@ void r8712_setassocsta_cmdrsp_callback(struct _adapte= r *padapter, unsigned long irqL; struct sta_priv *pstapriv =3D &padapter->stapriv; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct set_assocsta_parm *passocsta_parm =3D - (struct set_assocsta_parm *)(pcmd->parmbuf); - struct set_assocsta_rsp *passocsta_rsp =3D - (struct set_assocsta_rsp *) (pcmd->rsp); - struct sta_info *psta =3D r8712_get_stainfo(pstapriv, - passocsta_parm->addr); + struct set_assocsta_parm *passocsta_parm =3D (struct set_assocsta_parm *)= (pcmd->parmbuf); + struct set_assocsta_rsp *passocsta_rsp =3D (struct set_assocsta_rsp *) (p= cmd->rsp); + struct sta_info *psta =3D r8712_get_stainfo(pstapriv, passocsta_parm->add= r); =20 if (!psta) return; psta->aid =3D psta->mac_id =3D passocsta_rsp->cam_id; spin_lock_irqsave(&pmlmepriv->lock, irqL); - if ((check_fwstate(pmlmepriv, WIFI_MP_STATE)) && - (check_fwstate(pmlmepriv, _FW_UNDER_LINKING))) + if ((check_fwstate(pmlmepriv, WIFI_MP_STATE)) && (check_fwstate(pmlmepriv= , _FW_UNDER_LINKING))) pmlmepriv->fw_state ^=3D _FW_UNDER_LINKING; set_fwstate(pmlmepriv, _FW_LINKED); spin_unlock_irqrestore(&pmlmepriv->lock, irqL); r8712_free_cmd_obj(pcmd); } =20 -void r8712_disconnectCtrlEx_cmd(struct _adapter *adapter, u32 enableDrvCtr= l, - u32 tryPktCnt, u32 tryPktInterval, u32 firstStageTO) +void r8712_disconnectCtrlEx_cmd(struct _adapter *adapter, u32 enableDrvCtr= l, u32 tryPktCnt, + u32 tryPktInterval, u32 firstStageTO) { struct cmd_obj *ph2c; struct DisconnectCtrlEx_param *param; @@ -790,7 +744,6 @@ void r8712_disconnectCtrlEx_cmd(struct _adapter *adapte= r, u32 enableDrvCtrl, param->TryPktInterval =3D (unsigned char)tryPktInterval; param->FirstStageTO =3D (unsigned int)firstStageTO; =20 - init_h2fwcmd_w_parm_no_rsp(ph2c, param, - GEN_CMD_CODE(_DisconnectCtrlEx)); + init_h2fwcmd_w_parm_no_rsp(ph2c, param, GEN_CMD_CODE(_DisconnectCtrlEx)); r8712_enqueue_cmd(pcmdpriv, ph2c); } diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl871= 2/rtl871x_cmd.h index 8453d8de8248..2613b3c2acfc 100644 --- a/drivers/staging/rtl8712/rtl871x_cmd.h +++ b/drivers/staging/rtl8712/rtl871x_cmd.h @@ -716,39 +716,28 @@ struct DisconnectCtrlEx_param { #define H2C_RESERVED 0x07 =20 void r8712_setMacAddr_cmd(struct _adapter *padapter, const u8 *mac_addr); -u8 r8712_sitesurvey_cmd(struct _adapter *padapter, - struct ndis_802_11_ssid *pssid); +u8 r8712_sitesurvey_cmd(struct _adapter *padapter, struct ndis_802_11_ssid= *pssid); int r8712_createbss_cmd(struct _adapter *padapter); void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_k= ey); -int r8712_joinbss_cmd(struct _adapter *padapter, - struct wlan_network *pnetwork); +int r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network *pnet= work); void r8712_disassoc_cmd(struct _adapter *padapter); -void r8712_setopmode_cmd(struct _adapter *padapter, - enum NDIS_802_11_NETWORK_INFRASTRUCTURE networktype); +void r8712_setopmode_cmd(struct _adapter *padapter, enum NDIS_802_11_NETWO= RK_INFRASTRUCTURE networktype); int r8712_setdatarate_cmd(struct _adapter *padapter, u8 *rateset); void r8712_set_chplan_cmd(struct _adapter *padapter, int chplan); int r8712_getrfreg_cmd(struct _adapter *padapter, u8 offset, u8 *pval); int r8712_setrfreg_cmd(struct _adapter *padapter, u8 offset, u32 val); void r8712_addbareq_cmd(struct _adapter *padapter, u8 tid); void r8712_wdg_wk_cmd(struct _adapter *padapter); -void r8712_survey_cmd_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_disassoc_cmd_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_joinbss_cmd_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_createbss_cmd_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_getbbrfreg_cmdrsp_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_readtssi_cmdrsp_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_setstaKey_cmdrsp_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_setassocsta_cmdrsp_callback(struct _adapter *padapter, - struct cmd_obj *pcmd); -void r8712_disconnectCtrlEx_cmd(struct _adapter *adapter, u32 enableDrvCtr= l, - u32 tryPktCnt, u32 tryPktInterval, u32 firstStageTO); +void r8712_survey_cmd_callback(struct _adapter *padapter, struct cmd_obj = *pcmd); +void r8712_disassoc_cmd_callback(struct _adapter *padapter, struct cmd_ob= j *pcmd); +void r8712_joinbss_cmd_callback(struct _adapter *padapter, struct cmd_obj= *pcmd); +void r8712_createbss_cmd_callback(struct _adapter *padapter, struct cmd_ob= j *pcmd); +void r8712_getbbrfreg_cmdrsp_callback(struct _adapter *padapter, struct cm= d_obj *pcmd); +void r8712_readtssi_cmdrsp_callback(struct _adapter *padapter, struct cmd_= obj *pcmd); +void r8712_setstaKey_cmdrsp_callback(struct _adapter *padapter, struct cm= d_obj *pcmd); +void r8712_setassocsta_cmdrsp_callback(struct _adapter *padapter, struct = cmd_obj *pcmd); +void r8712_disconnectCtrlEx_cmd(struct _adapter *adapter, u32 enableDrvCtr= l, u32 tryPktCnt,=20 + u32 tryPktInterval, u32 firstStageTO); =20 struct _cmd_callback { u32 cmd_code; diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/stagin= g/rtl8712/rtl871x_ioctl_linux.c index 36f6904d25ab..0653aa27b1fa 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -59,8 +59,7 @@ void r8712_indicate_wx_assoc_event(struct _adapter *padap= ter) struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 wrqu.ap_addr.sa_family =3D ARPHRD_ETHER; - memcpy(wrqu.ap_addr.sa_data, pmlmepriv->cur_network.network.MacAddress, - ETH_ALEN); + memcpy(wrqu.ap_addr.sa_data, pmlmepriv->cur_network.network.MacAddress, E= TH_ALEN); wireless_send_event(padapter->pnetdev, SIOCGIWAP, &wrqu, NULL); } =20 @@ -111,11 +110,9 @@ static inline void handle_group_key(struct ieee_param = *param, memcpy(grk[param->u.crypt.idx - 1].skey, ¶m->u.crypt.key[24], 8); padapter->securitypriv.binstallGrpkey =3D true; - r8712_set_key(padapter, &padapter->securitypriv, - param->u.crypt.idx); + r8712_set_key(padapter, &padapter->securitypriv, param->u.crypt.idx); if (padapter->registrypriv.power_mgnt > PS_MODE_ACTIVE) { - if (padapter->registrypriv.power_mgnt !=3D - padapter->pwrctrlpriv.pwr_mode) + if (padapter->registrypriv.power_mgnt !=3D padapter->pwrctrlpriv.pwr_mo= de) mod_timer(&padapter->mlmepriv.dhcp_timer, jiffies + msecs_to_jiffies(60000)); } @@ -148,13 +145,11 @@ static noinline_for_stack char *translate_scan_wpa(st= ruct iw_request_info *info, memset(iwe, 0, sizeof(*iwe)); iwe->cmd =3D IWEVCUSTOM; iwe->u.data.length =3D (u16)strlen(buf); - start =3D iwe_stream_add_point(info, start, stop, - iwe, buf); + start =3D iwe_stream_add_point(info, start, stop, iwe, buf); memset(iwe, 0, sizeof(*iwe)); iwe->cmd =3D IWEVGENIE; iwe->u.data.length =3D (u16)wpa_len; - start =3D iwe_stream_add_point(info, start, stop, - iwe, wpa_ie); + start =3D iwe_stream_add_point(info, start, stop, iwe, wpa_ie); } if (rsn_len > 0) { memset(buf, 0, MAX_WPA_IE_LEN); @@ -168,13 +163,11 @@ static noinline_for_stack char *translate_scan_wpa(st= ruct iw_request_info *info, memset(iwe, 0, sizeof(*iwe)); iwe->cmd =3D IWEVCUSTOM; iwe->u.data.length =3D strlen(buf); - start =3D iwe_stream_add_point(info, start, stop, - iwe, buf); + start =3D iwe_stream_add_point(info, start, stop, iwe, buf); memset(iwe, 0, sizeof(*iwe)); iwe->cmd =3D IWEVGENIE; iwe->u.data.length =3D rsn_len; - start =3D iwe_stream_add_point(info, start, stop, iwe, - rsn_ie); + start =3D iwe_stream_add_point(info, start, stop, iwe, rsn_ie); } =20 return start; @@ -189,14 +182,11 @@ static noinline_for_stack char *translate_scan_wps(st= ruct iw_request_info *info, u8 wps_ie[512]; uint wps_ielen; =20 - if (r8712_get_wps_ie(pnetwork->network.IEs, - pnetwork->network.IELength, - wps_ie, &wps_ielen)) { + if (r8712_get_wps_ie(pnetwork->network.IEs, pnetwork->network.IELength, w= ps_ie, &wps_ielen)) { if (wps_ielen > 2) { iwe->cmd =3D IWEVGENIE; iwe->u.data.length =3D (u16)wps_ielen; - start =3D iwe_stream_add_point(info, start, stop, - iwe, wps_ie); + start =3D iwe_stream_add_point(info, start, stop, iwe, wps_ie); } } =20 @@ -259,16 +249,14 @@ static char *translate_scan(struct _adapter *padapter, start =3D iwe_stream_add_event(info, start, stop, &iwe, IW_EV_CHAR_LEN); /* Add mode */ iwe.cmd =3D SIOCGIWMODE; - memcpy((u8 *)&cap, r8712_get_capability_from_ie(pnetwork->network.IEs), - 2); + memcpy((u8 *)&cap, r8712_get_capability_from_ie(pnetwork->network.IEs), 2= ); le16_to_cpus(&cap); if (cap & (WLAN_CAPABILITY_IBSS | WLAN_CAPABILITY_ESS)) { if (cap & WLAN_CAPABILITY_ESS) iwe.u.mode =3D (u32)IW_MODE_MASTER; else iwe.u.mode =3D (u32)IW_MODE_ADHOC; - start =3D iwe_stream_add_event(info, start, stop, &iwe, - IW_EV_UINT_LEN); + start =3D iwe_stream_add_event(info, start, stop, &iwe, IW_EV_UINT_LEN); } /* Add frequency/channel */ iwe.cmd =3D SIOCGIWFREQ; @@ -276,28 +264,23 @@ static char *translate_scan(struct _adapter *padapter, /* check legal index */ u8 dsconfig =3D pnetwork->network.Configuration.DSConfig; =20 - if (dsconfig >=3D 1 && dsconfig <=3D sizeof( - ieee80211_wlan_frequencies) / sizeof(long)) - iwe.u.freq.m =3D - (s32)(ieee80211_wlan_frequencies - [dsconfig - 1] * 100000); + if (dsconfig >=3D 1 && dsconfig <=3D sizeof(ieee80211_wlan_frequencies) = / sizeof(long)) + iwe.u.freq.m =3D (s32)(ieee80211_wlan_frequencies[dsconfig - 1] * 10000= 0); else iwe.u.freq.m =3D 0; } iwe.u.freq.e =3D (s16)1; iwe.u.freq.i =3D (u8)pnetwork->network.Configuration.DSConfig; start =3D iwe_stream_add_event(info, start, stop, &iwe, - IW_EV_FREQ_LEN); + IW_EV_FREQ_LEN); /* Add encryption capability */ iwe.cmd =3D SIOCGIWENCODE; if (cap & WLAN_CAPABILITY_PRIVACY) - iwe.u.data.flags =3D (u16)(IW_ENCODE_ENABLED | - IW_ENCODE_NOKEY); + iwe.u.data.flags =3D (u16)(IW_ENCODE_ENABLED | IW_ENCODE_NOKEY); else iwe.u.data.flags =3D (u16)(IW_ENCODE_DISABLED); iwe.u.data.length =3D (u16)0; - start =3D iwe_stream_add_point(info, start, stop, &iwe, - pnetwork->network.Ssid.Ssid); + start =3D iwe_stream_add_point(info, start, stop, &iwe, pnetwork->network= .Ssid.Ssid); /*Add basic and extended rates */ current_val =3D start + iwe_stream_lcp_len(info); iwe.cmd =3D SIOCGIWRATE; @@ -307,10 +290,9 @@ static char *translate_scan(struct _adapter *padapter, i =3D 0; while (pnetwork->network.rates[i] !=3D 0) { /* Bit rate given in 500 kb/s units */ - iwe.u.bitrate.value =3D (pnetwork->network.rates[i++] & - 0x7F) * 500000; - current_val =3D iwe_stream_add_value(info, start, current_val, - stop, &iwe, IW_EV_PARAM_LEN); + iwe.u.bitrate.value =3D (pnetwork->network.rates[i++] & 0x7F) * 500000; + current_val =3D iwe_stream_add_value(info, start, current_val, stop, &iw= e, + IW_EV_PARAM_LEN); } /* Check if we added any event */ if ((current_val - start) > iwe_stream_lcp_len(info)) @@ -324,8 +306,7 @@ static char *translate_scan(struct _adapter *padapter, iwe.cmd =3D IWEVQUAL; rssi =3D r8712_signal_scale_mapping(pnetwork->network.Rssi); /* we only update signal_level (signal strength) that is rssi. */ - iwe.u.qual.updated =3D (u8)(IW_QUAL_QUAL_INVALID | IW_QUAL_LEVEL_UPDATED | - IW_QUAL_NOISE_INVALID); + iwe.u.qual.updated =3D (u8)(IW_QUAL_QUAL_INVALID | IW_QUAL_LEVEL_UPDATED = | IW_QUAL_NOISE_INVALID); iwe.u.qual.level =3D rssi; /* signal strength */ iwe.u.qual.qual =3D 0; /* signal quality */ iwe.u.qual.noise =3D 0; /* noise level */ @@ -490,71 +471,59 @@ static int r871x_set_wpa_ie(struct _adapter *padapter= , char *pie, goto exit; } if (r8712_parse_wpa_ie(buf, ielen, &group_cipher, - &pairwise_cipher) =3D=3D 0) { + &pairwise_cipher) =3D=3D 0) { padapter->securitypriv.AuthAlgrthm =3D 2; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; } if (r8712_parse_wpa2_ie(buf, ielen, &group_cipher, - &pairwise_cipher) =3D=3D 0) { + &pairwise_cipher) =3D=3D 0) { padapter->securitypriv.AuthAlgrthm =3D 2; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPA2PSK; } switch (group_cipher) { case WPA_CIPHER_NONE: - padapter->securitypriv.XGrpPrivacy =3D - _NO_PRIVACY_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11EncryptionDisabled; + padapter->securitypriv.XGrpPrivacy =3D _NO_PRIVACY_; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11EncryptionDisabl= ed; break; case WPA_CIPHER_WEP40: padapter->securitypriv.XGrpPrivacy =3D _WEP40_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption1Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enabl= ed; break; case WPA_CIPHER_TKIP: padapter->securitypriv.XGrpPrivacy =3D _TKIP_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption2Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption2Enabl= ed; break; case WPA_CIPHER_CCMP: padapter->securitypriv.XGrpPrivacy =3D _AES_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption3Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption3Enabl= ed; break; case WPA_CIPHER_WEP104: padapter->securitypriv.XGrpPrivacy =3D _WEP104_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption1Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enabl= ed; break; } switch (pairwise_cipher) { case WPA_CIPHER_NONE: - padapter->securitypriv.PrivacyAlgrthm =3D - _NO_PRIVACY_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11EncryptionDisabled; + padapter->securitypriv.PrivacyAlgrthm =3D _NO_PRIVACY_; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11EncryptionDisabl= ed; break; case WPA_CIPHER_WEP40: padapter->securitypriv.PrivacyAlgrthm =3D _WEP40_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption1Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enabl= ed; break; case WPA_CIPHER_TKIP: padapter->securitypriv.PrivacyAlgrthm =3D _TKIP_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption2Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption2Enabl= ed; break; case WPA_CIPHER_CCMP: padapter->securitypriv.PrivacyAlgrthm =3D _AES_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption3Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption3Enabl= ed; break; case WPA_CIPHER_WEP104: padapter->securitypriv.PrivacyAlgrthm =3D _WEP104_; - padapter->securitypriv.ndisencryptstatus =3D - Ndis802_11Encryption1Enabled; + padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enabl= ed; break; } padapter->securitypriv.wps_phase =3D false; @@ -574,8 +543,8 @@ static int r871x_set_wpa_ie(struct _adapter *padapter, = char *pie, (buf[cnt + 1] + 2) : (MAX_WPA_IE_LEN << 2); memcpy(padapter->securitypriv.wps_ie, - &buf[cnt], - padapter->securitypriv.wps_ie_len); + &buf[cnt], + padapter->securitypriv.wps_ie_len); padapter->securitypriv.wps_phase =3D true; netdev_info(padapter->pnetdev, "r8712u: SET WPS_IE, wps_phase=3D=3Dtr= ue\n"); @@ -592,8 +561,7 @@ static int r871x_set_wpa_ie(struct _adapter *padapter, = char *pie, return ret; } =20 -static int r8711_wx_get_name(struct net_device *dev, - struct iw_request_info *info, +static int r8711_wx_get_name(struct net_device *dev, struct iw_request_inf= o *info, union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); @@ -604,8 +572,7 @@ static int r8711_wx_get_name(struct net_device *dev, struct wlan_bssid_ex *pcur_bss =3D &pmlmepriv->cur_network.network; u8 *prates; =20 - if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE) =3D=3D - true) { + if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE) =3D=3D= true) { /* parsing HT_CAP_IE */ p =3D r8712_get_ie(&pcur_bss->IEs[12], WLAN_EID_HT_CAPABILITY, &ht_ielen, pcur_bss->IELength - 12); @@ -658,9 +625,7 @@ static int r8711_wx_set_freq(struct net_device *dev, int rc =3D 0; =20 /* If setting by frequency, convert to a channel */ - if ((fwrq->e =3D=3D 1) && - (fwrq->m >=3D 241200000) && - (fwrq->m <=3D 248700000)) { + if ((fwrq->e =3D=3D 1) && (fwrq->m >=3D 241200000) && (fwrq->m <=3D 24870= 0000)) { int f =3D fwrq->m / 100000; int c =3D 0; =20 @@ -685,8 +650,7 @@ static int r8711_wx_set_freq(struct net_device *dev, return rc; } =20 -static int r8711_wx_get_freq(struct net_device *dev, - struct iw_request_info *info, +static int r8711_wx_get_freq(struct net_device *dev, struct iw_request_inf= o *info, union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); @@ -745,7 +709,7 @@ static int r8711_wx_get_mode(struct net_device *dev, st= ruct iw_request_info *a, if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) wrqu->mode =3D IW_MODE_INFRA; else if (check_fwstate(pmlmepriv, - WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE)) + WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE)) wrqu->mode =3D IW_MODE_ADHOC; else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) wrqu->mode =3D IW_MODE_MASTER; @@ -754,9 +718,8 @@ static int r8711_wx_get_mode(struct net_device *dev, st= ruct iw_request_info *a, return 0; } =20 -static int r871x_wx_set_pmkid(struct net_device *dev, - struct iw_request_info *a, - union iwreq_data *wrqu, char *extra) +static int r871x_wx_set_pmkid(struct net_device *dev, struct iw_request_in= fo *a, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); struct security_priv *psecuritypriv =3D &padapter->securitypriv; @@ -828,7 +791,7 @@ static int r871x_wx_set_pmkid(struct net_device *dev, break; case IW_PMKSA_FLUSH: memset(psecuritypriv->PMKIDList, 0, - sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE); + sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE); psecuritypriv->PMKIDIndex =3D 0; intReturn =3D true; break; @@ -850,9 +813,8 @@ static int r8711_wx_get_sens(struct net_device *dev, return 0; } =20 -static int r8711_wx_get_range(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_get_range(struct net_device *dev, struct iw_request_in= fo *info, + union iwreq_data *wrqu, char *extra) { struct iw_range *range =3D (struct iw_range *)extra; u16 val; @@ -912,9 +874,9 @@ static int r8711_wx_get_rate(struct net_device *dev, union iwreq_data *wrqu, char *extra); =20 static int r871x_wx_set_priv(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *awrq, - char *extra) + struct iw_request_info *info, + union iwreq_data *awrq, + char *extra) { int ret =3D 0, len =3D 0; char *ext; @@ -995,12 +957,10 @@ static int r871x_wx_set_priv(struct net_device *dev, ); sprintf(ext, "OK"); } else { - netdev_info(dev, "r8712u: %s: unknown Command %s.\n", - __func__, ext); + netdev_info(dev, "r8712u: %s: unknown Command %s.\n", __func__, ext); goto FREE_EXT; } - if (copy_to_user(dwrq->pointer, ext, - min(dwrq->length, (__u16)(strlen(ext) + 1)))) + if (copy_to_user(dwrq->pointer, ext, min(dwrq->length, (__u16)(strlen(ext= ) + 1)))) ret =3D -EFAULT; =20 FREE_EXT: @@ -1021,10 +981,8 @@ static int r871x_wx_set_priv(struct net_device *dev, * For this operation to succeed, there is no need for the interface to be= up. * */ -static int r8711_wx_set_wap(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *awrq, - char *extra) +static int r8711_wx_set_wap(struct net_device *dev, struct iw_request_info= *info, + union iwreq_data *awrq, char *extra) { int ret =3D -EINPROGRESS; struct _adapter *padapter =3D netdev_priv(dev); @@ -1072,17 +1030,15 @@ static int r8711_wx_set_wap(struct net_device *dev, return ret; } =20 -static int r8711_wx_get_wap(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_get_wap(struct net_device *dev, struct iw_request_info= *info, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_bssid_ex *pcur_bss =3D &pmlmepriv->cur_network.network; =20 wrqu->ap_addr.sa_family =3D ARPHRD_ETHER; - if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE | - WIFI_AP_STATE)) + if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE | WIFI_= AP_STATE)) ether_addr_copy(wrqu->ap_addr.sa_data, pcur_bss->MacAddress); else eth_zero_addr(wrqu->ap_addr.sa_data); @@ -1122,9 +1078,8 @@ static int r871x_wx_set_mlme(struct net_device *dev, * For this operation to succeed, the interface is brought Up beforehand. * */ -static int r8711_wx_set_scan(struct net_device *dev, - struct iw_request_info *a, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_set_scan(struct net_device *dev, struct iw_request_inf= o *a, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1150,8 +1105,7 @@ static int r8711_wx_set_scan(struct net_device *dev, unsigned long irqL; u32 len =3D min_t(u8, req->essid_len, IW_ESSID_MAX_SIZE); =20 - memset((unsigned char *)&ssid, 0, - sizeof(struct ndis_802_11_ssid)); + memset((unsigned char *)&ssid, 0, sizeof(struct ndis_802_11_ssid)); memcpy(ssid.Ssid, req->essid, len); ssid.SsidLength =3D len; spin_lock_irqsave(&pmlmepriv->lock, irqL); @@ -1173,9 +1127,8 @@ static int r8711_wx_set_scan(struct net_device *dev, return 0; } =20 -static int r8711_wx_get_scan(struct net_device *dev, - struct iw_request_info *a, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_get_scan(struct net_device *dev, struct iw_request_inf= o *a, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1189,8 +1142,7 @@ static int r8711_wx_get_scan(struct net_device *dev, =20 if (padapter->driver_stopped) return -EINVAL; - while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | - _FW_UNDER_LINKING)) { + while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING)) { msleep(30); cnt++; if (cnt > 100) @@ -1228,9 +1180,8 @@ static int r8711_wx_get_scan(struct net_device *dev, * For this operation to succeed, there is no need for the interface to be= Up. * */ -static int r8711_wx_set_essid(struct net_device *dev, - struct iw_request_info *a, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_set_essid(struct net_device *dev, struct iw_request_in= fo *a, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1268,8 +1219,7 @@ static int r8711_wx_set_essid(struct net_device *dev, if ((!memcmp(dst_ssid, src_ssid, ndis_ssid.SsidLength)) && (pnetwork->network.Ssid.SsidLength =3D=3D ndis_ssid.SsidLength)) { - if (check_fwstate(pmlmepriv, - WIFI_ADHOC_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (pnetwork->network. InfrastructureMode !=3D @@ -1291,9 +1241,8 @@ static int r8711_wx_set_essid(struct net_device *dev, return -EINPROGRESS; } =20 -static int r8711_wx_get_essid(struct net_device *dev, - struct iw_request_info *a, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_get_essid(struct net_device *dev, struct iw_request_in= fo *a, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1311,9 +1260,8 @@ static int r8711_wx_get_essid(struct net_device *dev, return ret; } =20 -static int r8711_wx_set_rate(struct net_device *dev, - struct iw_request_info *a, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_set_rate(struct net_device *dev, struct iw_request_inf= o *a, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); u32 target_rate =3D wrqu->bitrate.value; @@ -1382,8 +1330,7 @@ static int r8711_wx_set_rate(struct net_device *dev, return r8712_setdatarate_cmd(padapter, datarates); } =20 -static int r8711_wx_get_rate(struct net_device *dev, - struct iw_request_info *info, +static int r8711_wx_get_rate(struct net_device *dev, struct iw_request_inf= o *info, union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); @@ -1437,9 +1384,8 @@ static int r8711_wx_get_rate(struct net_device *dev, return 0; } =20 -static int r8711_wx_get_rts(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_get_rts(struct net_device *dev, struct iw_request_info= *info, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); =20 @@ -1448,9 +1394,8 @@ static int r8711_wx_get_rts(struct net_device *dev, return 0; } =20 -static int r8711_wx_set_frag(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static int r8711_wx_set_frag(struct net_device *dev, struct iw_request_inf= o *info, + union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); =20 --=20 2.30.2