From nobody Fri Jan 2 05:07:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559A0CDB483 for ; Sun, 15 Oct 2023 08:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233525AbjJOIXJ (ORCPT ); Sun, 15 Oct 2023 04:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233483AbjJOIXH (ORCPT ); Sun, 15 Oct 2023 04:23:07 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6792BAD for ; Sun, 15 Oct 2023 01:23:05 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-579de633419so42330087b3.3 for ; Sun, 15 Oct 2023 01:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697358184; x=1697962984; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=lPlp3BV0kEhkLkLYlBgqaMjelRMepDFZfGgnfVSi7gs=; b=BD8XEdAXxRcxvK0Jnxk6Y8NtoaTy/j9iDURIwXr4cA87Vi6crAF+IROun+1CHWTNOg +IZz4zrrvtkSTrah5mvpSCT8Q3ITeRY9yGvPG/75uTGBpyQ+QCdRFrFph0P6KaGds4gF oVGoOQrbc17HUdn5rUvaneAUHJuLquzDyFDENjVKc/WqCrOGsyqm8HeFUg9ruUT2hcHp IlTIHohg2B0srF8VT6Gqz42SbnFVEiBKRtSK808E8G5RNF77dtstMBJp4GBWzm4lrsaV AY/9cXae0R6XzPGAK+sLdB84kfWkfwYzxRwvpJEe3w+UY4L4OgoW24q9UXrnza/UXFg8 zPNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697358184; x=1697962984; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lPlp3BV0kEhkLkLYlBgqaMjelRMepDFZfGgnfVSi7gs=; b=X0JhMZCtwH/Lt7/QPYem9pGa98BXh6K8BvAxWDSUGcvSNCaRpUJ+2longsIoTHcC6g cPXDba7LdCL5HFcuiyJhSoqrR8bS/PfjUBAc8sCydgJUMg1sdjwQZaE9ZJzOGEoL9d7Y oK/WTa8rJ5NUIVVlREvppwHHMFtvTj/OlQIZMS977+iuP8Z4qUgJg58nV4VV98+YY5j3 joo112WHb8EOOwMkHn+XfQtZmWR+fTzwr0DUORR/gE29nFggVcApSt84LEKW0op3YP73 zlrCOTNkDitxEUA+twiwpRQfS+wGJ9pAiq8nPbFOSfxiIKLkgneEfeb6Qb2bqMlBXNH/ TnFQ== X-Gm-Message-State: AOJu0YwvhISZ99POzR/hS6+SASQg47g+nVXzEVLk+xviLQotj/mF2EZg zOp0LlWPc8XR2683hUVGdDg= X-Google-Smtp-Source: AGHT+IE4WbvGtZc7fOiB7o7fn9fNhDA/1a3SGVNwueO5k0ABoks8ZtYQU5cE0wFA6CMX3e7MVID04A== X-Received: by 2002:a81:4f04:0:b0:5a7:bbd1:ec21 with SMTP id d4-20020a814f04000000b005a7bbd1ec21mr15206284ywb.0.1697358184450; Sun, 15 Oct 2023 01:23:04 -0700 (PDT) Received: from gilbert-PC ([105.112.18.68]) by smtp.gmail.com with ESMTPSA id t201-20020a8183d2000000b00582fae92aa7sm1210082ywf.93.2023.10.15.01.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 01:23:03 -0700 (PDT) Date: Sun, 15 Oct 2023 09:22:58 +0100 From: Gilbert Adikankwu To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8192u: Align descendant arguments Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adhere to Linux kernel coding style. "...A very commonly used style is to align descendants to a function open parenthesis" - (Excerpted from Linux kernel coding style (#2)) Reported by checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by: Gilbert Adikankwu --- v2: In the first patch I changed my commit title in the email and sent it before amending it in my git tree which then changed its SHA ID. I felt it might cause an issue so that is why I did a v2 of the patch. drivers/staging/rtl8192u/r8180_93cx6.c | 4 ++-- drivers/staging/rtl8192u/r8190_rtl8256.c | 16 +++++++-------- drivers/staging/rtl8192u/r8192U_core.c | 20 +++++++++--------- drivers/staging/rtl8192u/r8192U_dm.c | 24 +++++++++++----------- drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- 6 files changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl81= 92u/r8180_93cx6.c index 2527cea60e3e..1453a0307eb4 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.c +++ b/drivers/staging/rtl8192u/r8180_93cx6.c @@ -114,7 +114,7 @@ int eprom_read(struct net_device *dev, u32 addr) ret =3D 0; /* enable EPROM programming */ write_nic_byte_E(dev, EPROM_CMD, - (EPROM_CMD_PROGRAM << EPROM_CMD_OPERATING_MODE_SHIFT)); + (EPROM_CMD_PROGRAM << EPROM_CMD_OPERATING_MODE_SHIFT)); force_pci_posting(dev); udelay(EPROM_DELAY); =20 @@ -165,6 +165,6 @@ int eprom_read(struct net_device *dev, u32 addr) =20 /* disable EPROM programming */ write_nic_byte_E(dev, EPROM_CMD, - (EPROM_CMD_NORMAL << EPROM_CMD_OPERATING_MODE_SHIFT)); + (EPROM_CMD_NORMAL << EPROM_CMD_OPERATING_MODE_SHIFT)); return ret; } diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl= 8192u/r8190_rtl8256.c index 54747fda552f..a81e88894e01 100644 --- a/drivers/staging/rtl8192u/r8190_rtl8256.c +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c @@ -46,17 +46,17 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, e= num ht_channel_width Band priv->card_8192_version =3D=3D VERSION_819XU_B) { /* 8256 D-cut, E-cut, xiong: consider it later! */ rtl8192_phy_SetRFReg(dev, - (enum rf90_radio_path_e)eRFPath, - 0x0b, bMask12Bits, 0x100); /* phy para:1ba */ + (enum rf90_radio_path_e)eRFPath, + 0x0b, bMask12Bits, 0x100); /* phy para:1ba */ rtl8192_phy_SetRFReg(dev, - (enum rf90_radio_path_e)eRFPath, - 0x2c, bMask12Bits, 0x3d7); + (enum rf90_radio_path_e)eRFPath, + 0x2c, bMask12Bits, 0x3d7); rtl8192_phy_SetRFReg(dev, - (enum rf90_radio_path_e)eRFPath, - 0x0e, bMask12Bits, 0x021); + (enum rf90_radio_path_e)eRFPath, + 0x0e, bMask12Bits, 0x021); rtl8192_phy_SetRFReg(dev, - (enum rf90_radio_path_e)eRFPath, - 0x14, bMask12Bits, 0x5ab); + (enum rf90_radio_path_e)eRFPath, + 0x14, bMask12Bits, 0x5ab); } else { RT_TRACE(COMP_ERR, "%s(): unknown hardware version\n", __func__); } diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl81= 92u/r8192U_core.c index 0a60ef20107c..2985c4f05bc8 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -2236,7 +2236,7 @@ static int rtl8192_read_eeprom_info(struct net_device= *dev) *((u16 *)(&priv->EEPROMTxPowerLevelCCK_V1[1])) =3D tmpValue; if (bLoad_From_EEPOM) tmpValue =3D eprom_read(dev, - EEPROM_TX_PW_INDEX_OFDM_24G_V1 >> 1); + EEPROM_TX_PW_INDEX_OFDM_24G_V1 >> 1); else tmpValue =3D 0x1010; *((u16 *)(&priv->EEPROMTxPowerLevelOFDM24G[0])) =3D tmpValue; @@ -2536,16 +2536,16 @@ static bool rtl8192_adapter_start(struct net_device= *dev) =20 /* Initialize Number of Reserved Pages in Firmware Queue */ write_nic_dword(dev, RQPN1, - NUM_OF_PAGE_IN_FW_QUEUE_BK << RSVD_FW_QUEUE_PAGE_BK_SHIFT | - NUM_OF_PAGE_IN_FW_QUEUE_BE << RSVD_FW_QUEUE_PAGE_BE_SHIFT | - NUM_OF_PAGE_IN_FW_QUEUE_VI << RSVD_FW_QUEUE_PAGE_VI_SHIFT | - NUM_OF_PAGE_IN_FW_QUEUE_VO << RSVD_FW_QUEUE_PAGE_VO_SHIFT); + NUM_OF_PAGE_IN_FW_QUEUE_BK << RSVD_FW_QUEUE_PAGE_BK_SHIFT | + NUM_OF_PAGE_IN_FW_QUEUE_BE << RSVD_FW_QUEUE_PAGE_BE_SHIFT | + NUM_OF_PAGE_IN_FW_QUEUE_VI << RSVD_FW_QUEUE_PAGE_VI_SHIFT | + NUM_OF_PAGE_IN_FW_QUEUE_VO << RSVD_FW_QUEUE_PAGE_VO_SHIFT); write_nic_dword(dev, RQPN2, - NUM_OF_PAGE_IN_FW_QUEUE_MGNT << RSVD_FW_QUEUE_PAGE_MGNT_SHIFT | - NUM_OF_PAGE_IN_FW_QUEUE_CMD << RSVD_FW_QUEUE_PAGE_CMD_SHIFT); + NUM_OF_PAGE_IN_FW_QUEUE_MGNT << RSVD_FW_QUEUE_PAGE_MGNT_SHIFT | + NUM_OF_PAGE_IN_FW_QUEUE_CMD << RSVD_FW_QUEUE_PAGE_CMD_SHIFT); write_nic_dword(dev, RQPN3, - APPLIED_RESERVED_QUEUE_IN_FW | - NUM_OF_PAGE_IN_FW_QUEUE_BCN << RSVD_FW_QUEUE_PAGE_BCN_SHIFT); + APPLIED_RESERVED_QUEUE_IN_FW | + NUM_OF_PAGE_IN_FW_QUEUE_BCN << RSVD_FW_QUEUE_PAGE_BCN_SHIFT); write_nic_dword(dev, RATR0 + 4 * 7, (RATE_ALL_OFDM_AG | RATE_ALL_CCK)); =20 /* Set AckTimeout */ @@ -3019,7 +3019,7 @@ static void rtl819x_ifsilentreset(struct net_device *= dev) } =20 static void rtl819x_update_rxcounts(struct r8192_priv *priv, u32 *TotalRxB= cnNum, - u32 *TotalRxDataNum) + u32 *TotalRxDataNum) { u16 SlotIndex; u16 i; diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192= u/r8192U_dm.c index cbae852478ea..84c2ad89f02c 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -331,7 +331,7 @@ static void dm_check_rate_adaptive(struct net_device *d= ev) if (pra->ping_rssi_enable) { if (priv->undecorated_smoothed_pwdb < (long)(pra->ping_rssi_thresh_for_= ra+5)) { if ((priv->undecorated_smoothed_pwdb < (long)pra->ping_rssi_thresh_for= _ra) || - ping_rssi_state) { + ping_rssi_state) { pra->ratr_state =3D DM_RATR_STA_LOW; targetRATR =3D pra->ping_rssi_ratr; ping_rssi_state =3D 1; @@ -612,7 +612,7 @@ static void dm_TXPowerTrackingCallback_ThermalMeter(str= uct net_device *dev) if (tmpRegA =3D=3D OFDMSwingTable[i]) { priv->OFDM_index =3D (u8)i; RT_TRACE(COMP_POWER_TRACKING, "Initial reg0x%x =3D 0x%x, OFDM_index=3D= 0x%x\n", - rOFDM0_XATxIQImbalance, tmpRegA, priv->OFDM_index); + rOFDM0_XATxIQImbalance, tmpRegA, priv->OFDM_index); } } =20 @@ -622,7 +622,7 @@ static void dm_TXPowerTrackingCallback_ThermalMeter(str= uct net_device *dev) if (TempCCk =3D=3D (u32)CCKSwingTable_Ch1_Ch13[i][0]) { priv->CCK_index =3D (u8) i; RT_TRACE(COMP_POWER_TRACKING, "Initial reg0x%x =3D 0x%x, CCK_index=3D0= x%x\n", - rCCK0_TxFilter1, TempCCk, priv->CCK_index); + rCCK0_TxFilter1, TempCCk, priv->CCK_index); break; } } @@ -695,7 +695,7 @@ static void dm_TXPowerTrackingCallback_ThermalMeter(str= uct net_device *dev) priv->OFDM_index =3D tmpOFDMindex; rtl8192_setBBreg(dev, rOFDM0_XATxIQImbalance, bMaskDWord, OFDMSwingTable= [priv->OFDM_index]); RT_TRACE(COMP_POWER_TRACKING, "Update OFDMSwing[%d] =3D 0x%x\n", - priv->OFDM_index, OFDMSwingTable[priv->OFDM_index]); + priv->OFDM_index, OFDMSwingTable[priv->OFDM_index]); } priv->txpower_count =3D 0; } @@ -1352,7 +1352,7 @@ static void dm_CCKTxPowerAdjust_ThermalMeter(struct n= et_device *dev, bool bInCH (CCKSwingTable_Ch1_Ch13[priv->CCK_index][1]<<8); rtl8192_setBBreg(dev, rCCK0_TxFilter1, bMaskHWord, TempVal); RT_TRACE(COMP_POWER_TRACKING, "CCK not chnl 14, reg 0x%x =3D 0x%x\n", - rCCK0_TxFilter1, TempVal); + rCCK0_TxFilter1, TempVal); /* Write 0xa24 ~ 0xa27 */ TempVal =3D CCKSwingTable_Ch1_Ch13[priv->CCK_index][2] + (CCKSwingTable_Ch1_Ch13[priv->CCK_index][3]<<8) + @@ -1360,14 +1360,14 @@ static void dm_CCKTxPowerAdjust_ThermalMeter(struct= net_device *dev, bool bInCH (CCKSwingTable_Ch1_Ch13[priv->CCK_index][5]<<24); rtl8192_setBBreg(dev, rCCK0_TxFilter2, bMaskDWord, TempVal); RT_TRACE(COMP_POWER_TRACKING, "CCK not chnl 14, reg 0x%x =3D 0x%x\n", - rCCK0_TxFilter2, TempVal); + rCCK0_TxFilter2, TempVal); /* Write 0xa28 0xa29 */ TempVal =3D CCKSwingTable_Ch1_Ch13[priv->CCK_index][6] + (CCKSwingTable_Ch1_Ch13[priv->CCK_index][7]<<8); =20 rtl8192_setBBreg(dev, rCCK0_DebugPort, bMaskLWord, TempVal); RT_TRACE(COMP_POWER_TRACKING, "CCK not chnl 14, reg 0x%x =3D 0x%x\n", - rCCK0_DebugPort, TempVal); + rCCK0_DebugPort, TempVal); } else { /* Write 0xa22 0xa23 */ TempVal =3D CCKSwingTable_Ch14[priv->CCK_index][0] + @@ -1764,7 +1764,7 @@ static void dm_ctrl_initgain_byrssi_highpwr( =20 /* For smooth, we can not change high power DIG state in the range. */ if ((priv->undecorated_smoothed_pwdb > dm_digtable.rssi_high_power_lowthr= esh) && - (priv->undecorated_smoothed_pwdb < dm_digtable.rssi_high_power_highthres= h)) + (priv->undecorated_smoothed_pwdb < dm_digtable.rssi_high_power_highth= resh)) return; =20 /* 3. When RSSI >75% or <70%, it is a high power issue. We have to judge = if @@ -1790,7 +1790,7 @@ static void dm_ctrl_initgain_byrssi_highpwr( dm_digtable.dig_highpwr_state =3D DM_STA_DIG_OFF; =20 if (priv->undecorated_smoothed_pwdb < dm_digtable.rssi_high_power_lowthr= esh && - priv->undecorated_smoothed_pwdb >=3D dm_digtable.rssi_high_thresh) { + priv->undecorated_smoothed_pwdb >=3D dm_digtable.rssi_high_thresh) { /* 3.2 Recover PD_TH for OFDM for normal power region. */ if (priv->CurrentChannelBW !=3D HT_CHANNEL_WIDTH_20) { write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x20); @@ -1881,7 +1881,7 @@ static void dm_pd_th( else if (dm_digtable.rssi_val <=3D dm_digtable.rssi_low_thresh) dm_digtable.curpd_thstate =3D DIG_PD_AT_LOW_POWER; else if ((dm_digtable.rssi_val >=3D dm_digtable.rssi_high_thresh) && - (dm_digtable.rssi_val < dm_digtable.rssi_high_power_lowthresh)) + (dm_digtable.rssi_val < dm_digtable.rssi_high_power_lowthresh)) dm_digtable.curpd_thstate =3D DIG_PD_AT_NORMAL_POWER; else dm_digtable.curpd_thstate =3D dm_digtable.prepd_thstate; @@ -2620,7 +2620,7 @@ void dm_check_fsync(struct net_device *dev) RT_TRACE(COMP_HALDM, "RateBitmap 0x%x FirstDiffRateThreshold %d SecondDif= fRateThreshold %d\n", priv->ieee80211->fsync_rate_bitmap, priv->ieee80211->= fsync_firstdiff_ratethreshold, priv->ieee80211->fsync_seconddiff_ratethresh= old); =20 if (priv->ieee80211->state =3D=3D IEEE80211_LINKED && - (priv->ieee80211->pHTInfo->IOTAction & HT_IOT_ACT_CDD_FSYNC)) { + (priv->ieee80211->pHTInfo->IOTAction & HT_IOT_ACT_CDD_FSYNC)) { if (priv->ieee80211->bfsync_enable =3D=3D 0) { switch (priv->ieee80211->fsync_state) { case Default_Fsync: @@ -2779,7 +2779,7 @@ static void dm_dynamic_txpower(struct net_device *dev) } =20 if ((priv->bDynamicTxHighPower !=3D priv->bLastDTPFlag_High) || - (priv->bDynamicTxLowPower !=3D priv->bLastDTPFlag_Low)) { + (priv->bDynamicTxLowPower !=3D priv->bLastDTPFlag_Low)) { RT_TRACE(COMP_TXAGC, "SetTxPowerLevel8190() channel =3D %d\n", priv->ie= ee80211->current_network.channel); =20 #if defined(RTL8190P) || defined(RTL8192E) diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/r= tl8192u/r819xU_firmware.c index 4f8629e47e82..c515b4773e37 100644 --- a/drivers/staging/rtl8192u/r819xU_firmware.c +++ b/drivers/staging/rtl8192u/r819xU_firmware.c @@ -88,8 +88,8 @@ static bool fw_download_code(struct net_device *dev, u8 *= code_virtual_address, =20 index =3D tcb_desc->queue_index; if (!priv->ieee80211->check_nic_enough_desc(dev, index) || - (!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) || - (priv->ieee80211->queue_stop)) { + (!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) || + (priv->ieee80211->queue_stop)) { RT_TRACE(COMP_FIRMWARE, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D> tx full!\n"); skb_queue_tail(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index], skb); } else { diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl819= 2u/r819xU_phy.c index e6836eacc7aa..c61a29976e9a 100644 --- a/drivers/staging/rtl8192u/r819xU_phy.c +++ b/drivers/staging/rtl8192u/r819xU_phy.c @@ -875,7 +875,7 @@ void rtl8192_phy_getTxPower(struct net_device *dev) read_nic_byte(dev, rOFDM0_RxDetector2, &tmp); priv->framesyncC34 =3D tmp; RT_TRACE(COMP_INIT, "Default framesync (0x%x) =3D 0x%x\n", - rOFDM0_RxDetector3, priv->framesync); + rOFDM0_RxDetector3, priv->framesync); =20 /* Read SIFS (save the value read fome MACPHY_REG.txt) */ read_nic_word(dev, SIFS, &priv->SifsTime); --=20 2.34.1