From nobody Fri Jan 2 00:38:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F15CDB474 for ; Tue, 17 Oct 2023 10:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234926AbjJQKNG (ORCPT ); Tue, 17 Oct 2023 06:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234809AbjJQKND (ORCPT ); Tue, 17 Oct 2023 06:13:03 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1CB1E8 for ; Tue, 17 Oct 2023 03:13:01 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-406402933edso54988435e9.2 for ; Tue, 17 Oct 2023 03:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697537580; x=1698142380; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=E8E7YoxZ2av3orSrcaFfg8f95nyYUaTpAzrG7yxUAnU=; b=Z407z6pWTFSh+5gF1UxgXvG1qeQN5Ls0HgEy75VsQEGd3hM0sVCE/lxg1rSZko6adi 42Vhxko4pTMlKb2xUGeNOk2Y1z+Rdj83uv+m9538jVptuoOmSOMw/MwOZY5O09WGV7Pp tAKh/TSJdTI7HbfBeiG++ayGm38PUv+uvrhnugMNbi/leHyiOrFDyIsPUT/BiJiDTeg1 RuqSEya+DH5mgG0T19/prVaHHr4GOxoFM0dNakCNxQO2O7lT6ZocEnXo85/OUKrcDSJR i5yadOMjjEM3Zs4ceTOp/4kunJUsmHp8HCJBpQZLlj4XX0tmq5zvewSOkgOn9+Y+MQmh tQdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697537580; x=1698142380; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E8E7YoxZ2av3orSrcaFfg8f95nyYUaTpAzrG7yxUAnU=; b=oZqUcbuWN+4uRzs2zWdoSLU4WbnQ/ffeUQ1TAYvu05iU2MHmfz2DJQp6n6RCS3ZECJ s8RX+1Qu/dGUSMXPNo8i8UtMUXiVLWodOZP1IEpNkp8Nuv3XNCZcKPDlfKBlUbza4ZM1 kM2gMLtgvSfNy3Pl8RCQAVizXgZYoFBC5+Gzr9cPDIrRDCNAFap0augrUP0cJeJtgdwv oyoCuUJp8xII5ESX19ktNEIiM+FvI8920pN4HFcoWFu5LxtBEuSHf87gN1Y2N+mjk0IX eei7DzsWqbiS1mDtPqN8Pif3LFvY28UlzudwmJNeluJ7vtsDv2ZEIkTI3n7I1qjH+gFL c3Wg== X-Gm-Message-State: AOJu0Yyae6/6zwgR53F2VEVS1Ka92RuQDebfmFfOHTDTM4/p+8CMt4QU /KNPpkXUsAGeimHlffUncEIqqEGMd5l5VQ== X-Google-Smtp-Source: AGHT+IGC29aSwArOWKsG/fAbXePFt9Io7X0exKliBc79JW4dCiH8sjHjUReO3UOWvvCrFfLau9VPWw== X-Received: by 2002:adf:e504:0:b0:32d:b7d4:b90 with SMTP id j4-20020adfe504000000b0032db7d40b90mr1560360wrm.39.1697537579751; Tue, 17 Oct 2023 03:12:59 -0700 (PDT) Received: from lab-ubuntu ([41.90.67.11]) by smtp.gmail.com with ESMTPSA id y7-20020adffa47000000b0031aef72a021sm1323918wrr.86.2023.10.17.03.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 03:12:59 -0700 (PDT) Date: Tue, 17 Oct 2023 13:12:56 +0300 From: Calvince Otieno To: gustavo@embeddedor.com, outreachy@lists.linux.dev Cc: Greg Kroah-Hartman , Calvince Otieno , Bagas Sanjaya , Deepak R Varma , Simon Horman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: wlan-ng: remove function prism2sta_ev_txexc Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function prism2sta_ev_txexc() is called by the function hfa384x_usbin_txcompl() to print the transmit exception event - a debug information using netdev_dbg(). The debugging utility function can be called directly by hfa384x_usbin_txcompl(). Signed-off-by: Calvince Otieno --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- drivers/staging/wlan-ng/prism2mgmt.h | 4 +--- drivers/staging/wlan-ng/prism2sta.c | 24 ------------------------ 3 files changed, 2 insertions(+), 28 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-n= g/hfa384x_usb.c index 3e8c92675c82..35650f911ebc 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -3194,7 +3194,7 @@ static void hfa384x_usbin_txcompl(struct wlandevice *= wlandev, =20 /* Was there an error? */ if (HFA384x_TXSTATUS_ISERROR(status)) - prism2sta_ev_txexc(wlandev, status); + netdev_dbg(wlandev->netdev, "TxExc status=3D0x%x.\n", status); else prism2sta_ev_tx(wlandev, status); } diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng= /prism2mgmt.h index 8c3f1ac35913..17222516e85e 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.h +++ b/drivers/staging/wlan-ng/prism2mgmt.h @@ -45,9 +45,7 @@ extern int prism2_reset_settletime; =20 u32 prism2sta_ifstate(struct wlandevice *wlandev, u32 ifstate); =20 -void prism2sta_ev_info(struct wlandevice *wlandev, - struct hfa384x_inf_frame *inf); -void prism2sta_ev_txexc(struct wlandevice *wlandev, u16 status); +void prism2sta_ev_info(struct wlandevice *wlandev, struct hfa384x_inf_fram= e *inf); void prism2sta_ev_tx(struct wlandevice *wlandev, u16 status); void prism2sta_ev_alloc(struct wlandevice *wlandev); =20 diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/= prism2sta.c index 964164bb4165..cb6c7a9fb8f3 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -1748,30 +1748,6 @@ void prism2sta_ev_info(struct wlandevice *wlandev, } } =20 -/* - * prism2sta_ev_txexc - * - * Handles the TxExc event. A Transmit Exception event indicates - * that the MAC's TX process was unsuccessful - so the packet did - * not get transmitted. - * - * Arguments: - * wlandev wlan device structure - * status tx frame status word - * - * Returns: - * nothing - * - * Side effects: - * - * Call context: - * interrupt - */ -void prism2sta_ev_txexc(struct wlandevice *wlandev, u16 status) -{ - netdev_dbg(wlandev->netdev, "TxExc status=3D0x%x.\n", status); -} - /* * prism2sta_ev_tx * --=20 2.34.1