From nobody Fri Dec 19 04:58:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59718EC8738 for ; Thu, 7 Sep 2023 16:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232974AbjIGQQo (ORCPT ); Thu, 7 Sep 2023 12:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234718AbjIGQQS (ORCPT ); Thu, 7 Sep 2023 12:16:18 -0400 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B25334481 for ; Thu, 7 Sep 2023 09:15:10 -0700 (PDT) Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6515d44b562so7018216d6.3 for ; Thu, 07 Sep 2023 09:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694103189; x=1694707989; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=a5s7dP/467ayuNbwseHDZNpW6f/FXrHQn/xG7mdHTFw=; b=H3qGiOx2lFC479iiuGM4WaieuGM2kDk5ZBvb9BMHXiJV6t+42kQyKef7Axvv82eKA0 /cwGciAvUFP41UhKU7GmEejyQgj932E8TjU4aeGCt4qcvZjUtH6ZmT/1qoZWizAwNttt fwRjjAKuQQNqWsVWBVRZ+phAjmmPw8TRyloX3BjAA+rOXmeVXi8GVY09DcKu52rnTlBa MZFU4oVsFOXN1q63soxz2Lthqs6I++GoXUlc2KvqHjWxV8cZ4Zsex/ECjGPhAky/4uFh 5ZDs1iaE023v9jdOKLm4itjvzx7BhOcOB7+eshY2nd8ce5pZ8a9wpywL4+SIltU0YrVt ph1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694103189; x=1694707989; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a5s7dP/467ayuNbwseHDZNpW6f/FXrHQn/xG7mdHTFw=; b=GwT6u1Gg/5maMhrr9yLZvPFnLWgZkN2fTGQZjQCRGk8VGlspkpWLlAKvpaIGVqZhsy lO14/3UQ12150VV5Ktj8Rl59xesBEUsulEPWc1WAw/Z+WLDQobyOJaO4qrBpG0ZG00c7 HlSDJwKs6Du6rJZmbfqVeivyZJzuRYpJfcHiDbZv00g8qEvd8YfpnLZkV6lI2YwmL7tC FhSSBbxv2qeKCprAHpYx+b0uFATr9BT9qiA4JfMp314dpOxewGeCGTJZ/pUJ756xknGF 7l7D3MVzqv1hmxHapActGwlh/5K8uvrA4k/265WE0wHZw2SAe5cJQkkmJ9JfjJCLElQH /XPA== X-Gm-Message-State: AOJu0Yy1YBZ56ybl7OhAtDWI6WCBiQXGPT4zC27//lLXXKz+FJ3ANWW5 IVB3J/hTpwlWGL8zz3pd1TJlpRjPpV0= X-Google-Smtp-Source: AGHT+IHWLQsE90vf68sFqBp5ASDgOSjrW13RN3R3Ry8rG3Cv2AwZ7QAy/csTDJei8Xz+vJqSQ+G0Kw== X-Received: by 2002:a17:903:22cb:b0:1c3:749f:6a5c with SMTP id y11-20020a17090322cb00b001c3749f6a5cmr1453874plg.12.1694092231970; Thu, 07 Sep 2023 06:10:31 -0700 (PDT) Received: from ubuntu.myguest.virtualbox.org ([223.178.252.251]) by smtp.gmail.com with ESMTPSA id y21-20020a170902ed5500b001bb7a736b4csm12789595plb.77.2023.09.07.06.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 06:10:31 -0700 (PDT) Date: Thu, 7 Sep 2023 18:40:27 +0530 From: Pavan Bobba To: Forest Bond , Michael Straube , Philipp Hortmann Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3] staging: vt6655: Type encoding info dropped from array name "byVT3253B0_" Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Below array names updated as per coding guidelines: 1.byVT3253B0_AGC4_RFMD2959 2.byVT3253B0_AIROHA2230 3.byVT3253B0_UW2451 4.byVT3253B0_AGC Conversions performed: a.type encoding info dropped from names b.names replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba --- v1 -> v2: Name of the tool added in the body of explanation, which found this issue v2 -> v3: subject modified to more specific detail =20 drivers/staging/vt6655/baseband.c | 32 +++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/bas= eband.c index 696d4dd03aa2..55224918794b 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -761,7 +761,7 @@ static const unsigned char vt3253b0_rfmd[CB_VT3253B0_IN= IT_FOR_RFMD][2] =3D { #define CB_VT3253B0_AGC_FOR_RFMD2959 195 /* For RFMD2959 */ static -unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_FOR_RFMD2959][2] = =3D { +unsigned char vt3253b0_agc4_rfmd2959[CB_VT3253B0_AGC_FOR_RFMD2959][2] =3D { {0xF0, 0x00}, {0xF1, 0x3E}, {0xF0, 0x80}, @@ -962,7 +962,7 @@ unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_= FOR_RFMD2959][2] =3D { #define CB_VT3253B0_INIT_FOR_AIROHA2230 256 /* For AIROHA */ static -unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_FOR_AIROHA2230][2] = =3D { +unsigned char vt3253b0_airoha2230[CB_VT3253B0_INIT_FOR_AIROHA2230][2] =3D { {0x00, 0x31}, {0x01, 0x00}, {0x02, 0x00}, @@ -1223,7 +1223,7 @@ unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_= FOR_AIROHA2230][2] =3D { =20 #define CB_VT3253B0_INIT_FOR_UW2451 256 /* For UW2451 */ -static unsigned char byVT3253B0_UW2451[CB_VT3253B0_INIT_FOR_UW2451][2] =3D= { +static unsigned char vt3253b0_uw2451[CB_VT3253B0_INIT_FOR_UW2451][2] =3D { {0x00, 0x31}, {0x01, 0x00}, {0x02, 0x00}, @@ -1484,7 +1484,7 @@ static unsigned char byVT3253B0_UW2451[CB_VT3253B0_IN= IT_FOR_UW2451][2] =3D { =20 #define CB_VT3253B0_AGC 193 /* For AIROHA */ -static unsigned char byVT3253B0_AGC[CB_VT3253B0_AGC][2] =3D { +static unsigned char vt3253b0_agc[CB_VT3253B0_AGC][2] =3D { {0xF0, 0x00}, {0xF1, 0x00}, {0xF0, 0x80}, @@ -2010,8 +2010,8 @@ bool bb_vt3253_init(struct vnt_private *priv) =20 for (ii =3D 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_AGC4_RFMD2959[ii][0], - byVT3253B0_AGC4_RFMD2959[ii][1]); + vt3253b0_agc4_rfmd2959[ii][0], + vt3253b0_agc4_rfmd2959[ii][1]); =20 iowrite32(0x23, iobase + MAC_REG_ITRTMSET); vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0)); @@ -2027,12 +2027,12 @@ bool bb_vt3253_init(struct vnt_private *priv) } else if ((by_rf_type =3D=3D RF_AIROHA) || (by_rf_type =3D=3D RF_AL2230S= )) { for (ii =3D 0; ii < CB_VT3253B0_INIT_FOR_AIROHA2230; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_AIROHA2230[ii][0], - byVT3253B0_AIROHA2230[ii][1]); + vt3253b0_airoha2230[ii][0], + vt3253b0_airoha2230[ii][1]); =20 for (ii =3D 0; ii < CB_VT3253B0_AGC; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_AGC[ii][0], byVT3253B0_AGC[ii][1]); + vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]); =20 priv->abyBBVGA[0] =3D 0x1C; priv->abyBBVGA[1] =3D 0x10; @@ -2045,13 +2045,13 @@ bool bb_vt3253_init(struct vnt_private *priv) } else if (by_rf_type =3D=3D RF_UW2451) { for (ii =3D 0; ii < CB_VT3253B0_INIT_FOR_UW2451; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_UW2451[ii][0], - byVT3253B0_UW2451[ii][1]); + vt3253b0_uw2451[ii][0], + vt3253b0_uw2451[ii][1]); =20 for (ii =3D 0; ii < CB_VT3253B0_AGC; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_AGC[ii][0], - byVT3253B0_AGC[ii][1]); + vt3253b0_agc[ii][0], + vt3253b0_agc[ii][1]); =20 iowrite8(0x23, iobase + MAC_REG_ITRTMSET); vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0)); @@ -2067,12 +2067,12 @@ bool bb_vt3253_init(struct vnt_private *priv) } else if (by_rf_type =3D=3D RF_VT3226) { for (ii =3D 0; ii < CB_VT3253B0_INIT_FOR_AIROHA2230; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_AIROHA2230[ii][0], - byVT3253B0_AIROHA2230[ii][1]); + vt3253b0_airoha2230[ii][0], + vt3253b0_airoha2230[ii][1]); =20 for (ii =3D 0; ii < CB_VT3253B0_AGC; ii++) result &=3D bb_write_embedded(priv, - byVT3253B0_AGC[ii][0], byVT3253B0_AGC[ii][1]); + vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]); =20 priv->abyBBVGA[0] =3D 0x1C; priv->abyBBVGA[1] =3D 0x10; --=20 2.34.1