From nobody Wed Dec 17 09:04:03 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12230EE4996 for ; Tue, 22 Aug 2023 12:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235485AbjHVMdX (ORCPT ); Tue, 22 Aug 2023 08:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233344AbjHVMdW (ORCPT ); Tue, 22 Aug 2023 08:33:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC2811BD for ; Tue, 22 Aug 2023 05:33:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E2E7655C3 for ; Tue, 22 Aug 2023 12:33:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3987FC433C7; Tue, 22 Aug 2023 12:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692707599; bh=vnIdzGAF0y6qaOS7FfPLpa7ABxpUY3LbjrqN9lIQpCA=; h=Date:From:To:Cc:Subject:From; b=urCgWTBa6jErPRUjQi1CCUDEitgFysTzl+gky0LLDucR53VWS20E1JGNk+0pID/5R t/AZgw0FsHAWItB2qoToFsHMShdA8jg7l8btplsDygs1Dyd5yuq9PXlT66fpGH3qhH Rj3g8WGtvGsLlp9s4iTPqVZ2oQlDkHQ6GuSMmTY+dCzNpcQ98+NC5vyEoJ/T8SeVsV 0kuzubchgKJD+6LeWjTcRDLqA+wZrflLLTxBBBYiaq69R5kUIMm5jXj9ATFO4W8ZvO jOzvLUqfUOfnr+v6O0JVJIXxgpFbrpiCdQ0U5OmGg78bDtDLhmz6BJrbDmDAZXlq6c pcj/qq61BR9VQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 72B8440722; Tue, 22 Aug 2023 09:33:16 -0300 (-03) Date: Tue, 22 Aug 2023 09:33:16 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Adrian Hunter , Jiri Olsa , amadio@ghostprotocols.net, Namhyung Kim , Guilherme Amadio , Linux Kernel Mailing List Subject: perf tools: Options being passed to clang when building the BPF part of skels Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, On gentoo I'm noticing this: clang-16clang-16: : clang-16error: : error: clang-16clang-16: clang-16clang= -16clang-16: clang-16error: clang-16: : ignoring '-fstack-protector-strong'= option as it is not currently supported for target 'bpf' [-Werror,-Woption= -ignored]: : : clang-16error: ignoring '-fstack-protector-strong' option as= it is not currently supported for target 'bpf' [-Werror,-Woption-ignored]e= rror: error: :=20 error:=20 error: error: error: ignoring '-fstack-protector-strong' option as it is no= t currently supported for target 'bpf' [-Werror,-Woption-ignored]ignoring '= -fstack-protector-strong' option as it is not currently supported for targe= t 'bpf' [-Werror,-Woption-ignored]error: ignoring '-fstack-protector-strong= ' option as it is not currently supported for target 'bpf' [-Werror,-Woptio= n-ignored]ignoring '-fstack-protector-strong' option as it is not currently= supported for target 'bpf' [-Werror,-Woption-ignored] ignoring '-fstack-protector-strong' option as it is not currently supported= for target 'bpf' [-Werror,-Woption-ignored]ignoring '-fstack-protector-str= ong' option as it is not currently supported for target 'bpf' [-Werror,-Wop= tion-ignored]ignoring '-fstack-protector-strong' option as it is not curren= tly supported for target 'bpf' [-Werror,-Woption-ignored]ignoring '-fstack-= protector-strong' option as it is not currently supported for target 'bpf' = [-Werror,-Woption-ignored] ignoring '-fstack-protector-strong' option as it is not currently supported= for target 'bpf' [-Werror,-Woption-ignored] And while just doing: diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index a5dd1ba..7726b57 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -1101,7 +1101,7 @@ else endif =20 $(SKEL_TMP_OUT)/%.bpf.o: util/bpf_skel/%.bpf.c $(LIBBPF) $(SKEL_OUT)/vmlin= ux.h | $(SKEL_TMP_OUT) - $(QUIET_CLANG)$(CLANG) -g -O2 --target=3Dbpf -Wall -Werror $(BPF_INCLUDE)= $(TOOLS_UAPI_INCLUDE) \ + $(QUIET_CLANG)$(CLANG) -g -O2 --target=3Dbpf -Wall -Werror -Wno-option-ig= nored $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \ -c $(filter util/bpf_skel/%.bpf.c,$^) -o $@ =20 $(SKEL_OUT)/%.skel.h: $(SKEL_TMP_OUT)/%.bpf.o | $(BPFTOOL) "Fixes" it, I'm curious as where is that we're setting up the options that are being passed to clang at: tools/perf/Makefile.perf $(SKEL_TMP_OUT)/%.bpf.o: util/bpf_skel/%.bpf.c $(LIBBPF) $(SKEL_OUT)/vmlinu= x.h | $(SKEL_TMP_OUT) $(QUIET_CLANG)$(CLANG) -g -O2 --target=3Dbpf -Wall -Werror $(BPF_IN= CLUDE) $(TOOLS_UAPI_INCLUDE) \ -c $(filter util/bpf_skel/%.bpf.c,$^) -o $@ Perhaps it is plain just using CFLAGS? I.e. maybe the native build CFLAGS is being passed to the BPF target clang calls? Ideas? - Arnaldo