From nobody Sun Feb 8 15:59:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9982C0015E for ; Thu, 3 Aug 2023 09:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233910AbjHCJox (ORCPT ); Thu, 3 Aug 2023 05:44:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234101AbjHCJo2 (ORCPT ); Thu, 3 Aug 2023 05:44:28 -0400 Received: from wxsgout04.xfusion.com (wxsgout04.xfusion.com [36.139.87.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D57B358B for ; Thu, 3 Aug 2023 02:44:25 -0700 (PDT) Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4RGkRN5BbTz9xxKC; Thu, 3 Aug 2023 17:42:56 +0800 (CST) Received: from fedora (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 3 Aug 2023 17:44:02 +0800 Date: Thu, 3 Aug 2023 17:44:00 +0800 From: Wang Jinchao To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , CC: Subject: [PATCH] x86/head64: Harmonize the style of array-type parameter for fixup_pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Originating-IP: [10.82.147.3] X-ClientProxiedBy: wuxshcsitd00602.xfusion.com (10.32.132.250) To wuxshcsitd00600.xfusion.com (10.32.133.213) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The usage of '&' before the array parameter is redundant because '&array' is equivalent to 'array'. Therefore, there is no need to include '&' before the array parameter. In fact, using '&' can cause more confusion, especially for individuals who are not familiar with the address-of operation for arrays. They might mistakenly believe that one is different from the other and spend additional time realizing that they are actually the same. Harmonizing the style by removing the unnecessary '&' would save time for those individuals. Signed-off-by: Wang Jinchao --- arch/x86/kernel/head64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c index 49f7629b17f7..25a67a13a1fa 100644 --- a/arch/x86/kernel/head64.c +++ b/arch/x86/kernel/head64.c @@ -211,7 +211,7 @@ unsigned long __head __startup_64(unsigned long physadd= r, =20 /* Fixup the physical addresses in the page table */ =20 - pgd =3D fixup_pointer(&early_top_pgt, physaddr); + pgd =3D fixup_pointer(early_top_pgt, physaddr); p =3D pgd + pgd_index(__START_KERNEL_map); if (la57) *p =3D (unsigned long)level4_kernel_pgt; @@ -220,11 +220,11 @@ unsigned long __head __startup_64(unsigned long physa= ddr, *p +=3D _PAGE_TABLE_NOENC - __START_KERNEL_map + load_delta; =20 if (la57) { - p4d =3D fixup_pointer(&level4_kernel_pgt, physaddr); + p4d =3D fixup_pointer(level4_kernel_pgt, physaddr); p4d[511] +=3D load_delta; } =20 - pud =3D fixup_pointer(&level3_kernel_pgt, physaddr); + pud =3D fixup_pointer(level3_kernel_pgt, physaddr); pud[510] +=3D load_delta; pud[511] +=3D load_delta; =20 --=20 2.40.0