From nobody Thu Sep 11 15:06:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0508BC04E69 for ; Fri, 4 Aug 2023 14:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbjHDOu6 (ORCPT ); Fri, 4 Aug 2023 10:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230512AbjHDOuu (ORCPT ); Fri, 4 Aug 2023 10:50:50 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 281C449C7 for ; Fri, 4 Aug 2023 07:50:43 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3a3c78ede4bso1599324b6e.2 for ; Fri, 04 Aug 2023 07:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691160642; x=1691765442; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=apFnjtanFsvDoH1r3hzAONCxf1mKf/JHgQxxZH0tN3c=; b=ZRQtjbNEfchbovSeLOfZ4APCu47TlxciFiXER8UDuDo58CMb2QFNqStAhMzgND8eXC gux7m8TlxVtMsEn18AAKgnnzGj1EiPWkr41D6NK19ukdVHXqiWEdyW7ofV6DHKMiO3r+ 0mN+cyxXFUg0zdLO08nkLl/Lsqz+a27jks82DSPNZ6cQRqC6VZcGk4XGR3extHIA+xVV 8fxy6F1DUFZHucBiYyn+nHrXkIoEHll+QU2vrtDnof2MCtU0fDosEKOH8YNJQ+PrGrIE I7pgbzA2TI/SNOw7NX74gxMZsK0rF6R/FqFNws7N1slSA0WvSQT0Q+rYtmA1sE5X1w8H AuSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691160642; x=1691765442; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=apFnjtanFsvDoH1r3hzAONCxf1mKf/JHgQxxZH0tN3c=; b=Uq1kmitt2UdZAF/naAigB9NB2Ro3DEFe9Vh++urr6ae89n0XVlipsy3esDlcwdnSuj PK3O/ar1T4L29/tejJFuwsfx77xhIJdjTkd2Im0EAVQuZaOwEa4+cFwEH1DLZgGI5gKK M35saQMrB/HMLmPxccHelk9TTZzFSpSNzhk4i0StRC4YmwhAOk7M2UDwjyMd+/WYL28I 2f+Oxv52R5Zafn9G+pWy73CzJWJ+E24ztO+rn6lus5TvxF+p45YNZ+ERBXuc1FQJiW79 yCmIR4FrqzDhWMyK0P4Q5qIArOFYMyTOGsxsBOD/w6EFqv62yvJQkk2U4yz3uuoxTdIG 7JQA== X-Gm-Message-State: AOJu0YzVopSRngxKWKnRsZe19Z0ak65yJVmcYowUWf+pDWuoJn+Y/VFJ +tlMwej19dBQPFImiplt/bY= X-Google-Smtp-Source: AGHT+IHHOUbCbcKVI1mhgS5kFzRsuYA3AK2/EKpBbPJW2g5Jl5ILQ7i93ZmVw87Q9BM7AeTNn8Ki+Q== X-Received: by 2002:a05:6808:3086:b0:3a7:62ff:24c1 with SMTP id bl6-20020a056808308600b003a762ff24c1mr2336363oib.46.1691160642369; Fri, 04 Aug 2023 07:50:42 -0700 (PDT) Received: from alolivei-thinkpadt480s.gru.csb ([2804:14c:bf20:86d6:7871:f7e9:8a15:865a]) by smtp.gmail.com with ESMTPSA id bq7-20020a05680823c700b003a3bf96e055sm1061513oib.8.2023.08.04.07.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 07:50:42 -0700 (PDT) Date: Fri, 4 Aug 2023 11:50:37 -0300 From: Alexon Oliveira To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, martyn@welchs.me.uk, manohar.vanga@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v4] staging: vme_user: fix check alignment should match open parenthesis Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixed warnings and checks as reported by checkpatch to adhere to the Linux kernel coding-style guidelines. Signed-off-by: Alexon Oliveira Reviewed-by: Dan Carpenter --- Changes in v4: - Fixed changelog again Changes in v3: - Fixed changelog Changes in v2: - Fixed CHECK: line length exceeds 100 columns, noted by Greg KH and Dan Carpenter - Fixed CHECK: Alignment should match open parenthesis - Fixed CHECK: Lines should not end with a '(' drivers/staging/vme_user/vme_bridge.h | 46 +++++++++++---------------- 1 file changed, 18 insertions(+), 28 deletions(-) diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_us= er/vme_bridge.h index 11df0a5e7f7b..9bdc41bb6602 100644 --- a/drivers/staging/vme_user/vme_bridge.h +++ b/drivers/staging/vme_user/vme_bridge.h @@ -128,28 +128,24 @@ struct vme_bridge { struct mutex irq_mtx; =20 /* Slave Functions */ - int (*slave_get)(struct vme_slave_resource *, int *, - unsigned long long *, unsigned long long *, dma_addr_t *, - u32 *, u32 *); + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, + unsigned long long *, dma_addr_t *, u32 *, u32 *); int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, - unsigned long long, dma_addr_t, u32, u32); + unsigned long long, dma_addr_t, u32, u32); =20 /* Master Functions */ - int (*master_get)(struct vme_master_resource *, int *, - unsigned long long *, unsigned long long *, u32 *, u32 *, - u32 *); - int (*master_set)(struct vme_master_resource *, int, - unsigned long long, unsigned long long, u32, u32, u32); - ssize_t (*master_read)(struct vme_master_resource *, void *, size_t, - loff_t); - ssize_t (*master_write)(struct vme_master_resource *, void *, size_t, - loff_t); + int (*master_get)(struct vme_master_resource *, int *, unsigned long long= *, + unsigned long long *, u32 *, u32 *, u32 *); + int (*master_set)(struct vme_master_resource *, int, unsigned long long, + unsigned long long, u32, u32, u32); + ssize_t (*master_read)(struct vme_master_resource *, void *, size_t, loff= _t); + ssize_t (*master_write)(struct vme_master_resource *, void *, size_t, lof= f_t); unsigned int (*master_rmw)(struct vme_master_resource *, unsigned int, - unsigned int, unsigned int, loff_t); + unsigned int, unsigned int, loff_t); =20 /* DMA Functions */ int (*dma_list_add)(struct vme_dma_list *, struct vme_dma_attr *, - struct vme_dma_attr *, size_t); + struct vme_dma_attr *, size_t); int (*dma_list_exec)(struct vme_dma_list *); int (*dma_list_empty)(struct vme_dma_list *); =20 @@ -159,32 +155,26 @@ struct vme_bridge { =20 /* Location monitor functions */ int (*lm_set)(struct vme_lm_resource *, unsigned long long, u32, u32); - int (*lm_get)(struct vme_lm_resource *, unsigned long long *, u32 *, - u32 *); - int (*lm_attach)(struct vme_lm_resource *, int, - void (*callback)(void *), void *); + int (*lm_get)(struct vme_lm_resource *, unsigned long long *, u32 *, u32 = *); + int (*lm_attach)(struct vme_lm_resource *, int, void (*callback)(void *),= void *); int (*lm_detach)(struct vme_lm_resource *, int); =20 /* CR/CSR space functions */ int (*slot_get)(struct vme_bridge *); =20 /* Bridge parent interface */ - void *(*alloc_consistent)(struct device *dev, size_t size, - dma_addr_t *dma); - void (*free_consistent)(struct device *dev, size_t size, - void *vaddr, dma_addr_t dma); + void *(*alloc_consistent)(struct device *dev, size_t size, dma_addr_t *dm= a); + void (*free_consistent)(struct device *dev, size_t size, void *vaddr, dma= _addr_t dma); }; =20 -void vme_bus_error_handler(struct vme_bridge *bridge, - unsigned long long address, int am); +void vme_bus_error_handler(struct vme_bridge *bridge, unsigned long long a= ddress, int am); void vme_irq_handler(struct vme_bridge *, int, int); =20 struct vme_bridge *vme_init_bridge(struct vme_bridge *); int vme_register_bridge(struct vme_bridge *); void vme_unregister_bridge(struct vme_bridge *); -struct vme_error_handler *vme_register_error_handler( - struct vme_bridge *bridge, u32 aspace, - unsigned long long address, size_t len); +struct vme_error_handler *vme_register_error_handler(struct vme_bridge *br= idge, u32 aspace, + unsigned long long address, size_t len); void vme_unregister_error_handler(struct vme_error_handler *handler); =20 #endif /* _VME_BRIDGE_H_ */ --=20 2.41.0