From nobody Wed Feb 11 07:48:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F92EB64DA for ; Thu, 20 Jul 2023 13:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231787AbjGTNPq (ORCPT ); Thu, 20 Jul 2023 09:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231750AbjGTNPm (ORCPT ); Thu, 20 Jul 2023 09:15:42 -0400 Received: from wxsgout04.xfusion.com (wxsgout03.xfusion.com [36.139.52.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFFC710CB; Thu, 20 Jul 2023 06:15:39 -0700 (PDT) Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4R6Cp31Jwzz9xgYX; Thu, 20 Jul 2023 21:14:35 +0800 (CST) Received: from fedora (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 20 Jul 2023 21:15:26 +0800 Date: Thu, 20 Jul 2023 21:15:24 +0800 From: Wang Jinchao To: Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , , CC: Subject: [PATCH] x86/head64: Harmonize the style of array-type parameter for fixup_pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Originating-IP: [10.82.147.3] X-ClientProxiedBy: wuxshcsitd00602.xfusion.com (10.32.132.250) To wuxshcsitd00600.xfusion.com (10.32.133.213) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The usage of '&' before the array parameter is redundant because '&array' is equivalent to 'array'. Therefore, there is no need to include '&' before the array parameter. In fact, using '&' can cause more confusion, especially for individuals who are not familiar with the address-of operation for arrays. They might mistakenly believe that one is different from the other and spend additional time realizing that they are actually the same. Harmonizing the style by removing the unnecessary '&' would save time for those individuals. Signed-off-by: Wang Jinchao --- arch/x86/kernel/head64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c index 49f7629b17f7..25a67a13a1fa 100644 --- a/arch/x86/kernel/head64.c +++ b/arch/x86/kernel/head64.c @@ -211,7 +211,7 @@ unsigned long __head __startup_64(unsigned long physadd= r, =20 /* Fixup the physical addresses in the page table */ =20 - pgd =3D fixup_pointer(&early_top_pgt, physaddr); + pgd =3D fixup_pointer(early_top_pgt, physaddr); p =3D pgd + pgd_index(__START_KERNEL_map); if (la57) *p =3D (unsigned long)level4_kernel_pgt; @@ -220,11 +220,11 @@ unsigned long __head __startup_64(unsigned long physa= ddr, *p +=3D _PAGE_TABLE_NOENC - __START_KERNEL_map + load_delta; =20 if (la57) { - p4d =3D fixup_pointer(&level4_kernel_pgt, physaddr); + p4d =3D fixup_pointer(level4_kernel_pgt, physaddr); p4d[511] +=3D load_delta; } =20 - pud =3D fixup_pointer(&level3_kernel_pgt, physaddr); + pud =3D fixup_pointer(level3_kernel_pgt, physaddr); pud[510] +=3D load_delta; pud[511] +=3D load_delta; =20 --=20 2.40.0