From nobody Sat Feb 7 11:31:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0BFEB64D9 for ; Tue, 4 Jul 2023 12:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbjGDMgU (ORCPT ); Tue, 4 Jul 2023 08:36:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbjGDMgR (ORCPT ); Tue, 4 Jul 2023 08:36:17 -0400 X-Greylist: delayed 1193 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 04 Jul 2023 05:36:14 PDT Received: from wxsgout04.xfusion.com (wxsgout04.xfusion.com [36.139.87.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA8ABE7E for ; Tue, 4 Jul 2023 05:36:14 -0700 (PDT) Received: from wuxshcsitd00602.xfusion.com (unknown [10.32.132.250]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4QwMF80sf5z9xk0G; Tue, 4 Jul 2023 20:15:24 +0800 (CST) Received: from wuxshcsitd00600.xfusion.com (10.32.133.213) by wuxshcsitd00602.xfusion.com (10.32.132.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 4 Jul 2023 20:15:57 +0800 Received: from wuxshcsitd00600.xfusion.com ([fe80::6811:d152:496c:4db9]) by wuxshcsitd00600.xfusion.com ([fe80::6811:d152:496c:4db9%6]) with mapi id 15.01.2507.023; Tue, 4 Jul 2023 20:15:57 +0800 From: wangjinchao To: Greg Kroah-Hartman , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "outreachy@lists.linux.dev" CC: xulei Subject: [PATCH] staging: rtl8192u: Fix assignment in if condition Thread-Topic: [PATCH] staging: rtl8192u: Fix assignment in if condition Thread-Index: AQHZrmkySezXLmADBkO4wJdvqf1PeQ== Date: Tue, 4 Jul 2023 12:15:57 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-imapappendstamp: wuxshcsitd00600.xfusion.com (15.01.2507.023) x-originating-ip: [10.81.18.204] Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" I just participated in Outreachy of KernelNewbies and fixed one=20 'ERROR: do not use assignment in if condition' issue reported by=20 checkpatch.pl on drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c. Signed-off-by: Wang Jinchao --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/st= aging/rtl8192u/ieee80211/ieee80211_rx.c index ca09367005e1..52ff9e62ec08 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c @@ -1121,8 +1121,9 @@ int ieee80211_rx(struct ieee80211_device *ieee, struc= t sk_buff *skb, =20 /* skb: hdr + (possibly fragmented, possibly encrypted) payload */ =20 + keyidx =3D ieee80211_rx_frame_decrypt(ieee, skb, crypt); if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) && - (keyidx =3D ieee80211_rx_frame_decrypt(ieee, skb, crypt)) < 0) { + keyidx < 0) { netdev_dbg(ieee->dev, "decrypt frame error\n"); goto rx_dropped; } --=20 2.40.0