From nobody Sat Feb 7 22:07:14 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6D218CBF2 for ; Tue, 4 Mar 2025 07:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741071671; cv=none; b=G7Uc65GQG5un9rCAJOUuTjZvaD21YakkX3jPut7+83l3yblNxWgntQkM3ia/m8dsZKmf/KXaBS/ByTC3o823FTLcFjn7zGm85mjsJdfvOOkGrD87cOz+DJmgwpAt/tQZhg86RbjrUzaEfnucyuc5rqRfWTHcG3lEe9iP/7f/PfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741071671; c=relaxed/simple; bh=WeoK4O4lNVf1jf3RL4kog/vPaezBLPVB+yX+IBUebZs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GZkRCkEnJRfO88qn6hofQteVK8oxCj5XzkU7raq0oUDkiRfVgpfbcvCSv29T1spSftSUCwYhZTeMtGmIXLzzXYtI9d3FdB2Xc8O1DVK/Mdcx7aFU5Ik4yBqJhp58hzTXM/DbGhPwr3D9nik6q/UK58lqS2bn76sH2d3CQNJbZ7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kFLca5Hb; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kFLca5Hb" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-abf42913e95so523499466b.2 for ; Mon, 03 Mar 2025 23:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741071668; x=1741676468; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=YSdQFiVMCrS5O9/EkwHKFfamzvbURyk8m93xw+1w4DU=; b=kFLca5Hb30n3UWwFIlGhDXf1JnSJVCgZRapyX4U4p6xFm5XzpGBl29g+frv7oCXOc7 ta2gpOe2KP5V1EPggK0a+7F6kmNbqFylwINo3CSM0bPka3+YDtOUO+/H7ASDh5Ybusva DRkowRgqE58lU/5kZWOCYTUARzc/hnwuvLuAWNhZa2TQ0RbiaT7++XaR7u/yEIMih9py rscFulH1qYeIpkY5Un8kYCytSCezAOBYT5W6m2l4pHgKAvG76nlSBLOOvsXoR5he7Cw5 TSut2iecizCnAQton7W/GtOT/Qz0RwdHps1q0CJ5IPjmsxc4YFn5EeOKdrGEvKVD6C3O suvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741071668; x=1741676468; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YSdQFiVMCrS5O9/EkwHKFfamzvbURyk8m93xw+1w4DU=; b=wONQWiaQ3mFxUCm2Q/kGWtWn4n4csMrEzCfLjvf1PlTg7GBMxVyojoj2BcAcSIBVTc K261aDPjJF/MX+YUyzZbiwPusPNkMuwba67geTH4ljvLqBdk8X56pWOatjWPlf4U1biJ OAYf8XD68kXJ3/F69tnAVjYLUyYWUbpZ42xg5UzrSNZpWPkPurqpqXsCs+i12NlEjcpQ fqWy+cc8yfRJqrQQBf1youOtpdQCriVw744BW8I9fvtE1Ixz42cNIa1qTinm/qoQ3wqK Pdgh1N0XZW239zOq6uN2L/GoLrxDzmfXfe6KYv3lZToLjRe6E7gBSeQ8GwQa5NcCihu8 DPkA== X-Forwarded-Encrypted: i=1; AJvYcCXTnd3ThJv/ihENx5hn16jdrDeTTZnRJrw8kQL9LMzvqadLG7HlKb+ZCjDNU+bYqZ7/bmKrFrmgIy+3j2w=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9MJRcZ7x8SGOgUzOsUByPT+M/o8c5jDppE0SRnk74hQplZ3U1 OhgAv2KaLYXrTgZiVLcc8Fz/Zm2KfGxJ5Wmw5TohwB5vr6DckuGEphyu7W/jKI8= X-Gm-Gg: ASbGnctjhr28D7HAjHaA3m+MXM0a9+0i8KA1Q8raEvOK1ckJ8EE4alh9chCYh/b+gRM nouyPs88soHTtqikRYMGLgJgDX9QBrpR5NbweGDs3I45KSESd4nkIY4STMmof3Y/Mw9ZQB0WYkX zU2aoyHT7YnRZWEUFr1zrJmpQRXyXSFEYlDUxJifIqLCKJ6OzVu7uV8VCGjms/uY+ioQdu1ewcH VZQ94a2ekw4aa0OQnkAEePTiTdvDg6jfZ2kcvtukpGGiYgqw8HuO3lG3f2dyau3DqCTmYPGCK6T wRY4XuJCD2qFW+Ks6v61z3c9p/8q+HPdWmmDKvo6kbI8JcaKzQ== X-Google-Smtp-Source: AGHT+IGxyBW63fSgEIDkdKmUigp27y49JS7UkTA+NZOY+d9+or8SnPNDX/CPFO1XI+oWKppLDaoD5Q== X-Received: by 2002:a17:907:86a9:b0:abf:6424:79fa with SMTP id a640c23a62f3a-abf6424d073mr1083370966b.28.1741071668220; Mon, 03 Mar 2025 23:01:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-abf7981482csm286996066b.122.2025.03.03.23.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 23:01:07 -0800 (PST) Date: Tue, 4 Mar 2025 10:01:04 +0300 From: Dan Carpenter To: Ahmed Zaki Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Sebastian Andrzej Siewior , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2 net-next] net: Silence use after free static checker warning Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The cpu_rmap_put() will call kfree() when the last reference is dropped. Fortunately, this is not the the last reference so it won't free it here. Unfortunately, static checkers are not clever enough and they still warn that this could lead to a use after free on the next line. Flip these two statements around to silence the static checker false positve. Signed-off-by: Dan Carpenter Reviewed-by: Ahmed Zaki --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 9189c4a048d7..c102349e04ee 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -7072,8 +7072,8 @@ void netif_napi_set_irq_locked(struct napi_struct *na= pi, int irq) put_rmap: #ifdef CONFIG_RFS_ACCEL if (napi->dev->rx_cpu_rmap_auto) { - cpu_rmap_put(napi->dev->rx_cpu_rmap); napi->dev->rx_cpu_rmap->obj[napi->napi_rmap_idx] =3D NULL; + cpu_rmap_put(napi->dev->rx_cpu_rmap); napi->napi_rmap_idx =3D -1; } #endif --=20 2.47.2