From nobody Sun Feb 8 15:46:18 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732321F9F71 for ; Mon, 2 Dec 2024 09:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733130450; cv=none; b=V2eB+g5PlPyuBnqpaTVf5ksOrO57zAtjbVYzIn4O8W0IiY96KL3UHthfvv3N/ei4eARrxa57rbN4viRlNdK7nsFG25ZCj4Wd3rWecuTIW8ODr7Ll4VaSXBt6dV8YQPtsV2+P4V/tNnVGGdowLlbK4x4TtiBLz/3+B1yAhsQkVFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733130450; c=relaxed/simple; bh=eDatTayJdQZOiMDh398vW8A73/RB5IYaI7qGAmHkcV4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=U/wWUvqTO8JIrO2oRGaqiAUnw/WS1DMsJSuq30yCzJqGRnivEhJmsdAvvh7RbSg70Q3MbcZm+yK25HQPjgZWXseg+1n63S4rgHhwr+Gto4ozEbPsD1ie+EbhojcCaB9o0uyppRCtyC/Yj3Zn9mCkZL8Uq3eEeDNu/3zAW1ptvTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GjXKHDQK; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GjXKHDQK" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-434a044dce2so50346225e9.2 for ; Mon, 02 Dec 2024 01:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733130447; x=1733735247; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=BR7917va66KYfi/dxTW86XB5ZaenGMbVA2IyXvz+JIw=; b=GjXKHDQKQd5ZXfD05lLstT6GVkN4nM2KruJwqhgp6+QdzuLMAOJt4xcM9pkdoaB0Uh yelJU1omDuWAMXjn4+4RloQ5PAJkDnqB2WZivKcCcdCpGunmeeKdlRpk9N9FVSvk/LLj LYERcITvoR+pdxfSTAbSQhp5LLNh7F814tePm4iANAt+62NE7Kh0HXqzA8WV3WnEOEnE zIgXVM5iTH1j9JE+Ic0ovTuGMnTxRIM5S9Fr65fIaI/lIZQ7dtB2Q2NbhlcuqSQ1WWyR s8CwgJXzYUN+S3ZxggeHE5xGNrokVeou4RGRMVB+7LNebWSblGkCYFURQpM/oKE5MpiW ndKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733130447; x=1733735247; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BR7917va66KYfi/dxTW86XB5ZaenGMbVA2IyXvz+JIw=; b=dbQm6rQToExRgOioX8wVnP0q5nIL3h3Ok6r2iM6eC5HzMR8/Vvj8mPHx7HI84Lgxd/ Evj+PQ+MZvvkjpfhKUmVOjCv6UPUAtCbNA74NCAp3i73xK+3wfyAIhoXcVZXiqct8/uf 3Diwg/IXEz+MD1IctT/dkbjHP76FEpP4u4WzIer0wbxQBW1qfcnH8xvqv1hj9W9a8g8h 19qR0e587OOJ90ohT5hNrihFvNujZjwClmP10vW18qssVPnejChNwcN3X22ub8JaMbhB Twzl6F5GEylSIaTcOCdQ9N8vkxPwwtZZ4J1lFQka7Zfp1WQLZBGjwvYOE1l5cAPVDWYW xYRA== X-Forwarded-Encrypted: i=1; AJvYcCX1WbW+ogZfqhkPFtcGc0ofTenSu9Kbjf2WRwx2AQ6TXdlxJAcXiOwMFmFAnNqLHfvRR1V3fE1qQHRexHE=@vger.kernel.org X-Gm-Message-State: AOJu0YxQnovaMDpxBTd2JZO/l8GzqhAl+0IFFjwlm8MmA1hovbxZhQKe qWjVavk2X+zyBvgBzQGEvXx3O7Gnz+6yY2Wuq6iVYNY9jNn8se8Wf8uXRbERYUVBNBtHJD9CDvf G9CbIdg== X-Gm-Gg: ASbGncvo3RL2b72roAKXEGQhEgaX3OgOdkF4qI91UU+DoRvX5HjsEPel8UYe/2yV8ab yMq18pi0Y3inGGEQf6uOUejw3aan/rJt/OdhsgKNQsWP5FN9Elzo86ETYX3C5Y7pKB/pMREF9qA OU+pKA1mTOmKMdfalycghwIPAshFZbYYZosII4hDgPyYPR+N3w6z7dyV+lQ9wwQx1q6Q31a6Be3 RK8M6yerNTT7ePyIOgNXwdsQLRlDsGCCVvpWe7vI9T9FvX4gjbVZGA= X-Google-Smtp-Source: AGHT+IErHtjKyBNSf/XUWvWl1AoW/h4AU63KtH1xNYUNQzmKxpbD3bUa+ZybCCBWlQeaV0PJJSm5wQ== X-Received: by 2002:a05:6000:156e:b0:385:f062:c2d4 with SMTP id ffacd0b85a97d-385f062c49emr4402219f8f.37.1733130446807; Mon, 02 Dec 2024 01:07:26 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa78120dsm175382645e9.24.2024.12.02.01.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 01:07:26 -0800 (PST) Date: Mon, 2 Dec 2024 12:07:22 +0300 From: Dan Carpenter To: Damien Le Moal Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2] PCI: rockchip-ep: Fix error code in rockchip_pcie_ep_init_ob_mem() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success. Fixes: 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() m= emory allocations") Signed-off-by: Dan Carpenter Reviewed-by: Damien Le Moal Reviewed-by: Manivannan Sadhasivam Reviewed-by: Niklas Cassel --- v2: Update the git hash for the Fixes tag because the tree was rebased I gu= ess. drivers/pci/controller/pcie-rockchip-ep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/contro= ller/pcie-rockchip-ep.c index 1064b7b06cef..34162ca14093 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip= _pcie_ep *ep) SZ_1M); if (!ep->irq_cpu_addr) { dev_err(dev, "failed to reserve memory space for MSI\n"); + err =3D -ENOMEM; goto err_epc_mem_exit; } =20 --=20 2.45.2