From nobody Sat Apr 11 12:14:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC63BC54EE9 for ; Sun, 4 Sep 2022 10:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233758AbiIDK2n (ORCPT ); Sun, 4 Sep 2022 06:28:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233714AbiIDK21 (ORCPT ); Sun, 4 Sep 2022 06:28:27 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7693443E6F; Sun, 4 Sep 2022 03:28:25 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id f15so3032448wrw.3; Sun, 04 Sep 2022 03:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date; bh=5G8LFHpgoS2bGPzH+k4SrdhCNJTqa4gUr30jZ6kq88I=; b=QTyTrQAtLiuU16O+NxwEY3tYgaY2HWgLr3L6tJEYbo8CRp5pu1XcEr3IEwjdGTtrJR fMgtBKetI4F6fgXcxrr4t/vZSE1iKXlXKiFE9qLcHn3oOpw20ZQgagBOf0iJufhbW1k/ Ckz5JndZilwPH/XF5xSVfvGOkB72J0lw2xxuDFwROTyK9fECDsnrd2zrOh1LIDdx1baS kgBlbnYJ7dcJVOcr9b+qbojbnD5DLa4MZpV05cdumBdkE/KxpWYkRxlg+tyOEGAWNMEc F601mNGtq/g0ywhAb9fK2OZJJNGokMZhLVsA0qNp4T3CfDrhj65iL9NFmg6TmjeanPvr Hy7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=5G8LFHpgoS2bGPzH+k4SrdhCNJTqa4gUr30jZ6kq88I=; b=SVwHaXaBCEA4M5C8L32dm1oSniJD7rYmIgWMGQ7D9Eu4MbRupYcrPdnmlwCkbJfxst +Ejt078Dhj9Oes5aoIDejnhhw2CLzC96+8r4MT5hExkuPvNfEad5KGxsOReezrnJ8/Oe 6LWVznxptQMe67+Bqb33/K16ZXsVAT9pjZjFHIeCZbH+lJMwZSzDUyutLOpciinXTsx4 nrd6u5CnsOb/ZxhNqnSbZYQvTVxTF92E+pV/ByzwOMAUoxYYfzQH8pOU/go4o7Zds0Ef HUPyXOONg/FCzGfZqZOTDMA2eTRp7N+w7e72bFMwFaKGKSQWZC12k9v9VaZHCci+JB2N 2x6g== X-Gm-Message-State: ACgBeo0yG5A55kLo9SFj/149tTihxaNsFP/5voU4YSwldvLz6lp0MWJI /XKnLiaDxB55ABKPuaczxTZGB541FlcR X-Google-Smtp-Source: AA6agR6TjdtFPkMUf1SQmytAC+d8LEhltUJGozS2eJwFtukbL41dpE6jnvcaZZ/a+qehjXZeE6MeZQ== X-Received: by 2002:a5d:6f0b:0:b0:226:458c:269 with SMTP id ay11-20020a5d6f0b000000b00226458c0269mr21662874wrb.223.1662287303911; Sun, 04 Sep 2022 03:28:23 -0700 (PDT) Received: from playground (host-92-29-143-165.as13285.net. [92.29.143.165]) by smtp.gmail.com with ESMTPSA id p28-20020a05600c1d9c00b003a5b788993csm7666235wms.42.2022.09.04.03.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Sep 2022 03:28:23 -0700 (PDT) Date: Sun, 4 Sep 2022 11:28:15 +0100 From: Jules Irenge To: ast@kernel.org Cc: memxor@gmail.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, Elana.Copperman@mobileye.com Subject: [PATCH bpf-next] Fixes: 14a324f6a67e ("bpf: Wire up freeing of referenced kptr") Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes a warning generated by Sparse "warning: Using plain integer as NULL pointer" by replacing p with *p in the WRITE_ONCE() macro This enables the pointer to be cleared on map value delete, hence clearing the warning. Signed-off-by: Jules Irenge --- kernel/bpf/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 27760627370d..f798acd43a28 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -598,7 +598,7 @@ void bpf_map_free_kptrs(struct bpf_map *map, void *map_= value) if (off_desc->type =3D=3D BPF_KPTR_UNREF) { u64 *p =3D (u64 *)btf_id_ptr; =20 - WRITE_ONCE(p, 0); + WRITE_ONCE(*p, 0); continue; } old_ptr =3D xchg(btf_id_ptr, 0); --=20 2.35.1