From nobody Wed Apr 15 01:33:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B56DC04A68 for ; Thu, 28 Jul 2022 15:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232282AbiG1Pna (ORCPT ); Thu, 28 Jul 2022 11:43:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbiG1PnZ (ORCPT ); Thu, 28 Jul 2022 11:43:25 -0400 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37F06A4A9; Thu, 28 Jul 2022 08:43:22 -0700 (PDT) Received: by mail-pl1-f170.google.com with SMTP id x10so1424406plb.3; Thu, 28 Jul 2022 08:43:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=9J9OIkJMZnysMReJqY0eBDSfGAATl0A6Xx7Ap4m7F8k=; b=eit6dye5UVfLjH2AhkiBYZ1QuhsRRvNhx//RGJqzsTqPn023VZmDf+O9etHxNrJelk 3Efye8jN4sYlNLZHNSrlOsT2Mo+vLjgqaX3uZfA64+ft7RV5hZe8OB/1/5Ypq6OTJgTk QeZ4P9/hP2iZ+Dm3qAaPfvRcoc+E+uvojc9NaC/irr+bwNbVLKUcRzbcb+50UieOXnT+ DRU6bpyVnK7Q0GY9wWWh+gRqHWqPUVWagtvjdsfTON2/4BsoFJqXoDHY4QaETHJO9ifa vz4GWmWLqy9iOafc6d4T8IPYmQ7Kmco1ClG3IdYAzH85JOs+5JOD8laeCYwJ39OkKlQ0 EPrQ== X-Gm-Message-State: AJIora85cqIA7AoT0Lw+BVBRst2VX8wtcVnSVg8ftcPDIL1sIxk7xTjT SISxlSrS+OKLAWCjDzlWFF4= X-Google-Smtp-Source: AGRyM1u24LGPgyQLBUhgENLyOoBvMALle4uJlRPhTLWgWhlPPfmDqRB16Mor7m8gcDzDmrm1tfpMCA== X-Received: by 2002:a17:902:da88:b0:16d:b75e:16d8 with SMTP id j8-20020a170902da8800b0016db75e16d8mr7113840plx.157.1659023002111; Thu, 28 Jul 2022 08:43:22 -0700 (PDT) Received: from karthik-strix-linux.karthek.com ([61.1.131.162]) by smtp.gmail.com with ESMTPSA id q6-20020a170902dac600b0015e9f45c1f4sm1483344plx.186.2022.07.28.08.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 08:43:21 -0700 (PDT) Date: Thu, 28 Jul 2022 21:13:17 +0530 From: Karthik Alapati To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: hidraw: fix memory leak in hidraw_release() Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Free the buffered reports before deleting the list entry. BUG: memory leak unreferenced object 0xffff88810e72f180 (size 32): comm "softirq", pid 0, jiffies 4294945143 (age 16.080s) hex dump (first 32 bytes): 64 f3 c6 6a d1 88 07 04 00 00 00 00 00 00 00 00 d..j............ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [] kmemdup+0x23/0x50 mm/util.c:128 [] kmemdup include/linux/fortify-string.h:440 [inline] [] hidraw_report_event+0xa2/0x150 drivers/hid/hidraw.= c:521 [] hid_report_raw_event+0x27d/0x740 drivers/hid/hid-c= ore.c:1992 [] hid_input_report+0x1ae/0x270 drivers/hid/hid-core.= c:2065 [] hid_irq_in+0x1ff/0x250 drivers/hid/usbhid/hid-core= .c:284 [] __usb_hcd_giveback_urb+0xf9/0x230 drivers/usb/core= /hcd.c:1670 [] usb_hcd_giveback_urb+0x1b6/0x1d0 drivers/usb/core/= hcd.c:1747 [] dummy_timer+0x8e4/0x14c0 drivers/usb/gadget/udc/du= mmy_hcd.c:1988 [] call_timer_fn+0x38/0x200 kernel/time/timer.c:1474 [] expire_timers kernel/time/timer.c:1519 [inline] [] __run_timers.part.0+0x316/0x430 kernel/time/timer.= c:1790 [] __run_timers kernel/time/timer.c:1768 [inline] [] run_timer_softirq+0x44/0x90 kernel/time/timer.c:18= 03 [] __do_softirq+0xe6/0x2ea kernel/softirq.c:571 [] invoke_softirq kernel/softirq.c:445 [inline] [] __irq_exit_rcu kernel/softirq.c:650 [inline] [] irq_exit_rcu+0xc0/0x110 kernel/softirq.c:662 [] sysvec_apic_timer_interrupt+0xa2/0xd0 arch/x86/ker= nel/apic/apic.c:1106 [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 arch/x86= /include/asm/idtentry.h:649 [] native_safe_halt arch/x86/include/asm/irqflags.h:5= 1 [inline] [] arch_safe_halt arch/x86/include/asm/irqflags.h:89 = [inline] [] acpi_safe_halt drivers/acpi/processor_idle.c:111 [= inline] [] acpi_idle_do_entry+0xc0/0xd0 drivers/acpi/processo= r_idle.c:554 Link: https://syzkaller.appspot.com/bug?id=3D19a04b43c75ed1092021010419b5e5= 60a8172c4f Reported-by: syzbot+f59100a0428e6ded9443@syzkaller.appspotmail.com Signed-off-by: Karthik Alapati --- drivers/hid/hidraw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 681614a8302a..197b1e7bf029 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -350,6 +350,8 @@ static int hidraw_release(struct inode * inode, struct = file * file) down_write(&minors_rwsem); =20 spin_lock_irqsave(&hidraw_table[minor]->list_lock, flags); + for (int i =3D list->tail; i < list->head; i++) + kfree(list->buffer[i].value); list_del(&list->node); spin_unlock_irqrestore(&hidraw_table[minor]->list_lock, flags); kfree(list); --=20 2.36.1