From nobody Mon Sep 15 04:13:43 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE481C46467 for ; Sun, 15 Jan 2023 09:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjAOJch (ORCPT ); Sun, 15 Jan 2023 04:32:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjAOJcc (ORCPT ); Sun, 15 Jan 2023 04:32:32 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 122959017 for ; Sun, 15 Jan 2023 01:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673775142; bh=h3BV35ExW4Qp8mSJAt5y1TYkCZQhRUQwk+nplpac6xs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=XRtOftUNorQbmCMcA54sJ3NrwQZVSNveuKgJbOSftQ3YhAniPLLuZd6n26IXyzBvP IdBHzt9gQ8rZfCuwx8McAyz0q2H+nOcVA26wP9Ap4z+eD/nstnLbVAdBeEhuEjwYMk Yn3IEohbNoTvKG/x3Sfn3FqUK71GNlLbyu9dxWok= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 15 Jan 2023 10:32:22 +0100 (CET) X-EA-Auth: DwObgLNILM2GtGPAI+00q8N5h+32tnvd/PwBaxq/eKJBAyAYbimivsEbXvC9hVqYG8F0mkVbytx8mh28znre75c7q2Kq5iw9 Date: Sun, 15 Jan 2023 15:02:17 +0530 From: Deepak R Varma To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH] drm/amd/display: avoid variable reinitialization Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The member variable set_odm_combine is already initialized and hence the reinitialization instruction can be removed. Issue identified using the dubleinit.cocci Coccinelle semantic patch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/= gpu/drm/amd/display/dc/dcn314/dcn314_optc.c index 41edbd64ea21..777d8efee977 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c @@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = =3D { .get_hw_timing =3D optc1_get_hw_timing, .init_odm =3D optc3_init_odm, .set_odm_bypass =3D optc314_set_odm_bypass, - .set_odm_combine =3D optc314_set_odm_combine, .set_h_timing_div_manual_mode =3D optc314_set_h_timing_div_manual_mode, }; =20 --=20 2.34.1