From nobody Thu Apr 9 06:24:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CC4C433FE for ; Thu, 3 Nov 2022 11:29:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbiKCL3N (ORCPT ); Thu, 3 Nov 2022 07:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiKCL3L (ORCPT ); Thu, 3 Nov 2022 07:29:11 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E035811811 for ; Thu, 3 Nov 2022 04:29:08 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id c1so637010lfi.7 for ; Thu, 03 Nov 2022 04:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Ji8a4yG4RjSdG7BLCUtmcpBYrxK+oJyQ34/a2EhpGDc=; b=i437q/kUp1uPQM4UD6FyTPNjz/1+HTAK5HrZQ45guWjdEBZMg1e4w8DTUZc44Mbix9 lsuLn29TKXwj3Emf47sO7JCc91PLpS8alu+6kbOWEcbyRoxQT2TPt3JyagDsK0R+uou4 iyOmjPVS+Q1r/0RIiXQ28XjFNMshPlsuer6oOPgPFSkEkG+c+ptVBs0oSSHgm2IqD3dv XdYmreEpBMdSwY+9zZy2CvuZ6QryWhGoOJw+KI6cc1kS7UIcaBJ2R4qCEF9N4v8YWMbx cnTY/RQ/eSJBmn6376Jh3p7WD8ACNyiVRmLI2uqdXje/66a4qdKCQ02n1rr1TvmkSDMq bopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ji8a4yG4RjSdG7BLCUtmcpBYrxK+oJyQ34/a2EhpGDc=; b=EA+3nieOdQKSSjRjOo38G1QQpkd8j5BlFt2P1G1Lji7zgOrIgl/4i+6X4uL3fksLJV GZ5XhBDoLBPwDFKhPKfW6EInJ3Yzxwor4/BtikRKZAdru/s+RyKzFMnyTrXBSXrFdcoT xxNEWRwVhzSUwDBp+fKgZrBxNc0djFA7eV7s3hQ45qmdyclcKhvtVJL8qmJ3e6eOUgPV LABo5seBsgkL9wT9i070QbmebpYozXVSf8W1Xf5YDe+Ra9N3hQ/hgbwmrnbLiSyDFuUE d7sZDZKTdPdJ7xzy7Jlt72loApVngaLeJWpaEPP5iQLaoZRaKpGfJHRmq0evzpOHbYXG r/uA== X-Gm-Message-State: ACrzQf35rWKpStQzRr0aOQfI5+pwl06af9P04mwE2CP1BURde2ffKsYc ZpAG0UVZ3YgUtVZL/x7OPV2zKvL5RRUB7A== X-Google-Smtp-Source: AMsMyM4s9MpBhBrcnB17SSvGjjFfKFk+eOcyP84Lak/wUO1b/agDvBgCIiSwAt2FQLzagdQZmKObDA== X-Received: by 2002:a05:6512:3c8f:b0:4a2:5959:8b5e with SMTP id h15-20020a0565123c8f00b004a259598b5emr12323417lfv.647.1667474947037; Thu, 03 Nov 2022 04:29:07 -0700 (PDT) Received: from elroy-temp-vm ([20.240.130.248]) by smtp.gmail.com with ESMTPSA id s17-20020a056512203100b004a2cd6d5ad6sm100308lfs.19.2022.11.03.04.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 04:29:06 -0700 (PDT) Date: Thu, 3 Nov 2022 11:29:06 +0000 From: Tanjuate Brunostar To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH] staging: vt6655: change the function name s_vGenerateTxParameter Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the use of Hongarian notation which is not used in Linux kernel. Join some lines of code to avoid a line ending in a '(' Reported by Checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 54 ++++++++++++++++------------------- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index debc5d5daede..793a63b2ff46 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -10,7 +10,7 @@ * Date: May 20, 2003 * * Functions: - * s_vGenerateTxParameter - Generate tx dma required parameter. + * generate_tx_parameter - Generate tx dma required parameter. * vGenerateMACHeader - Translate 802.3 to 802.11 header * cbGetFragCount - Calculate fragment number count * csBeacon_xmit - beacon tx function @@ -95,17 +95,17 @@ static void fill_rts_header(struct vnt_private *pDevice, unsigned short wCurrentRate, unsigned char byFBOption); =20 -static void s_vGenerateTxParameter(struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate); +static void generate_tx_parameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate); =20 static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, @@ -864,21 +864,17 @@ s_vFillCTSHead( - * unsigned int cbFrameSize, Hdr+Payload+FCS */ -static -void -s_vGenerateTxParameter( - struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *tx_buffer_head, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate -) +static void generate_tx_parameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *tx_buffer_head, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate) { u16 fifo_ctl =3D le16_to_cpu(tx_buffer_head->fifo_ctl); bool bDisCRC =3D false; @@ -1107,8 +1103,8 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsign= ed char byPktType, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vGenerateTxParameter(pDevice, byPktType, tx_buffer_head, pvRrvTime, pvR= TS, pvCTS, - cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate); + generate_tx_parameter(pDevice, byPktType, tx_buffer_head, pvRrvTime, pvRT= S, pvCTS, + cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate); /* Fill DataHead */ uDuration =3D s_uFillDataHead(pDevice, byPktType, pvTxDataHd, cbFrameSize= , uDMAIdx, bNeedACK, 0, 0, uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll); --=20 2.34.1