From nobody Tue Apr 7 20:31:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5239C4332F for ; Fri, 21 Oct 2022 09:26:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiJUJ0M (ORCPT ); Fri, 21 Oct 2022 05:26:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbiJUJ0H (ORCPT ); Fri, 21 Oct 2022 05:26:07 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFB7216D55C for ; Fri, 21 Oct 2022 02:25:51 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id f37so4043385lfv.8 for ; Fri, 21 Oct 2022 02:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=C2MVCCy2Kj88bAGrrwyous+SY2zFdp50BJwaTNbSgJs=; b=e1Ug2fbqBV828vW2hp81OZQM8ZZrtqzFoCgUtgF1WPGaTyc+HKq4vG6c/GhnbLHqs/ G34p+YJXUqnyngkTTPuvqC3bVytW4N/GYy4OyczPzpg+BBUlNFmJwrqC4xICbSIJdGVq oTLTLNJXWuZlKtpB3+ZcBBceSmeXnnTjQCghJpJqk+BztA39iGgHGgeYr1Ypb5DonO0A JWnPCiGhpyQg5gtS4ywgKcQRgr3cLDK3m/cZ6jrod8s+I6nZbZX3XkZxrYocUebwMO1v RZBtWS7qIZ1PY9GrYy4RBUurwv1D8cznf9ihBC01AYjnLx2RhjAL4LG31co9eZKB1iQg m15w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C2MVCCy2Kj88bAGrrwyous+SY2zFdp50BJwaTNbSgJs=; b=FjeH6GpgB3da3nPWVbpFe13ErORd3twwswaREbAZUpbQ0ftkAy2tLnVI88AFvDad4R kZwBZo7GU9s0pkHp/Czpmo4DvTqFE/c2OsI2n/cd11XtXEL9hImr3dbUfROIYU3J6zX3 BTiFtjaVda/OZl6BuWxsHIoT2I9O9H9lrj8sI3N3p39DGoJ5wHh6Mc94Pwj9XJjFW3JU ErNZ+J7logyFx8aXc9ZhrkrgLdmlEdIDzvNbrGEzXXo/M6H3Sf2YnU90Gx+opWP565Ne XCMdN17uv2CYrTlDPMOJ6bLdi120N49fZNCqxjSG9gT79wjQcuc+cgLyW2+6KFzssjWc Hs4Q== X-Gm-Message-State: ACrzQf2p8/rbXu855apPCU8B4DIQV7/654RFNmbvlHSeYHlO/XbXSL+l o8SmScwyl2oVxvymFqZroj5DQpJntAYJ8qbu X-Google-Smtp-Source: AMsMyM4+5YCd0Luf4TS2xNZ0ncMzTartBJCb60IU0qioV9xKWdxD8sActTvNkZmCQGyb5TZ9G5oWjA== X-Received: by 2002:ac2:44c1:0:b0:4a6:113f:ab60 with SMTP id d1-20020ac244c1000000b004a6113fab60mr4222002lfm.475.1666344349940; Fri, 21 Oct 2022 02:25:49 -0700 (PDT) Received: from elroy-temp-vm ([20.240.130.248]) by smtp.gmail.com with ESMTPSA id n13-20020ac2490d000000b0049b8c0571e5sm3091491lfi.113.2022.10.21.02.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 02:25:49 -0700 (PDT) Date: Fri, 21 Oct 2022 09:25:48 +0000 From: Tanjuate Brunostar To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH v4] staging: vt6655: Fix Lines should not end with a '(' Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Code style warnings reported by checkpatch. Improve the layout of a function header: Put the first parameter immediately after the '(' and align the other parameters underneath it. Signed-off-by: Tanjuate Brunostar Tested-by: Philipp Hortmann --- v2: put static and void on the same line and adjusted the indentation as suggested by Greg KH --- v3: Reformat the code by inserting tabs and white space as recommended by Nam Cao and Julia Lawall --- v4: final version of this patch drivers/staging/vt6655/rxtx.c | 78 +++++++++++++++-------------------- 1 file changed, 33 insertions(+), 45 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 5bdb5176772c..1e5036121665 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -85,35 +85,27 @@ static const unsigned short wFB_Opt1[2][5] =3D { #define DATADUR_A_F1 13 =20 /*--------------------- Static Functions --------------------------*/ -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -); - -static -void -s_vGenerateTxParameter( - struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate -); +static void s_vFillRTSHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); + +static void s_vGenerateTxParameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate); =20 static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, @@ -121,22 +113,18 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsign= ed char byPktType, unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, unsigned int uNodeIndex); =20 -static -__le16 -s_uFillDataHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pTxDataHead, - unsigned int cbFrameLength, - unsigned int uDMAIdx, - bool bNeedAck, - unsigned int uFragIdx, - unsigned int cbLastFragmentSize, - unsigned int uMACfragNum, - unsigned char byFBOption, - unsigned short wCurrentRate, - bool is_pspoll -); +static __le16 s_uFillDataHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pTxDataHead, + unsigned int cbFrameLength, + unsigned int uDMAIdx, + bool bNeedAck, + unsigned int uFragIdx, + unsigned int cbLastFragmentSize, + unsigned int uMACfragNum, + unsigned char byFBOption, + unsigned short wCurrentRate, + bool is_pspoll); =20 /*--------------------- Export Variables --------------------------*/ =20 --=20 2.34.1