From nobody Tue Sep 9 21:36:07 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4438C6FA9D for ; Wed, 1 Mar 2023 19:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbjCATOJ (ORCPT ); Wed, 1 Mar 2023 14:14:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjCATOF (ORCPT ); Wed, 1 Mar 2023 14:14:05 -0500 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F63534015 for ; Wed, 1 Mar 2023 11:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1677698016; bh=eiqwtvnYck/1m0Yt7lMi6q3bdq0fyTlM8ZfdFltVRKE=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=CZLsHMAvNLBb93M64IRDSf/cIlL4QL96uIS2CGixwUwaJGSu011oomSy5JdyIn/0U YlKL1Mmgv/cbOEksgYf98K+5V53GuJwqy6DmSR1fEc5yzGPxgbFkmG+6m4jOYg0rTd xAnwRD4bEELhbIYlIv2K+IIiwn6mRdCBDQqSD64E= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 1 Mar 2023 20:13:36 +0100 (CET) X-EA-Auth: TSRsA2wbeBLpAiKN+cBrdG6+KjuRR4juq/RVwwPYl8JecVpgVWmrqxQWw9+/Q/F6wEJuDNSSKxR6LQt6f1rC4tfBn71YFHgx Date: Thu, 2 Mar 2023 00:43:31 +0530 From: Deepak R Varma To: Dinh Nguyen , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , pk.drv@ubun2204.myguest.virtualbox.org Subject: [PATCH RESEND] EDAC/altera: Remove redundant error logging Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified using platform_get_irq.cocci coccinelle semantic patch. Signed-off-by: Deepak R Varma --- Note: The change was compile tested only. Resending the patch for a review and feedback. =20 drivers/edac/altera_edac.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index e7e8e624a436..72fa49c44360 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -2149,10 +2149,8 @@ static int altr_edac_a10_probe(struct platform_devic= e *pdev) } =20 edac->sb_irq =3D platform_get_irq(pdev, 0); - if (edac->sb_irq < 0) { - dev_err(&pdev->dev, "No SBERR IRQ resource\n"); + if (edac->sb_irq < 0) return edac->sb_irq; - } =20 irq_set_chained_handler_and_data(edac->sb_irq, altr_edac_a10_irq_handler, @@ -2184,10 +2182,9 @@ static int altr_edac_a10_probe(struct platform_devic= e *pdev) } #else edac->db_irq =3D platform_get_irq(pdev, 1); - if (edac->db_irq < 0) { - dev_err(&pdev->dev, "No DBERR IRQ resource\n"); + if (edac->db_irq < 0) return edac->db_irq; - } + irq_set_chained_handler_and_data(edac->db_irq, altr_edac_a10_irq_handler, edac); #endif --=20 2.34.1