From nobody Mon Feb 9 01:01:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A92EB64DC for ; Tue, 18 Jul 2023 11:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231929AbjGRL0g (ORCPT ); Tue, 18 Jul 2023 07:26:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbjGRL0d (ORCPT ); Tue, 18 Jul 2023 07:26:33 -0400 Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on2101.outbound.protection.outlook.com [40.107.113.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C5BAD8; Tue, 18 Jul 2023 04:26:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPbmBlEck9uqF4IoDrwHyrKd7xjXwx/YhKS7Y6UYtB+wcQG3GHthqm+KBuNBeZLUwcYRjr0GpWWANOdxklxuUfNhV1RHWB5K1jXtGO7zqSIvV6UNk75awV0D628Jvi6QsxbVZ/+xDQdm6M0MarWEtKqT7Zi/vLT9dtdTUn95C84uD20O7Rkd1qtxkhIKLWXz8iKWzUdD6C1AWeomaKD9JdNZ8rxVIWQBS+484w9rqxqwVc7q667eDjqJYXcVhV28iYOjfSjQewso4z6JZ1zwB9Uky0MKDUIxy+Kqt7vVgxeeJH3cB/cTy0jDDZB8kzXufl1kdpCjMmxnaGcxtrtGUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7c8AEu4V2C71dnhusXWys2CJF3pdSaQXpRh97Rm8kDE=; b=bz+ijoRwV5M0fH/AKo3xKmtjHsxi16JF0DQYqeJSzTVjXEb95v489SBUPacFlquD/ZXb6013FtlDNzJ0iIX+Dpz7BDre1KUBGr5mJBQKecxXS4AMSCYhvdutZiDbYULLwGZUvhwm5G/bvASlMPWzQlqsCCUjvc2/7URfhPz79v0t4c6rY5lGWJIQ0dsBOOuVZxB7QhCKBHGHQVp4f+U8x+agZ01CXec56/6vX25tza1DFE1qNBHFIWG08eowwlj4MiWRVHQHcToyfO+o86xMo7WzWL7J4KYzGzaKeiPoSr4Q7nuKK/j1ybSVtV1RozEodVIBya2KGGzO65cocUlN4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7c8AEu4V2C71dnhusXWys2CJF3pdSaQXpRh97Rm8kDE=; b=aAaYZBB5boOa3wDqH8mv62cAtdv1HjG2+xqSHseNJPLVoheMba1nnd7l4tjEGIqyARx5xD4cvAVb/H82rxe97kPdc91ol67UEh+xzsZYCG732c4fn/d8UJea+vW5Q5EQliD47W3YfkFlY3w4m+dqA2LtQHjFuWZhNjUZyNmmzgE= Received: from OS0PR01MB5922.jpnprd01.prod.outlook.com (2603:1096:604:bb::5) by TYVPR01MB10719.jpnprd01.prod.outlook.com (2603:1096:400:298::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Tue, 18 Jul 2023 11:26:28 +0000 Received: from OS0PR01MB5922.jpnprd01.prod.outlook.com ([fe80::834b:28df:28dc:7f95]) by OS0PR01MB5922.jpnprd01.prod.outlook.com ([fe80::834b:28df:28dc:7f95%7]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 11:26:28 +0000 From: Biju Das To: Randy Dunlap , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" CC: Thierry Reding , =?utf-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Fabrizio Castro , "lee.jones@linaro.org" , Geert Uytterhoeven Subject: RE: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors Thread-Topic: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors Thread-Index: AQHZuULWGO/C9BN6KUGGSx2mRQXL7a+/Ym5g Date: Tue, 18 Jul 2023 11:26:28 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS0PR01MB5922:EE_|TYVPR01MB10719:EE_ x-ms-office365-filtering-correlation-id: ef1393df-3f4b-4bc3-8e3c-08db8781d42a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8xzWOXfFP7KlYccuxg/3rMqaI3OlL92hHpr7wdrtpg4fLoZ1qAjcYZqlcGQXH6x4v3DFP+RsjGs9+wuR8fQZO8CnMpkr+4oovP/HCRf/POI6dGocog5Qx+8tT1VDzKGLMKLL0yKUue+w3N+N0gGeNNJ5F/ZJAnPFFKTDDJseg0JQYX4c7eNnGgTUe6MKuLaFjXLLd/IxQbjTYKWEw0Z6FcpQ2OLdX0Yu9YdAUst4M0h/IG7DPi/jhbfDncQer34e/Q1N/EkIJ2U/7RHA1ZN7YC1CRpagyYgY4JQTLVCUZjeb4V85BApPLFiIL7Kt9jdcZt+pXOqBk7xss70Ni/+fzCI+8lv5U4IQjh6Co7isTUaNqx/UG62QMZk1o6grx/6zB/53S4ca3MYLkqTpEctnoNI2EamD7jln3ym7xLKMKS+FGMkzbYC3mCnl7mAl0biNEW8WCggdVMTmwhym31kL1yWTmiqTeVCw1mSeVMnWw0JFgL0QqDRgP2jsAQ4wqxfimCjnLv6kudaPGR4u+0bW59u8EZhOqBK3ZNbYuWmf9DWjgGSESxwdnK3kZ8DSH+TzkVP0d0uJxP3ZFHOCwlLOGuH6kIcj29iETwScKH3EUeGnfwl1ioNR4DGVJWb+krn4 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS0PR01MB5922.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199021)(66476007)(66446008)(66556008)(54906003)(110136005)(86362001)(186003)(64756008)(66946007)(76116006)(4326008)(478600001)(41300700001)(9686003)(316002)(7696005)(71200400001)(38100700002)(8676002)(8936002)(38070700005)(5660300002)(52536014)(6506007)(26005)(55016003)(2906002)(66574015)(83380400001)(122000001)(53546011)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d3ppR1pFVDhMU3c2YjVCTmNwajJ1c1hmeVVTNlUzM2hTVTVNS1Ara2tyMGFT?= =?utf-8?B?WDJmSXZHc0R6bGYydDhSMTdnT2JmVjVGbk5SenFuRWo1MXluWWdhRDNQTlJU?= =?utf-8?B?K3M0SWl6eTRteGJ6MWdpMjcrTDY4cmlzVzJaTTNOZm5pOVhGT2FSV29JazBL?= =?utf-8?B?eGhNZDhLSndJa1ZYdUhWZXlEWFk2R0FVS05GblJ6SUkrNEpWNCtZYnNlRG9G?= =?utf-8?B?U0JZQ0pYK0VIczVrRThyazFoNlNOZHorUmtOdUZGdkxlQzcvam1rWk96cXZZ?= =?utf-8?B?SVFFZktGY1RxVzRCMm14bEZTem8xTXA4R2NLZkd2ZXEwdGlJZUlqRXpxLzcy?= =?utf-8?B?TkFEYkg5YVpKWU9RTTVqYk1MS2ZWZktiOGpzNnVKckFDMUYzbU92dzZ6eWtK?= =?utf-8?B?Nk9uQkRNaFdpOUpzeTYzN3hVZlVxemExc2FrMkxaYTduVmY1d1pnUVdHMm1k?= =?utf-8?B?aDdOa0hqQTFVcGVsd3RNOWtoTEFSandFbGxpNlBsRCttWWV6NUlGL3ZTc1Nl?= =?utf-8?B?VFEwdFhJeGlwRVcrNTk1NEhXdTFtYzQ0bGVnNnFoQVlmZVBIMEUrTFNwa3lh?= =?utf-8?B?eUpucWhzd0kvanErdXpHc3c2MVdkWmdoOUZTekpQVzV3d2kwbjV5TXFUenlU?= =?utf-8?B?cVRydGtETTVhZlFsdFkrZGZjOHE4TVZvWk5qb2FVdFBqYUtUc1dob2YwZzhD?= =?utf-8?B?elZ1SDFhcjB4U2dwRXYyL293bWZDSnMwUXRDNE5Cakgvc0dBTTlFTWZ0aG9t?= =?utf-8?B?ZDUvbHluRTEzSnhKeXY1cmljVVM5Z1FTZTlHTmlBQkdySk5kdEZ6Y1p3bDFL?= =?utf-8?B?bTJRL0tIZTlxOVZNVGFSa3BRb05haDM2ZGhpSkpqS0FEN0ZqVEpvcFo5WVh4?= =?utf-8?B?dGdtZ3M4ZThPSDh0Yzg0cFYvWHoxdVhmQURZblpjMTd2bVRIUVlmclQ4ckRF?= =?utf-8?B?Si9uQk14WG11bi9YdWVuUnNMQ1FCT2JtZXlpZDlzdlJxb2hGdG81WXpPU24r?= =?utf-8?B?eSt5UVlNSGlNYUJXY1NDU1dEeS9yajRFMjd5SWxabXd5RGJFUjhsMG5GZk5p?= =?utf-8?B?OExCNlNuTGp4aW9ma1loVVJnK0E2c1BiYk5RSmNPM25RUHk2elpvUXovaWQv?= =?utf-8?B?Uks3dVlORTN2V21BYkFxL1E0OW51NjNmQ3dkU2dhVUNPbzUzQnorTk8yTWIz?= =?utf-8?B?QXdueG1lVTVGa0gzdVA1Z2hQdTU2bFgxR1NvUkpKUHhBbVF5SkVYcXhmVnM2?= =?utf-8?B?Q24vU0pYY2ttZWNJQTNaVldDSzlzMWFJR2szZFl2U2N4UkgzaUNxNGtyOU9p?= =?utf-8?B?cEZoLzgzRWVJUDN2RUhxeEt5TXZXTEkwd3ZCZEE1cWxwYmNSQUprVFhodWQr?= =?utf-8?B?dngzWGtvQmsxSHJKWEZTOFRyekZwZW5KUVVsK3hDby9Ea0ozWEU0WXZNZExm?= =?utf-8?B?NmZKNVE4R3NOc1RNQnIvb1NQNW1MQ2FTbmJLZ2R6VTJVczg4RUtyZlNwTHlG?= =?utf-8?B?a2tHWlR4TG82N2MxUEdIdFZVczB0bTBjOG9Hcm9LS2YrcW9MaWlBWVpvb3VX?= =?utf-8?B?TFhZa1o3T1lEeHR0bTB5L3V4VWhPRytUSDd5djhVNWp0OUc5bkd6c1pYTTVF?= =?utf-8?B?WHBCdmo5NW5CbDNxeUJMbmc0ZkJDdksxVEpPQjZlZ29mMWdWUmp4ZUxlSXM1?= =?utf-8?B?eW9iaU9vdm4rdnZEekZQWUp4MlB5U2p4NEpIQzFjTENxUVROZ0NBWkhJY3d4?= =?utf-8?B?dUxLQXAreHVvQ1dScldMaEtLVVlDRlpNdzhKSTJUSW9sVkpJd3VldWZoVTlH?= =?utf-8?B?R3A2M2VxSzdiQUhZUndWVjBxTzlBSG4xcUo1MWNacFRVMThzSnd3MTdqNDRo?= =?utf-8?B?UjkxbzIvYjRMUkFwN1RBY2EvQ2l3RldTZDlRaTYyb0xUZnl5S2E2SGVkVmlr?= =?utf-8?B?MGhQYUY3TlRMak1NdzJMbktEY0N4Rmc4L29LSWpXS1g3VGlGbUVIbXhTNlU0?= =?utf-8?B?Qmo2WVNtcjFQblVLTDVQcW0xM0RoMmpzSmdZdzlIYy9DTEJveUJRSEhNS2Zw?= =?utf-8?B?RGdFSXRVMmtjWGZRSDZMVlNRMHEyR3ByWGFOZnRWMFZ1SFl2OHJOeWlFWXdH?= =?utf-8?B?UUxaQ2MvUmlBcFdYRG43alI4cXhnalVCeG9TdCszazBQR1VLb1VwakpIWUVB?= =?utf-8?B?VkE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef1393df-3f4b-4bc3-8e3c-08db8781d42a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 11:26:28.3059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FV+Je5FUznvHXVlIbRfSMx0HJ4UGRqit6ExFopMQl3YBA76N6j/Yc0g44/IoGKp/qlRVWNVbZKPL0+OUlJnkuJ0Y6guAb3dlIWQjP4A4jSU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYVPR01MB10719 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, > -----Original Message----- > From: Randy Dunlap > Sent: Tuesday, July 18, 2023 7:41 AM > To: linux-kernel@vger.kernel.org; linux-pwm@vger.kernel.org > Cc: Biju Das ; Thierry Reding > ; Uwe Kleine-K=C3=B6nig koenig@pengutronix.de> > Subject: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors >=20 > From: Randy Dunlap >=20 > When (MFD) RZ_MTU3=3Dm and PWM_RZ_MTU3=3Dy, there are numerous build erro= rs: >=20 > ld: vmlinux.o: in function `rz_mtu3_pwm_config': > drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable' > ld: drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to > `rz_mtu3_8bit_ch_write' > ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers': > drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to > `rz_mtu3_16bit_ch_write' > ld: vmlinux.o: in function `rz_mtu3_pwm_config': > drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to > `rz_mtu3_8bit_ch_write' > ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers': > drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to > `rz_mtu3_16bit_ch_write' > ld: drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to > `rz_mtu3_16bit_ch_write' > ld: vmlinux.o: in function `rz_mtu3_pwm_config': > drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable' > ld: vmlinux.o: in function `rz_mtu3_pwm_disable': > drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to > `rz_mtu3_8bit_ch_write' > ld: drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to > `rz_mtu3_disable' > ld: vmlinux.o: in function `rz_mtu3_pwm_enable': > drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to > `rz_mtu3_8bit_ch_write' > ld: drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to > `rz_mtu3_8bit_ch_write' > ld: drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable' > ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled': > drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled' > ld: drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to > `rz_mtu3_8bit_ch_read' > ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers': > drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to > `rz_mtu3_16bit_ch_read' > ld: drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to > `rz_mtu3_16bit_ch_read' > ld: drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to > `rz_mtu3_16bit_ch_read' > ld: vmlinux.o: in function `rz_mtu3_pwm_get_state': > drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to > `rz_mtu3_8bit_ch_read' >=20 > Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is still > allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being built but also > allow the latter not to be built. >=20 > Fixes: 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver") > Signed-off-by: Randy Dunlap Cc: Biju Das > Cc: Uwe Kleine-K=C3=B6nig > Cc: Thierry Reding > Cc: linux-pwm@vger.kernel.org > --- > v2: fix typo in Subject; > correct my email address while infradead.org is down; >=20 > drivers/pwm/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -505,7 +505,8 @@ config PWM_ROCKCHIP >=20 > config PWM_RZ_MTU3 > tristate "Renesas RZ/G2L MTU3a PWM Timer support" > - depends on RZ_MTU3 || COMPILE_TEST > + depends on COMPILE_TEST > + depends on RZ_MTU3 || RZ_MTU3=3Dn > depends on HAS_IOMEM > help > This driver exposes the MTU3a PWM Timer controller found in The below patch also works fine, diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 1c8dbb064ee5..56ab2f4b91fe 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -505,7 +505,7 @@ config PWM_ROCKCHIP =20 config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on RZ_MTU3 || (COMPILE_TEST && RZ_MTU3) depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found in Renes= as So shall I send this fix instead. Cheers, Biju