From nobody Sun Feb 8 23:27:17 2026 Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72BAF1F754C for ; Fri, 17 Jan 2025 08:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.19.206 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737104082; cv=none; b=JV+ep3U4j8qv9V1r5eW1Q6U3eds35vZjxDt3LknKSrkDPtdjxPGP9UQxogSA3jl5iJdjvyzHvNoc4gfl0s9w3eveEadb7/FnIvGxQ2PsleKnwieGYn2sO0NmETVyX1RxCAHlVyEEfd2Q89ScIqszYcfg+8zydp2hlAlzGjHJKfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737104082; c=relaxed/simple; bh=Y9Ttyo5Nw/ZJIFs3OQ9xaB1lKaSgi2wJBZLcR6eOITc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NtUt+QgzH/KcNGI/f7hYzDiKEOxZ008K/j5DtbO9P8/D/d+Q98OyMuaM69G3mDWM3VIvs4gyi0Hb5NuQ5QX/WnVo/Kqno+r+Du9/Y2lgi/gOQu/ag+KlUB7tD/Mckkjd9KyCZTrEDsfq8eLnE/QLibZoYINE22kUmLKx24QdKvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=MA+5oKVb; arc=none smtp.client-ip=54.207.19.206 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="MA+5oKVb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1737103988; bh=oyD4OSv7s0u4v1dOVzIZ2eviXQch5B04ZycYDqMw16A=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=MA+5oKVbeDDjLdSc+i3vFZQvFf3JB4YJWTKeXANlOckM8DSq5v442U6TUTVXrsUY2 NKgaJ3NJF34olRMOql9mCc8dtUxmCbicq9T+SfuPxJFho6c6nWSoLkdmdOVcDREzRH +RZwHeAz1c0W8RnRzrm2jCseZmM1kmPeiuas29Wk= X-QQ-mid: bizesmtpsz13t1737103973t7vb19 X-QQ-Originating-IP: qKpG5HBEqo6FNixDU+IuHskNOHZjC+NebJ2qydNITTI= Received: from localhost.localdomain ( [113.57.152.160]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 17 Jan 2025 16:52:51 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 7382260033576977185 From: Chen Linxuan To: Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale Cc: Chen Linxuan , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] erofs: add error log in erofs_fc_parse_param Date: Fri, 17 Jan 2025 16:52:43 +0800 Message-ID: X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:uniontech.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-QQ-XMAILINFO: McJfg7Aee/FZWTP4/z5nHaL2F4Kv6v57wZTyuTeZMv8fI1HfQUJaRLdT gymAsWcJX4JZnKcLos/kHvSX8lsvXVZn8n8oYYlptMvCXRgTNt2obRsWCVqs4oGayviOC6d J0fMzMOlXpOklYCFsntUUjcF8+ZSaVPH+8gZz5nZnnnM07GkRgaV7T79tVCJtCivS1sneD7 15tpObkIr8zre4btS5bpFXYx3R9zlwQjPpQDAzRAYaoLa0phUo71ht5TjooU2cyiI8D7UrX yOu5eVGy1e98w3Yz1Q81R2I87bEeEwij06jwuAO0cbQ6t4e8/QC6T9HRjGYH742nU4CNS0n 9cT0SFnYObk+YTcPrvSg5+BSQBHYyh2kWgdPAMv+snb/8Q8IlF+EfUS2+LkQvD519X/WlDS c3ogozAfeUGCf41eZVZe5Lw76H9g1YFEQvnnc2Q4HPw3ItazLvlUXrAr0MyEogVQl0YMAqQ ts3OH4MANLuzkEo/ME+EkR2NKKDpE5OSt2xXpQz4OhwWZNo1XxRmkXO0/x+dORREP/wEnYW bkYD3OZOabQJYi6Ybx7nh/nchirz57rkgJ1t0vUOj6++K2U6rOL0xeaJ0bNb3c0maqAv/97 ygOzh+We+2U8rOvp+1fuea+ruAbd0kMPrh05szv0pMHl5AJAol4crWwXCX2HoOXHm3npoUp mu7v8jp5WErFAiqwx3Ih9KE4AOuOZXnHTzT7DForqwypI58ir8NhD8BtA7MVViMZNBDa01i pSEQsDa/+q19xgrfz01ddu/ZmgS5WLEo9i93TWHLjhCdhwW5ndIdaiV60REi4/L9uqjha/z dtp+0kX1OUjD/hcUcYpinL84HgXERydAe16GKlACqbcZuDOR6MOUPTw1OW10tv8wE+5VIZS m4WI2H85vH0QVLReJ1PdS6b911cYsX1EHjLCkUg7xmePn7LCbfFvepdv3foLsNZpAPu0Je1 8pelJE3DbJCLJGhfWFTHdAQrEDKVP/O2pVyTjw/ixOPk46Q== X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" While reading erofs code, I notice that `erofs_fc_parse_param` will return -ENOPARAM, which means that erofs do not support this option, without report anything when `fs_parse` return an unknown `opt`. But if an option is unknown to erofs, I mean that option not in `erofs_fs_parameters` at all, `fs_parse` will return -ENOPARAM, which means that `erofs_fs_parameters` should has returned earlier. Entering `default` means `fs_parse` return something we unexpected. I am not sure about it but I think we should return -EINVAL here, just like `xfs_fs_parse_param`. Signed-off-by: Chen Linxuan --- fs/erofs/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/erofs/super.c b/fs/erofs/super.c index 1fc5623c3a4d..67fc4c1deb98 100644 --- a/fs/erofs/super.c +++ b/fs/erofs/super.c @@ -509,7 +509,8 @@ static int erofs_fc_parse_param(struct fs_context *fc, #endif break; default: - return -ENOPARAM; + errorfc(fc, "%s option not supported", param->key); + return -EINVAL; } return 0; } --=20 2.43.0