From nobody Thu Apr 9 12:35:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2B3C4332F for ; Sun, 6 Nov 2022 01:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229511AbiKFB5D (ORCPT ); Sat, 5 Nov 2022 21:57:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiKFB5A (ORCPT ); Sat, 5 Nov 2022 21:57:00 -0400 Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7259410FEC for ; Sat, 5 Nov 2022 18:56:58 -0700 (PDT) Date: Sun, 06 Nov 2022 01:56:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acoro.eu; s=protonmail2; t=1667699815; x=1667959015; bh=mQo/LrxITE3DqpUIqglGeTMcTvldRTD81SH3Ss+5aSc=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Q90Mc13zK3an+OLi+M1g7Kn33zBw0Vbdlk/A+9nx35u0KsLpflK1TYr81OpbTkBrx nGhUErXbzsxHwOiBcrYlQqlWp6p6s0g0yTyVoWo0g+xnk11WDPATO0F4Cu8Yd9ZlWS L0OzSu+DGUMfTMgDJPpS0gZ+/CrBw4m3faiVK0V7/72vKoiL4H7fIIrImsFV95jqRc TqInnJBd1Z6cw8G9dOh2f7WYurArojs/LGOaPTZljSedd0NJdN0KUYLflnoleIU+DX enF9mkqwIOqF/3IZuQMYcLDVftrGkyg3MznQv1Rc6381deJ4xD8sDRGz1vNpnc3+zL Bp6nkgqI0X7Kw== To: "matt.ranostay@konsulko.com" , "jic23@kernel.org" , "lars@metafoo.de" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" From: =?utf-8?Q?Alejandro_Concepci=C3=B3n_Rodr=C3=ADguez?= Subject: [PATCH] iio: light: apds9960: fix wrong register for gesture gain Message-ID: Feedback-ID: 31930248:user:proton MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Gesture Gain Control is in REG_GCONF_2 (0xa3), not in REG_CONFIG_2 (0x90). Fixes: aff268cd532e ("iio: light: add APDS9960 ALS + promixity driver") Signed-off-by: Alejandro Concepcion-Rodriguez Acked-by: Matt Ranostay --- drivers/iio/light/apds9960.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c index b62c139baf41..38d4c7644bef 100644 --- a/drivers/iio/light/apds9960.c +++ b/drivers/iio/light/apds9960.c @@ -54,9 +54,6 @@ #define APDS9960_REG_CONTROL_PGAIN_MASK_SHIFT 2 =20 #define APDS9960_REG_CONFIG_2 0x90 -#define APDS9960_REG_CONFIG_2_GGAIN_MASK 0x60 -#define APDS9960_REG_CONFIG_2_GGAIN_MASK_SHIFT 5 - #define APDS9960_REG_ID 0x92 =20 #define APDS9960_REG_STATUS 0x93 @@ -77,6 +74,9 @@ #define APDS9960_REG_GCONF_1_GFIFO_THRES_MASK_SHIFT 6 =20 #define APDS9960_REG_GCONF_2 0xa3 +#define APDS9960_REG_GCONF_2_GGAIN_MASK 0x60 +#define APDS9960_REG_GCONF_2_GGAIN_MASK_SHIFT 5 + #define APDS9960_REG_GOFFSET_U 0xa4 #define APDS9960_REG_GOFFSET_D 0xa5 #define APDS9960_REG_GPULSE 0xa6 @@ -396,9 +396,9 @@ static int apds9960_set_pxs_gain(struct apds9960_data *= data, int val) } =20 ret =3D regmap_update_bits(data->regmap, - APDS9960_REG_CONFIG_2, - APDS9960_REG_CONFIG_2_GGAIN_MASK, - idx << APDS9960_REG_CONFIG_2_GGAIN_MASK_SHIFT); + APDS9960_REG_GCONF_2, + APDS9960_REG_GCONF_2_GGAIN_MASK, + idx << APDS9960_REG_GCONF_2_GGAIN_MASK_SHIFT); if (!ret) data->pxs_gain =3D idx; mutex_unlock(&data->lock); --=20 2.34.1