From nobody Mon Feb 9 09:03:36 2026 Received: from mx0a-00007101.pphosted.com (mx0a-00007101.pphosted.com [148.163.135.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5C11195F0D for ; Mon, 20 Jan 2025 23:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737415820; cv=none; b=ixcdMZkipv6tcQgII1xMuRC1lU7c/Nuj/06swzpXRlkKr1ODakphCKaYOj1Nhnro+pHpVs9rtv/n88KBWIIA7+wDtrntW84za2IX9ijA5kjK2qNX/mBVcVGl73DsNX3INi4gRcl3yIPasbOBSJsLPTFKN4eC5UW8B/q8RJufGFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737415820; c=relaxed/simple; bh=DlENozm6R6RtJjnRbloWU8UOpTAfy6uRv9nK0G8Z9QA=; h=To:Cc:Subject:Message-Id:From:Date; b=EoYdiWu6kv78D9XNMGYa1nMg37j/jmhwCM79u6MN+lMXyAaYoZO/V+pG6KvFysmdWYJ/FK4ZLoUXxP2CKJVp6g3rQhOgJSIwijoavGTi2364DSETdMtEx95tCpSCuf3Z7vFtvVgarudFu418xd8EhWJfShXkc4fLCeOU1oaii8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=coffee.vetmed.illinois.edu; spf=none smtp.mailfrom=coffee.vetmed.illinois.edu; dkim=pass (2048-bit key) header.d=illinois.edu header.i=@illinois.edu header.b=ZvmCJbBh; arc=none smtp.client-ip=148.163.135.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=coffee.vetmed.illinois.edu Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=coffee.vetmed.illinois.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=illinois.edu header.i=@illinois.edu header.b="ZvmCJbBh" Received: from pps.filterd (m0166255.ppops.net [127.0.0.1]) by mx0a-00007101.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50KNBjuN027063; Mon, 20 Jan 2025 23:30:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=illinois.edu; h= cc:date:from:message-id:reply-to:subject:to; s=campusrelays; bh= WTGbUmWRcu3c7abtCmSWvfjwM32LMSu5v5kALCi3epM=; b=ZvmCJbBh2EOqPjXD tgNGN+yfaKmfwEY1+OlVydaOVr5tW7vdV6fWO3ExFZcMiZMgFh2arUdRigJk6Xna P8mzUz8etBU5kHzGMkoq+8IqIHeLXA8iSkJgRfrI/nL0/DDlrjswJ+O8Sx8XThsC Ce28smCzQc1ntsQLYF7EF4uhddB0lcwS47pid21F34WrjDAv5U2CigmdU5fonoiC 94Dy+rdbVNnsB6BEqjQ1HbQ2ep+eXUA10v4oDJVsDHrpztl1rOe0sfVYdgFt8tZW 7LuEadgh1PsqJROo4C+LX5qsKfsxZFF+ssG6xYqnMZQzu2kAVzAhD71/YFL1jszW LpOBWg== Received: from coffee.vetmed.illinois.edu (coffee.vetmed.illinois.edu [130.126.20.28]) by mx0a-00007101.pphosted.com (PPS) with ESMTP id 449yxrr2tt-1; Mon, 20 Jan 2025 23:30:05 +0000 (GMT) Received: from lewart by coffee.vetmed.illinois.edu with local (Exim 4.96) (envelope-from ) id 1ta1DY-001QtJ-2K; Mon, 20 Jan 2025 17:30:04 -0600 To: Alexander Usyskin , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Petter Reinholdtsen Reply-To: lewart3@gmail.com Subject: mei modalias files missing device name and newline Message-Id: From: Daniel Lewart Date: Mon, 20 Jan 2025 17:30:04 -0600 X-Proofpoint-ORIG-GUID: Wn_VGuIg_d-rFfkX4V2GumRnv70d2ca- X-Proofpoint-GUID: Wn_VGuIg_d-rFfkX4V2GumRnv70d2ca- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-20_07,2025-01-20_03,2024-11-22_01 X-Spam-Details: rule=cautious_plus_nq_notspam policy=cautious_plus_nq score=0 impostorscore=0 malwarescore=0 mlxlogscore=928 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501200192 X-Spam-Score: 0 X-Spam-OrigSender: lewart@coffee.vetmed.illinois.edu X-Spam-Bar: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" mei modalias files are missing the following: * device name (cldev->name) * trailing newline Original Debian bug: #1091997 - isenkram: Documentation for locating all modalias strings is i= ncorrect https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1091997 I couldn't find any documentation that modalias files require a newline, but all non-mei files do. $ lspci -s 00:16.0 -v 00:16.0 Communication controller: Intel Corporation Alder Lake PCH HECI Con= troller (rev 01) DeviceName: Onboard - Other Subsystem: Micro-Star International Co., Ltd. [MSI] Alder Lake PCH HECI Co= ntroller Flags: bus master, fast devsel, latency 0, IRQ 138, IOMMU group 8 Memory at 6001145000 (64-bit, non-prefetchable) [size=3D4K] Capabilities: Kernel driver in use: mei_me Kernel modules: mei_me $ find /sys/devices -name modalias -print0 | xargs -0 file | \ sed -n 's/: *ASCII text, with no line terminators$//p' | \ sort | xargs head =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-082ee5a7-7c25-470a-9643-0c06f0= 466ea1/modalias <=3D=3D mei::082ee5a7-7c25-470a-9643-0c06f0466ea1:00: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-309dcde8-ccb1-4062-8f78-600115= a34327/modalias <=3D=3D mei::309dcde8-ccb1-4062-8f78-600115a34327:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-3c4852d6-d47b-4f46-b05e-b5edc1= aa440e/modalias <=3D=3D mei::3c4852d6-d47b-4f46-b05e-b5edc1aa440e:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-42b3ce2f-bd9f-485a-96ae-264062= 30b1ff/modalias <=3D=3D mei::42b3ce2f-bd9f-485a-96ae-26406230b1ff:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-55213584-9a29-4916-badf-0fb7ed= 682aeb/modalias <=3D=3D mei::55213584-9a29-4916-badf-0fb7ed682aeb:02: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-5565a099-7fe2-45c1-a22b-d7e9df= ea9a2e/modalias <=3D=3D mei::5565a099-7fe2-45c1-a22b-d7e9dfea9a2e:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-6861ec7b-d07a-4673-856c-7f22b4= d55769/modalias <=3D=3D mei::6861ec7b-d07a-4673-856c-7f22b4d55769:02: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-8c2f4425-77d6-4755-aca3-891fdb= c66a58/modalias <=3D=3D mei::8c2f4425-77d6-4755-aca3-891fdbc66a58:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-8e6a6715-9abc-4043-88ef-9e39c6= f63e0f/modalias <=3D=3D mei::8e6a6715-9abc-4043-88ef-9e39c6f63e0f:02: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b= 627f04/modalias <=3D=3D mei::b638ab7e-94e2-4ea2-a552-d1c54b627f04:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-dba4d603-d7ed-4931-8823-17ad58= 5705d5/modalias <=3D=3D mei::dba4d603-d7ed-4931-8823-17ad585705d5:01: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-dd17041c-09ea-4b17-a271-5b9898= 67ec65/modalias <=3D=3D mei::dd17041c-09ea-4b17-a271-5b989867ec65:02: =3D=3D> pci0000:00/0000:00:16.0/0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8c= be36b1/modalias <=3D=3D mei::fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1:01: Below is a patch for Linux kernel 6.13 which provides the missing newline. I don't know how to provide the missing device name. This is my first Linux kernel bug report. Please let me know what other information would be helpful. Thank you! Daniel Lewart Urbana, Illinois --- diff -ru a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c --- a/drivers/misc/mei/bus.c 2025-01-19 17:51:45.000000000 -0600 +++ b/drivers/misc/mei/bus.c 2025-01-20 00:00:00.000000000 -0600 @@ -1239,7 +1239,7 @@ const uuid_le *uuid =3D mei_me_cl_uuid(cldev->me_cl); u8 version =3D mei_me_cl_ver(cldev->me_cl); =20 - return scnprintf(buf, PAGE_SIZE, "mei:%s:%pUl:%02X:", + return scnprintf(buf, PAGE_SIZE, "mei:%s:%pUl:%02X:\n", cldev->name, uuid, version); } static DEVICE_ATTR_RO(modalias);