From nobody Mon Sep 28 04:55:37 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0D83BB674 for ; Wed, 26 Aug 2026 09:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787735565; cv=none; b=mV5SbWy+quroUtnOSUX1xW2lPGxriKwl5pccvRvqRpco82XYtzlU0RSW37marJJqKqLzTnXRlJlGYuSqNuLDUTWCsrCVXkdmqJ08Iopi2nizNBImLozInzCkTnfz+vQpOSU4TbjE+uavUeSacdswj5o0Vbv8obKIhtYx1IKm9/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787735565; c=relaxed/simple; bh=aJcop90w13DJ8VL98pNvskWWLzcXM7bekHcMKkoIZbo=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:Cc:To; b=lisVKVvNQCbsxYOFeXvk0w/I4j6/dHHWuCoYdp0D6mCVc6l2SbkJvTPOYliVCIlfxXm4u65u+B6QccKRG3Ra44FAdrr2jOjvk/ObVO53q4tsvV2EdTqOGVA4OL9RLFeWHN4UYoJdjVjbATC6F96Imd8m//gdUbChgcsE6mK2SJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=doyensec.com; spf=pass smtp.mailfrom=doyensec.com; dkim=pass (2048-bit key) header.d=doyensec.com header.i=@doyensec.com header.b=UUlvCU66; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=doyensec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=doyensec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=doyensec.com header.i=@doyensec.com header.b="UUlvCU66" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a18840e2abso1215320a12.0 for ; Wed, 26 Aug 2026 02:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=doyensec.com; s=google; t=1787735561; x=1788340361; darn=vger.kernel.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:content-type:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yzTkADWqxMGZG5YtmI2G+L98ZjXC8gtF2MPGuaf+Q6A=; b=UUlvCU66Rqi9RTpWluFM2BTykumV2iF5dD4bIzRjmAjzZ2yazIf2WaqSDZsRmGYNK0 0GG73cbppF3uJFTM4DkmTNOvGMOud6CfpYf+8w8Gnc9l6MRpAo9CqeJ07jTLMV93/lak Fqw3V/o7Z9zAOWvulMubqRtDlcrMOLNttTcQn7i2NNyP244gYhhGwvJIIzsIK/EmRjI2 Qay/wmtcZAf5b8UvPS8GNdCTTUtMl6p+3z2nXbB/m9CGbRnbkzMbpGw2q8iK4jqRnjKl 5hsFD1nrvksrgqiIT6mEKFeCXtY8geEiQ8GRmOEamRvTmEvlOo8Wbcvs5cp/u6Cv1ij5 cN1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787735561; x=1788340361; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:content-type:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yzTkADWqxMGZG5YtmI2G+L98ZjXC8gtF2MPGuaf+Q6A=; b=S+YIgz6nlE8+DoIn7ovZUa8dwJfE1/2uEdhF75+yyrlhqlyiurYRA6X6EtpGL7J+l8 oIybPWnlB6HncL88B6WFyg3KT4E0HlTpsYwvYlPS68F8y88RwbplUXBi+i72bxxXWndN 8V2DH0lMaVDych/bsd1qYbT21MsyHMP/w5ZPo2IJbzcqpZPV/ufb47l43jeC5JPSn1F+ Zy9NmsDskv5YzOpkafjfNuuvWn62NVBLPp6toD3XB26Eil4+J+xFkj3nuUB4GhGa2hUC ZzpG7NNo7zIzgQJX97dPfO6H1amSklvlWSZp8u2kMVdpeWnOJon9UW6V2Kmpo5aDLJbO 5OmQ== X-Forwarded-Encrypted: i=1; AHgh+RoNnZpJBI97Nx1k+cVYwsKIg101ggl2rmw9n09KQahwd7yZfonaZnZeDMc7I3tcdtTkRBqozmSfqM7mO4M=@vger.kernel.org X-Gm-Message-State: AFuF++nRFh/CmCE4cKlvLfFrt2+gf96rpOBjVCXDM+U83y/Nk6qNQ2Eb 4/f7e2M7IaKsQ/544+XZIU/UAUtbLe7IKapjzM2Z3+lnauUzVfTaS1+l3/rlf1LuZ/g= X-Gm-Gg: AR+sD12y0VNIVM2in7d3qR53mNb5fI7M8ejEN6yNfK7faI7DmXiqfvHiLNf9dpfbOn/ nnC4BBgyeBZfEY4hRvymukzySCQgdeh6QK9ynb0A8Szrj04siG6OBEK4//2Jpf29StpLnc+ysIb t10cP4I7Zw9KDRJ4thyg5BSVh2a0aGJ//SW7KuFHMQch91lb7/1jIAPciR0A+wHVC4v3u8Y2T9z o86WrTHNOglk08U5VvuC5LPJTIcv/wACj3R+I1lwv26YGRe33wIl1racO8uk0ES4IDLrL5qklC3 1gSyYJAmDiSR1NMECPjtaiJmeHrffeGIQgzIyYw+3iI4thDjCAu2lTs23V8bDsEATUZ74kZibOt ZNGpOc7xRNoEfo3yxH0ts1aEbGu4DDd3gmH36norVGno1mg2fJL5FMB4ZmvtNO1BZgFncYlyw6k uKaZdmuC5rCR3H+76cKIruBuAnMUpCwq2Or7aymVioJN1IntPrkm+14ryjbBblqG1TPV6mZVlyE AeRmjmTmu8TxbjZrF43pXU4csdS7CumbNk0cT4sdmy+u+LWnXRSo5VcyZDLs7BP4BuyBOJUvmLi 2BrOuXx1Gwka0RgznKdRGvyhB3OP9/J9aHdEBRjqpCCyygPA X-Received: by 2002:a05:6402:5d0:b0:6a3:87b7:b516 with SMTP id 4fb4d7f45d1cf-6a5df6292e0mr7506777a12.6.1787735560457; Wed, 26 Aug 2026 02:12:40 -0700 (PDT) Received: from smtpclient.apple (host-79-57-139-67.business.telecomitalia.it. [79.57.139.67]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a5dea8388fsm3466565a12.19.2026.08.26.02.12.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Aug 2026 02:12:39 -0700 (PDT) From: Norbert Szetei Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: [PATCH net v2] net: bridge: mcast: fix use-after-free of a master VLAN's multicast context Message-Id: Date: Wed, 26 Aug 2026 11:12:27 +0200 Cc: Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , bridge@lists.linux.dev, linux-kernel@vger.kernel.org To: netdev@vger.kernel.org X-Mailer: Apple Mail (2.3826.700.81.1.4) Content-Type: text/plain; charset="utf-8" br_multicast_toggle_one_vlan() clears BR_VLFLAG_MCAST_ENABLED under br->multicast_lock before stopping a VLAN's multicast context. That is the teardown handshake: lockless readers gate on the flag through br_multicast_ctx_should_use() -> br_multicast_ctx_vlan_disabled(), so once it is cleared under the lock no reader can arm the context again. For a master VLAN the handshake never runs. __vlan_del() clears BRIDGE_VLAN_INFO_BRENTRY before calling br_vlan_put_master(), so br_multicast_toggle_one_vlan(masterv, false) returns early on !br_vlan_is_brentry(vlan): the flag stays set and br->multicast_lock is never taken. br_vlan_put_master() then drains the context in br_multicast_ctx_deinit() and frees the VLAN through call_rcu(), while a reader still inside rcu_read_lock() sees the context as enabled and re-arms it. The port and port-VLAN branch of the function has no br_vlan_is_brentry() test and flips the flag under br->multicast_lock, so it is not affected. The reader is the bridge transmit path. For a master VLAN br_multicast_rcv() selects brmctx =3D &vlan->br_mcast_ctx with pmctx =3D NULL, so IGMP sent to the bridge device re-arms the context's timers after br_multicast_ctx_deinit() has already stopped them. BUG: KASAN: slab-use-after-free in detach_if_pending+0x412/0x4a0 Write of size 8 at addr ffff88810ac39918 by task brmc/601 __mod_timer+0x51a/0xc50 br_multicast_host_join+0x25b/0x390 __br_multicast_add_group+0x468/0x530 br_ip4_multicast_add_group+0x1a0/0x260 br_multicast_rcv+0x2cda/0x61e0 br_dev_xmit+0x6c4/0x1540 Allocated by task 610: br_vlan_add+0x111/0xb40 br_vlan_info+0x370/0x3e0 Freed by task 0: kfree+0x1a7/0x4f0 rcu_core+0x7dc/0x10a0 Only test br_vlan_is_brentry() when enabling, like the br_multicast_ctx_vlan_global_disabled() test next to it. Disabling then always clears BR_VLFLAG_MCAST_ENABLED under br->multicast_lock before br_multicast_ctx_deinit() drains the context. Fixes: 7b54aaaf53cb ("net: bridge: multicast: add vlan state initialization= and control") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-5 Signed-off-by: Norbert Szetei Acked-by: Nikolay Aleksandrov --- Changes in v2: - drop the paragraph above the splat, per review - no functional change Reproducer available on request. v1: https://lore.kernel.org/netdev/B41EB55B-E5FC-431D-956C-503CA7B95C30@doy= ensec.com/ net/bridge/br_multicast.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 75e1e2a8fc83..3ef5d8bbf552 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -4377,8 +4377,8 @@ void br_multicast_toggle_one_vlan(struct net_bridge_v= lan *vlan, bool on) if (br_vlan_is_master(vlan)) { br =3D vlan->br; =20 - if (!br_vlan_is_brentry(vlan) || - (on && + if (on && + (!br_vlan_is_brentry(vlan) || br_multicast_ctx_vlan_global_disabled(&vlan->br_mcast_ctx))) return; =20 --=20 2.55.0