From nobody Wed Apr 1 11:19:16 2026 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F16733D4E9 for ; Mon, 30 Mar 2026 20:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.170 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774902964; cv=pass; b=tJE3S0EFx4+jUo/Z7IQ4bLXywVKe6XDPRtzYtDk4X9+s6xiBDkSQYllO8ipeVl24f8Nd84Ga0Jub8FmjELxV4ypCSEUf6989TrpmSSx9XmEstQ65zrTusAM6kqmbddzyAtpHA4/WXXfU4RyclwlF2ohHiXwSgHjtc5O22UPvnkg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774902964; c=relaxed/simple; bh=i1ISeGcYSeJGsQxlq3CPLfSm6r/A8sqaabjLuKhnPIU=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=lq1pFMzC7t+Ig28hipMTaix4HM+DCBAOQt0VnoCR5narYXLFA1SUQnsAnUwjhXAln12VC1JM/6R6fD+FKGJwbTgwgKYJz+yTcLyQ/JECG2i57oS5dUmzQcv46pNYV+TniDIGeRQSTcnFTHHlvEsr7MYnOabjOrjI1ouCb8Yv0CA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sgF4XH31; arc=pass smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgF4XH31" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-56ce5c899fcso1473226e0c.3 for ; Mon, 30 Mar 2026 13:36:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774902962; cv=none; d=google.com; s=arc-20240605; b=VE5hy+RumSWz83LVuHt+8y/HBSPZlmolHD9Opz3q97Uqb5eWWujFYQ1O5hDfvl2Dpk rsoUaIvrD+QDohEG4fXcqHRl1S2QWyz6eqiPO/1QHj/pydX4E+VI73muwNfEdu5TpwW/ MkEEA+1OlPcZRwC2VzYPHTLxFrxF6be658VU0bO485SadN+85PvyvYQHZUiM1UlbxvAy W1leUuNdd1/46UfY+8vvPFArUEWQXus5RJipZz1yInm6QDbKPkYVAsgflhGRgT6PqUME sX2qJCRGChde1mapIS2YCWPM6MRW2usASQuINvINK3hoe94tSjHpfDbjXaUsYAurSo7a aNCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=rDToa3OIBIO8goM+2fWqgtZfJ2cOD2nziJXxCF3UAbY=; fh=sB76mfqmZBBdHCTcddLH7AFoMrv8AFw+CSPdhreuHys=; b=NYOj//FUKsAsIwOfliVBCyZ4gWQoMPgcAPv1OLApgOYCZ6zKeQMp8VIwTX79wbo0fa 8mwDoJ60NV8TsW/So/J92pwQbN9yGbyec6LvKiQ5xnjO/qPqsGmG9VqYRFLtI5/e8w7H QjPHGE8jFdnpRf3pbLgO4notLJ6Yt+kchNs3lDHLTg5EAIzw41OjcgjEDyvoRjEd0xAl smWqytIeEZMlgcQFaXq3+iFI70rGbRBiteuAr66Lr9C9o5derO7Ev8TRzD1jrhdhYhsK 83WXflKnx4DdZcr/eyTAHXcezy7YLF5lnN3jJxuL5UCTjrN47QeiFsM1PRuxtUNAuGD5 en+Q==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774902962; x=1775507762; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=rDToa3OIBIO8goM+2fWqgtZfJ2cOD2nziJXxCF3UAbY=; b=sgF4XH315wS2eYyZo53HxMM3b99BxRKolYcdgi/Bb1/R6yn63DRZ6mRUcsegMXQUrB TRs+k2C/MmB/PrMe2Kxo1uBCfXTduyL/YKyj3rm2j//OpizsmIZRmQvH2EUP6T4pjsbN BXYuQWu+H/MvTmblozzJXnFGBwZIzYdhaFyfMfOOYyHDAceX3T+QPXDO7Wio3DKVEXbS U/lwtZ1oawH6m4tEoNswm4KxcQ248NVTj92GW+f7DihVmYAtQnjsl3hTS9AE1tffUf/v 5SiIWPbOBhUN9q/QPSYSFgIeSXL9xFFAXidV8XHawp5w5W8f1hZWfhrY4AL7hUAEcvaM ZBuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774902962; x=1775507762; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rDToa3OIBIO8goM+2fWqgtZfJ2cOD2nziJXxCF3UAbY=; b=Y1ExH3FSG64S30wLlVg8WEYM8EbVo6w7b578ZWd5K9XAF5vO7okAMZBOt+Q75OG9AS bwMXi6TrUo+iLX4QYJlvdkF8tpXSPBRMQWlhrYjtOoCY1Ty3y2Nal0mtJJ6uuKQLF4wn 1dPLyUb9wVxUgwtE71cO3QrzxGMBhxD/BsNxCyQ2XMoaKk/+4b2Eb3LJTZhnJ0kFbA8U ZxlIKiY7ht5zJaQoibrwlxMyUhDZD4Fy5Ske+pDgPtHxyPJuYMYSnRIsYR3KCRn1DBcU WuaNqi4TTq8IRN8BnJ3YqCVIu+tOBVz/0JzMAXPm7PN2mn9ey4wJGu4DLWulPaHEiVWn 5qWA== X-Forwarded-Encrypted: i=1; AJvYcCWd3Ldtj5/ABa+NCscoG0hypXkKJWWcTR16G4yL3uWq1bA4NyeiCOotsiURWTqUQWfUBsApvP+MdjSqZog=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4FI1qmVi4bFellL9RmTaaxxvY54RkAQGobz8S7d7IM1D/Azwv 9MzzNiByJbFSR6L5qNPZ3mYwzA27up3785PWZP4Y2VarEoVFj42Pv4qI/17chv06BM57FPLpzDL 8bKiLz9Op5zr6lBMH6ICM/Y8PcZINa4s= X-Gm-Gg: ATEYQzxViW2oSWpV+czp9mqVE9ptF75uKlMhDgfZozAtViOIyVeXmcJc9RsB67edwaE 0v5bWimGwHHdE8iTiW4Y3ibiKoumJXDC6N923VPZMisqXosNuX0vlz4uyy09CwFOVhs8u8+ZnVB aW86Zz2YNs3IBitoMIaTzbjxCJsrgfZb0LWhwV8kvPc0vdY57ltnBa5OUPmWIYsc2j9QF1vvebU nsonaYMuSC7fmSka+Q0tBxTOW32gOeczxHHkN32pi1iABzXDWzNxw1lBMga/1uqV1E5g9fGGJDC 4/za9l4= X-Received: by 2002:a05:6102:4b89:b0:602:8ad9:1f6f with SMTP id ada2fe7eead31-604f904cc47mr4758708137.5.1774902961997; Mon, 30 Mar 2026 13:36:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: =?UTF-8?B?0JTQsNC90LjQuNC7INCR0YPQu9Cz0LDRgNGM?= Date: Mon, 30 Mar 2026 22:35:50 +0200 X-Gm-Features: AQROBzCzDvSQp2IiGmthrT5mtRJoU9aa_9VX8kQN4bDyCzLZ2kyC_pMmdLR9Ab8 Message-ID: Subject: [PATCH] platform/x86/lenovo: thinkpad_acpi: add named speed presets to fan_write_cmd_speed To: hmh@hmh.eng.br, mpearson-lenovo@squebb.ca, Derek John Clark Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" platform/x86/lenovo: thinkpad_acpi: add named speed presets to fan_write_cmd_speed The fan_write_cmd_speed() function had a TODO comment suggesting support for named speed presets (low, medium, high). Implement this by mapping the preset names to the existing fan_speed_presets enum values, following the same strstarts() pattern used in fan_write_cmd_level(). Signed-off-by: Daniil Bulgar --- drivers/platform/x86/lenovo/thinkpad_acpi.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c index 8982d92df..f10cebe11 100644 --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c @@ -7957,6 +7957,12 @@ enum fan_control_commands { * and also watchdog cmd */ }; +enum fan_speed_preset { + TPACPI_FAN_SPEED_LOW =3D 65535 / 4, /* 25% speed */ + TPACPI_FAN_SPEED_MEDIUM =3D 65535 / 2, /* 50% speed */ + TPACPI_FAN_SPEED_HIGH =3D 65535, /* 100% speed */ +}; + static bool fan_control_allowed; static enum fan_status_access_mode fan_status_access_mode; @@ -9249,10 +9255,13 @@ static int fan_write_cmd_speed(const char *cmd, int= *rc) { int speed; - /* TODO: - * Support speed ? */ - - if (sscanf(cmd, "speed %d", &speed) !=3D 1) + if (strstarts(cmd, "speed low")) + speed =3D TPACPI_FAN_SPEED_LOW; + else if (strstarts(cmd, "speed medium")) + speed =3D TPACPI_FAN_SPEED_MEDIUM; + else if (strstarts(cmd, "speed high")) + speed =3D TPACPI_FAN_SPEED_HIGH; + else if (sscanf(cmd, "speed %d", &speed) !=3D 1) return 0; *rc =3D fan_set_speed(speed); --=20 2.53.0