From nobody Mon Feb 9 06:49:25 2026 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C99027472 for ; Tue, 23 Dec 2025 15:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766504728; cv=none; b=OUXMhcKXKs4u/yqxMtetSgN7XrAfnEIHZPlRbFyK0dIwsk25qvMGjAoCYe+fgg1qqwS2IZKZHYeBTXflgxYjJWZRl2E2a4IWaP55r/vN0zDAs/vzeQcGmT7WRfC+JuiL+LyzcFwrFhZqhb/Qx9q/Pix8mXpW8yGddRt9/zkXkiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766504728; c=relaxed/simple; bh=Nbr+595wzIlfQktoqESVqjE0AhgwC1Glx9IxPG70c/8=; h=From:MIME-Version:Date:Message-ID:Subject:To:Cc:Content-Type; b=eWBO1BwzjPIIrIb81tWs5+Hl2UrbOCB7VE5tUFmteTCH3t9fYDEbneb4/UnfvNNW5s6sgHPPD2E47oqlXR4xx3ANTEmUhgXSturDiIrzaguVASYaXYAOsI1J+o4Xt70GmM85h7n+BnpWf6lhl8rcwkKZTemMSXtnhJRnDGtGQ+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N5PlvaWx; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N5PlvaWx" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-595819064cdso8258278e87.0 for ; Tue, 23 Dec 2025 07:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766504725; x=1767109525; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=ALf8MaedbdPI72V8d/dNEG4Su8CUjZKSY9JmPqjIM9g=; b=N5PlvaWxexhQKWjuIcz1Fsh70m0oV0rTMagMwKEvrUyzLJvtf6ltGGslzC57bGVPeE coApMp5LGryTXz41lEAEQ1RlpUdyr3T/rt+5yRQyNF3annGqSGgTAu45OK6N5A+BkzM7 GdeUp3Zd6oCeT5E+bciKX1y6QHmSsFZFx3CJLAZGs7fhwZWH4qUNjG0BkGlIH2SgbO8c E53XwKA0UTw1gogepgPS1iffFAPNbxjVn6+/lhvTeYoD5+nXZMc+bDX1iZBbBtf5lFoE YttMd4x0GAEKeT/S3zl5tnD4ftihmJKyQWihlxfLXdtIB1x5XP44BzGeTcqaFwjcJKla HQMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766504725; x=1767109525; h=cc:to:subject:message-id:date:mime-version:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALf8MaedbdPI72V8d/dNEG4Su8CUjZKSY9JmPqjIM9g=; b=aRGY/fQGFoCR6r5wmx0RMxJmPGzTr4f69emh3EdMQIOzpphF6kk88MyLXeC2G1zsTN SNY8TmK2LcnxfqxsfGwEYMRGCdL+ilrbAyLrzxgqgJCRut85Q1V3gXg+FzG20ihHQHQ8 NFTLfk1FVsfv3V1P6drmdIsk4atZU0rw8rYBhSPm6GJEJ/QzrHZhszqAqv5ZOSGGJX70 a7p6JAcPkZYkdA5Qz5wIAb7+/28znMCOoPsxfoqDU9f8D28gJfP508nuuyefHuFY/w8c NApRqaYa6uYpGuuI2MYZTEgrK0xjUH3/0b9IKdoD1h4+F1O/XAyDugvS0e2wToWkH1PZ uXig== X-Forwarded-Encrypted: i=1; AJvYcCURn8XPlEPNLGA2hpnxOVCMFgsJUBo7TbmTkAplUjI/hrXnLNbwC+r1wQd3AzVamGFXtXhfXJeCqbPbqdY=@vger.kernel.org X-Gm-Message-State: AOJu0YylA4JCcnL2t7X/u69vo1UxKndp0Vl6noglAA3mFfGCXqEq9oxM 3HQ11TF14zaon3C23NoY5F3p9G621MyG+MYTY453uJB7j2WHaE7Is/IvVdB5wVOmmOXshDg+q2W WWe8nBvGd/QOeF0Mjpm3jTtI1XBECLdg= X-Gm-Gg: AY/fxX52ynuFiiJfb7qnUuK/TnniOf+gkIUCLjKkezTZYXjFVLJ+yKoS4rx+/eyUjT7 5nVPCklxZv8tOW9V+j8/sNI3oxCYZy1RBCjdliDwbjvNQLtCqDOqw4XFjmB7TuOH8On5kNLgw8f OmqL1pahdKeTqkKIXBBGX38GgBLvvyNo6+OOg7KtFyLa3kKFnnignzM53h0nAVoPZYUBUfe7b1I MRdSgqhXaayJqrH0K/t8PybhRZxifoEzk+Mv5qh69noXGKNXU29oN6B/oB4XlszW4jU3b0= X-Google-Smtp-Source: AGHT+IGKXn8CvNdJZ3wBpTQc5VgFKkoN0BfrlPmpP4+ias/h/3PcHyJSI5zoTkdLVWNDMK3cd94Oe4qQzmYXiz3CTLg= X-Received: by 2002:a05:6512:3d24:b0:598:f400:6683 with SMTP id 2adb3069b0e04-59a126e9aacmr7076683e87.17.1766504724327; Tue, 23 Dec 2025 07:45:24 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 15:45:23 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 15:45:23 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 15:45:23 +0000 X-Gm-Features: AQt7F2qqrQGoOfIH8cMa_Qcy5Fnwkay18o2ty9H2kPG4UbQchzAq3X8Jipduz3Q Message-ID: Subject: [PATCH] platform/x86: yogabook: Clean up code style To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Benjamin Philip , Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit cleans up the following checks flagged by checkpatch in yogabook.c: - CHECK: Prefer kernel type 'u8' over 'uint8_t' - CHECK: Unnecessary parentheses around '...' - CHECK: Comparison to NULL could be written "!data" - CHECK: line length of ... exceeds 100 columns Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/yogabook.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/lenovo/yogabook.c b/drivers/platform/x86/lenovo/yogabook.c index 31b298dc5046..ee6c625076df 100644 --- a/drivers/platform/x86/lenovo/yogabook.c +++ b/drivers/platform/x86/lenovo/yogabook.c @@ -57,7 +57,7 @@ struct yogabook_data { struct work_struct work; struct led_classdev kbd_bl_led; unsigned long flags; - uint8_t brightness; + u8 brightness; }; static void yogabook_work(struct work_struct *work) @@ -160,7 +160,7 @@ static int kbd_brightness_set(struct led_classdev *cdev, { struct yogabook_data *data =3D kbd_led_to_yogabook(cdev); - if ((value < 0) || (value > YB_KBD_BL_MAX)) + if (value < 0 || value > YB_KBD_BL_MAX) return -EINVAL; data->brightness =3D value; @@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device *wdev, const void *context) int r; data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); - if (data =3D=3D NULL) + if (!data) return -ENOMEM; data->kbd_adev =3D acpi_dev_get_first_match_dev("GDIX1001", NULL, -1); if (!data->kbd_adev) - return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device in ACPI tables\n"); + return dev_err_probe(dev, -ENODEV, + "Cannot find the touchpad device in ACPI tables\n"); data->dig_adev =3D acpi_dev_get_first_match_dev("WCOM0019", NULL, -1); if (!data->dig_adev) { - r =3D dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in ACPI tables\n"); + r =3D dev_err_probe(dev, -ENODEV, + "Cannot find the digitizer device in ACPI tables\n"); goto error_put_devs; } @@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *= pdev) int r; data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); - if (data =3D=3D NULL) + if (!data) return -ENOMEM; data->kbd_dev =3D bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodi= x_ts"); --=20 2.52.0