From nobody Tue Feb 10 10:19:38 2026 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F033081CA for ; Tue, 23 Dec 2025 19:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517869; cv=none; b=bU6IhK02Ai2/s3rEUvxuWfBru23u8iXhDUdfEIFm6prZ3kZMdAm/otf8YOPdGxvIE9CetBCNS/VcKKiQjF+RNiLpDkL1MPRaz+2NppdzG/QqcqjaBtQOB5DeWZLiNXX/ZW5fvulC+tG5Irh7LFQ601nUtcrbQOvjv/Jz8fJIqk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517869; c=relaxed/simple; bh=rjyEWf85YzHLrtYPAFhy72tVlNMvhiXFu+YvwjxGXbw=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=VwbNstgAVmvgQpBVwa46o5B5XBKiah3XrPJ+NFcnIxKJcKr4kmoJ2TSqVCGUreENc0xXcDXXKkSbJsGMcMoRKIIV4pLwD4Mg+RNqRw4TfRPyYpAPcnoV+hULMg4GozUGokLt+wD69rkmeKy7bQ6wJDNKQUO2IGl64DVEgfV+xo4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VaS70/OO; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VaS70/OO" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-38105ad3720so44510731fa.0 for ; Tue, 23 Dec 2025 11:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517865; x=1767122665; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=l56PyPTvBksExPgkW9juhbN4bXzt4MS2OYE//VwO+OY=; b=VaS70/OOmzstc+PDnSHheuAUhCGZKq4gtrk7mdvh/dUCQBU4MNXqhJ+YQ401vArjw9 3B/DN0ZoVYHkb7n0vFEdJ4Njr73pr1XoI4jrILt4GeYZaUTwJedbK/laf5WbpXQDFlY7 ji7HRPr/wuZCy9OcfMgnbONrBBNbXzBTP13GWNGR+6nkFp6roaT5nNkA3EZu7XVR1OGY jSsoMfpD1zCDuQ0AtGV809AopnB5e767xEZs/8Vs3i8dcPPn/rnPOOKBUAujuQVtkV8I rmkocWnJ0pIC4dFytx5ZL050YrmSYwkhJdQpYHYQuKRvgXrDviqP1hFJQIE4E27N7uGh FYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517865; x=1767122665; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l56PyPTvBksExPgkW9juhbN4bXzt4MS2OYE//VwO+OY=; b=XIU5ywaQfbTz7GBFzg49tyMg9W9299v6a3bhUbIASw4N8wGAiDy7mM2C5Ld1pM6tjB 8YR79pU2QED+AJn03N9lBckm4lOikV0frAa3zprMto3yg4fulnmwqidXpGDz/AZYbQpX oGMWklT6bIhNo2wpueTUhjzqg5GIH2zIsCllXUptyarPhC8dZkmZG6hSEXTbkmbaWjrz ArkZMC+Rdmx3UvSOJ/ou5+bRQ+IfYxjtKYI7/eACQ7Lg/c0zzoMP3MU9WTXKukPWb05h +oBDLebdG8i4nJsUw7qlGjiaNGw3SoH/6UUVZcQohZv/jA2NNapaMPlgrgwnzISyw0eU 2XHQ== X-Forwarded-Encrypted: i=1; AJvYcCUGpd5DuzXHlBvsEJBaoEJfjLEoQ9jh8rWzMx9LctA/jrLm+lUqQYRC0HhOE2+wtOp4Ow9ujUYWnd5GFeM=@vger.kernel.org X-Gm-Message-State: AOJu0YwYYXbEpvBLHh9QDoK2DjpGP3ogMiMW6puU0lJTzDcup3tq3u3I 99QfmOtnCpLbJAdHd86i4GpAMaJtxgc7AVaMBhyQNAtKaMVw78vD2ZQiqKk0uy0h9ChX8QqU0A5 ifPDnwQF+UlgnFo+KUGtAhVOuXs55EYLLqeIX X-Gm-Gg: AY/fxX70dJxLtQ0olq7gsA0/5pET5yS7O4jnYgb4P9mqzz5ghLUSCttbm7ooh5rp8JJ 6Q3Isr3o/tpi3GJwywmkQmp7UEx8J+bsrNYI9SuIa7qOwMSCvmCrglOuZ0HEAsf7SQ8juSof1Sw 2CHgiPRpw7gfVzDr+MEbeLO54ixetKhiBJlBe4kTTiYwSZ+RvH9cY3zigfdHoGgv8KVGy1avXft 9PlRgNBVcesyAR3xRqOdwws2eHWKxVaZotJseIHPog+UkXukX8LUQYnusjJ4eHy+Uhc9QA= X-Google-Smtp-Source: AGHT+IH/6vwWnlwA+2ntbE4BBo5XBjXA037mg+f20SX6cMQDjTN3ZXQ4fmykN3IACIIMo1og8rJowUn2qiDqMDD0GQo= X-Received: by 2002:a05:651c:507:b0:37f:d484:59b8 with SMTP id 38308e7fff4ca-3812156a27dmr56195091fa.7.1766517864402; Tue, 23 Dec 2025 11:24:24 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:24:21 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:24:21 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: <20251223191932.946794-1-benjamin.philip495@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 19:24:21 +0000 X-Gm-Features: AQt7F2pon76cn3q1cVXsWOfbABA0VzmPkHryHoTqQJO424NmQQfz6rtksbdtGpM Message-ID: Subject: [PATCH 5/5] platform/x86: think-lmi: Clean up alignment To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit fixes multiple instances of the following checkpatch check: CHECK: Alignment should match open parenthesis Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.c | 75 +++++++++++++------------ 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index 07ba0d84720a..ccb767c3972e 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -424,7 +424,7 @@ static int tlmi_get_bios_selections(const char *item, char **value) /* ---- Authentication sysfs --------------------------------------------------------- */ static ssize_t is_enabled_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); @@ -513,7 +513,7 @@ static ssize_t new_password_store(struct kobject *kobj, */ if (tlmi_priv.pwd_admin->pwd_enabled && strlen(tlmi_priv.pwd_admin->password)) { ret =3D tlmi_opcode_setting("WmiOpcodePasswordAdmin", - tlmi_priv.pwd_admin->password); + tlmi_priv.pwd_admin->password); if (ret) goto out; } @@ -527,8 +527,8 @@ static ssize_t new_password_store(struct kobject *kobj, } else { /* Format: 'PasswordType,CurrentPw,NewPw,Encoding,KbdLang;' */ auth_str =3D kasprintf(GFP_KERNEL, "%s,%s,%s,%s,%s;", - setting->pwd_type, setting->password, new_pwd, - encoding_options[setting->encoding], setting->kbdlang); + setting->pwd_type, setting->password, new_pwd, + encoding_options[setting->encoding], setting->kbdlang); if (!auth_str) { ret =3D -ENOMEM; goto out; @@ -545,7 +545,7 @@ static ssize_t new_password_store(struct kobject *kobj, static struct kobj_attribute auth_new_password =3D __ATTR_WO(new_password); static ssize_t min_password_length_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); @@ -555,16 +555,17 @@ static ssize_t min_password_length_show(struct kobject *kobj, struct kobj_attrib static struct kobj_attribute auth_min_pass_length =3D __ATTR_RO(min_password_length); static ssize_t max_password_length_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%d\n", setting->maxlen); } + static struct kobj_attribute auth_max_pass_length =3D __ATTR_RO(max_password_length); static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); @@ -601,16 +602,15 @@ static ssize_t encoding_store(struct kobject *kobj, struct kobj_attribute *attr, static struct kobj_attribute auth_encoding =3D __ATTR_RW(encoding); static ssize_t kbdlang_show(struct kobject *kobj, struct kobj_attribute *a= ttr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%s\n", setting->kbdlang); } -static ssize_t kbdlang_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t kbdlang_store(struct kobject *kobj, struct kobj_attribute *= attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); int length; @@ -665,16 +665,15 @@ static ssize_t index_store(struct kobject *kobj, struct kobj_attribute *attr, static struct kobj_attribute auth_index =3D __ATTR_RW(index); static ssize_t level_show(struct kobject *kobj, struct kobj_attribute *att= r, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%s\n", level_options[setting->level]); } -static ssize_t level_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t level_store(struct kobject *kobj, struct kobj_attribute *at= tr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); int i; @@ -731,8 +730,9 @@ static ssize_t cert_thumbprint(char *buf, const char *arg, int count) static char *thumbtypes[] =3D {"Md5", "Sha1", "Sha256"}; -static ssize_t certificate_thumbprint_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) +static ssize_t certificate_thumbprint_show(struct kobject *kobj, + struct kobj_attribute *attr, + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); unsigned int i; @@ -764,8 +764,8 @@ static ssize_t certificate_thumbprint_show(struct kobject *kobj, struct kobj_att static struct kobj_attribute auth_cert_thumb =3D __ATTR_RO(certificate_thumbprint); static ssize_t cert_to_password_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); char *auth_str, *passwd; @@ -809,8 +809,8 @@ enum cert_install_mode { }; static ssize_t certificate_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, const char *buf, + size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); enum cert_install_mode install_mode =3D TLMI_CERT_INSTALL; @@ -913,8 +913,8 @@ static ssize_t certificate_store(struct kobject *kobj, static struct kobj_attribute auth_certificate =3D __ATTR_WO(certificate); static ssize_t signature_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, const char *buf, + size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); char *new_signature; @@ -940,8 +940,8 @@ static ssize_t signature_store(struct kobject *kobj, static struct kobj_attribute auth_signature =3D __ATTR_WO(signature); static ssize_t save_signature_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); char *new_signature; @@ -1029,8 +1029,8 @@ static const struct attribute_group auth_attr_group = =3D { __ATTRIBUTE_GROUPS(auth_attr); /* ---- Attributes sysfs --------------------------------------------------------- */ -static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) +static ssize_t display_name_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); @@ -1069,7 +1069,7 @@ static ssize_t possible_values_show(struct kobject *kobj, struct kobj_attribute } static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); @@ -1491,15 +1491,15 @@ static int tlmi_sysfs_init(void) { int i, ret; - tlmi_priv.class_dev =3D device_create(&firmware_attributes_class, NULL, MKDEV(0, 0), - NULL, "%s", "thinklmi"); + tlmi_priv.class_dev =3D device_create(&firmware_attributes_class, NULL, + MKDEV(0, 0), NULL, "%s", "thinklmi"); if (IS_ERR(tlmi_priv.class_dev)) { ret =3D PTR_ERR(tlmi_priv.class_dev); goto fail_class_created; } tlmi_priv.attribute_kset =3D kset_create_and_add("attributes", NULL, - &tlmi_priv.class_dev->kobj); + &tlmi_priv.class_dev->kobj); if (!tlmi_priv.attribute_kset) { ret =3D -ENOMEM; goto fail_device_created; @@ -1637,8 +1637,8 @@ static int tlmi_analyze(struct wmi_device *wdev) tlmi_priv.opcode_support =3D true; if (wmi_has_guid(LENOVO_SET_BIOS_CERT_GUID) && - wmi_has_guid(LENOVO_SET_BIOS_SETTING_CERT_GUID) && - wmi_has_guid(LENOVO_SAVE_BIOS_SETTING_CERT_GUID)) + wmi_has_guid(LENOVO_SET_BIOS_SETTING_CERT_GUID) && + wmi_has_guid(LENOVO_SAVE_BIOS_SETTING_CERT_GUID)) tlmi_priv.certificate_support =3D true; /* ThinkCenter uses different GUIDs for certificate support */ @@ -1693,7 +1693,7 @@ static int tlmi_analyze(struct wmi_device *wdev) &setting->possible_values); if (ret || !setting->possible_values) pr_info("Error retrieving possible values for %d : %s\n", - i, setting->display_name); + i, setting->display_name); } else { /* * Older Thinkstations don't support the bios_selections API. @@ -1710,8 +1710,9 @@ static int tlmi_analyze(struct wmi_device *wdev) optend =3D strstr(optstart, "]"); if (optend) setting->possible_values =3D - kstrndup(optstart, optend - optstart, - GFP_KERNEL); + kstrndup(optstart, + optend - optstart, + GFP_KERNEL); } kfree(optitem); } @@ -1772,7 +1773,7 @@ static int tlmi_analyze(struct wmi_device *wdev) if (tlmi_priv.pwdcfg.core.password_state & TLMI_HDD_PWD) { /* Check if PWD is configured and set index to first drive found */ if (tlmi_priv.pwdcfg.ext.hdd_user_password || - tlmi_priv.pwdcfg.ext.hdd_master_password) { + tlmi_priv.pwdcfg.ext.hdd_master_password) { tlmi_priv.pwd_hdd->pwd_enabled =3D true; if (tlmi_priv.pwdcfg.ext.hdd_master_password) tlmi_priv.pwd_hdd->index =3D --=20 2.52.0