From nobody Tue Feb 10 12:13:20 2026 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4E434AAE4 for ; Tue, 23 Dec 2025 19:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517840; cv=none; b=lC+bmdm95pVF0As2jfbgpuSugmGPP2jwecarhXF9N2CtQyUFIkPQAGS6slPhjULpP7fS4OPCwpoN1/T30W5WNIzbzWtCL4f16m2htPwPxmmuQdTLf22NDs/Qtlvlt9yXLKUvUX8PGlekaWRIDvmujusdbBERMEfgWHQZ0wcUzHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517840; c=relaxed/simple; bh=PDjLoWb+Goab0JJY1HXslrPwRQiSHQMlYcfPKsVPVpI=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=BKRkV6CsyTgWBJja0vDE+jKJ+vPwAOFOKSxzDjPqowPZyWLuG+UWgVuZVx2D/ntCU2vtYxv8faMMCSPR+T/9RqBpwc6srjG6CzmOMZgqDCKF9/STQoKs5xM5xLEd5nayFqLPTT0Pb9wTTN5WPS4gfbAB3YH38nSuQ1dbqPFmHGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F6GhPQ0b; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F6GhPQ0b" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-38107fadda2so39878241fa.1 for ; Tue, 23 Dec 2025 11:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517836; x=1767122636; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=FSV6UuqHlZBkFieIcW60346ekqC5sdDa/YRUCgK7hwE=; b=F6GhPQ0bwsSO04IDC5zf+acO9a355HSybS+M9bYm8/BdeD5qZUgtQkYEXTt5vmNelQ DeMg9k8K8y0SWShaB86FiDwaEg+askiVPKk+rX3WU1sw+ZC21VFqqP2w56rrc7rz4WGB eWsrD+WyQdTXcULFBGTc/FuIRZFd5Zf9jR6hf4YFmNkWPbXPNlSA/6yHA5FFT1Cq67VV O4iM8w5NF8KrjmgUdLAuBEdR0DBFR/yu3rcKB/Jo/NsVFaNGSaCLlncgvK/fVXmbMtSW 5pR06FO3LgXxlOg5b10fW5wH0FdCHULyIZc2zsceFYmvdyVXOmyoBIaq4izkPv9vpvIG fhKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517836; x=1767122636; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FSV6UuqHlZBkFieIcW60346ekqC5sdDa/YRUCgK7hwE=; b=uaASYrPaWCqupMBYyz4OSr0t16u5F4ofQUrC5v2nUFdcOex7yYmS4BU3e8CYsTHAPi HL6OCbC54suvQ9qa0TT6G1+PEYTH3JxTxE89oRNR6SU3SrhuiQsWd68wZ8/+3ozYxGk4 MaB9BX8thMSTv/lGERxIunmEvDwG6SDq0uo8dKn5dibp7QeNZ2m7xMpibhn+sQyleums Z7tm30zxlhOOljPZR+p+kiYv8gZbgHTbYmbfGL5yiYtWjFoq6dFgAROtkcTEWPv36bcY TtNTpD/j4t5hVqqYp8jBqRjuEg4it4cinJPZ8dAu+QtiX9ul8GFmXrxj2DP0U4Xf6gqs Q7PA== X-Forwarded-Encrypted: i=1; AJvYcCWY82FQK5q+5WYO1wzUp9QeN53+x8IW8ZHblh0kRomaJywp7Yw5JAHlc8lMinizaMn7Uip4zaxfUIULuPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3svLTG4ggXzHlAxHdE9HnSRJTwv/b4vxVtFo/YB5AYm+2Vz31 NGKOFFb+PFeIddpW3hIlMooLq+kXvvBZ92s9JoDuCM3N5oc1ibYJJWOGTjW+ShiOU5MnVeIgyzG lBHxT9egGQzgvv7gi6BEXJ60Ui9is3DU= X-Gm-Gg: AY/fxX65AVDIHmoR00P9cujxowGnxpKJyMllbFsB5tiC3JsFCklRz3mP/sdixYZw0Rd +ePej27UUJSt0lxEg8M1HszApxIY4rjkIp5MCAWffzTQG180VQMD03f2a0iUSsFwSyoSuRY59c+ Cg9rIFLAG2qif5YfWPfRsXPPxj4JjeqrmUgQssNxRewoPNl5OuOqf6XIuZyJYNCbmFdkxWWI5bx 9kCLuwjzKrka+JXldly8EbaZLW9GrzHhJeW3vqAIPbHOp6dp+KO5mQN+ehkGTCYgv4LSpw= X-Google-Smtp-Source: AGHT+IEmMQLP457ERuHoxX54P29gSdhLxMjqrqBR+Kw9dX9ly86Yew/0qQa8PVli746IrLIDwhZPod32DHlVIH48ETA= X-Received: by 2002:a05:651c:1581:b0:37b:97b8:3ca with SMTP id 38308e7fff4ca-3812158e08amr46554441fa.10.1766517835816; Tue, 23 Dec 2025 11:23:55 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:23:54 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:23:54 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: <20251223191932.946794-1-benjamin.philip495@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 19:23:54 +0000 X-Gm-Features: AQt7F2qpjW8wgR3wuQ9o1DlpxHaN1Oan_G1aMXyTOy9yBS2sdbo4yhCD8R5ECbA Message-ID: Subject: [PATCH 2/5] platform/x86: think-lmi: Remove unnecessary parens To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit removes any unnecessary parentheses as flagged by checkpatch in the following check: CHECK: Unnecessary parentheses around '...' Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index 540b472b1bf3..1fac8986d077 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -440,7 +440,7 @@ static ssize_t current_password_store(struct kobject *k= obj, pwdlen =3D strlen(buf); /* pwdlen =3D=3D 0 is allowed to clear the password */ - if (pwdlen && ((pwdlen < setting->minlen) || (pwdlen > setting->maxlen))) + if (pwdlen && (pwdlen < setting->minlen || pwdlen > setting->maxlen)) return -EINVAL; strscpy(setting->password, buf, setting->maxlen); @@ -476,7 +476,7 @@ static ssize_t new_password_store(struct kobject *kobj, pwdlen =3D strlen(new_pwd); /* pwdlen =3D=3D 0 is allowed to clear the password */ - if (pwdlen && ((pwdlen < setting->minlen) || (pwdlen > setting->maxlen)))= { + if (pwdlen && (pwdlen < setting->minlen || pwdlen > setting->maxlen)) { ret =3D -EINVAL; goto out; } @@ -859,7 +859,7 @@ static ssize_t certificate_store(struct kobject *kobj, signature =3D setting->signature; } else { /* Cert install */ /* Check if SMC and SVC already installed */ - if ((setting =3D=3D tlmi_priv.pwd_system) && tlmi_priv.pwd_admin->cert_installed) { + if (setting =3D=3D tlmi_priv.pwd_system && tlmi_priv.pwd_admin->cert_ins= talled) { /* This gets treated as a cert update */ install_mode =3D TLMI_CERT_UPDATE; signature =3D tlmi_priv.pwd_admin->signature; @@ -881,7 +881,7 @@ static ssize_t certificate_store(struct kobject *kobj, } else { /* This is a fresh install */ /* To set admin cert, a password must be enabled */ - if ((setting =3D=3D tlmi_priv.pwd_admin) && + if (setting =3D=3D tlmi_priv.pwd_admin && (!setting->pwd_enabled || !setting->password[0])) { kfree(new_cert); return -EACCES; @@ -965,13 +965,13 @@ static ssize_t save_signature_store(struct kobject *k= obj, static struct kobj_attribute auth_save_signature =3D __ATTR_WO(save_signat= ure); static umode_t auth_attr_is_visible(struct kobject *kobj, - struct attribute *attr, int n) + struct attribute *attr, int n) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); /* We only want to display level and index settings on HDD/NVMe */ if (attr =3D=3D &auth_index.attr || attr =3D=3D &auth_level.attr) { - if ((setting =3D=3D tlmi_priv.pwd_hdd) || (setting =3D=3D tlmi_priv.pwd_= nvme)) + if (setting =3D=3D tlmi_priv.pwd_hdd || setting =3D=3D tlmi_priv.pwd_nvm= e) return attr->mode; return 0; } @@ -985,8 +985,8 @@ static umode_t auth_attr_is_visible(struct kobject *kob= j, if (tlmi_priv.certificate_support) { if (setting =3D=3D tlmi_priv.pwd_admin) return attr->mode; - if ((tlmi_priv.pwdcfg.core.password_mode >=3D TLMI_PWDCFG_MODE_MULTICER= T) && - (setting =3D=3D tlmi_priv.pwd_system)) + if (tlmi_priv.pwdcfg.core.password_mode >=3D TLMI_PWDCFG_MODE_MULTICERT= && + setting =3D=3D tlmi_priv.pwd_system) return attr->mode; } return 0; @@ -1216,13 +1216,13 @@ static struct kobj_attribute attr_current_val =3D __ATTR_RW_MODE(current_value, 06 static struct kobj_attribute attr_type =3D __ATTR_RO(type); -static umode_t attr_is_visible(struct kobject *kobj, - struct attribute *attr, int n) +static umode_t attr_is_visible(struct kobject *kobj, struct attribute *att= r, + int n) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); /* We don't want to display possible_values attributes if not available */ - if ((attr =3D=3D &attr_possible_values.attr) && (!setting->possible_value= s)) + if (attr =3D=3D &attr_possible_values.attr && !setting->possible_values) return 0; return attr->mode; --=20 2.52.0