From nobody Mon Feb 9 12:14:41 2026 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AB9A2C11D4 for ; Tue, 23 Dec 2025 19:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517593; cv=none; b=Wyx3hM84pftl0GKLtG6J28IhJIZxxlU9dhByK7A21t1ZUQIQAWat0HogMzACSYWUilCL2UlwRxGWxrXoeFfu5UOXYyJiJzGiakfLep23xYO0llmvHJ4KM8V5qoxAb6jrUPWB8mTamjk1rQnHtUWEGaLcHKCzVbnsuFC6B5qEe5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517593; c=relaxed/simple; bh=IuW3ft2k35MAniwOYCLe7MFi00Zud8YNij77x8jy8Q8=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=GY8CU1E1CzcwRLBOafS69MNZw+AY3xZaL2t3AdhQJyyWoH9OdGcXGroKu8Rb5+18mt9HBPMJkQAkupUUcCshmEPBCNHC/uXu6ppsZmf00zttoucHOh/jrYAWTxNzzDEFsVmNAZv3ijJdXWT791JzT7S2xZnKOf3+TmNdH7DVvAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I0KixlYW; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I0KixlYW" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-37b95f87d4eso47013161fa.1 for ; Tue, 23 Dec 2025 11:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517590; x=1767122390; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XIl8aapFfoVEdVThyT8e/W+2bxVCSeI46Ht9h2+xOy0=; b=I0KixlYWqhxKMDxcndrrvB4wM9amAxJ1NKhrtkdoPtu6YovR1P114uN6snZSxcL7ZH 1Gb+U+M8bCytvDlVGmynlnW3Vhr/6/v/rWmDI/dDIHEMuPxPlj2CNjBLe5YZlV8Rvt9n 40N378G7tWZ7awhotzZhyZ0aQut1jyT/qeE1MFwRpeMbbVypdGq6BTN8iO5lgJE0Hmah GixSkyWQesFUhpRwu6IG1/vapVwbsrLEzSJZba7bya2yIP73dvNxxVoYdqu5uUcZJlgP 2KuU8YqcXlNDFWpNilOCzJNaeHrqzsnMFbmW7NpwEBc4TW4vKMEUbp6wHOw9N45i46Kn UekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517590; x=1767122390; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XIl8aapFfoVEdVThyT8e/W+2bxVCSeI46Ht9h2+xOy0=; b=LiNZX9aCQCssuCsYhbuvQVNvqArxy7scZVQEUbWh/iLQqZjeP3LEs3OUmzeIqMCrT/ BnSkVj27mv9rjXfd2n1tdkcr+Pla9zFP0s2Pk1z74zds9z/gFesJX+r5BsQ05vDyjXVf +DQSAkoOm4xwjD1B9M3pxYsmVNZw3b5H3LCboZyJ2WXwAqbcu73LyoDVikT+RzkUqP7r yvx9yFMbhstGsth8M8OEpmb/ytNnMaQcZy0Uord7LRstYa4G44ICbqIvtwTpQhDgmCBb dLDTQRi3madralwRqjkHMEM8WZf9U+w37+qEJFehBgkjx78YieRCKyCy1ljO7FDMa+2L 39Nw== X-Forwarded-Encrypted: i=1; AJvYcCVdNjevU5XKMeYN1D53wD0XsPGfnpZLkhBmiDQljw4Bh7xzp6N3idVm81LNrD0kwi9sZk9pK3AhpYmxZFE=@vger.kernel.org X-Gm-Message-State: AOJu0YwUDhyyrZ7xrgFnwrX1LTsLe3o3A/c2TB9cqN2eevcxr7kgkeiB 2GbwF7TWCh44DdWAPhmMN9mcZn9IvUiVVkb4q88cZwT2Op7vWZpITDDLwnIqptEnSZXTKZ7gNdo RUZF0FDNpX+VaXkvVIJx1eoWcdfXbVIw= X-Gm-Gg: AY/fxX63XdSgmihcaXjlX/nY1GKRxo8Cnz1qBy5BlMXxWKHE4lHRixIqVs5a/l1dnjk oOMl3DZLUaM5ELPXqaRb6Bh+li4AOqnqkY40PHGPK+RGzxSKQ3jjuQhy3awiuOjJSdagaka5LCM m89rNlvEgOwJqoxO4mCTFI3Jh8R1aXdC28YOV8B8TAt6W+MqC28xwla+BJNCvaDyUKCVgfjtStI lwFdIjloUtqfBc9xayUDseAS8B0Vtng/8a5kHuKQSSC/shsTy9YcXL05O11fPwEWDMOlEg= X-Google-Smtp-Source: AGHT+IHNrBAhAcXdlX8cz2u4uFifVxNE0J6JMW4c7P1T1MksQYe+kl6sV+tNtewCFKz0Iup2HtGcDd3QmCPS7QTv2g8= X-Received: by 2002:a05:6512:238c:b0:594:768d:c3ef with SMTP id 2adb3069b0e04-59a17d3c40emr5635200e87.30.1766517590076; Tue, 23 Dec 2025 11:19:50 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:19:49 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:19:49 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 19:19:49 +0000 X-Gm-Features: AQt7F2oWDdGUzTnndG-Xab99IP6lVMinFR6JUjPvj448_RanV_yjy80doozqAzk Message-ID: Subject: [PATCH 1/5] platform/x86: think-lmi: Clean up types in headers To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit replaces the uint32_t standard type with preferred u32 kernel type, fixing the following checkpatch check: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.h b/drivers/platform/x86/lenovo/think-lmi.h index 017644323d46..6ea4bceafab2 100644 --- a/drivers/platform/x86/lenovo/think-lmi.h +++ b/drivers/platform/x86/lenovo/think-lmi.h @@ -58,19 +58,19 @@ struct tlmi_cert_guids { #define TLMI_PWDCFG_MODE_MULTICERT 3 struct tlmi_pwdcfg_core { - uint32_t password_mode; - uint32_t password_state; - uint32_t min_length; - uint32_t max_length; - uint32_t supported_encodings; - uint32_t supported_keyboard; + u32 password_mode; + u32 password_state; + u32 min_length; + u32 max_length; + u32 supported_encodings; + u32 supported_keyboard; }; struct tlmi_pwdcfg_ext { - uint32_t hdd_user_password; - uint32_t hdd_master_password; - uint32_t nvme_user_password; - uint32_t nvme_master_password; + u32 hdd_user_password; + u32 hdd_master_password; + u32 nvme_user_password; + u32 nvme_master_password; }; struct tlmi_pwdcfg { --=20 2.52.0 From nobody Mon Feb 9 12:14:41 2026 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4E434AAE4 for ; Tue, 23 Dec 2025 19:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517840; cv=none; b=lC+bmdm95pVF0As2jfbgpuSugmGPP2jwecarhXF9N2CtQyUFIkPQAGS6slPhjULpP7fS4OPCwpoN1/T30W5WNIzbzWtCL4f16m2htPwPxmmuQdTLf22NDs/Qtlvlt9yXLKUvUX8PGlekaWRIDvmujusdbBERMEfgWHQZ0wcUzHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517840; c=relaxed/simple; bh=PDjLoWb+Goab0JJY1HXslrPwRQiSHQMlYcfPKsVPVpI=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=BKRkV6CsyTgWBJja0vDE+jKJ+vPwAOFOKSxzDjPqowPZyWLuG+UWgVuZVx2D/ntCU2vtYxv8faMMCSPR+T/9RqBpwc6srjG6CzmOMZgqDCKF9/STQoKs5xM5xLEd5nayFqLPTT0Pb9wTTN5WPS4gfbAB3YH38nSuQ1dbqPFmHGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F6GhPQ0b; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F6GhPQ0b" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-38107fadda2so39878241fa.1 for ; Tue, 23 Dec 2025 11:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517836; x=1767122636; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=FSV6UuqHlZBkFieIcW60346ekqC5sdDa/YRUCgK7hwE=; b=F6GhPQ0bwsSO04IDC5zf+acO9a355HSybS+M9bYm8/BdeD5qZUgtQkYEXTt5vmNelQ DeMg9k8K8y0SWShaB86FiDwaEg+askiVPKk+rX3WU1sw+ZC21VFqqP2w56rrc7rz4WGB eWsrD+WyQdTXcULFBGTc/FuIRZFd5Zf9jR6hf4YFmNkWPbXPNlSA/6yHA5FFT1Cq67VV O4iM8w5NF8KrjmgUdLAuBEdR0DBFR/yu3rcKB/Jo/NsVFaNGSaCLlncgvK/fVXmbMtSW 5pR06FO3LgXxlOg5b10fW5wH0FdCHULyIZc2zsceFYmvdyVXOmyoBIaq4izkPv9vpvIG fhKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517836; x=1767122636; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FSV6UuqHlZBkFieIcW60346ekqC5sdDa/YRUCgK7hwE=; b=uaASYrPaWCqupMBYyz4OSr0t16u5F4ofQUrC5v2nUFdcOex7yYmS4BU3e8CYsTHAPi HL6OCbC54suvQ9qa0TT6G1+PEYTH3JxTxE89oRNR6SU3SrhuiQsWd68wZ8/+3ozYxGk4 MaB9BX8thMSTv/lGERxIunmEvDwG6SDq0uo8dKn5dibp7QeNZ2m7xMpibhn+sQyleums Z7tm30zxlhOOljPZR+p+kiYv8gZbgHTbYmbfGL5yiYtWjFoq6dFgAROtkcTEWPv36bcY TtNTpD/j4t5hVqqYp8jBqRjuEg4it4cinJPZ8dAu+QtiX9ul8GFmXrxj2DP0U4Xf6gqs Q7PA== X-Forwarded-Encrypted: i=1; AJvYcCWY82FQK5q+5WYO1wzUp9QeN53+x8IW8ZHblh0kRomaJywp7Yw5JAHlc8lMinizaMn7Uip4zaxfUIULuPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3svLTG4ggXzHlAxHdE9HnSRJTwv/b4vxVtFo/YB5AYm+2Vz31 NGKOFFb+PFeIddpW3hIlMooLq+kXvvBZ92s9JoDuCM3N5oc1ibYJJWOGTjW+ShiOU5MnVeIgyzG lBHxT9egGQzgvv7gi6BEXJ60Ui9is3DU= X-Gm-Gg: AY/fxX65AVDIHmoR00P9cujxowGnxpKJyMllbFsB5tiC3JsFCklRz3mP/sdixYZw0Rd +ePej27UUJSt0lxEg8M1HszApxIY4rjkIp5MCAWffzTQG180VQMD03f2a0iUSsFwSyoSuRY59c+ Cg9rIFLAG2qif5YfWPfRsXPPxj4JjeqrmUgQssNxRewoPNl5OuOqf6XIuZyJYNCbmFdkxWWI5bx 9kCLuwjzKrka+JXldly8EbaZLW9GrzHhJeW3vqAIPbHOp6dp+KO5mQN+ehkGTCYgv4LSpw= X-Google-Smtp-Source: AGHT+IEmMQLP457ERuHoxX54P29gSdhLxMjqrqBR+Kw9dX9ly86Yew/0qQa8PVli746IrLIDwhZPod32DHlVIH48ETA= X-Received: by 2002:a05:651c:1581:b0:37b:97b8:3ca with SMTP id 38308e7fff4ca-3812158e08amr46554441fa.10.1766517835816; Tue, 23 Dec 2025 11:23:55 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:23:54 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:23:54 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: <20251223191932.946794-1-benjamin.philip495@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 19:23:54 +0000 X-Gm-Features: AQt7F2qpjW8wgR3wuQ9o1DlpxHaN1Oan_G1aMXyTOy9yBS2sdbo4yhCD8R5ECbA Message-ID: Subject: [PATCH 2/5] platform/x86: think-lmi: Remove unnecessary parens To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit removes any unnecessary parentheses as flagged by checkpatch in the following check: CHECK: Unnecessary parentheses around '...' Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index 540b472b1bf3..1fac8986d077 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -440,7 +440,7 @@ static ssize_t current_password_store(struct kobject *k= obj, pwdlen =3D strlen(buf); /* pwdlen =3D=3D 0 is allowed to clear the password */ - if (pwdlen && ((pwdlen < setting->minlen) || (pwdlen > setting->maxlen))) + if (pwdlen && (pwdlen < setting->minlen || pwdlen > setting->maxlen)) return -EINVAL; strscpy(setting->password, buf, setting->maxlen); @@ -476,7 +476,7 @@ static ssize_t new_password_store(struct kobject *kobj, pwdlen =3D strlen(new_pwd); /* pwdlen =3D=3D 0 is allowed to clear the password */ - if (pwdlen && ((pwdlen < setting->minlen) || (pwdlen > setting->maxlen)))= { + if (pwdlen && (pwdlen < setting->minlen || pwdlen > setting->maxlen)) { ret =3D -EINVAL; goto out; } @@ -859,7 +859,7 @@ static ssize_t certificate_store(struct kobject *kobj, signature =3D setting->signature; } else { /* Cert install */ /* Check if SMC and SVC already installed */ - if ((setting =3D=3D tlmi_priv.pwd_system) && tlmi_priv.pwd_admin->cert_installed) { + if (setting =3D=3D tlmi_priv.pwd_system && tlmi_priv.pwd_admin->cert_ins= talled) { /* This gets treated as a cert update */ install_mode =3D TLMI_CERT_UPDATE; signature =3D tlmi_priv.pwd_admin->signature; @@ -881,7 +881,7 @@ static ssize_t certificate_store(struct kobject *kobj, } else { /* This is a fresh install */ /* To set admin cert, a password must be enabled */ - if ((setting =3D=3D tlmi_priv.pwd_admin) && + if (setting =3D=3D tlmi_priv.pwd_admin && (!setting->pwd_enabled || !setting->password[0])) { kfree(new_cert); return -EACCES; @@ -965,13 +965,13 @@ static ssize_t save_signature_store(struct kobject *k= obj, static struct kobj_attribute auth_save_signature =3D __ATTR_WO(save_signat= ure); static umode_t auth_attr_is_visible(struct kobject *kobj, - struct attribute *attr, int n) + struct attribute *attr, int n) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); /* We only want to display level and index settings on HDD/NVMe */ if (attr =3D=3D &auth_index.attr || attr =3D=3D &auth_level.attr) { - if ((setting =3D=3D tlmi_priv.pwd_hdd) || (setting =3D=3D tlmi_priv.pwd_= nvme)) + if (setting =3D=3D tlmi_priv.pwd_hdd || setting =3D=3D tlmi_priv.pwd_nvm= e) return attr->mode; return 0; } @@ -985,8 +985,8 @@ static umode_t auth_attr_is_visible(struct kobject *kob= j, if (tlmi_priv.certificate_support) { if (setting =3D=3D tlmi_priv.pwd_admin) return attr->mode; - if ((tlmi_priv.pwdcfg.core.password_mode >=3D TLMI_PWDCFG_MODE_MULTICER= T) && - (setting =3D=3D tlmi_priv.pwd_system)) + if (tlmi_priv.pwdcfg.core.password_mode >=3D TLMI_PWDCFG_MODE_MULTICERT= && + setting =3D=3D tlmi_priv.pwd_system) return attr->mode; } return 0; @@ -1216,13 +1216,13 @@ static struct kobj_attribute attr_current_val =3D __ATTR_RW_MODE(current_value, 06 static struct kobj_attribute attr_type =3D __ATTR_RO(type); -static umode_t attr_is_visible(struct kobject *kobj, - struct attribute *attr, int n) +static umode_t attr_is_visible(struct kobject *kobj, struct attribute *att= r, + int n) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); /* We don't want to display possible_values attributes if not available */ - if ((attr =3D=3D &attr_possible_values.attr) && (!setting->possible_value= s)) + if (attr =3D=3D &attr_possible_values.attr && !setting->possible_values) return 0; return attr->mode; --=20 2.52.0 From nobody Mon Feb 9 12:14:41 2026 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD9C34AB1C for ; Tue, 23 Dec 2025 19:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517855; cv=none; b=ut4QTfCK2L2nbWB5AGl3+sTkGv7NBAEw4JQXmcMQtK3nVUi8/OpUH0Xtb/RjgZokegPlrApJrahDZVYTiGgyF94dAusq3D1Mp3YsE2tMfGdlxUTE2NSoWM3Bt3wNZmTzXou6dhJgwwIGZmmbhZY1qqO9Erl3rNXQvQQP+k5i0Dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517855; c=relaxed/simple; bh=ytxYq5dumOjUM+zW47/QayeuiSLcWk0I4K5pUD//gP0=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=k6rddAuW1ixzLE0X0vWMW7dcHi4FdflrLrNIOdbJzgxTA9hTS4IdcI2cWoA9zO71rKZJtnN7PqrKB3R8ZuZ4VtQPpw9Zk6GCn4+K7uemV1VkkonUmIKu8BtXEs1sqP43tS8AWATj8zbepY65FkFCvyl9PSbwI/X0hx4+crbLJM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bo+Bq6cF; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bo+Bq6cF" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-37d275cb96cso49062531fa.2 for ; Tue, 23 Dec 2025 11:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517850; x=1767122650; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=c2wz1QtkrmyGbQChH9BPNFA2K4rppg6qm6bIfWePGFI=; b=Bo+Bq6cFwnDbCofk/fH3Fk0llWariS2BeqZHdGcyO61mrJQ+1zoTu+bveK9nz+ITWp B7Ozl0/Tr3DdBuCLaxMSd7zuVDSKsWSFYpo2+7ej2Wm7VJV43Ycf1KYl2J/CeVnmnQJ5 NhM6yn4jzsvEl/K2hqnx96TFCoLyZWViM+ljV6Luc1bg9UREXVsyg5PTGevv7tsfkLQm NenK3Uflf+Y9nJuvNz04TB4VlNlhY9MK4jSVpmPnw8ihmCw5NVALRXkdKC+C65tQmfb7 DM60a3fKnRRdiet4fmBpsn6nYy0GSn6y3yb/bsV4tfkmDWf9BGU4ei5eOMI/EJaGOL8W tyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517850; x=1767122650; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c2wz1QtkrmyGbQChH9BPNFA2K4rppg6qm6bIfWePGFI=; b=nlT48N+Z2x+Xzru8KXgWtnvHhIKd37G5O96Yf0VaSx/1S888Pnl87H8UPUo5lfzJPn LZVdlRVsUU2zx9WGnrrsU2CNNLXd78tENis4JPzk0A265kphyj+LlSrGBpACOlCJIDhq HP/9kT1OfuA/1DgfTxI8x4QvIVRHp43LIKK/vQ5DPdv70BwezqdulX5XmlmXgW5Qji1o S25gnPPLAZnaa2NuUt+ePG0/Dk284PHMvFdN+YzHZFMKdjvPcok91GdD/rTgP4HDws8B oYESFSWB2KxPDKLpNyoF4/WHStVaHSRiRLhDusNBRFZCYd153oMm69SxL5nFesIdkJfK s2xw== X-Forwarded-Encrypted: i=1; AJvYcCWhZawPAiM05kcDwJ8qwmYDIt4jXGU+6p0sTQjgReZZQcI8VFnJgZeGt4jCv+ECieUDXqFop3Q3eykspFc=@vger.kernel.org X-Gm-Message-State: AOJu0YyMS2LCqrOYsrq3pnexL1c3fKcE2AfcXKQtanGxUX4qY+eifP0I IMlZilGxbsFgtkIpROOolOUzyki8lwWLGdpRpOKdTPBEXN+PdGhHWJkq05PoeanfG52cns3akmA 9yae8K5vRXci8i0KvGxi+G+Py9GgCF4U= X-Gm-Gg: AY/fxX5h/Ei6H9AnM8OUiXGKpL2BlUBG4TuEa/2mUIGIUSMplDxl75LqgNajowV73c6 CX+IBfotU3j+XFkwFtLJprc9BsAqeglEJiayJj1N2Skczu6C00NyUbODM1SmEuZb+qNJouRIbUT kYZgYYGESVc0Iks6D1IRiZW2mFDmn/Q3blfWe2y0qEAbYpp/TlYvkFufEEI8ZlJipPGT+d1qon/ sMfcF/eOOJB3CSqrjEwfPRfx2nrCU2LbxkqfvjNUX3LcHdK2V6tD/hMJm+G+MTi/dQ7QNlu4fDi t2nRVA== X-Google-Smtp-Source: AGHT+IEEGYGEeljB1FPaBLu3wRjlyXq/Y7VzSElMupYoOp8z8/S9m1pS1SJoewIIzXL8xmdMCFqLXk6xb5T2Si7cLt8= X-Received: by 2002:a05:651c:b12:b0:37f:825c:dcc4 with SMTP id 38308e7fff4ca-38121687cebmr45110391fa.35.1766517850057; Tue, 23 Dec 2025 11:24:10 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 11:24:09 -0800 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 11:24:09 -0800 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: <20251223191932.946794-1-benjamin.philip495@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 11:24:09 -0800 X-Gm-Features: AQt7F2pi2TrRdIWsoWP-UTz2ZHLDj1b6QeZ1IJWWrXkB8qv-EX1kkbtANMpo3hc Message-ID: Subject: [PATCH 3/5] platform/x86: think-lmi: Clean up misc checks To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit cleans up the following checks: - CHECK: braces {} should be used on all arms of this statement - CHECK: Please use a blank line after function/struct/union/enum declarations - CHECK: Prefer kzalloc(sizeof(*new_pwd)...) over kzalloc(sizeof(struct tlmi_pwd_setting)...) - CHECK: spaces preferred around that '/' (ctx:VxV) - CHECK: Unbalanced braces around else statement Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.c | 32 +++++++++++++------------ 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index 1fac8986d077..1ada4d800383 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -223,14 +223,16 @@ static const struct tlmi_err_codes tlmi_errs[] =3D { {"Set Certificate operation failed with status:Certificate too large.", -EFBIG}, }; -static const char * const encoding_options[] =3D { +static const char *const encoding_options[] =3D { [TLMI_ENCODING_ASCII] =3D "ascii", [TLMI_ENCODING_SCANCODE] =3D "scancode", }; -static const char * const level_options[] =3D { + +static const char *const level_options[] =3D { [TLMI_LEVEL_USER] =3D "user", [TLMI_LEVEL_MASTER] =3D "master", }; + static struct think_lmi tlmi_priv; static DEFINE_MUTEX(tlmi_mutex); @@ -249,7 +251,7 @@ static int tlmi_errstr_to_err(const char *errstr) { int i; - for (i =3D 0; i < sizeof(tlmi_errs)/sizeof(struct tlmi_err_codes); i++) { + for (i =3D 0; i < sizeof(tlmi_errs) / sizeof(struct tlmi_err_codes); i++)= { if (!strcmp(tlmi_errs[i].err_str, errstr)) return tlmi_errs[i].err_code; } @@ -570,19 +572,19 @@ static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr, return sysfs_emit(buf, "certificate\n"); return sysfs_emit(buf, "password\n"); } + static struct kobj_attribute auth_mechanism =3D __ATTR_RO(mechanism); static ssize_t encoding_show(struct kobject *kobj, struct kobj_attribute *= attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%s\n", encoding_options[setting->encoding]); } -static ssize_t encoding_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t encoding_store(struct kobject *kobj, struct kobj_attribute *attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); int i; @@ -632,19 +634,19 @@ static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr, return sysfs_emit(buf, "%s\n", setting->role); } + static struct kobj_attribute auth_role =3D __ATTR_RO(role); static ssize_t index_show(struct kobject *kobj, struct kobj_attribute *att= r, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%d\n", setting->index); } -static ssize_t index_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t index_store(struct kobject *kobj, struct kobj_attribute *at= tr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); int err, val; @@ -1047,9 +1049,9 @@ static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *a /* validate and split from `item,value` -> `value` */ value =3D strpbrk(item, ","); - if (!value || value =3D=3D item || !strlen(value + 1)) + if (!value || value =3D=3D item || !strlen(value + 1)) { ret =3D -EINVAL; - else { + } else { /* On Workstations remove the Options part after the value */ strreplace(value, ';', '\0'); ret =3D sysfs_emit(buf, "%s\n", value + 1); @@ -1585,11 +1587,11 @@ static int tlmi_sysfs_init(void) /* ---- Base Driver ------------------------------------------------------= -- */ static struct tlmi_pwd_setting *tlmi_create_auth(const char *pwd_type, - const char *pwd_role) + const char *pwd_role) { struct tlmi_pwd_setting *new_pwd; - new_pwd =3D kzalloc(sizeof(struct tlmi_pwd_setting), GFP_KERNEL); + new_pwd =3D kzalloc(sizeof(*new_pwd), GFP_KERNEL); if (!new_pwd) return NULL; --=20 2.52.0 From nobody Mon Feb 9 12:14:41 2026 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6091634B1A4 for ; Tue, 23 Dec 2025 19:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517859; cv=none; b=hqEWsAYD5bUtL9tgp9bBNmGgJ9BvNKcvvL4LhwiUFAYKMlSLqYSbi62jgb4lj+L50r8G2J+bJ3gOuJjODEGf4wI5nkFlCO5++7GT1w+S884D2Laq6UcsaaezbKt+uoa/MypD3b5IAn9aRKIyoJTofZ4jF4eU4PZ5rt/Juqtiztc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517859; c=relaxed/simple; bh=ySYADvvc8y2/n2L7x+HusCwWvM0hvQ8qNqof/iJYVWk=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=FgFhurGmrbtUUx/ow/nFSQgt6By1a/Divk/R6rPDjy+GBtoFbCfrxDSzkedHjPmLjSQ7Lz8QpwSoh3kHQrZsLt7fWz+6YVupsYjfc1pYWUet6sClHWR+uevxNnwdVF2Wei6m6gRnaLKY4J0bLy+j8y1MflCTrdm8RblPlInNaAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C9wbkCJs; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C9wbkCJs" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-37d96f97206so40363741fa.3 for ; Tue, 23 Dec 2025 11:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517855; x=1767122655; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=n3KTOeOgbJaX0y3CDqxp4/2HWbdCBK3qHQJYC6bNE1E=; b=C9wbkCJs/gRfK8FmKH+ql2G2NSuyEMFIux+U8h0gL4mYXCd1VaBFP3HFLKwMfQYyR4 Al8nIVfeesKeDmFFlXPU9vvrdVYdlTmA6TZ/zQmbtzElKLCXRvNV4uklfBzTXFwS2mdb dWBOgpaEmerME3MzijieEVnZZ0DQ36SNlu+z/hl3wCW8cCCAHqsULaeZxqHb9xMeJCMZ NPXPHyeNUAEsUKRY7HYyDROkhVo7mZ12JxXeqwI/oBhH0LLBzGY6U7MnPi3Ks9yhBKvg 4ILTwWa8wvTMZrhAukzbxg8ytehb05gZCtGYIK7gw9+MdTQQlmnrKJwN7C8371tOSAkJ m6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517855; x=1767122655; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n3KTOeOgbJaX0y3CDqxp4/2HWbdCBK3qHQJYC6bNE1E=; b=wzdIghkv75oiOnJm9MVQvCYHqTPyooYn7lE3LE5XCsXPe31Q4JSM+RzJaoQybAZnIH zQVY8g+YtQvq7H9krFH990VSKtzPIbnkb6vAUu37PkmPvWGqu7zlbTaacZkN3Jjnovt/ eMI0gU2dTxfN+ITdfi0zXG3iMFvgi3DNGdue22e2Aoc4MwbAmYtHzjMtaMvhWC/JpDxw xJCTca+ThkWLV+6ST/BmiMO9DiopKkLwZ/Jomt1HaNQitZd8V4W4NIx0WpWpvaP3cSAU BW53s3G/d9ltyPMauIxwbXIbTa6/qlgNAFuMisnPZPUzG2f0OWYM4JwVkOBm1vQKF7CB tV4A== X-Forwarded-Encrypted: i=1; AJvYcCWRN0FQXt2NqsMOFsip01qhlnknH2zxNePLJmaknNYvSTDpm9fnltBZLDQbRlAzkRQSdiOsoGxMSrY7r8s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0qbAGxpa3o1/Ng9LS54Guix1exQ/pKT4stF5vkWtczoIJzlWQ w0DmhPOXNMdZsGY98q4HtuBcYb3XZwY8zu3fZST4FGPzjmmR45UKg4ZiOAr5/MoA1bbiGOY6rR6 V07k+iL5gauFi/K31LEoNkn7CF0wT80U= X-Gm-Gg: AY/fxX7IG9S2wp4H25KIA+Il3q1u+uHQf60aik9mFKGSbXhQ/f9wLNZERpvUBkn9ILW xXuRVHJt+/06DDDMTQ7/1KAvvgoJLZrqtFcde0dvkQy/q9eJv72s5uuj56b6ksjtlKzXl/KF/1I suGM6NDYiUYpKfSsLZnAS6iCgCAA1qxjkxYbWrjFMPYJe6i38syBg9WZ6iGGP3hfjZxO4k8CWUu +DEgpHLGyoSPvsyf79oo1PkPYpkpoUxOq3ulHPRC5fH9quPq71pUBqjaJ3YlG1qIubBYg4= X-Google-Smtp-Source: AGHT+IGhGCM/EJJBNbkrqk1aVDxnaDT7lHNAVQIkNGmCrWU4+4uGFHCZQUY6buIbRvzaGlQJ1JYl3yNmtUcQ95Ro6pE= X-Received: by 2002:a2e:a7c1:0:b0:382:4f4b:a9aa with SMTP id 38308e7fff4ca-3824f4babc9mr5081291fa.34.1766517855315; Tue, 23 Dec 2025 11:24:15 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:24:14 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:24:14 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: <20251223191932.946794-1-benjamin.philip495@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 19:24:14 +0000 X-Gm-Features: AQt7F2px6JFqBlrrhNdWQbnWzXmfaAK4a2iVZExig6yFAZHtoi3jt4IAOjqDrIs Message-ID: Subject: [PATCH 4/5] platform/x86: think-lmi: fix column limit overflow To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit handles some column limit overflows (that occur after fixing their alignment), i.e. the following check: CHECK: line length of ... exceeds 100 columns by defining a constant opt, and replacing the offending expression with opt. Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.c | 31 +++++++++++++++---------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index 1ada4d800383..07ba0d84720a 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -1083,12 +1083,13 @@ static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr, } static ssize_t current_value_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, const char *buf, + size_t count) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); char *set_str =3D NULL, *new_setting =3D NULL; char *auth_str =3D NULL; + const char *opt; int ret; if (!tlmi_priv.can_set_bios_settings) @@ -1163,10 +1164,11 @@ static ssize_t current_value_store(struct kobject *= kobj, ret =3D tlmi_save_bios_settings(""); } else { /* old non-opcode based authentication method (deprecated) */ if (tlmi_priv.pwd_admin->pwd_enabled && tlmi_priv.pwd_admin->password[0]= ) { + opt =3D encoding_options[tlmi_priv.pwd_admin->encoding]; auth_str =3D kasprintf(GFP_KERNEL, "%s,%s,%s;", - tlmi_priv.pwd_admin->password, - encoding_options[tlmi_priv.pwd_admin->encoding], - tlmi_priv.pwd_admin->kbdlang); + tlmi_priv.pwd_admin->password, + opt, + tlmi_priv.pwd_admin->kbdlang); if (!auth_str) { ret =3D -ENOMEM; goto out; @@ -1299,6 +1301,7 @@ static ssize_t save_settings_store(struct kobject *kobj, struct kobj_attribute * const char *buf, size_t count) { char *auth_str =3D NULL; + const char *opt; int ret =3D 0; int cmd; @@ -1347,9 +1350,10 @@ static ssize_t save_settings_store(struct kobject *kobj, struct kobj_attribute * ret =3D tlmi_save_bios_settings(""); } else { /* old non-opcode based authentication method (deprecated) */ if (tlmi_priv.pwd_admin->pwd_enabled && tlmi_priv.pwd_admin->password[0= ]) { + opt =3D encoding_options[tlmi_priv.pwd_admin->encoding]; auth_str =3D kasprintf(GFP_KERNEL, "%s,%s,%s;", tlmi_priv.pwd_admin->password, - encoding_options[tlmi_priv.pwd_admin->encoding], + opt, tlmi_priv.pwd_admin->kbdlang); if (!auth_str) { ret =3D -ENOMEM; @@ -1381,11 +1385,13 @@ static ssize_t save_settings_store(struct kobject *kobj, struct kobj_attribute * static struct kobj_attribute save_settings =3D __ATTR_RW(save_settings); /* ---- Debug interface---------------------------------------------------= ------ */ -static ssize_t debug_cmd_store(struct kobject *kobj, struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t debug_cmd_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, + size_t count) { char *set_str =3D NULL, *new_setting =3D NULL; char *auth_str =3D NULL; + const char *opt; int ret; if (!tlmi_priv.can_debug_cmd) @@ -1397,10 +1403,11 @@ static ssize_t debug_cmd_store(struct kobject *kobj, struct kobj_attribute *attr return -ENOMEM; if (tlmi_priv.pwd_admin->pwd_enabled && tlmi_priv.pwd_admin->password[0])= { + opt =3D encoding_options[tlmi_priv.pwd_admin->encoding]; auth_str =3D kasprintf(GFP_KERNEL, "%s,%s,%s;", - tlmi_priv.pwd_admin->password, - encoding_options[tlmi_priv.pwd_admin->encoding], - tlmi_priv.pwd_admin->kbdlang); + tlmi_priv.pwd_admin->password, + opt, + tlmi_priv.pwd_admin->kbdlang); if (!auth_str) { ret =3D -ENOMEM; goto out; @@ -1775,7 +1782,7 @@ static int tlmi_analyze(struct wmi_device *wdev) ffs(tlmi_priv.pwdcfg.ext.hdd_user_password) - 1; } if (tlmi_priv.pwdcfg.ext.nvme_user_password || - tlmi_priv.pwdcfg.ext.nvme_master_password) { + tlmi_priv.pwdcfg.ext.nvme_master_password) { tlmi_priv.pwd_nvme->pwd_enabled =3D true; if (tlmi_priv.pwdcfg.ext.nvme_master_password) tlmi_priv.pwd_nvme->index =3D --=20 2.52.0 From nobody Mon Feb 9 12:14:41 2026 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F033081CA for ; Tue, 23 Dec 2025 19:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517869; cv=none; b=bU6IhK02Ai2/s3rEUvxuWfBru23u8iXhDUdfEIFm6prZ3kZMdAm/otf8YOPdGxvIE9CetBCNS/VcKKiQjF+RNiLpDkL1MPRaz+2NppdzG/QqcqjaBtQOB5DeWZLiNXX/ZW5fvulC+tG5Irh7LFQ601nUtcrbQOvjv/Jz8fJIqk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766517869; c=relaxed/simple; bh=rjyEWf85YzHLrtYPAFhy72tVlNMvhiXFu+YvwjxGXbw=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=VwbNstgAVmvgQpBVwa46o5B5XBKiah3XrPJ+NFcnIxKJcKr4kmoJ2TSqVCGUreENc0xXcDXXKkSbJsGMcMoRKIIV4pLwD4Mg+RNqRw4TfRPyYpAPcnoV+hULMg4GozUGokLt+wD69rkmeKy7bQ6wJDNKQUO2IGl64DVEgfV+xo4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VaS70/OO; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VaS70/OO" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-38105ad3720so44510731fa.0 for ; Tue, 23 Dec 2025 11:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766517865; x=1767122665; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=l56PyPTvBksExPgkW9juhbN4bXzt4MS2OYE//VwO+OY=; b=VaS70/OOmzstc+PDnSHheuAUhCGZKq4gtrk7mdvh/dUCQBU4MNXqhJ+YQ401vArjw9 3B/DN0ZoVYHkb7n0vFEdJ4Njr73pr1XoI4jrILt4GeYZaUTwJedbK/laf5WbpXQDFlY7 ji7HRPr/wuZCy9OcfMgnbONrBBNbXzBTP13GWNGR+6nkFp6roaT5nNkA3EZu7XVR1OGY jSsoMfpD1zCDuQ0AtGV809AopnB5e767xEZs/8Vs3i8dcPPn/rnPOOKBUAujuQVtkV8I rmkocWnJ0pIC4dFytx5ZL050YrmSYwkhJdQpYHYQuKRvgXrDviqP1hFJQIE4E27N7uGh FYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766517865; x=1767122665; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l56PyPTvBksExPgkW9juhbN4bXzt4MS2OYE//VwO+OY=; b=XIU5ywaQfbTz7GBFzg49tyMg9W9299v6a3bhUbIASw4N8wGAiDy7mM2C5Ld1pM6tjB 8YR79pU2QED+AJn03N9lBckm4lOikV0frAa3zprMto3yg4fulnmwqidXpGDz/AZYbQpX oGMWklT6bIhNo2wpueTUhjzqg5GIH2zIsCllXUptyarPhC8dZkmZG6hSEXTbkmbaWjrz ArkZMC+Rdmx3UvSOJ/ou5+bRQ+IfYxjtKYI7/eACQ7Lg/c0zzoMP3MU9WTXKukPWb05h +oBDLebdG8i4nJsUw7qlGjiaNGw3SoH/6UUVZcQohZv/jA2NNapaMPlgrgwnzISyw0eU 2XHQ== X-Forwarded-Encrypted: i=1; AJvYcCUGpd5DuzXHlBvsEJBaoEJfjLEoQ9jh8rWzMx9LctA/jrLm+lUqQYRC0HhOE2+wtOp4Ow9ujUYWnd5GFeM=@vger.kernel.org X-Gm-Message-State: AOJu0YwYYXbEpvBLHh9QDoK2DjpGP3ogMiMW6puU0lJTzDcup3tq3u3I 99QfmOtnCpLbJAdHd86i4GpAMaJtxgc7AVaMBhyQNAtKaMVw78vD2ZQiqKk0uy0h9ChX8QqU0A5 ifPDnwQF+UlgnFo+KUGtAhVOuXs55EYLLqeIX X-Gm-Gg: AY/fxX70dJxLtQ0olq7gsA0/5pET5yS7O4jnYgb4P9mqzz5ghLUSCttbm7ooh5rp8JJ 6Q3Isr3o/tpi3GJwywmkQmp7UEx8J+bsrNYI9SuIa7qOwMSCvmCrglOuZ0HEAsf7SQ8juSof1Sw 2CHgiPRpw7gfVzDr+MEbeLO54ixetKhiBJlBe4kTTiYwSZ+RvH9cY3zigfdHoGgv8KVGy1avXft 9PlRgNBVcesyAR3xRqOdwws2eHWKxVaZotJseIHPog+UkXukX8LUQYnusjJ4eHy+Uhc9QA= X-Google-Smtp-Source: AGHT+IH/6vwWnlwA+2ntbE4BBo5XBjXA037mg+f20SX6cMQDjTN3ZXQ4fmykN3IACIIMo1og8rJowUn2qiDqMDD0GQo= X-Received: by 2002:a05:651c:507:b0:37f:d484:59b8 with SMTP id 38308e7fff4ca-3812156a27dmr56195091fa.7.1766517864402; Tue, 23 Dec 2025 11:24:24 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:24:21 +0000 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 23 Dec 2025 19:24:21 +0000 From: Benjamin Philip X-Mailer: git-send-email 2.52.0 In-Reply-To: References: <20251223191932.946794-1-benjamin.philip495@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 23 Dec 2025 19:24:21 +0000 X-Gm-Features: AQt7F2pon76cn3q1cVXsWOfbABA0VzmPkHryHoTqQJO424NmQQfz6rtksbdtGpM Message-ID: Subject: [PATCH 5/5] platform/x86: think-lmi: Clean up alignment To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Pearson , "Derek J. Clark" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Benjamin Philip Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit fixes multiple instances of the following checkpatch check: CHECK: Alignment should match open parenthesis Signed-off-by: Benjamin Philip --- drivers/platform/x86/lenovo/think-lmi.c | 75 +++++++++++++------------ 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index 07ba0d84720a..ccb767c3972e 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -424,7 +424,7 @@ static int tlmi_get_bios_selections(const char *item, char **value) /* ---- Authentication sysfs --------------------------------------------------------- */ static ssize_t is_enabled_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); @@ -513,7 +513,7 @@ static ssize_t new_password_store(struct kobject *kobj, */ if (tlmi_priv.pwd_admin->pwd_enabled && strlen(tlmi_priv.pwd_admin->password)) { ret =3D tlmi_opcode_setting("WmiOpcodePasswordAdmin", - tlmi_priv.pwd_admin->password); + tlmi_priv.pwd_admin->password); if (ret) goto out; } @@ -527,8 +527,8 @@ static ssize_t new_password_store(struct kobject *kobj, } else { /* Format: 'PasswordType,CurrentPw,NewPw,Encoding,KbdLang;' */ auth_str =3D kasprintf(GFP_KERNEL, "%s,%s,%s,%s,%s;", - setting->pwd_type, setting->password, new_pwd, - encoding_options[setting->encoding], setting->kbdlang); + setting->pwd_type, setting->password, new_pwd, + encoding_options[setting->encoding], setting->kbdlang); if (!auth_str) { ret =3D -ENOMEM; goto out; @@ -545,7 +545,7 @@ static ssize_t new_password_store(struct kobject *kobj, static struct kobj_attribute auth_new_password =3D __ATTR_WO(new_password); static ssize_t min_password_length_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); @@ -555,16 +555,17 @@ static ssize_t min_password_length_show(struct kobject *kobj, struct kobj_attrib static struct kobj_attribute auth_min_pass_length =3D __ATTR_RO(min_password_length); static ssize_t max_password_length_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%d\n", setting->maxlen); } + static struct kobj_attribute auth_max_pass_length =3D __ATTR_RO(max_password_length); static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); @@ -601,16 +602,15 @@ static ssize_t encoding_store(struct kobject *kobj, struct kobj_attribute *attr, static struct kobj_attribute auth_encoding =3D __ATTR_RW(encoding); static ssize_t kbdlang_show(struct kobject *kobj, struct kobj_attribute *a= ttr, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%s\n", setting->kbdlang); } -static ssize_t kbdlang_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t kbdlang_store(struct kobject *kobj, struct kobj_attribute *= attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); int length; @@ -665,16 +665,15 @@ static ssize_t index_store(struct kobject *kobj, struct kobj_attribute *attr, static struct kobj_attribute auth_index =3D __ATTR_RW(index); static ssize_t level_show(struct kobject *kobj, struct kobj_attribute *att= r, - char *buf) + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); return sysfs_emit(buf, "%s\n", level_options[setting->level]); } -static ssize_t level_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) +static ssize_t level_store(struct kobject *kobj, struct kobj_attribute *at= tr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); int i; @@ -731,8 +730,9 @@ static ssize_t cert_thumbprint(char *buf, const char *arg, int count) static char *thumbtypes[] =3D {"Md5", "Sha1", "Sha256"}; -static ssize_t certificate_thumbprint_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) +static ssize_t certificate_thumbprint_show(struct kobject *kobj, + struct kobj_attribute *attr, + char *buf) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); unsigned int i; @@ -764,8 +764,8 @@ static ssize_t certificate_thumbprint_show(struct kobject *kobj, struct kobj_att static struct kobj_attribute auth_cert_thumb =3D __ATTR_RO(certificate_thumbprint); static ssize_t cert_to_password_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); char *auth_str, *passwd; @@ -809,8 +809,8 @@ enum cert_install_mode { }; static ssize_t certificate_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, const char *buf, + size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); enum cert_install_mode install_mode =3D TLMI_CERT_INSTALL; @@ -913,8 +913,8 @@ static ssize_t certificate_store(struct kobject *kobj, static struct kobj_attribute auth_certificate =3D __ATTR_WO(certificate); static ssize_t signature_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, const char *buf, + size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); char *new_signature; @@ -940,8 +940,8 @@ static ssize_t signature_store(struct kobject *kobj, static struct kobj_attribute auth_signature =3D __ATTR_WO(signature); static ssize_t save_signature_store(struct kobject *kobj, - struct kobj_attribute *attr, - const char *buf, size_t count) + struct kobj_attribute *attr, + const char *buf, size_t count) { struct tlmi_pwd_setting *setting =3D to_tlmi_pwd_setting(kobj); char *new_signature; @@ -1029,8 +1029,8 @@ static const struct attribute_group auth_attr_group = =3D { __ATTRIBUTE_GROUPS(auth_attr); /* ---- Attributes sysfs --------------------------------------------------------- */ -static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) +static ssize_t display_name_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); @@ -1069,7 +1069,7 @@ static ssize_t possible_values_show(struct kobject *kobj, struct kobj_attribute } static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr, - char *buf) + char *buf) { struct tlmi_attr_setting *setting =3D to_tlmi_attr_setting(kobj); @@ -1491,15 +1491,15 @@ static int tlmi_sysfs_init(void) { int i, ret; - tlmi_priv.class_dev =3D device_create(&firmware_attributes_class, NULL, MKDEV(0, 0), - NULL, "%s", "thinklmi"); + tlmi_priv.class_dev =3D device_create(&firmware_attributes_class, NULL, + MKDEV(0, 0), NULL, "%s", "thinklmi"); if (IS_ERR(tlmi_priv.class_dev)) { ret =3D PTR_ERR(tlmi_priv.class_dev); goto fail_class_created; } tlmi_priv.attribute_kset =3D kset_create_and_add("attributes", NULL, - &tlmi_priv.class_dev->kobj); + &tlmi_priv.class_dev->kobj); if (!tlmi_priv.attribute_kset) { ret =3D -ENOMEM; goto fail_device_created; @@ -1637,8 +1637,8 @@ static int tlmi_analyze(struct wmi_device *wdev) tlmi_priv.opcode_support =3D true; if (wmi_has_guid(LENOVO_SET_BIOS_CERT_GUID) && - wmi_has_guid(LENOVO_SET_BIOS_SETTING_CERT_GUID) && - wmi_has_guid(LENOVO_SAVE_BIOS_SETTING_CERT_GUID)) + wmi_has_guid(LENOVO_SET_BIOS_SETTING_CERT_GUID) && + wmi_has_guid(LENOVO_SAVE_BIOS_SETTING_CERT_GUID)) tlmi_priv.certificate_support =3D true; /* ThinkCenter uses different GUIDs for certificate support */ @@ -1693,7 +1693,7 @@ static int tlmi_analyze(struct wmi_device *wdev) &setting->possible_values); if (ret || !setting->possible_values) pr_info("Error retrieving possible values for %d : %s\n", - i, setting->display_name); + i, setting->display_name); } else { /* * Older Thinkstations don't support the bios_selections API. @@ -1710,8 +1710,9 @@ static int tlmi_analyze(struct wmi_device *wdev) optend =3D strstr(optstart, "]"); if (optend) setting->possible_values =3D - kstrndup(optstart, optend - optstart, - GFP_KERNEL); + kstrndup(optstart, + optend - optstart, + GFP_KERNEL); } kfree(optitem); } @@ -1772,7 +1773,7 @@ static int tlmi_analyze(struct wmi_device *wdev) if (tlmi_priv.pwdcfg.core.password_state & TLMI_HDD_PWD) { /* Check if PWD is configured and set index to first drive found */ if (tlmi_priv.pwdcfg.ext.hdd_user_password || - tlmi_priv.pwdcfg.ext.hdd_master_password) { + tlmi_priv.pwdcfg.ext.hdd_master_password) { tlmi_priv.pwd_hdd->pwd_enabled =3D true; if (tlmi_priv.pwdcfg.ext.hdd_master_password) tlmi_priv.pwd_hdd->index =3D --=20 2.52.0