From nobody Fri Apr 17 09:19:30 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD309476 for ; Sat, 21 Feb 2026 13:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.215.176 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771682187; cv=pass; b=GlsB2F1BC8w70zji1nOvUtsJyGGRGNjjuOYRKtqPolrCuyN2SWluCrEmu3cjK8oZkBvwQE8S3eT4e7ax3JSQVO+hvvYql87PyAbn8TquTcNdzpOwz40wUYAc5rgl3SzzP1S7RonaBCa8hxSWR59kqIylJIGF1C/PrI2g19pEJu4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771682187; c=relaxed/simple; bh=YItOr1vE8u9Y48dHND1D4J+EDE9L8yIAk0f6MsCnPIM=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=WIS6Gx83TY074ekTZSexi53TSER7IFMhqFVX33bOsy97bJdX6hNRGHIWYmuX385gwRI5I9YUKTiqc3hKVSw1jkBFux3mv3PysyGONg8YBEOxlF0EbbuGzPBPoEPUwMnCq1rCZSXTalhaC3FW7zPxsIlAbleH1o9B+SgEISRf8oo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cr96RTA4; arc=pass smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cr96RTA4" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-b6ce6d1d3dcso1084600a12.3 for ; Sat, 21 Feb 2026 05:56:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771682185; cv=none; d=google.com; s=arc-20240605; b=PetBZdl0p/tzjhvvOAaX+A5YlCaMRQ/C6z6VGVnxlKdnpu43CD3q1TOwyv01cWrgYl /QWw1P78iFbxTeJxtMAC1uN9+gwxqP8kaaHzRGz3AScLlFlHQlypObvwjeDh6r9meYBU kDBgpxTtkyzUWo6YxxaHv7mbQ3S6qLnInNLS+eqTXGuBuMdkSqpCBbwP0imJOEKYKGyg T03irzk9McGKf+1wYOxNexAPQ/mynGjbBvwJv7EamTKdWqStDTQyZXMA4jq7wSiSjxN6 gJGcEvNgzk8O1w5Wkd7A+8dGi1rV5S3KxLxqXNdg82Q1aeOLETsx0B6QXtIaE/2dX4vG 4LmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=48EVcoxajP9uja+w8cshH5BCBWvcVabhjhgRsLB/1yY=; fh=goWUj7kceim3do/dVqEYH5/54QknxjRm/BIEdZimV88=; b=gCEKDp3Pe9zoWhn/9hG1yOYcPzEV2QOogpt8sBeGYxDOjKM8b2/n4BDx6GiQgdh1Gj zbJyApIcIN2ztn1XJATv4kD26IOM0sjUzmzCO6SZKPG2egSD3dPvEl56ciF0mM5KRGkV sP7OlrDEn01yyRMhRSZHvKVmLZKmDvnnjVbMjksMDuzDs8qDLUils/dh2x55momR1U1I h+A9r+tbpwgvrD243qeuw8JPJ19thlu/JBiq6u7fhBKzFdRDhO75lfNwuNg0UtfKZUfN qQug0vN0b5Ygei7jr/fd3rzU1hBuRMR2M3wT4VkwtaZZ1lbTSuPYh/IJfni4+HSGf9BR GuIw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771682185; x=1772286985; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=48EVcoxajP9uja+w8cshH5BCBWvcVabhjhgRsLB/1yY=; b=cr96RTA4wYaY17mrjeFaVMFT8po91dlINuts4S9GGnzwKkkFx7RJw839v5nbh4nugu htDQgFT/VepI7vFcITb2ec4BWTdZSGUnzX6kfE7VymWe7PwI29nMzBpseabGLiDmSl8r 0NhBFEssLCcbtaFKIYPE8f0VnpwacxjwR31pn/VkExln4tBL7oh1Xk4DMGuiIJV5hOvv OSwHFIuD+32TesRKwnN7mPynYIiLcEKOeFWzGJCXrXAZDG1Nnq2lt3BunNHyX1s2b4N7 SUmkIyD7pc1N9AppG/XlM3Ils5/Xf40VBbSoAlOjzajMpZpzPXWKY4aTGC1ahDFIOVPe Y3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771682185; x=1772286985; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=48EVcoxajP9uja+w8cshH5BCBWvcVabhjhgRsLB/1yY=; b=XQmjzfSa6RpCNBMkgrE782XuAEOYyNy5IfP1beqekSNpJct0TBabfz3uBtS6lppyBj GAHOvNsAkXvEUieJ3Ki6oQUzxkJyLPNPeLhYBLWVCdZGth7A8Hts0qfpROM5kIthTbvt ocalDk2rrly7eTC3L3pvU/Ue59lV5EkHBctRCCjG1LSCgIaCqlhGd9jUdir2JF33x4QP HmBQnF0SNuP2ymF6x2C3Zi2VQXZbXY+zQMCdEqDV7C/obawLd3zdM/JNIPCgHV9eSHtC Jxru0p7uHibT5eaMX38pb4nZ/JXWCg+10xmZc5g0Euluvgjk42GasAa2eUTXd01Q7dzy VJEg== X-Forwarded-Encrypted: i=1; AJvYcCWkfFW/oLuu5huGm4xccA+TYB5inkdOi8RHC4ddAmSlMrJrq1dw0JpZRqeG3wP+ikfRoe4H0ALpeiR16Ys=@vger.kernel.org X-Gm-Message-State: AOJu0YyJOFkpDgyd0ZBFaqXRw5Y1fuEgwWihScxR8xNpXwVGo5v6QRdF 3PouA7xsNO+pwk7kUBPJaMwssprj8fOdqDcAebq8aeqAJ1xVHHd8Kf8Aq1bI4DT42frZkii64zW Ygs+eNuzzhp4qBqFuK50qpIbm58oGThDzE3d2ASU= X-Gm-Gg: AZuq6aKMFRFtfo6ZtGiZXmNF2JPbiH1VhO9dvCRfvNBwkwhHdAjNgraUauUWywr4s08 Q+q8AXEG1IJjvGDlSoKojhJxxWKhBT4M1GoBpzfMjlB6PfZnP1h+21i1IIJcsCLmXqnWRcrds+B /i6U98jkmbTFzCnK+QowUDGKDcAxMkYLZXliO0jKvEhqCNi4IiFZmj1xZzJng72zeyFpJho8GdL VigDJUkcJHSJXmmHJgelOT0MXgRrq3+IV/oLzhRN8vfxKB6wj4Am2eU32kzI08z18bbpdpXaKtv iVfzDmI9NQ6FHJT8J10vmcJfLhtz7Kdn/JuJlhfiD1V9ZvuEqNiPv3xa X-Received: by 2002:a17:903:4b30:b0:2aa:e6fa:2f74 with SMTP id d9443c01a7336-2ad74419fa3mr25800655ad.2.1771682184653; Sat, 21 Feb 2026 05:56:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Wojciech Date: Sat, 21 Feb 2026 14:56:13 +0100 X-Gm-Features: AaiRm504GZjJl6tFoZ6tHrO4hbzCYdgyCH_cz2tpuWHGa9eEC92j7O4aJEqmdF0 Message-ID: Subject: [PATCH] staging: rtl8723bs: cleanup rtw_io.c To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, ethantidmore06@gmail.com, arthur.stupa@gmail.com, horstaufmental@gmail.com, kaizhetan@yahoo.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace tabs with a space in return statements and declarations. Remove dead code and redundant vendor comments. No functional changes. Signed-off-by: Wojciech S. --- drivers/staging/rtl8723bs/core/rtw_io.c | 49 ++++--------------------- 1 file changed, 7 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c index 965c3cfea103..4b36a39946f1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_io.c +++ b/drivers/staging/rtl8723bs/core/rtw_io.c @@ -1,35 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 -/*************************************************************************= ***** - * - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. - * - *************************************************************************= *****/ -/* - * The purpose of rtw_io.c - * - * a. provides the API - * - * b. provides the protocol engine - * - * c. provides the software interface between caller and the hardware inte= rface - * - * - * Compiler Flag Option: - * - * 1. CONFIG_SDIO_HCI: - * a. USE_SYNC_IRP: Only sync operations are provided. - * b. USE_ASYNC_IRP:Both sync/async operations are provided. - * - * jackson@realtek.com.tw - */ #include u8 rtw_read8(struct adapter *adapter, u32 addr) { - /* struct io_queue *pio_queue =3D (struct io_queue *)adapter->pio_queue; = */ struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr); _read8 =3D pintfhdl->io_ops._read8; @@ -39,9 +15,8 @@ u8 rtw_read8(struct adapter *adapter, u32 addr) u16 rtw_read16(struct adapter *adapter, u32 addr) { - /* struct io_queue *pio_queue =3D (struct io_queue *)adapter->pio_queue; = */ struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr); _read16 =3D pintfhdl->io_ops._read16; @@ -51,9 +26,8 @@ u16 rtw_read16(struct adapter *adapter, u32 addr) u32 rtw_read32(struct adapter *adapter, u32 addr) { - /* struct io_queue *pio_queue =3D (struct io_queue *)adapter->pio_queue; = */ struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 =3D pintfhdl->io_ops._read32; @@ -63,9 +37,8 @@ u32 rtw_read32(struct adapter *adapter, u32 addr) int rtw_write8(struct adapter *adapter, u32 addr, u8 val) { - /* struct io_queue *pio_queue =3D (struct io_queue *)adapter->pio_queue; = */ struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; int (*_write8)(struct intf_hdl *pintfhdl, u32 addr, u8 val); int ret; @@ -77,9 +50,8 @@ int rtw_write8(struct adapter *adapter, u32 addr, u8 val) } int rtw_write16(struct adapter *adapter, u32 addr, u16 val) { - /* struct io_queue *pio_queue =3D (struct io_queue *)adapter->pio_queue; = */ struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; int (*_write16)(struct intf_hdl *pintfhdl, u32 addr, u16 val); int ret; @@ -90,9 +62,8 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 va= l) } int rtw_write32(struct adapter *adapter, u32 addr, u32 val) { - /* struct io_queue *pio_queue =3D (struct io_queue *)adapter->pio_queue; = */ struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; int (*_write32)(struct intf_hdl *pintfhdl, u32 addr, u32 val); int ret; @@ -107,7 +78,7 @@ u32 rtw_write_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem) { u32 (*_write_port)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem= ); struct io_priv *pio_priv =3D &adapter->iopriv; - struct intf_hdl *pintfhdl =3D &pio_priv->intf; + struct intf_hdl *pintfhdl =3D &pio_priv->intf; _write_port =3D pintfhdl->io_ops._write_port; @@ -131,11 +102,6 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt return _SUCCESS; } -/* - * Increase and check if the continual_io_error of this @param dvobjprive is larger than MAX_CONTINUAL_IO_ERR - * @return true: - * @return false: - */ int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj) { int error_count =3D atomic_inc_return(&dvobj->continual_io_error); @@ -146,7 +112,6 @@ int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj) return false; } -/* Set the continual_io_error of this @param dvobjprive to 0 */ void rtw_reset_continual_io_error(struct dvobj_priv *dvobj) { atomic_set(&dvobj->continual_io_error, 0); --=20 2.47.3