From nobody Mon Sep 28 22:41:20 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350AF3D9050 for ; Sun, 16 Aug 2026 07:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.172 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786866120; cv=pass; b=CfP9Cq1StrqbSjJJxt1Ch3EkWYR3VH/3cCiDZ+xwrDp2PwrPHFr1N6LD1PJdB15kRpZP4GLF1p8gzcb5XMnZ5oKSYF+ACL8YXWfr6Kj0GfgYKNuTtFz+f+fyfN+TRPc6tTiIntdFNnAYUIDTHhZQKZ8DYtEVAC0gohd2W0WNDB8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786866120; c=relaxed/simple; bh=oUj9a05u3BrZXpZY8d2cwDmZZkc0AB+gL3ZeNRklfdI=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=C/Va/hfIn8Ou+tgae5ywKUeVqG6/+RgTJJver2NqP5rMlS8bxkg6XBi8xy/REHxmrgDMBNFzMveN2MwdoJ0hpj56pux+BEbGcpfAjUXkfUwFI/JBT3bPIKXsNSiiHJHMVVgO80NdRIMuGHWibJgJG1zz/vAOnt1OeGRkpYhMQso= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DNK7zjQb; arc=pass smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DNK7zjQb" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-81ff017d420so45076457b3.0 for ; Sun, 16 Aug 2026 00:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786866118; cv=none; d=google.com; s=arc-20260327; b=j359ADDFmfeXec+7DauHURI3OCj1nJm0rxn1In4RjBNofW+SXemZHhpnut2SObWuEo ZWD4DWaG2uNNOwbHauH9h71Isvtsj6/jYi+Q4cDV7Qni5FSig4b4MY3zRyw/xPUURFDx od5BmIKnbrUVjeirsnLmL3EE1mT/83i+Brw0NkBTpl5w99lvlkuS5ePeoeWEtgJI/S8y 5TIw3SFJVhFsAHcn0y/LMUcQCNVL4StOvr+rPRRN2Z/gFSitOy+oOF/8LtP+HUzyC0ao vg55MfPDX1wnhk6Ssri/EM5O4sEtL3I1/lOxY+2WWUDV4XZxr4tdoGGaKOrOEt4WeFE4 o6xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=UIOqvIl7xDfcrdTSa6EMB4Htg56pwX6vcT6tUP5VQD4=; fh=ypVfJtvje9cnBxxRWAbZjoiIwEOzW49rbsfJ6Y7Kne8=; b=s+Isik/5rwONfL5vJUNlnHq8OsKbm/fDu4TrpBgR+AR+remO5ai8hzkZBxbbURt9Mp XEbBDOkzMukAQ1EqqlSil9SFYWEdSuJXRRf9DzJhPxXwQO3OGqdXN0kK76IUgabqIJQr ciuZgEofb0k+xCeBDhksHHHvQ3a+gq+apkyUHnxEnYknRlL1zGrCGXS7tpM+YjjDQpX3 7h2BbiTDYj0vjqGbGjahUXES1rYHYxj6n4IzDo6taGMRvSfwmiWRNHXY1ay2aUlkICdr 23831DQW+iHOI321Nd/tAhbuUUWyuyCPrUMyyv18mSW4rRTCICGDex1sa/yM+jGhwlO7 d0jg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786866118; x=1787470918; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:mime-version:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UIOqvIl7xDfcrdTSa6EMB4Htg56pwX6vcT6tUP5VQD4=; b=DNK7zjQbCFx1tl6j2ElbKnHfh+TOvD1XKvrXhVXKzM7hGI4HEkeMbuWgxdGuQq0d7x mCCu828Xq3fOct6L6RL45FCi1XxF+NHia8EVM6JZxiobsdi/FnTiVfwqtIMMqfUrT57x gae1r6Vl83amnHgDTroAjgKG0TsPztMSO1ifB99cLP/O1hl6unjD/QVsSuuu/GzHKSJ9 BxDwG2ZTinmLIN+kFsIG97D1p2BgTZsmeBc+F1621B5cCF8i4iufiTX1F0AlCx0w6b7H l2Onxw7kVFIRNxgefMt2YiIvKCwbiO0UCUXtlnjfMfnDE9FMhqLo1c10GVEIFtJGb++b 51IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786866118; x=1787470918; h=content-type:cc:to:subject:message-id:date:from:mime-version :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=UIOqvIl7xDfcrdTSa6EMB4Htg56pwX6vcT6tUP5VQD4=; b=h50CZktmyCpCnt7D4XrMVRjo0bTBHdk7zajnBngBhBPTISIK5J7yEIivgdMmVPcnIv U2ezfR1ft/HG4YW68X7X0fbqQ4ebCOTl8O1pLNmg2T3nEm0P//TMb5FJWFshMgSf2pzD x/fSDnigQQl3UFbmGMFp/g6rnQfiS7nc+raTvovkABkIk0Rf8fHqk7U4xJFl0Q2PmHqX mc2v4eOTvPpc/7Jy/VtfKTJtH6ktbJVmy0Z1poWVRrXixwjOCIzRDCx2eq/I5iP/xnE1 o9iHdCKZnU7caZ3SNJoP3JgrgzwLEVJXFJ2WrCnCCHWutRAvG7A63PAsSW+3WJMyBq+u UMxw== X-Forwarded-Encrypted: i=1; AHgh+RrhhVL+anHDWjdkbzFP+vhmye2+MYbXyenGdGOk21v/Qm+RuCYUGh+/xIEUTSB8ZpbF1tsh/WXaVJIPOQI=@vger.kernel.org X-Gm-Message-State: AOJu0YxeXbewhY6hliGkSxGNEN7oIwJ5qQAGs5zYCFnZgMgmkDbjuk4x RqaHSNaLU0vmPpymOFZW6kXqLLXhIrvKscEZDpV4EQCTv6+hbo8PnRCkYqrJh8/YDftnLUXadc+ f9SNMdRj/BwQMKDpw0ZPk4dacjbHm0PU= X-Gm-Gg: AR+sD13myWsYfdPtaHfGRw/5d2SspUSSiOT9xQrc7RiCFPRHZcGA4AMzRkr3f26x1sP wR6Jo2u9nSkcjSUaXF0N24QDnnTiWhFwoTSQN32WniFjOGCAZskO79SREK+vkoTsdR0NG5Uok+E ENu8FrAjLmY9a46fHQCu7Fp7uyjimmbit/O8UnaH/kidOi1IXYDKwyisrFLi9gHsIhBc8ePWIQh EBkdWZf0Eo/BNiF0sXkIL/qkH5P3jLQrP/8xga4k3rMA5Vc3AvD6cXZYv6BuJSbnTUFLcrogEzp ofQFBMJo7o4/MhcuRFoVLzTg8OmWCnWd+ollEAL2 X-Received: by 2002:a05:690c:370a:b0:825:468e:e0eb with SMTP id 00721157ae682-8371327bc01mr63323357b3.15.1786866118228; Sun, 16 Aug 2026 00:41:58 -0700 (PDT) Received: from 77377267392 named unknown by gmailapi.google.com with HTTPREST; Sun, 16 Aug 2026 00:41:57 -0700 Received: from 77377267392 named unknown by gmailapi.google.com with HTTPREST; Sun, 16 Aug 2026 00:41:57 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Alexander Smoliyaninov Date: Sun, 16 Aug 2026 00:41:57 -0700 X-Gm-Features: AcwNN1UI3NNRB9P3qcWjgYW37D2nM1o8f1bOtnqcf2JP7hb4GdfF2ldFrgZEWpI Message-ID: Subject: [PATCH] rust: list: add SAFETY comment for HasListLinks in impl_has_list_links_self_ptr! To: ojeda@kernel.org Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, daniel.almeida@collabora.com, tamird@kernel.org, acourbot@nvidia.com, work@onurozkan.dev Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Document the safety rationale for the `unsafe impl HasListLinks` generated by `impl_has_list_links_self_ptr!`. The implementation of `raw_get_list_links` computes a pointer to the `ListLinksSelfPtr` field and casts it to a `ListLinks` pointer. This is sound because `ListLinksSelfPtr` is `#[repr(C)]` with `inner: ListLinks` as its first field, and the method only compiles if the field has the expected `ListLinksSelfPtr` type. Suggested-by: Miguel Ojeda Link: https://github.com/Rust-for-Linux/linux/issues/351 Signed-off-by: Alex Smolya --- rust/kernel/list/impl_list_item_mod.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rust/kernel/list/impl_list_item_mod.rs b/rust/kernel/list/impl_list_item_mod.rs index 5a3eac9f3..d84aedfdc 100644 --- a/rust/kernel/list/impl_list_item_mod.rs +++ b/rust/kernel/list/impl_list_item_mod.rs @@ -86,7 +86,9 @@ macro_rules! impl_has_list_links_self_ptr { // right type. unsafe impl$(<$($generics)*>)? $crate::list::HasSelfPtr<$item_type $(, $id)?> for $self {} - // SAFETY: TODO. + // SAFETY: `raw_get_list_links` only compiles if the field has type + // `ListLinksSelfPtr<$item_type, $id>`, which is `repr(C)` and has `ListLinks` as its first + // field. unsafe impl$(<$($generics)*>)? $crate::list::HasListLinks$(<$id>)? for $self { #[inline] unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut $crate::list::ListLinks$(<$id>)? { --=20 2.55.0