From nobody Wed Feb 11 08:40:16 2026 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DEF1219ED for ; Tue, 21 May 2024 18:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716317821; cv=none; b=uB2kIuG97H//8Zaz5Gxzzkq492wc0/Duv1VPRVoh1KJSYvBG76maLo1Z5/3di/Zoe4zFNLGJYMbofogqxAGAUdoTvc7JPozdzBjtpVwspyN/bV7m9VJamJWJjcjkGdrLJzsO9IZbOh9GSP+QMB+Gx7ZTv4ewb7WPk6NBrQoZLeM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716317821; c=relaxed/simple; bh=uT+ls486dG8nHmi/MyCGG3XvVfsPdmT4J2Rnn+NHSdE=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=e/Wbx08RLY0CQaoRVL1F/b7Mjzxghw/pRGU8P1A8mejPUq1f8pXNIAMo3SY+JzltdV6TX1cRoyXw7njVQ9g6kvyXlmBCQx4Gd4tjAaAqkoV27Jmg+XCDpK8jNidbWcieMAJKsD5zx/RSNFqhNXlp0hIXP6XIQ2JalB//sYIg/NM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=libre.computer; spf=none smtp.mailfrom=libretech.co; dkim=pass (2048-bit key) header.d=libre.computer header.i=@libre.computer header.b=MYS8fL3w; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=libre.computer Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=libretech.co Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=libre.computer header.i=@libre.computer header.b="MYS8fL3w" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2e564cad1f6so82976181fa.1 for ; Tue, 21 May 2024 11:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libre.computer; s=google; t=1716317816; x=1716922616; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=wK5e67Jdl5vfjzEOu3Eo6/JgeP8I4p2OioGReqzd8h8=; b=MYS8fL3wPzIJIPY41/mzt1cBgKJp0tSU7hDVp+u3Rva+IadjYFBeNQnVBc7ywkbHRz zWAikAMUJSB0xaWxHd+wvf2WDxKWizgBCCzJ/8M299ZekO0lG55Mf8NMI2lep/I4Xh+f 0Azn578DgfvXtKippuirqphAY/2SQoVgRLao8PaXRAhiwVc+Z7MOrVGl0cGgsAeRH1ih IzBMPegnpgpf466ZE7sl5mYWJivlIkWm1rRvKNDDbSqMLuEmyDObGfTlPlyQxunMlqcC oFOiJ5wBSbLfNYx9Jfda7YX6JMh/KoasB/YJ+wVjX9NDWK/zjcoNhDEmJyGDhCsvRDmh uq0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716317816; x=1716922616; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wK5e67Jdl5vfjzEOu3Eo6/JgeP8I4p2OioGReqzd8h8=; b=RSN59M/5YGtlvIenVVbBvJ67NBmBjwuDVEJzq/XMEQLlF50ThaYuvOQUNxhh2NGG1Z 5VxugvngROMRiwdPp/g96kTRDmFLVcT2HyWkvOJe/68Oi2ELT4lqDFb0EkpB0J2RxKmZ G9+Y6BUcaURnDoUnF3mNtHwzIoPOCQwwsVo3avmky2TXjXwbywt3IwRclv9I3klJCN3z EQguth4obzQbXkXktOxTI0FKcZZDmGDYpw4epppECMcExHurRXRJtnkpxxjj6W2S2mwx 952Ga62XT0o8qe2gMJl3lkXh/yxbuTfqk0MedBfs3nm+KsjMGTmXIv44LqUftEzgGB4M sQlg== X-Forwarded-Encrypted: i=1; AJvYcCWkVwA66SyvxAMSCBXBs75YGy0frFjsA4dqUXARjgbqbglxCtHYi6T87bANss5DjAf0XP2PizkR4WtYnuGpperAUAdC7xsHkFoTgF0C X-Gm-Message-State: AOJu0YwTjpuGb5/XC7ro0yeVSPxTKSIh1uQYNeF9pDXilOrnGF+B8NFk 52QyM/lD53Row2qjqDgiW2JUWSSlZBCkFnT/R9pYdTfAzHt93T/GjEFQykGDhrFHugIi5fFAABB Y/D/d15VWTLu61XRUEtWucv5Lf+s3OEMD2jQt X-Google-Smtp-Source: AGHT+IEqPa+du8fjYKGXkpILJkupqk3Qb0cGifkvSVqA1SHvtN7Dt3pRQ9a8SeREQmZzpASy17m8MSkPD92GjkUvBm8= X-Received: by 2002:a2e:a58b:0:b0:2e2:891d:5f62 with SMTP id 38308e7fff4ca-2e51ff6692amr237140221fa.29.1716317816220; Tue, 21 May 2024 11:56:56 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Da Xue Date: Tue, 21 May 2024 14:56:45 -0400 Message-ID: Subject: [PATCH] net: mdio: meson-gxl set 28th bit in eth_reg2 To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linux-stable Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This bit is necessary to enable packets on the interface. Without this bit set, ethernet behaves as if it is working but no activity occurs. The vendor SDK sets this bit along with the PHY_ID bits. u-boot will set this bit as well but if u-boot is not compiled with networking, the interface will not work. Fixes: 9a24e1ff4326 ("net: mdio: add amlogic gxl mdio mux support"); Signed-off-by: Da Xue --- drivers/net/mdio/mdio-mux-meson-gxl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c index 89554021b5cc..b2bd57f54034 100644 --- a/drivers/net/mdio/mdio-mux-meson-gxl.c +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c @@ -17,6 +17,7 @@ #define REG2_LEDACT GENMASK(23, 22) #define REG2_LEDLINK GENMASK(25, 24) #define REG2_DIV4SEL BIT(27) +#define REG2_RESERVED_28 BIT(28) #define REG2_ADCBYPASS BIT(30) #define REG2_CLKINSEL BIT(31) #define ETH_REG3 0x4 @@ -65,7 +66,7 @@ static void gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) * The only constraint is that it must match the one in * drivers/net/phy/meson-gxl.c to properly match the PHY. */ - writel(FIELD_PREP(REG2_PHYID, EPHY_GXL_ID), + writel(REG2_RESERVED_28 | FIELD_PREP(REG2_PHYID, EPHY_GXL_ID), priv->regs + ETH_REG2); /* Enable the internal phy */ --=20 2.39.2