From nobody Mon Sep 28 14:48:33 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1C013D7D91 for ; Thu, 20 Aug 2026 15:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.214.173 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787240276; cv=pass; b=oba6EgXGv3/D6EVxchFjvDt7/9jmji2OTc3d3Qb+Zhexut/1uTJBNM9fJ/Kpprc5M6o3Iajiyh9lBT7O2fNGjlI/SI/glZ7zDptCkySZ8edTYuIflEi2Jd/096qu709lhhlqfGVvR8nCz9zcDEZsEb2JsVSYV/cqLOnBNMwTGQY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787240276; c=relaxed/simple; bh=/oxZkxFAEHCqx9LDeQeRQTe9kGwQJLteh0MJCekMPWw=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=Ejkxius1QSdwPJu9PFKP8QVE3GGHDdcIyQ/RlkOMdh1v0rAgelxF/KC1Cxz9z4KcGlgFPbmsipGDk0zgiRZhOLavB8rT1yJP3wBzdUCQhxblaQAmQyJnjd4aAQaLzSm8C0mLOxgUrwfv1PqrHgo5OXk61f+NloMxhRc5JbzSdtY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UEQ0ZMyg; arc=pass smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UEQ0ZMyg" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2d049069377so160435ad.0 for ; Thu, 20 Aug 2026 08:37:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1787240274; cv=none; d=google.com; s=arc-20260327; b=fPVUoaVATlNWVHq5LP5gfLiF2mgoRklboNacPGjFGFXSFPuItZdPu27Lqi0iqBJecM vkwPAVLDlY1F2UYAsc8W2ZbSbonszCxyEj3ezYKjYZy7LxcBQ6o5bRCK3vPPfHdd1VTY 4p2GSKN7GOcxPThskv6nrlHecb8Tb1b8oUt1ImZ70hmZcQeHxsIZLxtV2ORR/4L9oXLQ DWlXG49EADiRPnWucF7p3y7NFNfw3SvRJ4gVO9fMMG17+4d4QYfHvzq9zXXiR/qHsHe6 mUsVHrEFE6TmYrvNcZk8CPxjduiu6C47aGtv8s/SZL8qZiFylv7rPIWH0S1LCJm674WD RmcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=/oxZkxFAEHCqx9LDeQeRQTe9kGwQJLteh0MJCekMPWw=; fh=yTSDP5rNYNtcZxOtXL9tOa8n9vcJUT8q9HO5rYgEH8s=; b=UUV5puag0KTb9x0HLu9ulixQaB9dBCIUp6FjYeUPO9RSnpwIU9Qkn34j+21pydzyf5 RFWl0KU6X0gibBY59Jzmh+nAQNIx4+8TlrtRWCmJp2qMLenfbyjjEGTK30ZhhaRJ4Hjc 0Zveo+pjH8gtK/fxdiEcSMwjXdPVh5tZOyXl0iUZmTfUv3y2SoffwOvHrGtRYN4C4R/5 3liMletedq39Zbf6TsrhHfwGa13snxN+r+Hzja4QojY4uvllWj/661bGP3XuZIqJpu/X 97TlwEGKXcBYgMggox1AFDp4OvrG2GlB7680XcHyU3Cfbs/X4Jw9FSOQwp8U5I074jMY bRzg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787240274; x=1787845074; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:mime-version:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/oxZkxFAEHCqx9LDeQeRQTe9kGwQJLteh0MJCekMPWw=; b=UEQ0ZMygyGSFRKBUU1wbN0pKXSgubnB4P15kc1IE4OhLPrrlP22KrNIB9lCAwsg56O AzlEIw80ZfHlV2yTnEtkoh/d5lNJpPG44H3j40BLM1+Yb2GdU9LTs7/RSMm+WTFN6EDr +4BPRHxk6P2w3Win7nc/xuzLpWsUBYgLvsgg56VPy/L/UFPWffVaWWDfWuVDEDV295V4 qHddcsfHG+nFo+7oQbadS5+TCjwBeix/zKuqg2Qgx7SRJJH29ijIU3FBbFX9Fd28ggFT ShQ8nSBMqoPWJ2+pJ6UUS9eiIt7U/TiOT1ZCAVkDWOhT+O0kyNH+3L1Sy+BYv89vPtvI Y6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787240274; x=1787845074; h=content-type:cc:to:subject:message-id:date:from:mime-version :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/oxZkxFAEHCqx9LDeQeRQTe9kGwQJLteh0MJCekMPWw=; b=hUz+EU29miuMGWh1tEzcWaTPKudb3M5FkyJvdaeKUATZ/etBeyYwduM3zgc4OVmuxz hF3Ep2qaNaD+8XI1krqYWrt3IV0AHK5k3LDOd2Eb4sMA75U6Xq4Xv+nfN3SarttYAMIs 3wcLlgWa42oZTyIVMbo2ELRL/GU75X+3X+T9OOPSJVY17kaAxwxItAKHsVA9JNA2/RJH qH07kOGBL6h/dFF3PcFBFNQQADod1RIduE0Z2MzuGYYGIiO30lsS3RIH58vqYnx8v8ok GXcpHt3s6Ns+yDMTbpwFQ05tFCbuDNTkvEeP5g6dD00AOuiqMboQ2/iOtqozLpnCRrTQ +Ogw== X-Forwarded-Encrypted: i=1; AHgh+RpnDqRehT+01nETHk8HV+uSTSTVPJoIzF3tzwg93rSdpx5xMQy0/2hlclzoiuXoF8ChbdkZIR6ygKE6kzM=@vger.kernel.org X-Gm-Message-State: AFuF++l43/4UDYtl1H/KCvL2Sxk4TQgzh927jJZ5hBkLNmYwkcgmtsjv NOonfx0+VtElej/bfwnFlEP1YQjNACFdj6yQ7kgm9ui0xNw7ncQYNgZei2C6o6tn5LqulOAcjuX X4Ctmn1g2wNBxE6bztPnf0nkoTEiz8Rc= X-Gm-Gg: AR+sD12dQmGdbH2EKRtL6VJBfitLHxmqxK5KWZFdWmckbmw2QyVavafKf1tKere5Ihp FHnAXbPsdZ5UxNJ6D9S/MSXMY+PX90uMHDbLjeY2vK8Gt9EVEAO5+AWL/xq314SBq8vZsPaMjO+ ULFylogP/Lg9XVo53AYJyFvTsbVEBGdh1ZVG5J/XVK0/cmY3g+svGCNALtN0L/ZFJgn6dsq43+Q //2klvQ6T8nkylwIz1ufCJqMo+K/2HOT0R1etktTBuLBxskHxYLGSHK2vshyEm64bu1erb4TTHl wGf1/wohrCN9GkP3T8+BjXxKJ3HzXw4nDZtw7os0xwulCdwwv+FUtFRfAV1ZHMQisB93tn6NSb5 4Cl0= X-Received: by 2002:a17:903:38c3:b0:2c9:8f4a:90b with SMTP id d9443c01a7336-2d5fd64494emr260634925ad.3.1787240273987; Thu, 20 Aug 2026 08:37:53 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Giuseppe Piscitelli Date: Thu, 20 Aug 2026 17:37:41 +0200 X-Gm-Features: AcwNN1WFgFPTmMMp-erXz7xwrQhUWpenAY8086vGvZ_ImDJaxwIXQJ9qLdqQPpY Message-ID: Subject: [PATCH net v2] net/sched: sch_cake: fix autorate reconfiguration throttling To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" CAKE's autorate-ingress path intends to limit shaper reconfiguration to once per 250 ms, but last_reconfig_time is only checked and never updated. Since the field stays zero, every qualifying capacity-estimate window can call cake_reconfigure(), causing avoidable rate churn and scheduler work under bursty traffic. Store the current timestamp when autorate actually reconfigures the qdisc so the guard enforces the intended interval. Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") Assisted-by: Codex:gpt-5.5 Signed-off-by: Giuseppe Piscitelli --- v2: spell out my full name in From/Signed-off-by (Paolo Abeni) net/sched/sch_cake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index f25f60978..dc9326702 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ktime_add_ms(q->last_reconfig_time, 250))) { q->config->rate_bps =3D (q->avg_peak_bandwidth * 15) >> 4; + q->last_reconfig_time =3D now; cake_reconfigure(sch); } } base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b -- 2.54.0