From nobody Sun Apr 5 13:17:17 2026 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC06B2C1788 for ; Fri, 20 Feb 2026 08:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.208.182 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771577085; cv=pass; b=O6y6k2eFvx/QyfMqWb4cgXMXLK0fns05DgRZjKHlf2p1ThCMJ320yv4S8Y6HS3gL2TBNwEmkgmH/jyGpL3FAx/jxpXcoQ/n5NDS+6ePD8IqchLgAsMYAzOE/nf5KUKuLUfIhpDsLBTsxMQm8+FxD4zIiL9co8OyJY+Xj8TYRbrc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771577085; c=relaxed/simple; bh=D1d3nMZ8GciEhhzINPmS47VAgCmnA2SuG+3VbAKzaDE=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=LJ+MnTNrbX6DVwRCww2uEys6jvLjCk6lXAxu4S1ZfIeR3bwgRC4A/9vafDiMYUA/i/vPtBFVHXsRZQtgiJOkthGItHRgtLYtGrIz4141qMUMZ8GufZa5Aiiyjn273lgTWrj3hwbOtfauFB+Ua5bY82E8u4YNDwgt+hbb2BZThDc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fiwRkYjz; arc=pass smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fiwRkYjz" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-3870cbd6c40so16440231fa.0 for ; Fri, 20 Feb 2026 00:44:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771577082; cv=none; d=google.com; s=arc-20240605; b=XzeyMnXOWoXlExGjXrBWD81K0eemcCnzuDInfC9tjRRsN186I8C4OYdudfPxpDN4ol pzR07LGjkAwjSNkXEfj+9nTH0Sva6gKP2BiFwr/cCJNgOWLdi4iwM5JzgbvQBwY6QPzw Hgu4YdPJ9/SCZm58q3KBtfr93V9VFcX0/QuF1SL8OpE2xkXrjzz8vqTwh5RZHLIt5MyU K7lWWkbEYrQnGDFH0g4vs0iyJH9crXBGdxOH6akx2ZLzh1jMNReQ/q30eU2h2IVHyU02 LSPIc95S+lkK3mkmwgLfrwubHHex+Cyx6BlNqbdgp3P5ZI8zAe4sEErEkneJaYcUJKlH 4X1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=8qKoRJoGoOXyGG+ED8eoFULD1E8tDVSYzdIvFnMgNlI=; fh=7IgV1iURWWl7UItMXBdAuf+kZVEubbfX9AYLS/YJ/mg=; b=cPT30YH7sZe5AnnwCnodRagtkAv7ttHmjGG9orthb46wMBC8ZkK6gYt0DXxEaLsfp4 /sKIA+l+QU6dlkAqx8dK8R101V7+fT5abcG45Ry+nkDCwwD3aglWuF4xovpI8JtRNhMy LOv7S8MKFHtCX075KjIHL1ebqRS/Bjeq3VJO3pm6Gy5WrSDcPmb/OkcPZL0DnIh3XWJW 8tkD6BTSoLZyVNGVNvAX5yFgglky0+0VieBikchjHiM7ngU+FUJPrVPkrjX5NaW8UnpJ 3SHhTlJquuCx66+rt1H6evVRChS3svH/v04EYQlIPArCdQd5ktYoNQAgFKAVuyl+o5rz +x7A==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771577082; x=1772181882; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8qKoRJoGoOXyGG+ED8eoFULD1E8tDVSYzdIvFnMgNlI=; b=fiwRkYjz4FvCoTHtM0lk15LPfBCK18RQXqxAm9ajbAPhBNi7FJkphzkMKt6GSEZ8ZI lLn0BY3XbJhTeaubsWSD/NXiCbvD+QkAB2ISyOGUAL9MDLdEwDuaTE0wtfiEgXIsY+Al qi3egbu2aPnZWVRNSz8ZUfheI1teSRJ2CF+5Qk+/AqT3r1vfn+kaRlGmLofMgybKlBvX QhFQA/lwxEZglsiriPjWs45SdUqEfr9XMl0aEx2IqVJQaQ1EI3go3JyQpHhcLHkjdRkX VBoLcO8bBGb/PX7+27jHyA9v8rvtkbs+8Df28NMFziN2GendAS5BH2ubgMlAwTjNoSsk bP1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771577082; x=1772181882; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8qKoRJoGoOXyGG+ED8eoFULD1E8tDVSYzdIvFnMgNlI=; b=qy+n4Po2XVcZVYrTJEr5sRlFEntXmiBkYR0v8oQSRao1mN3AqPTd2cMJfKPD4Cb/+L hpzYLYzXcSYDWvw9NPyuxsAU2bVLjeAasVfq4jpt79IM4UO1t8d4umnOZd1muuOwwMhr cJhFePKt1LffyG8CJeqXfirFJgZ5BCxB9c6QWBdkgaxccIJuiZLuPLq4dYZFXBKYmyog Zq8b1MelgWXrmzqDlukpMTdu1EYKqa7i9Kf17AoWap7TrPtqwohvKAcVTnS/Cl7fyOmZ CznOYSw8l5IePlQD55y3BWb+G7P86bf2+xDnQ4qw9nBlCZdjk4pX8FbHyZ5NkCtigGj4 01MQ== X-Forwarded-Encrypted: i=1; AJvYcCWbZzbqv1s/4BZWN/+VhkuuOwxpWPjdBVdNHKr+fanclqz5jAyu2ge6i+TawAzUhr+9xQkzqaqgad4hP3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwBJoTRpp6EvLXbJzNeRyqi+osyFdLCzrHMZqH/G9dG9nxSbSAl lDIKQikW008REZ8hgWX/U7p7Jl5085/J/v6cRwOXXuXc+3MgVJ7sT8+nf+6f9Z3HAiNpS4N3XW/ WHvHZxq40Z5kTYJzu9z8F2nCOByltg1Y= X-Gm-Gg: AZuq6aKwOAinAeJpV+vBFHNKdbGGE/5ByzaGSxdMSNh8WxZIq5IpuAcVf9lNioLjmTp kxr/UNOdOIW9lTQvd0LOrCxpqdEGCL9NjUz9JAHZ4ansMQfmQXAj823J02QTCfCPvfyYyR49Db6 J8dTn0IIEn+chUNaVapTvHJiNwC9WfphJhkSIowAIJzpoaitTVSa5uLrfuN+HeBYMlSmg827ZTu dolTanHNI29dbO7VKf/lHjf4o8Yr4fGdxjRJbRZdwviRijeb+wP+Rl05jADT9T8Ip8pad3lT7b+ OoAY56Vr X-Received: by 2002:a2e:bc81:0:b0:386:eb27:8ca0 with SMTP id 38308e7fff4ca-3881b8b436cmr62469191fa.1.1771577081418; Fri, 20 Feb 2026 00:44:41 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Ariel Silver Date: Fri, 20 Feb 2026 10:44:28 +0200 X-Gm-Features: AaiRm507GrU7GU8euPW7vyh0hEPKVj58rhtMZtN4UCnPQ7GXH9v7SAX8gMuaR3Q Message-ID: Subject: Subject: [PATCH] Input: atkbd - validate scancode in firmware keymap entries To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The SCANCODE() macro extracts a 16-bit value (0..65535) from firmware device property data, but atkbd_get_keymap_from_fwnode() uses it directly to index atkbd->keycode[], which only has ATKBD_KEYMAP_SIZE (512) elements. A firmware-supplied scancode >=3D 512 causes a heap out-of-bounds write that can corrupt adjacent struct atkbd fields and neighboring slab objects. Add a bounds check that rejects the entire firmware keymap if any entry contains an out-of-range scancode, consistent with the validation performed by matrix_keypad_parse_keymap() in drivers/input/matrix-keymap.c for the same "linux,keymap" property format. When rejected, the driver falls back to the default keycode table. Fixes: 9d17ad2369dc ("Input: atkbd - receive and use physcode->keycode mapping from FW") Reported-by: Ariel Silver Signed-off-by: Ariel Silver Cc: stable@vger.kernel.org --- drivers/input/keyboard/atkbd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -1111,6 +1111,13 @@ static int atkbd_get_keymap_from_fwnode(struct atkbd *atkbd) for (i =3D 0; i < n; i++) { scancode =3D SCANCODE(ptr[i]); keycode =3D KEYCODE(ptr[i]); + if (scancode >=3D ATKBD_KEYMAP_SIZE) { + dev_warn(dev, + "invalid scancode 0x%x in FW keymap entry %d\n", + scancode, i); + kfree(ptr); + return -EINVAL; + } atkbd->keycode[scancode] =3D keycode; }