From nobody Fri Apr 3 07:59:55 2026 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5CA318EC8 for ; Wed, 18 Feb 2026 09:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771407924; cv=pass; b=jxXBFeJZftQzS7DWA2WkshoauPAVrNOKPqpFdzh+xPYaPT8wb8lexaV+C2RgEJkav7zzBkjP+JIh1EzC8koerf1vjcbGNc9fvOo86c+NDWL5O3ZVQoGTId5BkIlPsytU5A7b0GFVCZY+F2ukIgyLDEYSw+6slVaxKZ/cNzXSRYQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771407924; c=relaxed/simple; bh=vZYaHq8XIaGCe3yL01xxAzr4U7wZPV5HIrm0Ssppl+k=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=JXOXkmHSclp6I5b53uTK72XJCF4E63MRF7YlJNchVfXexkWDybWGdGlDzFguNk6vX7T+qE+MuGnlsN98a/9DBk0hONDWlb/L09BMXMSPV7GHo4Nwn+HHK8ISGiPvfN3YAASsJu5qn7bVcE1iH9o1YkXCzK7sR84CHs7ZxyHTTv4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=GXHRnj7Q; arc=pass smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="GXHRnj7Q" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-64aea64bf15so4556509d50.2 for ; Wed, 18 Feb 2026 01:45:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771407922; cv=none; d=google.com; s=arc-20240605; b=Bcuvg6Zh+leYmrlJsWzQXt2lwbW7N5hDmX7ifD0t7h2vJBc4Pk0de5mSsFhzVxzESU uAdB+SbACmDJWArDWcAGjWqLGY20/ITXyChUjGxAE8dx03MtPWe/kYJkZaa8VysY5+wX RPuw/7SETo007Ferb7OLdbYBhVG8rKwqIT6/PeQC3CQ5uWwuARik1oaPYOJn9YmQNt40 zwokOGgw/+/BM3ICGqkrTun2NGnfAfopPOAinwcizn40MpN50gbyuaqz50aJ6oR8Rwrl UXoYM7l2tbISUz0NtW2/0lKR454PWkvXLM0FwWPy1OVdJxtMNXAXrdxwK67dmW5HXs50 ZtWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=zh2XBD//+tf+dYXF4FzuNwerEvQ8DxJonv37jHw22p8=; fh=J2OetlyYM2EO1gVXbgOnw6PeP1C5eDsEhOCdhfjNjHQ=; b=DY4G3I4QvhRDOfEDh12vlXH9DWzmNbN15s4QBtTA3r/e4ZOX3jic8MxSmSBTtT9Uom vpmMXYJ0e6S3++JwLLnD5p6hox/mfls7L6YqNnG691dIOKy6nNtQfcacG3gbB10a708W Ff51YzdXUwPEMY0bB3YRxZ/lPe6t9i6VsZ1SAOxY4gph0/QllAhlRfc1y8uvXrPOeS1Y 4AJ1clQzKjf3R381I4oQUbmfbgAr7s9gdg2ItqX5UPz8+cEB00C/nPAQWcbfnzdAOf0K m4mADvvf4LJtER09gx8hCJWGGfAgGu6qzL5HmRVdP3jm4Nj9HyRcnN+xgGc+o69Z5dXO gtUQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1771407922; x=1772012722; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=zh2XBD//+tf+dYXF4FzuNwerEvQ8DxJonv37jHw22p8=; b=GXHRnj7QnqIfBNgt8HdLd/mjnDPw+mvyPLA7PtDnT8h7puCxiHnaRKEBmVAXW8M39+ vcja/bXGvJPeMOHvWRMErLnqKm6xVnUbkN8ch6W1tBNVaSjSNBLmyH5ifmMdV7xuvjoT YASPMEn7myLV/sfL5NkJQgLipMjGPCoV1kJ6BVzQGcCliiP6yEEwoZSOXgnzUINyaGvT 1YLL0JDrPyJYS2C002WzoTVsRXUUWiwEsztYyunKVC4NsU4CUj5IybNx9gvOemYRaVTy Sp0uz0xY1oMJFc2cCTwqtB9du6FlmPZ3YeLQr10VgKzpL3k0B8NzuMuIR1pl826tVxbn yI4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771407922; x=1772012722; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zh2XBD//+tf+dYXF4FzuNwerEvQ8DxJonv37jHw22p8=; b=X0Hwt0zZYoFOFp7E1gBgPZyQsMsCQDLN5HKsIrqU+ZXlC2GPOAjqDcGtRZ51uPQvIG 48ieI/W5nRh21eH8OXUuddTqNJRBsPjm3MsvNK2utEQNEt5dlYfczxZQfW7lfQc1UMDB KMVkwyRhsBNE9NC+IHWA2/vZJjYDh27o9L/1/rHl1kjO3Gjpoq6gB9rJPVy7rsscn1Zw tK8T+BvI1vwyzlSSoQu5CwICygd0h60bSX0WXluwvVEo3JDkV/qByJymmE+QNUY0jdIw FmTf3oliQgwWsw7Y1vQusMaeHIeLmxMkERh+yevvXPZfPIqELhZReqJ3KVs4xM21OoBH MCig== X-Gm-Message-State: AOJu0YxaIWDTw8hUm06AFPcyNktSPEjoqIWDeUN2U0DWtsSyld3VaWrQ 6q+vyObSzMzqRjLFtAUNsrSp/ndexBcDsH74CN/qRfelgUG+kw794S21KmEqW7IW0MF+qF62QQ0 GJ+RUKg6qVppPqwI/tdb7jlyjYs0N8eiDaAabkxpTeUV1rpaFBIs= X-Gm-Gg: AZuq6aLOH1oqT621YiDtQtllp7BWIDVeGi1owU2uqAV+ZTJEGOPvRc7J1A6rZ8PJegT nKFPPpZtUiMZFgdV0TACMrwtV499PKtBgZWkIHbblHk5HX8XViektPENHzKW01WfVv4O8G2j5Dy bLJuDqQoGI6gy9mirc3lLtAI+5uG1Be5f6fDop8v/JEDKYCmoeDNz52qpc39fWYn0Br4UgGvtkx clBZcPEOr9IZS59sq+Z3PUisKkMpIit1pUcAfyrfOiQ6/jUHoxrEhmF81xySo/1eJaZNK80MFty ArViPkj/hUm8eAJitfk6uuw/yVh3afSjexM8cvRz X-Received: by 2002:a05:690e:d4f:b0:64c:2a4b:72e with SMTP id 956f58d0204a3-64c556b2d57mr490842d50.54.1771407922021; Wed, 18 Feb 2026 01:45:22 -0800 (PST) Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Feb 2026 01:45:21 -0800 Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Feb 2026 01:45:21 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Sean Rhodes Date: Wed, 18 Feb 2026 01:45:21 -0800 X-Gm-Features: AaiRm52gX5a_5aeMBm4HuSK2B8Pxrx0P8MGCuYuCFyrk9bOEay2WTmkJcrLLTns Message-ID: Subject: [PATCH v3] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter To: linux-kernel@vger.kernel.org Cc: tiwai@suse.com, perex@perex.cz, sbinding@opensource.cirrus.com, kailang@realtek.com, chris.chiu@canonical.com, edip@medip.dev, linux-sound@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From 4929cc45c32e30361c7e35f0581c83a08fd29b88 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 17 Feb 2026 11:53:41 +0000 Subject: [PATCH] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter On Star Labs StarFighter (Realtek ALC233/235), the internal speakers can emit an audible pop when entering or leaving runtime suspend. Mute the speaker output paths via snd_hda_gen_shutup_speakers() in the Realtek shutup callback before the codec is powered down. This is enough to avoid the pop without special EAPD handling. Test results: - runtime PM pop fixed - still reaches D3 (PCI 0000:00:1f.3 power_state=3DD3hot) - does not address pops on cold boot (G3 exit) or around display manager start/shutdown journalctl -k (boot): - snd_hda_codec_alc269 hdaudioC0D0: ALC233: picked fixup for PCI SSID 7017:2014 - snd_hda_codec_alc269 hdaudioC0D0: autoconfig for ALC233: line_outs=3D1 (0x1b/0x0/0x0/0x0/0x0) type:speaker Suggested-by: Takashi Iwai Tested-by: Sean Rhodes Signed-off-by: Sean Rhodes --- sound/hda/codecs/realtek/alc269.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index b66965a52107..00a92da0ba05 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -1017,6 +1017,24 @@ static int alc269_resume(struct hda_codec *codec) return 0; } +#define STARLABS_STARFIGHTER_SHUTUP_DELAY_MS 30 + +static void starlabs_starfighter_shutup(struct hda_codec *codec) +{ + if (snd_hda_gen_shutup_speakers(codec)) + msleep(STARLABS_STARFIGHTER_SHUTUP_DELAY_MS); +} + +static void alc233_fixup_starlabs_starfighter(struct hda_codec *codec, + const struct hda_fixup *fix, + int action) +{ + struct alc_spec *spec =3D codec->spec; + + if (action =3D=3D HDA_FIXUP_ACT_PRE_PROBE) + spec->shutup =3D starlabs_starfighter_shutup; +} + static void alc269_fixup_pincfg_no_hp_to_lineout(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -3802,6 +3820,7 @@ enum { ALC245_FIXUP_CLEVO_NOISY_MIC, ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE, ALC233_FIXUP_MEDION_MTL_SPK, + ALC233_FIXUP_STARLABS_STARFIGHTER, ALC294_FIXUP_BASS_SPEAKER_15, ALC283_FIXUP_DELL_HP_RESUME, ALC294_FIXUP_ASUS_CS35L41_SPI_2, @@ -6238,6 +6257,10 @@ static const struct hda_fixup alc269_fixups[] =3D { { } }, }, + [ALC233_FIXUP_STARLABS_STARFIGHTER] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc233_fixup_starlabs_starfighter, + }, [ALC294_FIXUP_BASS_SPEAKER_15] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc294_fixup_bass_speaker_15, @@ -7370,6 +7393,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =3D { SND_PCI_QUIRK(0x2782, 0x1705, "MEDION E15433", ALC269VC_FIXUP_INFINIX_Y4_= MAX), SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME), SND_PCI_QUIRK(0x2782, 0x4900, "MEDION E15443", ALC233_FIXUP_MEDION_MTL_SP= K), + SND_PCI_QUIRK(0x7017, 0x2014, "Star Labs StarFighter", ALC233_FIXUP_STARLABS_STARFIGHTER), SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC= ), SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), @@ -7466,6 +7490,7 @@ static const struct hda_model_fixup alc269_fixup_models[] =3D { {.id =3D ALC298_FIXUP_TPT470_DOCK_FIX, .name =3D "tpt470-dock-fix"}, {.id =3D ALC298_FIXUP_TPT470_DOCK, .name =3D "tpt470-dock"}, {.id =3D ALC233_FIXUP_LENOVO_MULTI_CODECS, .name =3D "dual-codecs"}, + {.id =3D ALC233_FIXUP_STARLABS_STARFIGHTER, .name =3D "starlabs-starfight= er"}, {.id =3D ALC700_FIXUP_INTEL_REFERENCE, .name =3D "alc700-ref"}, {.id =3D ALC269_FIXUP_SONY_VAIO, .name =3D "vaio"}, {.id =3D ALC269_FIXUP_DELL_M101Z, .name =3D "dell-m101z"}, --=20 2.51.0