From nobody Fri Apr 3 06:25:49 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2FD830AD0D for ; Wed, 18 Feb 2026 08:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.178 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771402726; cv=pass; b=g+TETkl5DXyo+gxvO3ypjTqZqqFiQNNemfDxvLVAlmxl58Ysf1NMvc3m/qMT6RABEOR5a5AH44bHscr04/ZZOr77fe5oXNvVZEHCosBnhZJ/cOvsI5YhE0llB9fzWHHqjdAJoxFuPiLFNrrTL0sAORjwlZpiwQcbXMwuN98bX9A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771402726; c=relaxed/simple; bh=l0jahKjEQ5Y1A+QkEFrxkFj8tLhquDkwi9jGVtnSlMQ=; h=MIME-Version:from:Date:Message-ID:Subject:To:Cc:Content-Type; b=NSA8p5fW2dt4xRFRtS3w0f9sC+3yaFqzCMDkHiSCRzwsOjasg9X1AZL+gQmAYLGEIeQY1b7/hkVLd8fAWhRBnzZt8073SJg9JRSvIg2WvkSKQ7bN6161HYCPcnIiPxau7Z03yqwn7LIZUhMPWwin1WJ/l5QZ4wI/Ja8U76gcykw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=1MdFkhHc; arc=pass smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="1MdFkhHc" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-797a52d8c34so44626177b3.2 for ; Wed, 18 Feb 2026 00:18:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771402723; cv=none; d=google.com; s=arc-20240605; b=ec+YN92YS0Vd/TNL68lrG7wrSFNN3SpDvzsgiOOi7nxRrLM4Zl/fFzTuIQ5uGZVlbz 716RhhaHsbX6JdMHbMzLfVMXCuvlMfitSNJolln9rRc0g3LQhBE1gRBATKcddYadRUit nwIwW9Jvgzewx86Z4sc/Z3WI3OSEdhIpuWirPXBlSl/CwooB9CaODNqbdVT5bNH8f00e ayHhsCtnd/9vLQlotCPV8dUVuoAcb1QPKIEa5/v/A1j1+xoqQnKaPyt4u5oL4DuLk9fV ixXiZbxCiJtPYhRLyNHB0G7Vy9WEf9cy0djgvlHAVF/WqGtPm0AABpY8/4cHsJItjgcO Ek9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=GFlg9XZqeuqWtNr094xxelkb9AaE5Nk2q5ML898v3WM=; fh=k0oZCuyW14urmal/TJPxGoNB1YWspOMkBN4p6ddL7R4=; b=hwCPJE20EsolauSAQqifzPDh023z6ZogshupYr0jXLuMEvqBZxKDymWww0Wk4z3Iaw PJpLNLgvz0uOYMvQCjkvkMZ0AW8kJ3tQmzTx9ILNn4qNpHLvIX3w9P+l5ySpnaAJeBIc fFw+4AaoVJ3k8tXndZl2eWSfid5l/pWCmS81/HvtFWc6JodrIqqsvGhoZItT+eqsrc6S DVy4iEKwx3B6lTAn7PFSrQXJdxxuttP5xnW49u3X3hBAiPO2QJJVX8dnZ/qUUYLYNtOw nyeLV+wi6rgd57RB17QnYZkrmBLCkHYnv/+RM2tWbMJZq4JtdZmKp4hcP45ESN10vQ31 Hdkg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1771402723; x=1772007523; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=GFlg9XZqeuqWtNr094xxelkb9AaE5Nk2q5ML898v3WM=; b=1MdFkhHc0AuNhs/6NSpmStyIBMSvLka+5QPdNkgoA0J7KKNCFJ7lNog35mWPiQ3oMU Ct0u8AZqeu+yLnILK8gfn5H8Th4IQRNncDNrVhUVOJKSux4zkHQZmLytNgpxLMSly9x/ fs+KHJ/xKO35TjiVkfeulYn/xswPCZXhX1x3llmzZPZ2XpJK8G4WmNN5um56uf77ksSw 872WZ89/1FNmGTbqy7enicfp8Ymv1OAQNP4jb89J4Q/+I0M71I4tBT93szuL5sxzxJ3x 7XblThy8pZQqBR4yJUmO+A+1+LNqndlvrHWAW9+Wxj5IUjJmNcRX/GdwamHpNIU8eTaf G5Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771402723; x=1772007523; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GFlg9XZqeuqWtNr094xxelkb9AaE5Nk2q5ML898v3WM=; b=u+piu6L6VIbicdyJZ3iFu2rO8C35ZtRc2YMQZPvKaecRP0aC8lOSbPtfAeFlh87cGK i+XjFNjIzRcLgR4VUp2PD97IKVrSEkFGI/QoEsldJ/WHPeW32U6BZquABLx4d4VLCT6q 9SVo7o7by+9Xcn0jxMgF0glfnu/r2kWso5WLSNwQvzj3nz9irbH8iH3/a9niTyH/vUh4 ahueAo/zmvACMxPruA+pLgDTHKPkj7T33p6cdc5H9F7X8oATAyAdI1HQ2MNngS0oherz yw5mDB6l1Fkm4kHLHZkqUOl1IH9JwJMRUSWGlz3Y1vGYFyKGP3ijna6ylirleT+ahsd3 tzVg== X-Gm-Message-State: AOJu0YwjzfyPSYlsE6aCUuSPBMQlrOGMcnHzNjP7ALZtLQ9VzzceqR7h dAAPWqbPiC0/K+zyPo55nDAQf50VE0GgqM+0mgRXWu7E4/X8lRx0fMyqWjIcDQidWvjO/iIhqvr 4Mwlpe9nBxE3N2WhlmLAYR0MtxWMpN0EBqOFt3r20O9LXqi0o3piD+Q== X-Gm-Gg: AZuq6aIdvtSMkBwxUEgVIty+vb2+uOEejaM8ypaMU5qdt4xDlBb2Ilia5JvBrszojNa 4l7wO9bzwItXFOrmuEWILRKE6IoGhonvoL0SuFqdaL4FnQFsXZQrBguAdTWdAFtCTUvfcqFtZp+ 9MDu39eJqfnxYMOFlvTO8rnrbOIx8Ln8FOp1G/bV1cTgaQm3Z4gYWir+dzRKwDvfwGLrJJXapa3 rcupZMp2+tp///U1d7rcACJfjfVqoUTd/iJucB/3e7qsqq3NA70w3HqAROYxIGlwi6Usxa+cupC /yetRpoOInQvvQVRPLK640fraAjtHagNO/0MT/gj X-Received: by 2002:a05:690c:298:b0:78f:f32e:8b5b with SMTP id 00721157ae682-797f6f020a3mr8090127b3.0.1771402723541; Wed, 18 Feb 2026 00:18:43 -0800 (PST) Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Feb 2026 03:18:42 -0500 Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Feb 2026 03:18:42 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 from: Sean Rhodes Date: Wed, 18 Feb 2026 03:18:42 -0500 X-Gm-Features: AaiRm50g6RQyT8oyqWPYdEz0H6FC-kYp1-DFZzN8h1Y1ga_u6UoaGVQ-j0FmVJ4 Message-ID: Subject: [PATCH] ALSA: hda/realtek: Fix speaker pop on Star Labs To: linux-kernel@vger.kernel.org Cc: tiwai@suse.com, david.henningsson@canonical.com, perex@perex.cz, kailang@realtek.com, linux-sound@vger.kernel.org, edip@medip.dev, sbinding@opensource.cirrus.com, chris.chiu@canonical.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From a673e45b345d494b7ec7143a8ace72faf6aa85f1 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 17 Feb 2026 11:53:41 +0000 Subject: [PATCH v2] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter To: linux-kernel@vger.kernel.org Cc: tiwai@suse.com, perex@perex.cz, sbinding@opensource.cirrus.com, kailang@realtek.com, chris.chiu@canonical.com, edip@medip.dev, david.henningsson@canonical.com, linux-sound@vger.kernel.org On Star Labs StarFighter (Realtek ALC233/235), the internal speakers can emit an audible pop when entering or leaving runtime suspend. The default Realtek shutup path powers down the codec by toggling EAPD and adjusting pin widget control. When the speaker path is still unmuted, this can lead to a pop. Mute the speaker output paths via snd_hda_gen_shutup_speakers() before running the normal Realtek shutup path. Test results: fixes the runtime PM suspend/resume speaker pop. Pops that can occur on cold boot (G3 exit) and around display manager start/shutdown are not addressed. Suggested-by: Takashi Iwai Tested-by: Sean Rhodes Signed-off-by: Sean Rhodes --- sound/hda/codecs/realtek/alc269.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index b66965a52107..fe74cc550322 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -1017,6 +1017,26 @@ static int alc269_resume(struct hda_codec *codec) return 0; } +#define STARLABS_STARFIGHTER_SHUTUP_DELAY_MS 30 + +static void starlabs_starfighter_shutup(struct hda_codec *codec) +{ + if (snd_hda_gen_shutup_speakers(codec)) + msleep(STARLABS_STARFIGHTER_SHUTUP_DELAY_MS); + + alc_default_shutup(codec); +} + +static void alc233_fixup_starlabs_starfighter(struct hda_codec *codec, + const struct hda_fixup *fix, + int action) +{ + struct alc_spec *spec =3D codec->spec; + + if (action =3D=3D HDA_FIXUP_ACT_PRE_PROBE) + spec->shutup =3D starlabs_starfighter_shutup; +} + static void alc269_fixup_pincfg_no_hp_to_lineout(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -3802,6 +3822,7 @@ enum { ALC245_FIXUP_CLEVO_NOISY_MIC, ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE, ALC233_FIXUP_MEDION_MTL_SPK, + ALC233_FIXUP_STARLABS_STARFIGHTER, ALC294_FIXUP_BASS_SPEAKER_15, ALC283_FIXUP_DELL_HP_RESUME, ALC294_FIXUP_ASUS_CS35L41_SPI_2, @@ -6238,6 +6259,10 @@ static const struct hda_fixup alc269_fixups[] =3D { { } }, }, + [ALC233_FIXUP_STARLABS_STARFIGHTER] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc233_fixup_starlabs_starfighter, + }, [ALC294_FIXUP_BASS_SPEAKER_15] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc294_fixup_bass_speaker_15, @@ -7370,6 +7395,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =3D { SND_PCI_QUIRK(0x2782, 0x1705, "MEDION E15433", ALC269VC_FIXUP_INFINIX_Y4_= MAX), SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME), SND_PCI_QUIRK(0x2782, 0x4900, "MEDION E15443", ALC233_FIXUP_MEDION_MTL_SP= K), + SND_PCI_QUIRK(0x7017, 0x2014, "Star Labs StarFighter", ALC233_FIXUP_STARLABS_STARFIGHTER), SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC= ), SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), @@ -7466,6 +7492,7 @@ static const struct hda_model_fixup alc269_fixup_models[] =3D { {.id =3D ALC298_FIXUP_TPT470_DOCK_FIX, .name =3D "tpt470-dock-fix"}, {.id =3D ALC298_FIXUP_TPT470_DOCK, .name =3D "tpt470-dock"}, {.id =3D ALC233_FIXUP_LENOVO_MULTI_CODECS, .name =3D "dual-codecs"}, + {.id =3D ALC233_FIXUP_STARLABS_STARFIGHTER, .name =3D "starlabs-starfight= er"}, {.id =3D ALC700_FIXUP_INTEL_REFERENCE, .name =3D "alc700-ref"}, {.id =3D ALC269_FIXUP_SONY_VAIO, .name =3D "vaio"}, {.id =3D ALC269_FIXUP_DELL_M101Z, .name =3D "dell-m101z"}, --=20 2.51.0