From nobody Fri Apr 3 08:24:10 2026 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35BD6328B76 for ; Wed, 18 Feb 2026 09:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.181 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771407919; cv=pass; b=RdN9abm4raUL1gaQ7ZjhCod7x7OW+3Vs7AGVcN6GsHTbXP+dUoah/Ng2SORTn0TB0ecrI0GejzGRmNLtaHnysbC8OTPxmb3Gh4OsWaNoIaNzbr028PeqLhyoLP/Mi5TEUrx0v6r48dPrHmXnMJLGXk9lAQIx8lYeSHOwFHXKX5s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771407919; c=relaxed/simple; bh=E19+ToorRxaDsMlevRO1o66igwvNZTwDx7nCEzb9mpM=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=GvUTpy2F3I+sY2LrplaBaXaJeNOwpfjUvG4Ch2rKx9rIaCSmP2MNWFi+FUIXTkreKcdJY8/qBPUmR+oDDw1/e6EIU8E9dio+tPYh7QmAO3M2lZhE0GjxDfDh91CU8RqexjmkGL6dX0Ohe2/MbcPKagtpQkbUfBHDQv2w6CRYMao= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=UWO1qq1r; arc=pass smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="UWO1qq1r" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-7950881727cso32030537b3.3 for ; Wed, 18 Feb 2026 01:45:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771407916; cv=none; d=google.com; s=arc-20240605; b=AnSCCgPwX9ToLRuhxnuTBR4XEZeqDfgcxHW5lhdoM90xL5Cfs1nvlwSybnRzdwyn7F P8ZO9cHndZQjnDpchFgPfhoSjpOIZiOTKv1aUf0Klut1NKVICSkBopNYMar7/ucEmQ/i eR1PNkLBSFfKlQreIQ0STLRrJWSBXBpqGF+6nnRCvD4mVJZrd8rEFKnQC993aO2ifXcu 4zYFhT4hZh5WuIisiZnFEjF/SUHj/6aAi03pUTgoRSEmvCfEJvOMhlp4T7cvA9buQLJO 845NJbjC+/tdoAALfusKHi/KSr7GkHdBU50iQEzKdfEFUxy79gIGfuiLWoMZ8cEMdgJd GIQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=IT51WJyaCcatx1dqA8OfeeJe8+GbWb120BHsdoQgm8s=; fh=J2OetlyYM2EO1gVXbgOnw6PeP1C5eDsEhOCdhfjNjHQ=; b=lB44cK7FPSW8pbOhu/1hDD/Jz8fXJQDMu2aE4FBfqDZ9j6b9iO6pz1UydMl0eH2vWk mxZ6Dy9Q8t+cv261+VbwfbjQqA5yXqYDaN6/ZLHf1LCNgY+cQyf1PFNE6GGN2oXmPBXI Pn0qXRYIJqym4VcqMWmBMebJLnaAZzrEOy5QwP4HoJsEU6faQxQsODdSsAS/D04XsVzY m57IQrPHwLX9xS2jbQ+lm2ResobjF4IYfvk1zdaYsQsVSKC+WQbQhcYw/kTMiKvFZd0z /3iIjv/iFYV6cbF1oj9IXkXSBzdsSadWSqQTl5TzWf3BADRc6urr666d3zNPJdzGaSaH HjzQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1771407916; x=1772012716; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=IT51WJyaCcatx1dqA8OfeeJe8+GbWb120BHsdoQgm8s=; b=UWO1qq1ryZES53OKJc0AqaHkDtVsRwI5nofp4PSHoDNVuV+JvVgmRePSxtjpLoU7BD yJ4buAE4K8BJJ2QG7kXM+hiI96mExnQbKqPwOTrOFPklmllq1WuUH+Cr23Omr8I2iVgx 0gg2c7qS7FbqM/HwqL6EB5mav+ZjDIYQ+rVaBEDRi3yazCKGdjNKHj1bbG8w9BFqnD+Q CfbmhaUzq/dwbhuaS6QKNmZPaln82JowTqBNaPtJgsaxjMT0PPy9cHBKuCM+0WVyfU5B t8EUOlpiBDwLyl2b8IBZz9XgoZ5NWu0Q2FC9tZ74y6VLiGhP/0ha+CfeSzNrG1fInD+g 6DiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771407916; x=1772012716; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IT51WJyaCcatx1dqA8OfeeJe8+GbWb120BHsdoQgm8s=; b=HXyaRrLiU+8nvcmPeXi11Lepbd91ktwRKuuPQDGbBEPAjmOB4QPw22qclEsYemkPXH Un4ax7M/lZAJh21ocCm5L8N8R1VibzclXLeoFw0Lf56qYg+P4LGi+Pv0dV9jykAR1zNg pFbaxJWc9yehftxeLJRzoAr7wb9jRhQFrhJQPbEWTK4tCjiGYW7hSdTbXIbL9UxbGltX RFAqLRlpMeJFYPZQwWfOvKgQmV1dDqGnLAatM6Gr+CAD8445iPoBil+4tVQE9Wlw9B7f klgcTCFNhjtogYTv7kme8FWaiHjQHzs9xdErjOuUODI0xzygO2fC/e81NnQ7zygY2oPd VFSA== X-Gm-Message-State: AOJu0YxcUiGLbOYp/rTq60l2Vwp7Pdoe5mz7yU590XpLfsURCRcq4YJ3 VBKTNgx/JAXrjDLY12HcaVEUET71EdbnrTuHymNYJnb9XJBDPRmRyReY3TVh1EMkINSnM2Dkdw+ OeiXiW7Wjv01tT63y4NYOkkkd1eRPtN2uzkGMmC90ARE4aGVGl2Q= X-Gm-Gg: AZuq6aLU4poxR6EcUZQbjCfQtEx1QBGDyM2IOTF9MC3oxWOuM8xqAq3iIBDzGMUol2p qb06lIZWuunDzHCVud9o1aQS2zMC9jXc7RVTX/1RYnr5zVW5D7UFXvJjV2NhdHT04zXa8BK4H8s ssV0JKrDE5WGlwqwZbmW+VfY4nNw15EdTJfhsgHcV3DNqTxnbHN4q9whFk8ogwprpYgxzkIbiit +LCt0eVxaXQrARasLFYmY1HvABz8zazsOFuhubxuK08LygLx6t86FPCHcW+4NreR94uRFyWBcRz qIDvtUWWMmUJz7dxwjKcs7XAGadEpJQK74SFxZXbKCJnGwCIvXs= X-Received: by 2002:a05:690c:e3e8:b0:796:4235:ea0d with SMTP id 00721157ae682-797f73525d3mr12443267b3.37.1771407915946; Wed, 18 Feb 2026 01:45:15 -0800 (PST) Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Feb 2026 01:45:15 -0800 Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Feb 2026 01:45:15 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Sean Rhodes Date: Wed, 18 Feb 2026 01:45:15 -0800 X-Gm-Features: AaiRm50__4O_tjTmy2kk4l4FZuyhnBO_h99w7tVDNYchd53O_aU9LFL4TMi12ZU Message-ID: Subject: [PATCH v3] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter To: linux-kernel@vger.kernel.org Cc: tiwai@suse.com, perex@perex.cz, sbinding@opensource.cirrus.com, kailang@realtek.com, chris.chiu@canonical.com, edip@medip.dev, linux-sound@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Star Labs StarFighter (Realtek ALC233/235), the internal speakers can emit an audible pop when entering or leaving runtime suspend. Mute the speaker output paths via snd_hda_gen_shutup_speakers() in the Realtek shutup callback before the codec is powered down. This is enough to avoid the pop without special EAPD handling. Test results: - runtime PM pop fixed - still reaches D3 (PCI 0000:00:1f.3 power_state=3DD3hot) - does not address pops on cold boot (G3 exit) or around display manager start/shutdown journalctl -k (boot): - snd_hda_codec_alc269 hdaudioC0D0: ALC233: picked fixup for PCI SSID 7017:2014 - snd_hda_codec_alc269 hdaudioC0D0: autoconfig for ALC233: line_outs=3D1 (0x1b/0x0/0x0/0x0/0x0) type:speaker Suggested-by: Takashi Iwai Tested-by: Sean Rhodes Signed-off-by: Sean Rhodes --- sound/hda/codecs/realtek/alc269.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index b66965a52107..00a92da0ba05 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -1017,6 +1017,24 @@ static int alc269_resume(struct hda_codec *codec) return 0; } +#define STARLABS_STARFIGHTER_SHUTUP_DELAY_MS 30 + +static void starlabs_starfighter_shutup(struct hda_codec *codec) +{ + if (snd_hda_gen_shutup_speakers(codec)) + msleep(STARLABS_STARFIGHTER_SHUTUP_DELAY_MS); +} + +static void alc233_fixup_starlabs_starfighter(struct hda_codec *codec, + const struct hda_fixup *fix, + int action) +{ + struct alc_spec *spec =3D codec->spec; + + if (action =3D=3D HDA_FIXUP_ACT_PRE_PROBE) + spec->shutup =3D starlabs_starfighter_shutup; +} + static void alc269_fixup_pincfg_no_hp_to_lineout(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -3802,6 +3820,7 @@ enum { ALC245_FIXUP_CLEVO_NOISY_MIC, ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE, ALC233_FIXUP_MEDION_MTL_SPK, + ALC233_FIXUP_STARLABS_STARFIGHTER, ALC294_FIXUP_BASS_SPEAKER_15, ALC283_FIXUP_DELL_HP_RESUME, ALC294_FIXUP_ASUS_CS35L41_SPI_2, @@ -6238,6 +6257,10 @@ static const struct hda_fixup alc269_fixups[] =3D { { } }, }, + [ALC233_FIXUP_STARLABS_STARFIGHTER] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc233_fixup_starlabs_starfighter, + }, [ALC294_FIXUP_BASS_SPEAKER_15] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc294_fixup_bass_speaker_15, @@ -7370,6 +7393,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =3D { SND_PCI_QUIRK(0x2782, 0x1705, "MEDION E15433", ALC269VC_FIXUP_INFINIX_Y4_= MAX), SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME), SND_PCI_QUIRK(0x2782, 0x4900, "MEDION E15443", ALC233_FIXUP_MEDION_MTL_SP= K), + SND_PCI_QUIRK(0x7017, 0x2014, "Star Labs StarFighter", ALC233_FIXUP_STARLABS_STARFIGHTER), SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC= ), SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), @@ -7466,6 +7490,7 @@ static const struct hda_model_fixup alc269_fixup_models[] =3D { {.id =3D ALC298_FIXUP_TPT470_DOCK_FIX, .name =3D "tpt470-dock-fix"}, {.id =3D ALC298_FIXUP_TPT470_DOCK, .name =3D "tpt470-dock"}, {.id =3D ALC233_FIXUP_LENOVO_MULTI_CODECS, .name =3D "dual-codecs"}, + {.id =3D ALC233_FIXUP_STARLABS_STARFIGHTER, .name =3D "starlabs-starfight= er"}, {.id =3D ALC700_FIXUP_INTEL_REFERENCE, .name =3D "alc700-ref"}, {.id =3D ALC269_FIXUP_SONY_VAIO, .name =3D "vaio"}, {.id =3D ALC269_FIXUP_DELL_M101Z, .name =3D "dell-m101z"}, --=20 2.51.0