From nobody Fri Apr 3 09:50:08 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731B3348469 for ; Thu, 19 Feb 2026 16:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.182 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771518365; cv=pass; b=WFaziaOAGVDaJU/0CDSkD/9ThgmKP2AnoVIgAZZJIzwH+6SJT4QzGUrNveMKTxUKUFQYwi8VkcwpQe4WOD9dba2hGUnXISXFEs885X4tZ548WDdQPxGZko1g9hG97/tRgApxPxfpblR/h7uoYg9mAbO3ysm5ZS3/4ALETrdWqyM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771518365; c=relaxed/simple; bh=aYqvMTjChUosLQj24AHzjkncE2q8062Pm+aQwdld4OA=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=lHrRea8vafP6BNfN7EBqddScoCaV2DV1d3vAB5gBrHNwr0lvCgaz2oiqlcIcppfX4CJv7PiDJODWZ+R5nf6d+LqUzHpidKEfW/3jDuR1MnKMRCs2keu4Nw3jZlYPmbMjwMumCVVrjlwYSv+YzTy/sAf1hrkB5wc88racq3pDhz0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=wlSILah7; arc=pass smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="wlSILah7" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-79801df3e21so10915507b3.2 for ; Thu, 19 Feb 2026 08:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771518362; cv=none; d=google.com; s=arc-20240605; b=Z9IY5J5IRUpRwQi7gWhy449e6/Q0XVuGhAYAXPkG/zATsvI9takwjjqChY4Fl4q+jK CSYSY38QzkJxUaJ3xAUbqIWDhH/Yu9q1ruOWPpjKkp20rKIoPixP+BWiu+9BtRsrofnO MYrOsnswxRrdjOV03njfeqiDhBcy6vaZH5GbCsMNFb2ML80CF6eDjAiN5lHWWR33fe58 liEe/yrCsMpbSkakcx+AiOI04ouFalb3QaYUv9LhU0C7+1rJciMRjCO5TN8b88j67WUu K0k+vV3uUS6g2lSfar4hO5Snh1Ft5r+fCrhEuNdZ09xJTGwiZRGChGuoELzFvdgwBWoV loPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:mime-version:dkim-signature; bh=Qj4JjrmCwnu2VpA6QRKnw2s/8HTQh7dMLUnqktW/KrE=; fh=4rRZKDXQq63kVD6GqQXJz9yJg0Io3kx09R5e7K5up5g=; b=MD+XhC8uiH/fO4OpmOkUDCFRBBFMwGx4f0RlmrXPrQNG500rJgOqXBH4xFgpqZp6jW +Aga7dwikeeYBewhGRLV786hGFlm+D+R0Hqu42sjgqqoDD1jsjggKtwCBDnC8Glyegvq Vo6ceGX4C30GYAeTIXkBjothy1VKuX7NaP1H/diXBGH9fWLS4H/EogiCKUH3I3Gf0ZvO AhC7UxsQegLPnrdNTVfQgicBxqVm3EzfBeosyLB8+HVpG/ekM2Ag6keR3HSdBRi7N/jM kuK0cMiLdJKd52w3fPkp82sVf/pHbPnNwTuLh8gzDKeGrp/bWpjL44+Vr9W6ACb5aK7G clpg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1771518362; x=1772123162; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Qj4JjrmCwnu2VpA6QRKnw2s/8HTQh7dMLUnqktW/KrE=; b=wlSILah7CNMiu3fwlL5mLPc5XFq61AQsfZZYrXTnpLicgfI1Agmbc0HpjKrEZGPB9T Hzr9fTqCRAdbfk9Ow+JP8X4NBYSHRCdPosIO/ihvRyAn8SV7kmdqbiE57gmCEYpJq+Uf aZgu4XCnAgZusv8CjP8FleAFxOBc43frmE9g6gFxmi4vAraCLKjtkDsNnuNth2KGU9sP IpFC5poEo1ybIF/UpQAl52gfkghNiCKyT7qMzqlvGzJM+lTKC89XtGZgpCTADmM8jZTV 0gA+ovcrGiiNlnBcJRryASoFVB99XKU2oYYGzpq3g73Xk207eRcgCHgJUfEA2cbxazT/ 1ORA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771518362; x=1772123162; h=cc:to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qj4JjrmCwnu2VpA6QRKnw2s/8HTQh7dMLUnqktW/KrE=; b=aeEVJGgoN1/BTtmEDjwDhJWBFOsU1SUW7Fja5nfNAFcFUNKQEur7Smk6vaarpPwMG3 gvpgmGislweonhr/fiZcYDx9DWkACf/BO19tkoAPFKexJWkCTcZaSWrRB2X8s1oW0Nr3 h2iE+UFO5rwAWBkXcq1Gskt69qguVP1NLcUoovsf+wligOXMk6WCDv0Zn4NL1G+VzI/H rpZFyQ/HjJeIbPQNZHuCF/tX2ZDjBza/h5vstgkmb2Rv83ptJXUnKXwvayFmEmYNjPVH uPd4MH6u3X8sOHwNkWz4AZHdcyiaNvBqM0/Zjh7md0rdTrc2isa0J85UH6d68dX0rMW+ G4xg== X-Gm-Message-State: AOJu0YwXoo2mAV2Z96OcgNPBU/3ux9HU42/1m/sy0Sbr2dT/LOasuAFF LILCJe/X6n3Qe62kmgJm5zmTWsi/D57dm0Gv9gBBQcC/MaBBG/hoi276pm3ce+bwrKuKhPY4X0Q sKwWFHwag4IUxlNl8FWYgUzM3QO44dG8BevmBbruFlPgjBY2WC+I= X-Gm-Gg: AZuq6aLsYnpFvqnduj8ekno4t9lpiihz4qK8jHGchK+9Mf5xI71UWWasT4ElP/3+qfT QKKtqjJTQLSJcFfDcalIiSHNYEeyl5n0568NX9+lkz3y5s59uUEtpB4USYDHYAFI3JG7nexxh7b owmkcM+b63bF25L7o9OPXfQnOIOs0plmRT149802XwZHMx7WX0FexWel11m2+ij2ZVFOPEm6ERW 0UNkkBN2irpQxlrshAEP/6MD72w6KNv3LfFftFq1EUicviTgrhS2GutS9KEZU5LtzLtl5ydW6pO mBqqR7nHfPstNMGYph2TwyC9bPqBHoECbxKIvYqE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:690c:e3e2:b0:786:5712:46af with SMTP id 00721157ae682-797ac4e1d84mr142901807b3.9.1771518361938; Thu, 19 Feb 2026 08:26:01 -0800 (PST) Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 Feb 2026 11:26:00 -0500 Received: from 239600423368 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 Feb 2026 11:26:00 -0500 From: Sean Rhodes Date: Thu, 19 Feb 2026 11:26:00 -0500 X-Gm-Features: AaiRm531OIutHJX6LrGCp7CXJFwx95josEN9BAsxJCrpBcTcO9-bAWLTQ8MrvZY Message-ID: Subject: [PATCH v5] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter To: linux-kernel@vger.kernel.org Cc: Jaroslav Kysela , Takashi Iwai , Stefan Binding , Kailang Yang , Chris Chiu , Edip Hazuri , linux-sound@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Star Labs StarFighter (Realtek ALC233/235), the internal speakers can emit an audible pop when entering or leaving runtime suspend. Mute the speaker output paths via snd_hda_gen_shutup_speakers() in the Realtek shutup callback before the codec is powered down. This is enough to avoid the pop without special EAPD handling. Test results: - runtime PM pop fixed - still reaches D3 (PCI 0000:00:1f.3 power_state=3DD3hot) - does not address pops on cold boot (G3 exit) or around display manager start/shutdown journalctl -k (boot): - snd_hda_codec_alc269 hdaudioC0D0: ALC233: picked fixup for PCI SSID 7017:2014 - snd_hda_codec_alc269 hdaudioC0D0: autoconfig for ALC233: line_outs=3D1 (0x1b/0x0/0x0/0x0/0x0) type:speaker Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Stefan Binding Cc: Kailang Yang Cc: Chris Chiu Cc: Edip Hazuri Cc: linux-sound@vger.kernel.org Cc: linux-kernel@vger.kernel.org Suggested-by: Takashi Iwai Tested-by: Sean Rhodes Signed-off-by: Sean Rhodes --- sound/hda/codecs/realtek/alc269.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index b66965a52107..00a92da0ba05 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -1017,6 +1017,24 @@ static int alc269_resume(struct hda_codec *codec) return 0; } +#define STARLABS_STARFIGHTER_SHUTUP_DELAY_MS 30 + +static void starlabs_starfighter_shutup(struct hda_codec *codec) +{ + if (snd_hda_gen_shutup_speakers(codec)) + msleep(STARLABS_STARFIGHTER_SHUTUP_DELAY_MS); +} + +static void alc233_fixup_starlabs_starfighter(struct hda_codec *codec, + const struct hda_fixup *fix, + int action) +{ + struct alc_spec *spec =3D codec->spec; + + if (action =3D=3D HDA_FIXUP_ACT_PRE_PROBE) + spec->shutup =3D starlabs_starfighter_shutup; +} + static void alc269_fixup_pincfg_no_hp_to_lineout(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -3802,6 +3820,7 @@ enum { ALC245_FIXUP_CLEVO_NOISY_MIC, ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE, ALC233_FIXUP_MEDION_MTL_SPK, + ALC233_FIXUP_STARLABS_STARFIGHTER, ALC294_FIXUP_BASS_SPEAKER_15, ALC283_FIXUP_DELL_HP_RESUME, ALC294_FIXUP_ASUS_CS35L41_SPI_2, @@ -6238,6 +6257,10 @@ static const struct hda_fixup alc269_fixups[] =3D { { } }, }, + [ALC233_FIXUP_STARLABS_STARFIGHTER] =3D { + .type =3D HDA_FIXUP_FUNC, + .v.func =3D alc233_fixup_starlabs_starfighter, + }, [ALC294_FIXUP_BASS_SPEAKER_15] =3D { .type =3D HDA_FIXUP_FUNC, .v.func =3D alc294_fixup_bass_speaker_15, @@ -7370,6 +7393,7 @@ static const struct hda_quirk alc269_fixup_tbl[] =3D { SND_PCI_QUIRK(0x2782, 0x1705, "MEDION E15433", ALC269VC_FIXUP_INFINIX_Y4_= MAX), SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME), SND_PCI_QUIRK(0x2782, 0x4900, "MEDION E15443", ALC233_FIXUP_MEDION_MTL_SP= K), + SND_PCI_QUIRK(0x7017, 0x2014, "Star Labs StarFighter", ALC233_FIXUP_STARLABS_STARFIGHTER), SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC= ), SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10), @@ -7466,6 +7490,7 @@ static const struct hda_model_fixup alc269_fixup_models[] =3D { {.id =3D ALC298_FIXUP_TPT470_DOCK_FIX, .name =3D "tpt470-dock-fix"}, {.id =3D ALC298_FIXUP_TPT470_DOCK, .name =3D "tpt470-dock"}, {.id =3D ALC233_FIXUP_LENOVO_MULTI_CODECS, .name =3D "dual-codecs"}, + {.id =3D ALC233_FIXUP_STARLABS_STARFIGHTER, .name =3D "starlabs-starfight= er"}, {.id =3D ALC700_FIXUP_INTEL_REFERENCE, .name =3D "alc700-ref"}, {.id =3D ALC269_FIXUP_SONY_VAIO, .name =3D "vaio"}, {.id =3D ALC269_FIXUP_DELL_M101Z, .name =3D "dell-m101z"},