From nobody Mon Jun 8 04:27:37 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68D662C234A for ; Tue, 2 Jun 2026 03:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.172 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780369814; cv=pass; b=IibULNJllNR0/6ybO87au08s6adJtoV4Z7mG/TWmLxx/Fvyg1LGgI9BH8FqjEeFNRNxoco5d4ZgJISu02no86ovT1VPxlKltGRqbSp737AfNVG0nTGOJgbgfLDj7yyMumS6iIcmTYKYFMBGx5OrBQZ9galvkAoWnFPrQp7qtykU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780369814; c=relaxed/simple; bh=cwAVpJuKlEp9kEmPE4v3fWnLBXPmYqHqdhlp7l4T5cA=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=INQ4z9+HN+ylGICEF5ybxaJb2UKQvxKww57CBmLAtA+1Ls1PKIzKgsdM2VcUpC+TOEvCJcJo+LhqBa7VLWnx5jZvc6mTzuanhbS+2QJiVvvmoftAPREWbhnh344nBteC7CI4bejXxB6M88npppZGErfIqYkeMgr2Co16BzfnTbw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=berkeley.edu; spf=pass smtp.mailfrom=berkeley.edu; dkim=pass (2048-bit key) header.d=berkeley.edu header.i=@berkeley.edu header.b=RFYG3QNq; arc=pass smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=berkeley.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=berkeley.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=berkeley.edu header.i=@berkeley.edu header.b="RFYG3QNq" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7dee6b76a73so35055017b3.0 for ; Mon, 01 Jun 2026 20:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780369810; cv=none; d=google.com; s=arc-20240605; b=MeqBL0dkpPEeD/i2DHGQVUMixLWPThk18/BOK4Rj0/AVrTfj3bTLQP+auHbTiOlk6M bU6zDYIFaP8aK0c/MkC1WzYm5i7aeoMubCdk2MlTt7Qk0e5R7MjzG6BC1EXnIcNrZpda uZFHYEA+XrXQkYoKDPf5C6PGq5LQuhwE7NWaX7nGjkZ1N/TkQAmsT1JhWfW7mwz+YBad E6dzob0z1tu7BvPPItZUExbSpx66Gr4NBZ74kfhyBtnpludpoR8uvR9GYFCDu0eypCDU 8fJdt19kZLYF2DH9TXvmL3c6VoLRR+25peilur2f749wZBdB2y+QuqvmGXS1l3ti3DFD sM/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:dkim-signature; bh=6fdhswAexcCHtqjvZiOVmNsqcqEhluDdYm31R2U+3Hw=; fh=aOKp+3osnFkIpIMWwM9/H06Mjg5socHx4Q/oDyrHpJQ=; b=bQy5jYqMJr8xoib0FQeYLAJRfmknIOf6ecAgMuTAiLgzYeuw/XFGfGRDJdbbu+DXTk nvvT7T5aY6mSRLtMQqaKUiW5zc8ZtgvwJ6fd0MQ1Bn3jbHtcqkVpVtUIiEmj/9c3USAt DLjYvRzZZ128BTQ5/rWwGdgWcpzprEazTOpV1TsnvxZhxk/2TRW74mHdSnZOARwaTlWV qqBvBdxWk9wtZzb8iRN5+RnVYXyhNsAj2pivdQud31IzF2yG/SoQFv/KjF3e1JohFUb2 BrpS5v09mas+fsOtuEC0Bh7D3tdLtjQZrVk7B6wU7L7q3tL1DRs4X6W+xKAJLDJvbPU9 Iyow==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berkeley.edu; s=google; t=1780369810; x=1780974610; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=6fdhswAexcCHtqjvZiOVmNsqcqEhluDdYm31R2U+3Hw=; b=RFYG3QNqrVMNsfKU+oEc8kLGG+wV2TD3Rfk0qUcFo/Bj+h7t/nspdx9CWFSHvQ0SqW L3WEqm1XaBfh/ppyJcGIeVRdMNe7nL6enu79d9bfw6Q9GZmLYyAvmEkkdFafJllCz+Nn 5YxT//FU/osOlJGyH0Jh5svLHMxGw9YxwchHF6aZkH0APPIhVAn0D28bjuO/SJQz+87I DPjzN9hHmhuMOTO5d4Aornc9hwf1OYg0i9anAwg3SQbUdgq3a8876GShu2UYOAu0BIcy 6pfgleTxIElHboQoypv3pcPUgwZpW809kuMkNtgZxVRoRmZmK8fLUmE1LHC7rAfT42fF QhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780369810; x=1780974610; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6fdhswAexcCHtqjvZiOVmNsqcqEhluDdYm31R2U+3Hw=; b=JfM2BrWjbX2TrZD68iN2OhFTcUv1LmirrJZ1tApDMh29RsGxZvszo987h4YJlcQHG7 PcZohkbJDE0W6x/U3PeEgV9/3ogmGMH/cs2JQXf4XbTLIZwDk0UYGnfA+azSWbTDOb+q sxCS9pHczLj8oSA6yIBr5aOOapCR+HYaaThvXpVqktHoK36RKem5s+bCoQV5rMXpEFqb MjNKV/ryOxYO4yGxGNP5DAdBssc9NFK+mLJpQh51g97SSKpGSy/5UsWHlgVRqOY/s4MO u6PsGndVyq/zhRh6R2JYMyZ9LbMivMyE/yqsNnVw5K6lXT7SudVIZh84TzesejaBzScC 31lw== X-Forwarded-Encrypted: i=1; AFNElJ8wbHiNdG5hpNJ811aCtBKC65yD6HisTIIZUBT3z13X6eSeB8XaQ5s8YTHO+y316UdWd9k3jBrO1+ikN9o=@vger.kernel.org X-Gm-Message-State: AOJu0YyRnSRFPBeqZae7pph/EdoFpwiOUe0zafYVWE7DDy0TlnJrvPrr gGR/1OMVSHlBBpYdiZRuMz0zQoq/e4sTOHCFxYIhlIgiXg8kJ0GAhNFNaJfhpRKLqu45/GsmDic e2WhmZPZ6fOnMjMjbf52gJzMuzN0fmAUSWF1oflEv X-Gm-Gg: Acq92OFzDdcZLdbDSgFR+5Igs1lCAar/xAbelmXLZMlblb6Th85Jld48ZXOhDOJyvNH 4wt6zkY3O1kuTRP0jhdMCN1eCi3YmHfTyxI/2rRKo8dw2tyAU3Thpho2vKsQv94iXA/xiBqRbIH F1n7p5jWdPM72dM6qEuoZeXULoVxRfxQIIOiogBUO3UpkbWAqJoWsBTOLQHCsr4FUtm/+OdHT1z Qq94TXbDqPHnH4qagm/l0uYISeban87yfNBCqw5YCdiajxcPRw8X3v1RHFV+kez1suIMBoQyDO+ hgDeiBUmTsyxeEO7/9k7 X-Received: by 2002:a05:690c:3391:b0:7dc:1d92:180b with SMTP id 00721157ae682-7e05c664b3bmr123328887b3.23.1780369809315; Mon, 01 Jun 2026 20:10:09 -0700 (PDT) Received: from 474444807712 named unknown by gmailapi.google.com with HTTPREST; Mon, 1 Jun 2026 20:10:08 -0700 Received: from 474444807712 named unknown by gmailapi.google.com with HTTPREST; Mon, 1 Jun 2026 20:10:08 -0700 From: Farhad Alemi X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 1 Jun 2026 20:10:08 -0700 X-Gm-Features: AVHnY4Iui-ID622VDwxr8uEuQB7BFvNN3vwYOUNrp6RUN-4zlOIf1vlS7zDt85E Message-ID: Subject: [PATCH v2] freevxfs: don't BUG() on unknown typed-extent type To: Christoph Hellwig Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vxfs_bmap_typed() handles four typed-extent types and calls BUG() in its default case, so an on-disk typed extent with any other type value crashes the kernel. It is reachable from ioctl(FIBMAP) on a regular file: kernel BUG at fs/freevxfs/vxfs_bmap.c:230! RIP: vxfs_bmap_typed fs/freevxfs/vxfs_bmap.c:230 [inline] vxfs_bmap1+0x128a/0x12d0 fs/freevxfs/vxfs_bmap.c:257 Replace the BUG() with WARN_ON_ONCE() and return 0 -- the value vxfs_bmap_typed() already returns on failure (and from the DEV4 case above); vxfs_getblk() maps 0 to -EIO, so the ioctl fails cleanly. Reported-by: Farhad Alemi Signed-off-by: Farhad Alemi Reviewed-by: Christoph Hellwig --- v2: tone down the changelog wording (Christoph Hellwig); code unchanged. fs/freevxfs/vxfs_bmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/freevxfs/vxfs_bmap.c b/fs/freevxfs/vxfs_bmap.c index e85222892038..1b8216eb1d90 100644 --- a/fs/freevxfs/vxfs_bmap.c +++ b/fs/freevxfs/vxfs_bmap.c @@ -227,7 +227,8 @@ vxfs_bmap_typed(struct inode *ip, long iblock) return 0; } default: - BUG(); + WARN_ON_ONCE(1); + return 0; } } --=20 2.43.0