From nobody Sat Feb 7 21:24:55 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45F6818CC13 for ; Tue, 30 Dec 2025 21:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767128837; cv=none; b=dhALT0gr++OyQ8riVAyIvkVKfN0pGi25jhawW0yP1SpcpGQW9JhgBji4f2Rb8ggTY97EbFcbfrb5+ZfLpYgPmxxjSbdzDgMCfsDd/lECNFpJvIgPwsRkK2ztgbcnsowoORIYguELm9d3YYPh+QIM6uQcJQrTJ5/sbI46L481D7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767128837; c=relaxed/simple; bh=buFLvgqPk07T/IK64g26n1eo7lJtPO3A+e/41msTbVI=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=f1bXzG0vsSqMjeVS/BEmmzhwgz021lbUwAazs4zwGbx7EJFx9hcZ99APu9h+EovvkXf1BP3sAirrYc/6RdjbIbLOP05ZnWd2nFwoxuwAoOJCm36crKeDJG9y/oa6vCPrQHZJIFjsA6IE0168PJ3wVl4G67Fr7XLh/Pu6/Zx4ab4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h3DalcOv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=n6ANiaz6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h3DalcOv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="n6ANiaz6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767128835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fs3dF5XgyMuZpukt7W4gv9P8n3NBqDsrPfX7SygV9BU=; b=h3DalcOvoHKiTAW0Asbg+3Nir7ZxSPHEihhkyyy0FKnBMA51w+lHDJjrjBFCmfbvTU882P YSY5JxBxze6XPPVkt+6NEZEjC97kj5OsRgH8V7EoRDx49HkJ7treV9DL5M4n/AkbJMNQ+Z 8CcILXWTvFIMmexsDGQAOd4jLGzJrtE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-LjPnUA4ZMnOmcJcsKefFBA-1; Tue, 30 Dec 2025 16:07:13 -0500 X-MC-Unique: LjPnUA4ZMnOmcJcsKefFBA-1 X-Mimecast-MFC-AGG-ID: LjPnUA4ZMnOmcJcsKefFBA_1767128833 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ee0488e746so225153371cf.0 for ; Tue, 30 Dec 2025 13:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767128833; x=1767733633; darn=vger.kernel.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Fs3dF5XgyMuZpukt7W4gv9P8n3NBqDsrPfX7SygV9BU=; b=n6ANiaz6PMbTZFOGmF/K2N/vQILkJsoM7rNUXCI2LMd2gNR7x3g+casr90eb60ooYj +dGRs6mCoW+Zk1X9e2YXdod+a0v22MjdwbGxmhW9fUy1wTY085BcLnuAOLUiHXrhbDIe P04oDGmTd3oROMTRcU3pLGOUrLwvovC2nOag+pnq5yD0PFGCmuBXbo4Vt9+xrnThWjUn ChQ9kCZCQqtTntKd4fizgbZRkvXSK9xMI6WTDbOcEK7J3IkfmaCFJppwKqKRAjKjf9H5 pSj3Di/6wansYRrW6nfKquI37JoDIRx1LhY2g5RKw0XkgO9kDLrHijDDqKT3vUMcxHQn gAaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128833; x=1767733633; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Fs3dF5XgyMuZpukt7W4gv9P8n3NBqDsrPfX7SygV9BU=; b=sQgX/c8gwrwl9A+sk8NtpgFYMevMj4jxYBYuNQSOQGF68K7YIdvSp6Rbg7GiTs4kxL gAw7tmM+zRmPHzj7Excz3izlKPFVuh/vk6DdxavP+gTphyA18S4JgQMLiGRijrllGmSG HZUyV3nqiKsLDZXUyxJa1GVrIRiZfmryN4u7kn1FLNWIIxYtfBhjGqLZ9j2Nn43AkzKM cDY6E2FmFz59xI9/GVQJHQYuqAnL6Npoc/sqC1Rz8LUki54T2TVF7wUV4mOhLS4k26+r JHz8XVUmaPpJTqxFk1ZIofoRsuBxioX/ti7FFQXQp6lXxJQ5otvRdxO427H9/idYSr05 BBcg== X-Forwarded-Encrypted: i=1; AJvYcCXjwz2HvN74rEKVQjfytghyZbtn3SwCrGk7UsmN3tLiQl8kQ3FJggEIoA6wwtWnxexf0ddR6uS2uUQ81Kw=@vger.kernel.org X-Gm-Message-State: AOJu0YxagJFb2K1ohMvzleCJQSuEut1xd/ZOwAKezfV0ILRQC/3NaSji G/22+2GKRcMPOBK0QSbyilRDDZlZCRMdyR1gVlXiaLiN5xMZV5Z0fL4AdXxrfRRefJfpXSMG2jC CKQcTqsFiWQEjazkSibV/fNpExPVWfGBeiOtX69pACIrEC+J6YaOJNptQkEa0g5N85g== X-Gm-Gg: AY/fxX59ymtZmeGOC7tSk2jV3efzbFOEs5RFdTXuYpB1MW8vKAKYf+aKAoHkVRLWvoV ZW6yhS3nejB+M40vDkBDbXLToSrs66M/BPG+em2I1rMbAU2t8+ywBNOn+tKNWMMN+Q1RPZSt713 UsHP40+wY0hIEG4RuQzE7oDTPFqrDgIV9cfgJ4+oxS+nGNMSvJu+8HMMsLIDlFM0xzd2EqNDdyx UfDhUQeCS90H5vvQItVeGtx1Z2ODwS9UJqt9uRH6RomlQak+8Ct06k+9/KvXPlEfBZF39PevUh+ 7AqnA9N7Mq+3orTphObYj5QxW8pd1OK9w6jZgqop5E0iimaGf9Q6O1eZVrv0h3LW4J7goupw07C dWg1ob9jhuu0hjjIYjpHIBfxNJOrZzwsZSty/9BAXUrmaJ3TfugOO X-Received: by 2002:ac8:5812:0:b0:4e7:4a3:ae88 with SMTP id d75a77b69052e-4f4aac5d21bmr505335981cf.7.1767128832946; Tue, 30 Dec 2025 13:07:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGniPugfrtKUmrAdsMvFifGxehdYRRZoaKgkEFfGSz35yFouArtimGZRwcWQsxAfpgWRHElYg== X-Received: by 2002:ac8:5812:0:b0:4e7:4a3:ae88 with SMTP id d75a77b69052e-4f4aac5d21bmr505335751cf.7.1767128832539; Tue, 30 Dec 2025 13:07:12 -0800 (PST) Received: from [10.0.0.82] (97-127-77-149.mpls.qwest.net. [97.127.77.149]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4ac66841bsm242201241cf.30.2025.12.30.13.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 13:07:12 -0800 (PST) Message-ID: <9fbb6bf2-70ae-4d49-9221-751d28dcfd1a@redhat.com> Date: Tue, 30 Dec 2025 15:07:10 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: linux-fsdevel , linux-kernel@vger.kernel.org Cc: Christian Brauner , David Howells , lkp@intel.com, oe-lkp@lists.linux.dev, Alexander Viro From: Eric Sandeen Subject: [PATCH RFC] fs: cache-align lock_class_keys in struct file_system_type Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" LKP reported that one of their tests was failing to even boot with my "old mount API code" removal patch. The test was booting an i386 kernel under QEMU, with lockdep enabled. Rather than a functional failure, it seemed to have been slowed to a crawl and eventually timed out. I narrowed the problem down to the removal of the ->mount op from file_system_type, which changed structure alignment and seems to have caused cacheline issues with this structure. Annotating the alignment fixes the problem for me. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202512230315.1717476b-lkp@intel.com Fixes: 51a146e05 ("fs: Remove internal old mount API code") Signed-off-by: Eric Sandeen --- RFC because I honestly don't understand why this should be so critical, especially the structure was not explicitly (or even very well) aligned before. I would welcome insights from folks who are smarter than me! diff --git a/include/linux/fs.h b/include/linux/fs.h index 9949d253e5aa..b3d8cad15de1 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2279,7 +2279,7 @@ struct file_system_type { struct file_system_type * next; struct hlist_head fs_supers; =20 - struct lock_class_key s_lock_key; + struct lock_class_key s_lock_key ____cacheline_aligned; struct lock_class_key s_umount_key; struct lock_class_key s_vfs_rename_key; struct lock_class_key s_writers_key[SB_FREEZE_LEVELS];