From nobody Wed Dec 17 02:26:53 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06D7C4167B for ; Fri, 8 Dec 2023 16:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235908AbjLHQJX (ORCPT ); Fri, 8 Dec 2023 11:09:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233610AbjLHQJN (ORCPT ); Fri, 8 Dec 2023 11:09:13 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D61B9171C for ; Fri, 8 Dec 2023 08:09:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-000088-EY; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0O-Qo; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaO-H9; Fri, 08 Dec 2023 17:09:12 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , "Steven Rostedt (Google)" , Paolo Abeni , Kalle Valo , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 4/7] pcmcia: omap_cf: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:09 +0100 Message-ID: <9d96646b75b10f7562d4d18010e885b7fc55e0ab.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=RbjHfi5RXtO4cc8x56c5B+Z/tmcBf4To9DyVqGrX0Mw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9uzcEXgFvxHOFei0v+/iJGpZmJ3AUq5eLjE /WeNYj57paJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bgAKCRCPgPtYfRL+ TuNiCACNqZGlNha/Xc541obujpShtx6aayui0pbg6Wz+3ZIzoDiAvtzMRVCvJOaLzjEh13m/bGs tClR79pkmqPpYeAmLQ82WGZbEbvjohsA+5bofFYGzUVFAAv5Iu2YGsz8k0KU9Rgs2EPPSJbBuuG rfFcXDs/n1dlm3DpHuCKOO+XlfxABBtBXD3VgxUXBpEg9LWy55JXRewJQtAP2TTG48q+H6uo7nP bu2Sxwmf1MLzIqLOJYkzv6+HFPR5EMBsaLwLZ9dX2LCKdFwDZT6X0dQJUgNR1hdPrH/i2dNQruQ QWYqvuLCEimGnBiIgTqLzjj+njANSuoYpjF1WfJXxEjxile2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/pcmcia/omap_cf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c index e613818dc0bc..80137c7afe0d 100644 --- a/drivers/pcmcia/omap_cf.c +++ b/drivers/pcmcia/omap_cf.c @@ -290,7 +290,7 @@ static int __init omap_cf_probe(struct platform_device = *pdev) return status; } =20 -static int __exit omap_cf_remove(struct platform_device *pdev) +static void __exit omap_cf_remove(struct platform_device *pdev) { struct omap_cf_socket *cf =3D platform_get_drvdata(pdev); =20 @@ -300,14 +300,13 @@ static int __exit omap_cf_remove(struct platform_devi= ce *pdev) release_mem_region(cf->phys_cf, SZ_8K); free_irq(cf->irq, cf); kfree(cf); - return 0; } =20 static struct platform_driver omap_cf_driver =3D { .driver =3D { .name =3D driver_name, }, - .remove =3D __exit_p(omap_cf_remove), + .remove_new =3D __exit_p(omap_cf_remove), }; =20 static int __init omap_cf_init(void) --=20 2.42.0