From nobody Thu Apr 2 00:15:04 2026 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386D8396D30 for ; Thu, 5 Mar 2026 11:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772711794; cv=none; b=QrRE54CoOc9CS8jw+4OaHdfdEa5dxXVF5Nq0aDCnECS3HQ3An8okA0Og+AFgN33DhX5zsXRnarbVU18yNChVojq85h1Iz28QRtfdJgynxq3YchaZFN9HQ6V3WqgtoW80SfzjDbhJAygNN0JmcrIQQjLO/qQARLOq/76WPgHpIZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772711794; c=relaxed/simple; bh=09h+jdEV69JyhGkg3G43NcjR1oD6XyLBM6oBs4yRPiI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r3F/cdgGosS2sxcg/fOZ4fRSrwhhXL0fCPET2CklWJO9w35DQjF0Xsazs0Of7THPuf0qYijlnBxD8Wl9g2ByjXCzHWsblgHOMeefmkBAFKwCMa7c67XpbLRP+4TjLDoQEB5M7DLinsG0okGvQ2zr3uC+2FVLhj5vic6OV876Hx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aYY6BFEh; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aYY6BFEh" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772711789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=50It2KWkplJCk5rfNOAinOMdF3qOxn822zHuSg5yVbw=; b=aYY6BFEhf3mRI3VEazB541/h+Ze1kRL1T3Rkx2QrL6z4PUiW/zGnHy3PoFZBmvGLsO0m3n n1ulPJkbmUdk9NdpCNGrTnTk69ATRWXhf8K/4eKeCiyoxOVjm91Y6ghwuFwnSmjwthd/Iy kOTAGa1xFjCZIWPSMsCLoL0zwIKrHWI= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng Subject: [PATCH v6 14/33] mm: mglru: prevent memory cgroup release in mglru Date: Thu, 5 Mar 2026 19:52:32 +0800 Message-ID: <9d887662a9d39c425742dd8468e3123316bccfe3.1772711148.git.zhengqi.arch@bytedance.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Muchun Song In the near future, a folio will no longer pin its corresponding memory cgroup. To ensure safety, it will only be appropriate to hold the rcu read lock or acquire a reference to the memory cgroup returned by folio_memcg(), thereby preventing it from being released. In the current patch, the rcu read lock is employed to safeguard against the release of the memory cgroup in mglru. This serves as a preparatory measure for the reparenting of the LRU pages. Signed-off-by: Muchun Song Signed-off-by: Qi Zheng Acked-by: Shakeel Butt Reviewed-by: Harry Yoo --- mm/vmscan.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 61303ec85d587..024ff870b1a03 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3443,8 +3443,10 @@ static struct folio *get_pfn_folio(unsigned long pfn= , struct mem_cgroup *memcg, if (folio_nid(folio) !=3D pgdat->node_id) return NULL; =20 + rcu_read_lock(); if (folio_memcg(folio) !=3D memcg) - return NULL; + folio =3D NULL; + rcu_read_unlock(); =20 return folio; } @@ -4202,12 +4204,12 @@ bool lru_gen_look_around(struct page_vma_mapped_wal= k *pvmw) unsigned long addr =3D pvmw->address; struct vm_area_struct *vma =3D pvmw->vma; struct folio *folio =3D pfn_folio(pvmw->pfn); - struct mem_cgroup *memcg =3D folio_memcg(folio); + struct mem_cgroup *memcg; struct pglist_data *pgdat =3D folio_pgdat(folio); - struct lruvec *lruvec =3D mem_cgroup_lruvec(memcg, pgdat); - struct lru_gen_mm_state *mm_state =3D get_mm_state(lruvec); - DEFINE_MAX_SEQ(lruvec); - int gen =3D lru_gen_from_seq(max_seq); + struct lruvec *lruvec; + struct lru_gen_mm_state *mm_state; + unsigned long max_seq; + int gen; =20 lockdep_assert_held(pvmw->ptl); VM_WARN_ON_ONCE_FOLIO(folio_test_lru(folio), folio); @@ -4242,6 +4244,12 @@ bool lru_gen_look_around(struct page_vma_mapped_walk= *pvmw) } } =20 + memcg =3D get_mem_cgroup_from_folio(folio); + lruvec =3D mem_cgroup_lruvec(memcg, pgdat); + max_seq =3D READ_ONCE((lruvec)->lrugen.max_seq); + gen =3D lru_gen_from_seq(max_seq); + mm_state =3D get_mm_state(lruvec); + lazy_mmu_mode_enable(); =20 pte -=3D (addr - start) / PAGE_SIZE; @@ -4282,6 +4290,8 @@ bool lru_gen_look_around(struct page_vma_mapped_walk = *pvmw) if (mm_state && suitable_to_scan(i, young)) update_bloom_filter(mm_state, max_seq, pvmw->pmd); =20 + mem_cgroup_put(memcg); + return true; } =20 --=20 2.20.1