From nobody Wed Feb 11 05:17:54 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C78B2820D2 for ; Thu, 24 Apr 2025 16:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511631; cv=none; b=c3IQo83Hff5XY3NBQpBx3AyZ4WZbNMs3P+XRuXla0Ki9oa56Z9b1C1rYzWWy66KI7Z9DEh2JrclOx+9WH2YJHJz31Lgz5rkN+d9vBaK0nOdbV6/cd0EGlgEvx2b69U4T7cMjtT0f649gkOPixtpeKV/jlTJ+zyoQ2lPl+P+l7Rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511631; c=relaxed/simple; bh=aDJVHGaFvaN7ytJ3XZQ82dd5Q/CiK/ofSwCmDjO8+jY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=J6bThba3F0reyRrKI50Gec5Dw1VxrBNxc1hAly3+jzw/KisJpKektu9HgwmTC+JqsgECpHANKUb23lrW2G+NCcEU0fNBI0I+Ztj+zq7uTQNjIsUtn+kOru9UqyvBkicO7vfHeAZWLf409RmQW1RsRgoUACSZseBVCeBkAOzPCNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KNiYkABA; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KNiYkABA" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-223fb0f619dso14812305ad.1 for ; Thu, 24 Apr 2025 09:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745511629; x=1746116429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VAEMnNThm5BtYQLpYvVy8LbqrgUr5WpG4VLt5eZ55BY=; b=KNiYkABAKvuybyX51ypI/jTgfwSwU5Apv3vCr3wuXxUb2JmNcXpIS9LjFiyL4fydlv 5XHfm+J3hzLrl7R5gV5qK02tEEFdNtrEl/Yh+4QK31PL23Iz03kabEEqq4DfhCe/PlYt 4dbjlDLVhDJG6WRpHqOUFiEkUJGwewUdV3c19jV6P6cBS04DVFxuw04G3ZaEybWQy3/n NcZdJxvvcX9UyPuRMN0ycxk+Lg8gvbiRJ4VvJoQ1z+pNzTyxpDwb6JYxM5stP021y59g sAHALTFuWik6+kO0q9Ar4qRLUKPDYx3+fDti8qCdjGpbCkdxcfV6kmTffsIQ0Pu+T0pB Vy0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745511629; x=1746116429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VAEMnNThm5BtYQLpYvVy8LbqrgUr5WpG4VLt5eZ55BY=; b=pX1eEO5DMPEyW215EZmEip0u7G44GwixzySPrKaoYzYPulfNiCVup3S37lXSxwkX0M R6zMCeOzsjMJ3FJ09nBYlETdn5Kez+KZgwbiMS+Pz9VMc+YuVA6vKNpCC7VyM0oYOSzu UVlW19v2uNuMzY/1zqL87jEaosDFpA5hDSInd010BnBxpbH2bA+yde2gf5VIqOQOCSid zdYpuJ8Pqy6ahQhOug2wNm15RgJrKRphyEzQmwvwdt9I9olpE8BicQqdyC9BD2f94PeR yZZPoRilA10fpJCdIzgoWJPPo/s1lDEm+f71+hquq1HDCJkuk6wM4QD1PQezRmX4DS5V DN5w== X-Forwarded-Encrypted: i=1; AJvYcCXeY+l4MVu7B5v2e1/rSm1UO97N3TeaVZFMlzV/uunI3dUEl2eTo0wkBbFUrjcfaodStzsVGk+JbSvbGeA=@vger.kernel.org X-Gm-Message-State: AOJu0YyW/Ml6SDwq3mTI0dp/AFzLjuKZ+EJWdGO0ZWilBHtXCGixs2PV d3XLrBx5xWkkQpi/EA6/jjihq0KKJjSLpWifqjZAfFjHCkg0KNspIY3f9oiE2C0= X-Gm-Gg: ASbGncvgNl/6rOu56b3G+BGapn8uZ7DwfsPeggmvq5AbTAK5TQuDDuEwiyicgk33lKk XmV3onmrkNO2Ab8ZELnjjTgGzwVCAD65U5ItqS+EzAwgdT8qyR65xxM3E0pwsGck79BJxoGcTSE Y9Ies4z9fBWaGkiMw30hXc6/4u+JG3ViHK2dw5cQwfWytvF9Dw5XP3fw+N9vxNnZhM0JJAXQ3Es biFvGUGPdtwQTpV61T1juD5CWrXPVy5f2y6FIeCge2cwpgmbgJKFMTepKpzedZRSwwns0OCCP8A vAwEBfZegwhGtNweCpF0yUv5Du9j1NQLrYyg3xZBvA== X-Google-Smtp-Source: AGHT+IEC3G34HKnmp/Vwarv5ELQVHqGjzcRLSaOEM6FO3zSw7ZdDlftUSYsTgO6oH/156Kb1ZAVPTA== X-Received: by 2002:a17:903:2f84:b0:224:26fd:82e5 with SMTP id d9443c01a7336-22db3dc764dmr44052455ad.48.1745511629400; Thu, 24 Apr 2025 09:20:29 -0700 (PDT) Received: from localhost ([122.172.83.32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db510304csm15416315ad.204.2025.04.24.09.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 09:20:28 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Viresh Kumar , Lifeng Zheng Cc: linux-pm@vger.kernel.org, Vincent Guittot , Nicholas Chin , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: [PATCH V2 1/5] cpufreq: acpi: Re-sync CPU boost state on system resume Date: Thu, 24 Apr 2025 21:50:14 +0530 Message-Id: <9c7de55fb06015c1b77e7dafd564b659838864e0.1745511526.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable During CPU hotunplug events (such as those occurring during suspend/resume cycles), platform firmware may modify the CPU boost state. If boost was disabled prior to CPU removal, it correctly remains disabled upon re-plug. However, if firmware re-enables boost while the CPU is offline, the CPU may return with boost enabled=E2=80=94even if it was originally disabled=E2=80=94once it is hotplugged back in. This leads to inconsistent behavior and violates user or kernel policy expectations. To maintain consistency, ensure the boost state is re-synchronized with the kernel policy when a CPU is hotplugged back in. Note: This re-synchronization is not necessary during the initial call to ->init() for a CPU, as the cpufreq core handles it via cpufreq_online(). At that point, acpi_cpufreq_driver.boost_enabled is initialized to the value returned by boost_state(0). Fixes: 2b16c631832d ("cpufreq: ACPI: Remove set_boost in acpi_cpufreq_cpu_i= nit()") Reported-by: Nicholas Chin Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D220013 Tested-by: Nicholas Chin Reviewed-by: Lifeng Zheng Signed-off-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 924314cdeebc..d26b610e4f24 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -909,8 +909,19 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy= *policy) if (perf->states[0].core_frequency * 1000 !=3D freq_table[0].frequency) pr_warn(FW_WARN "P-state 0 is not max freq\n"); =20 - if (acpi_cpufreq_driver.set_boost) - policy->boost_supported =3D true; + if (acpi_cpufreq_driver.set_boost) { + if (policy->boost_supported) { + /* + * The firmware may have altered boost state while the + * CPU was offline (for example during a suspend-resume + * cycle). + */ + if (policy->boost_enabled !=3D boost_state(cpu)) + set_boost(policy, policy->boost_enabled); + } else { + policy->boost_supported =3D true; + } + } =20 return result; =20 --=20 2.31.1.272.g89b43f80a514