From nobody Tue Apr 7 03:29:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98764C433FE for ; Tue, 11 Oct 2022 00:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229464AbiJKAXP (ORCPT ); Mon, 10 Oct 2022 20:23:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiJKAXM (ORCPT ); Mon, 10 Oct 2022 20:23:12 -0400 X-Greylist: delayed 319 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 10 Oct 2022 17:23:09 PDT Received: from mail.yuka.dev (mail.yuka.dev [IPv6:2a0f:4ac0:0:1::ec3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D800E7FFA6 for ; Mon, 10 Oct 2022 17:23:09 -0700 (PDT) Message-ID: <9b7e4894-deec-39ba-bb7c-3c6d6427fa1d@yuka.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuka.dev; s=mail; t=1665447465; bh=ZEXWibNk0G+0njFhoJ+ESklUwZYerAFgwVyY2eFpiks=; h=Date:From:Subject:To:Cc; b=upu52iPC5a+qk/xHIMVsMQKXit+TDMIKjgAoldduOzz8futJdBDS8o18xy5WpWHSu uTeetSPPCUPaP9vZFm30vjK15xIhOmhzZk4TmH4k8f1AjyQaJOOssmsMLnfr9dvsLp BF+DzcdNlD0p3D9Ua8Qlkvx+62256FzHWFdxMB5Y= Date: Tue, 11 Oct 2022 02:17:43 +0200 MIME-Version: 1.0 From: Yureka Subject: [PATCH] speakup: remove usage of non-standard u_char To: samuel.thibault@ens-lyon.org Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, chris@the-brannons.com, gregkh@linuxfoundation.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yureka Lilian This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined. Signed-off-by: Yureka Lilian Reviewed-by: Samuel Thibault --- =C2=A0drivers/accessibility/speakup/utils.h | 2 +- =C2=A01 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/= speakup/utils.h index 4bf2ee8ac..4ce9a12f7 100644 --- a/drivers/accessibility/speakup/utils.h +++ b/drivers/accessibility/speakup/utils.h @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info) =C2=A0 =C2=A0static inline struct st_key *hash_name(char *name) =C2=A0{ -=C2=A0=C2=A0 u_char *pn =3D (u_char *)name; +=C2=A0=C2=A0 unsigned char *pn =3D (unsigned char *)name; =C2=A0=C2=A0=C2=A0 int hash =3D 0; =C2=A0 =C2=A0=C2=A0=C2=A0 while (*pn) { --=20 2.37.3