From nobody Sun Oct 5 05:31:38 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78241263C9E; Sun, 10 Aug 2025 13:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754833344; cv=none; b=Pyrse0xr63aqOS1td3AWytshOgNt5z+pZR7Mq2KbN5RvM5VaxVZC0tmu/ijInzyfuCupNezPr1A36GihMYfKmzR/mKjCXlcZpSXJTlrR2RiKKnHBg6OGiNSaipTjqK191t11YMXNYSIRkBG8GAm81SYVk40RggU6WDdI3Vwn0Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754833344; c=relaxed/simple; bh=/+UX7YI8QuUtPa998750h8tQ3mN0imbXJivKjzTgFXM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bEQPrGtOWVuK1GFS7zFCAifbK5Wo3E7xwu3bvsQTkJZqWK8sQVgp1F2ZVvaCUEmkFPObF71rq1l9WZufnqGu/UM1HEvLfWUDoRLko+EfOMQRyVH++bH7G7QQsefO/GaqwGuShyXrWmy3tma4eQ6GRVxmGMUlnNqpzHVvL5zv/xY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=LcVvMYrZ; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="LcVvMYrZ" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57AAaUju016873; Sun, 10 Aug 2025 13:42:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=WHopWYB9IEVpbApCT umqAJkSAH7oesowCcUhN6x7VP0=; b=LcVvMYrZN0NXb6iU7LiIXb1+UNB6OA1Kx W/YCy8YHuBk20aVY1TZT5RFEPlxisK7/iiCl1s3PH6wey4ZW3fnmjymYxEihYj4D PquxkdSIRARrWZLVmouwcto1afvwnV2+Yt8grBzjLqTlEDgKpyRn5w3XN2YTZSY1 keDLJJlY6abz1IPGU/L/WHWkGdzka7J2jcuTC5fbav7nFeM/tE9m9m3GUCcrH3z1 I3WdP1CSxv7yfVCaR6zFOBaJWp+nc+R0IE2n2COm+3y4kwLxQNS8XgMoQIZxr4gd HkWLkLg5TINbxIvqgupwzOaMEEmaW8Km8WdLPwt2RxJ5A+aeCjVCg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48durtwjas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Aug 2025 13:42:14 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 57ADgDfI006966; Sun, 10 Aug 2025 13:42:14 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48durtwjaq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Aug 2025 13:42:13 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 57A8ZwlQ025654; Sun, 10 Aug 2025 13:42:13 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 48ejvm1rp3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Aug 2025 13:42:12 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 57ADgBxA50659614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 10 Aug 2025 13:42:11 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4531820043; Sun, 10 Aug 2025 13:42:11 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 399B620040; Sun, 10 Aug 2025 13:42:09 +0000 (GMT) Received: from li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com (unknown [9.124.216.43]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Sun, 10 Aug 2025 13:42:08 +0000 (GMT) From: Ojaswin Mujoo To: Zorro Lang , fstests@vger.kernel.org Cc: Ritesh Harjani , djwong@kernel.org, john.g.garry@oracle.com, tytso@mit.edu, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH v4 02/11] common/rc: Add a helper to run fsx on a given file Date: Sun, 10 Aug 2025 19:11:53 +0530 Message-ID: <9af96fe74e29e3300c7f5861299bbe6d8f330625.1754833177.git.ojaswin@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Hh8yT4mtuUqWwEQ6j9_YF8BzqVVBgsff X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODEwMDA5NyBTYWx0ZWRfX5JxHkea0nGGs 4Jkq0zPtbf3ITyKaFeOSmnD4OlNdsGU6P0o5uAnSqkckPrS45XaCwkFXxvVVIWULGCICzGz/y6c UAuwj9BbunvEzH4rk3/KLaAVmqaYsD7bB395EVwjEXGEsxPdQ2/2XEYNxHrBwnx4WV6PSnA/EZf 1zcKGl5FNbIw182/OlTX/JXU+sHZRwVLm1MNrY1dZL7vT/zeAXnRRwmqQho7F7Fyts6a0t/cxE4 f6oMH6PY7IAguzYasFURWfdKvkntgHf+tHI1USQTTWYHZnn7yFfvA+clBZT/8YLKTeHFvVkfE9v 8GVpEkoegAIEomBb3yngUCmRVq0HjTDoBnCHFm6V10Ovx3TxdR5VyW7TV9f5JJxdLan8fmaEgvf We7Jcje2K7HDKE8FjZS5QAEQoAIJcgiRxcuF8bQKEyZ2WeSS7IFd38e4yxPpc27sneA1aHQm X-Authority-Analysis: v=2.4 cv=QtNe3Uyd c=1 sm=1 tr=0 ts=6898a1b6 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=u_VYNAqGXo6OSSAA:21 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=EfcJlRrZmV05EoLhlkQA:9 X-Proofpoint-ORIG-GUID: tZR7uruh8wCFz5z0kV-MspDCpgBFn83M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-10_04,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 mlxlogscore=961 impostorscore=0 suspectscore=0 bulkscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508100097 Content-Type: text/plain; charset="utf-8" Currently run_fsx is hardcoded to run on a file in $TEST_DIR. Add a helper _run_fsx_on_file so that we can run fsx on any given file including in $SCRATCH_MNT. Also, refactor _run_fsx to use this helper. No functional change is intended in this patch. Reviewed-by: Darrick J. Wong Signed-off-by: Ojaswin Mujoo --- common/rc | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/common/rc b/common/rc index 3858ddce..dc45bff6 100644 --- a/common/rc +++ b/common/rc @@ -5169,13 +5169,24 @@ _require_hugepage_fsx() _notrun "fsx binary does not support MADV_COLLAPSE" } =20 -_run_fsx() +_run_fsx_on_file() { + local testfile=3D$1 + shift + + if ! [ -f $testfile ] + then + echo "_run_fsx_on_file: $testfile doesn't exist. Creating" >> $seqres.fu= ll + touch $testfile + fi + echo "fsx $*" local args=3D`echo $@ | sed -e "s/ BSIZE / $bsize /g" -e "s/ PSIZE / $psi= ze /g"` - set -- $FSX_PROG $args $FSX_AVOID $TEST_DIR/junk + + set -- $FSX_PROG $args $FSX_AVOID $testfile + echo "$@" >>$seqres.full - rm -f $TEST_DIR/junk + rm -f $testfile "$@" 2>&1 | tee -a $seqres.full >$tmp.fsx local res=3D${PIPESTATUS[0]} if [ $res -ne 0 ]; then @@ -5187,6 +5198,12 @@ _run_fsx() return 0 } =20 +_run_fsx() +{ + _run_fsx_on_file $TEST_DIR/junk $@ + return $? +} + # Run fsx with -h(ugepage buffers). If we can't set up a hugepage then sk= ip # the test, but if any other error occurs then exit the test. _run_hugepage_fsx() { --=20 2.49.0