From nobody Sun May 5 00:25:08 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1E0C761AF for ; Sun, 26 Mar 2023 12:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231839AbjCZMiD (ORCPT ); Sun, 26 Mar 2023 08:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbjCZMiA (ORCPT ); Sun, 26 Mar 2023 08:38:00 -0400 Received: from smtp.smtpout.orange.fr (smtp-19.smtpout.orange.fr [80.12.242.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B67C076A3 for ; Sun, 26 Mar 2023 05:37:58 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id gPd9pANE3TpvfgPd9p9CXS; Sun, 26 Mar 2023 14:37:56 +0200 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 26 Mar 2023 14:37:56 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Marek Szyprowski , Joerg Roedel , Will Deacon , Robin Murphy , Krzysztof Kozlowski , Alim Akhtar Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] iommu/exynos: Use the devm_clk_get_optional() helper Date: Sun, 26 Mar 2023 14:37:50 +0200 Message-Id: <99c0d5ce643737ee0952df41fd60433a0bbeb447.1679834256.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use devm_clk_get_optional() instead of hand writing it. This saves some loC and improves the semantic. Signed-off-by: Christophe JAILLET Acked-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 483aaaeb6dae..867f409e0325 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -747,22 +747,16 @@ static int exynos_sysmmu_probe(struct platform_device= *pdev) return ret; } =20 - data->clk =3D devm_clk_get(dev, "sysmmu"); - if (PTR_ERR(data->clk) =3D=3D -ENOENT) - data->clk =3D NULL; - else if (IS_ERR(data->clk)) + data->clk =3D devm_clk_get_optional(dev, "sysmmu"); + if (IS_ERR(data->clk)) return PTR_ERR(data->clk); =20 - data->aclk =3D devm_clk_get(dev, "aclk"); - if (PTR_ERR(data->aclk) =3D=3D -ENOENT) - data->aclk =3D NULL; - else if (IS_ERR(data->aclk)) + data->aclk =3D devm_clk_get_optional(dev, "aclk"); + if (IS_ERR(data->aclk)) return PTR_ERR(data->aclk); =20 - data->pclk =3D devm_clk_get(dev, "pclk"); - if (PTR_ERR(data->pclk) =3D=3D -ENOENT) - data->pclk =3D NULL; - else if (IS_ERR(data->pclk)) + data->pclk =3D devm_clk_get_optional(dev, "pclk"); + if (IS_ERR(data->pclk)) return PTR_ERR(data->pclk); =20 if (!data->clk && (!data->aclk || !data->pclk)) { @@ -770,10 +764,8 @@ static int exynos_sysmmu_probe(struct platform_device = *pdev) return -ENOSYS; } =20 - data->clk_master =3D devm_clk_get(dev, "master"); - if (PTR_ERR(data->clk_master) =3D=3D -ENOENT) - data->clk_master =3D NULL; - else if (IS_ERR(data->clk_master)) + data->clk_master =3D devm_clk_get_optional(dev, "master"); + if (IS_ERR(data->clk_master)) return PTR_ERR(data->clk_master); =20 data->sysmmu =3D dev; --=20 2.34.1